HeyPuter/firefox
1
0 Fork 0
mirror of https://github.com/HeyPuter/firefox.git synced 2026-11-13 20:14:57 -10:00
Code Issues Packages Projects Releases Wiki Activity
976,508 Commits 2 Branches 0 Tags
singlethreaded
Commit Graph
132 Commits
Author SHA1 Message Date
Nika Layzell 5f0f9dd22a Bug 2020817 - Part 4: Annotate & clean up nsACString callers of BeginReading/Data, r=xpcom-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,toolkit-telemetry-reviewers-rotation,layout-reviewers,dom-worker-reviewers,gfx-reviewers,webgpu-reviewers,necko-reviewers,dom-core,smaug,handyman,emilio,pehrsons,kershaw,timhuang,edenchuang,padenot,bradwerth 
This is a large number of largely mechanical changes. When possible, the code
was called to directly call `.get()` instead, performing the assertions
manually. In many places PromiseFlatCString() calls were added to dynamically
copy the strings into null terminated buffers if the string was not null
terminated.

Differential Revision: https://phabricator.services.mozilla.com/D286158
 2026-03-25 08:23:04 +00:00
Sylvestre Ledru 9eb1a31a98 Bug 2023419 - Remove Emacs/Vim modelines from dom/ r=emilio,media-playback-reviewers,webidl,padenot 
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287843
 2026-03-16 21:02:32 +00:00
Ryan VanderMeulen 4b80e50e76 Bug 1998861 - Update Snappy to version 1.2.2. r=dom-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D271788
 2025-11-10 13:14:47 +00:00
serge-sans-paille 7662b3abdc Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch 
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
 2025-10-21 19:36:01 +00:00
Cristina Horotan 8a1b1970b7 Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing Gtest failures on AlreadyAddRefed.h 
This reverts commit e98adca292.
 2025-10-21 16:16:29 +00:00
serge-sans-paille e98adca292 Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch 
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
 2025-10-21 15:05:17 +00:00
Cristina Horotan aab924e90d Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing build bustage at nsBrowserApp.cpp 
This reverts commit fd0ffa193c.
 2025-10-21 10:44:13 +00:00
serge-sans-paille fd0ffa193c Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch 
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
 2025-10-21 09:44:11 +00:00
Narcis Beleuzu e1e6bbb1c9 Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing bustages on Document.cpp 
This reverts commit b23c15e927.
 2025-10-21 06:34:58 +00:00
serge-sans-paille b23c15e927 Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch 
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
 2025-10-21 06:01:36 +00:00
Emilio Cobos Álvarez 791917d8af Bug 1976665 - Sort headers in dom/. r=dom-core,media-playback-reviewers,webrtc-reviewers,dom-storage-reviewers,padenot,janv,smaug,jesup,jib 
Most changes are automated. Relevant bit is dom/.clang-format. I had to
manually disable clang-format in a few places where importing external
files and so on that aren't self-contained, and fix a couple includes /
forward declarations.

Differential Revision: https://phabricator.services.mozilla.com/D256800
 2025-08-05 11:47:34 +00:00
Jens Stutte 589bee8c53 Bug 1951283 - Invert the default of aCreateDirIfNotExists in BodyIdToFile. r=dom-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D240769
 2025-03-08 22:11:12 +00:00
Jens Stutte d511cad37c Bug 1951283 - Avoid needless attempt to create the cache directory in BodyMaybeUpdatePaddingSize. r=dom-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D240741
 2025-03-08 22:11:12 +00:00
Jens Stutte c588855458 Bug 1951283 - Avoid needless attempt to create the cache directory in BodyOpen. r=dom-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D240740
 2025-03-08 22:11:11 +00:00
Jens Stutte 87539771fb Bug 1951283 - Avoid needless attempt to create the cache directory in GetBodyDiskSize. r=dom-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D240739
 2025-03-08 22:11:11 +00:00
Jens Stutte cc3d66def9 Bug 1951283 - Avoid needless attempt to create the cache directory in BodyFinalizeWrite. r=dom-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D240738
 2025-03-08 22:11:10 +00:00
Jens Stutte e06739134f Bug 1951283 - Avoid duplicate attempt to create the cache directory in BodyStartWriteStream. r=dom-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D240737
 2025-03-08 22:11:10 +00:00
Jens Stutte 54ccaa7962 Bug 1951283 - Simplify and rename BodyTraverseFiles to BodyTraverseFilesForCleanup. r=dom-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D240736
 2025-03-08 22:11:10 +00:00
Jens Stutte d24c20e208 Bug 1951283 - Wrap aDirectoryMetadata into Some in BodyDeleteOrphanedFiles. r=dom-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D240735
 2025-03-08 22:11:09 +00:00
Jens Stutte 4506cefa1a Bug 1951283 - Speedup id lookups by using a hash set in BodyDeleteOrphanedFiles. r=dom-storage-reviewers,asuth 
The basic functionality remains the same, including the use of
BodyTraverseFile with all its cleanups.

Differential Revision: https://phabricator.services.mozilla.com/D240734
 2025-03-08 22:11:09 +00:00
Jens Stutte 968563f972 Bug 1951283 - Simplify BodyDeleteFiles. r=dom-storage-reviewers,asuth 
BodyTraverseFile does an expensive directory traversal while we
basically already know, which files we want to delete and can construct
their paths directly from the id.

BodyTraverseFile's additional functionality of deleting folders or
orphaned temp files it encounters while traversing is not resembled
here and we expect the caller to know what should be deleted. However,
we do delete orphaned temp files matching any of the passed ids.

Differential Revision: https://phabricator.services.mozilla.com/D240733
 2025-03-08 22:11:08 +00:00
Ryan VanderMeulen e7a093d50c Bug 1883629 - Update Snappy to version 1.2.0. r=dom-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D203634
 2024-04-08 13:48:06 +00:00
Jan Varga bf2a048815 Bug 1866240 - Maintain usage information in the database; r=dom-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D195081
 2023-12-01 22:38:10 +00:00
Cristian Tuns 07ea4344cd Backed out changeset 0279020821f5 (bug 1866240) for causing mochitest failures in test_cache_padding.html CLOSED TREE 2023-12-01 13:06:52 -05:00
Jan Varga 5be0701145 Bug 1866240 - Maintain usage information in the database; r=dom-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D195081
 2023-12-01 16:57:13 +00:00
hsingh c80ea97d51 Bug 1835298: Encrypt CacheAPI data on disk in PBM.r=dom-storage-reviewers,janv 
Depends on D180296

Differential Revision: https://phabricator.services.mozilla.com/D180297
 2023-10-27 14:10:08 +00:00
Jan Varga d8be1f3946 Bug 1791762 - CreateFileInputStream, CreateFileOutputStream and CreateFileInputOutputStream should return MovingNotNull<T> instead of NotNull<T>; r=dom-storage-reviewers,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D157819
 2022-10-28 14:27:19 +00:00
Ryan VanderMeulen 89e2fea01a Bug 1743947 - Update Snappy to version 1.1.9. r=dom-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D132651
 2022-07-12 15:38:23 +00:00
Jan Rio Krause 3fe00f5de7 Bug 1519200 - Remove NS_ERROR_FILE_TARGET_DOES_NOT_EXIST in favor of NS_ERROR_FILE_NOT_FOUND. r=xpcom-reviewers,nika,dom-storage-reviewers,jstutte 
Differential Revision: https://phabricator.services.mozilla.com/D77575
 2022-04-05 15:17:03 +00:00
Jan Varga f3b6f859bd Bug 1731969 - Rename ToResultInvoke member function overloads to ToResultInvokeMember; r=dom-storage-reviewers,jari 
Differential Revision: https://phabricator.services.mozilla.com/D126328
 2021-11-30 05:05:53 +00:00
Jan Varga 3e73e7ce93 Bug 1731960 - Move all Result extensions from QMResult.h to a dedicated file; r=dom-storage-reviewers,jari 
Differential Revision: https://phabricator.services.mozilla.com/D126324
 2021-11-30 05:05:51 +00:00
Haiyang Xu 79af612655 Bug 1672140 - Rename cache::ClientMetadata to cache::CacheDirectoryMetadata; r=dom-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D131590
 2021-11-24 20:50:37 +00:00
hxu d2301973ac Bug 1672140 - Change cache::ClientMetadata's base class from quota::OriginMetadata to quota::ClientMetadata; r=dom-storage-reviewers,janv 
Depends on D125583

Differential Revision: https://phabricator.services.mozilla.com/D126056
 2021-11-24 20:50:37 +00:00
hxu 6940518aa5 Bug 1672140 - Rename cache::QuotaInfo to cache::ClientMetadata and rename corresponding functions; r=dom-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D125583
 2021-11-24 20:50:36 +00:00
Butkovits Atila 2972038726 Backed out 3 changesets (bug 1672140) for causing Bp-hybrid build bustages. 
Backed out changeset 32edbc243607 (bug 1672140)
Backed out changeset 549556f430a7 (bug 1672140)
Backed out changeset 396640d13ece (bug 1672140)
 2021-11-23 20:25:56 +02:00
Haiyang Xu 83543e511c Bug 1672140 - Rename cache::ClientMetadata to cache::CacheDirectoryMetadata; r=dom-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D131590
 2021-11-23 16:53:50 +00:00
hxu 0034188532 Bug 1672140 - Change cache::ClientMetadata's base class from quota::OriginMetadata to quota::ClientMetadata; r=dom-storage-reviewers,janv 
Depends on D125583

Differential Revision: https://phabricator.services.mozilla.com/D126056
 2021-11-23 16:53:50 +00:00
hxu 0ddf5a9d23 Bug 1672140 - Rename cache::QuotaInfo to cache::ClientMetadata and rename corresponding functions; r=dom-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D125583
 2021-11-23 16:53:49 +00:00
Jan Varga dec6d4fb9c Bug 1731546 - Replace existing ToResultGet uses with MOZ_TO_RESULT_GET_TYPED; r=dom-storage-reviewers,jstutte,jari 
Differential Revision: https://phabricator.services.mozilla.com/D125325
 2021-10-11 06:00:15 +00:00
Jan Varga 7fbbc22b76 Bug 1731544 - Replace existing ToResult uses with MOZ_TO_RESULT; r=dom-storage-reviewers,jstutte 
Differential Revision: https://phabricator.services.mozilla.com/D125324
 2021-10-10 19:06:36 +00:00
Jan Varga bbfd5be8cd Bug 1728267 - Remove implicit ToResult from QM_TRY when no extra argument is passed in dom/cache; r=dom-storage-reviewers,jstutte,jari 
Differential Revision: https://phabricator.services.mozilla.com/D125319
 2021-09-24 13:08:30 +00:00
Jan Varga 7345ed5f93 Bug 1728267 - Remove implicit ToResult from QM_TRY when one extra argument is passed; r=dom-storage-reviewers,jstutte,jari 
Differential Revision: https://phabricator.services.mozilla.com/D125316
 2021-09-23 10:16:09 +00:00
Jan Varga 2c53929de2 Bug 1728267 - Remove implicit ToResult from QM_WARNONLY_TRY macros; r=dom-storage-reviewers,jstutte,jari 
We can use QM_TO_RESULT (instead of MOZ_TO_RESULT) because QM_WARNONLY_TRY
doesn't propagate errors, so no other adjustment is needed.

Differential Revision: https://phabricator.services.mozilla.com/D125314
 2021-09-23 10:16:08 +00:00
Jan Varga a0895ea9fc Bug 1711848 - Add argument separation comments for QM_OR_ELSE(WARN|NOTE|LOG_VERBOSE)(_IF) uses; r=dom-storage-reviewers,jstutte 
Differential Revision: https://phabricator.services.mozilla.com/D115465
 2021-06-01 13:58:27 +00:00
Jan Varga ea18231e8b Bug 1711656 - Rename QM_OR_ELSE_LOG to QM_OR_ELSE_LOG_VERBOSE; r=dom-storage-reviewers,jstutte 
Differential Revision: https://phabricator.services.mozilla.com/D115363
 2021-06-01 12:12:27 +00:00
Jan Varga 72a62d1841 Bug 1708643 - CACHE: Replace QM_OR_ELSE_(WARN|LOG) with QM_OR_ELSE_(WARN|LOG)_IF in places where the fallback needs to be called conditionally; r=dom-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D115150
 2021-05-30 11:08:02 +00:00
Jan Varga 3c117bf290 Bug 1711181 - Use QM_OR_ELSE_LOG in remaining places where QM_OR_ELSE_WARN would spam the reports; r=dom-storage-reviewers,jstutte 
Differential Revision: https://phabricator.services.mozilla.com/D115159
 2021-05-21 09:30:30 +00:00
Jan Varga 7e88bb0001 Bug 1711181 - Change uses of ordinary orElse to QM_OR_ELSE_LOG; r=dom-storage-reviewers,jstutte 
This is more consistent with other cases where we either use QM_OR_ELSE_WARN or
QM_OR_ELSE_NOTE. We will later change some uses of QM_OR_ELSE_LOG to
QM_OR_ELSE_LOG_IF. The switch from custom OrElseIf to Result::orElseIf will be
easier when we don't use OrElseIf directly.

This patch only changes uses of ordinary orElse introduced in bug 1701346.

Remaining uses will be handled in bug 1711180 (the ones that were missed in bug
1686191).

Differential Revision: https://phabricator.services.mozilla.com/D115055
 2021-05-21 09:30:30 +00:00
Jan Varga f35732b709 Bug 1709067 - CACHE: Remove module specific QM_TRY macros; r=dom-storage-reviewers,jstutte 
Depends on D114080

Differential Revision: https://phabricator.services.mozilla.com/D114081
 2021-05-03 19:44:39 +00:00
Jan Varga 7ae200db8a Bug 1701346 - CACHE: Add explanatory comments for some ordinary orElse uses; r=dom-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D113526
 2021-04-28 07:33:55 +00:00