This patch does not make some header files stop including the inline
header because fixing them require more changes.
Note that `#include "nsComponentManagerUtils.h"` is fixing a bustage
caused by "use of undeclared identifier 'do_CreateInstance'" error.
Differential Revision: https://phabricator.services.mozilla.com/D304432
This requires some changes to the various places which currently directly read
the BlobImpl from the BlobURLChannel.
This requires a change to how MediaResource handles Blob URL loads, as the
existing code was avoiding creating a BlobURLChannel entirely when loading a
Blob URL. This could be improved in the future in a similar manner to how
HTTP(s) URLs are handled for ChannelMediaResource, but that was left as
out-of-scope for this bug.
Differential Revision: https://phabricator.services.mozilla.com/D276059
This reverts commit 47367770c3.
Revert "Bug 2005247 - Part 3: Always read BlobURL info over IPC, r=asuth"
This reverts commit df37ac38f8.
Revert "Bug 2005247 - Part 2: Validate BlobURL ContentLength header during channel fetch, r=asuth,necko-reviewers,valentin"
This reverts commit 45e63e6920.
Revert "Bug 2005247 - Part 1: Get the BlobImpl from the BlobURLChannel, r=asuth,media-playback-reviewers,padenot"
This reverts commit 440a33211b.
Revert "Bug 2005002 - Part 5: sec-fetch-storage-access not implemented for workers, r=manuel"
This reverts commit 5654faf8a0.
Revert "Bug 2005002 - Part 4: Fix devtools tests for blob: URL dedicated worker changes, r=devtools-reviewers,ochameau"
This reverts commit 9c9c197990.
Revert "Bug 2005002 - Part 3: Extension content scripts for Blob URLs no longer match with full paths, r=extension-reviewers,robwu"
This reverts commit 55f399175f.
Revert "Bug 2005002 - Part 2: Infer Blob URL principal from URL when possible, r=asuth,extension-reviewers,necko-reviewers,home-newtab-reviewers,robwu,mconley,kershaw,bvandersloot"
This reverts commit d3022ec470.
Revert "Bug 2005002 - Part 1: Support do_QueryObject for nsSimpleURI and subclasses, r=necko-reviewers,valentin,asuth"
This reverts commit 3d1199b4d4.
This requires some changes to the various places which currently directly read
the BlobImpl from the BlobURLChannel.
This requires a change to how MediaResource handles Blob URL loads, as the
existing code was avoiding creating a BlobURLChannel entirely when loading a
Blob URL. This could be improved in the future in a similar manner to how
HTTP(s) URLs are handled for ChannelMediaResource, but that was left as
out-of-scope for this bug.
Differential Revision: https://phabricator.services.mozilla.com/D276059
Changes name of "WorkerAssociatedBrowsingContext" in LoadInfo to just
"AssociatedBrowsingContext" to signal it's somewhat broader use case.
For reporting api, to show up in dev tools, we need dev tooling to match
against the channel and for that it needs a browsing context id (or
something similar). We set the associated bc id and then try matching
against that in NetworkUtils.sys.mjs.
Differential Revision: https://phabricator.services.mozilla.com/D283896
Normally, a fetch request acquires its cookieJarSettings from the global
that triggers it (a window or a worker). However, the global may not
always have the correct cookieJarSettings. For example, the Reporting API
delivers reports using fetch from a global whose cookieJarSettings does
not match the originating content. In this case, the fallback creates a
default cookieJarSettings which can cause crashes when processing
Set-Cookie response headers (e.g. CHIPS cookies with the Partitioned
attribute).
This patch adds a ChromeOnly cookieJarSettings field to RequestInit and
a corresponding member on InternalRequest, allowing callers to explicitly
provide the correct cookieJarSettings. When set, it takes precedence
over the cookieJarSettings obtained from the global.
Differential Revision: https://phabricator.services.mozilla.com/D285021
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
Most changes are automated. Relevant bit is dom/.clang-format. I had to
manually disable clang-format in a few places where importing external
files and so on that aren't self-contained, and fix a couple includes /
forward declarations.
Differential Revision: https://phabricator.services.mozilla.com/D256800
Keith Cirkel