Emilio Cobos Álvarez
12175ecc61
Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug
...
These are manual but straight-forward.
Differential Revision: https://phabricator.services.mozilla.com/D297186
2026-05-02 22:04:23 +00:00
iulian moraru
480fc572da
Revert "Bug 2036439, Bug 2033243 - Deal with ownerGlobal -> documentGlobal rename in extensions. r=robwu,home-newtab-reviewers,mconley" for causing newtab failures.
...
This reverts commit 4f62279d01 .
Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug"
This reverts commit 91a4ece356 .
Revert "Bug 2033243 - BindToOwner -> BindToGlobal. r=dom-core,smaug"
This reverts commit 5a95a889e1 .
Revert "Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug"
This reverts commit 7177a68e67 .
Revert "Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop"
This reverts commit 5263254690 .
2026-05-02 16:43:35 +00:00
Emilio Cobos Álvarez
91a4ece356
Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug
...
These are manual but straight-forward.
Differential Revision: https://phabricator.services.mozilla.com/D297186
2026-05-02 15:33:29 +00:00
rperta
d4cc71008d
Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug" on developer request
...
This reverts commit e58e122135 .
This reverts commit 84ca206f3e .
This reverts commit a7945292ed .
This reverts commit 367d83d299 .
2026-05-02 06:20:30 +00:00
Emilio Cobos Álvarez
e58e122135
Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug
...
These are manual but straight-forward.
Differential Revision: https://phabricator.services.mozilla.com/D297186
2026-05-01 11:58:19 +00:00
agoloman
c814da612d
Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug" for causing multiple failures.
...
This reverts commit c7246654bc .
Revert "Bug 2033243 - BindToOwner -> BindToGlobal. r=dom-core,smaug"
This reverts commit 8873ddf33c .
Revert "Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug"
This reverts commit 8bf999e03c .
Revert "Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop"
This reverts commit 7dea1af2e0 .
2026-04-30 20:13:14 +00:00
Emilio Cobos Álvarez
c7246654bc
Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug
...
These are manual but straight-forward.
Differential Revision: https://phabricator.services.mozilla.com/D297186
2026-04-30 17:47:17 +00:00
Emilio Cobos Álvarez
8141eeb3e0
Bug 2023628 - Remove FakeString. r=smaug,dom-worker-reviewers,asuth,webidl
...
The reasoning for having it was faster / inline constructor / destructor
behavior, but bug 2025271 inlines the string destructor, so there isn't
a need for this anymore, and perf profiles agree.
There were some unsound checks like not checking for adopted strings
etc.
There's a subtle loss of functionality in which we can't depend on
another string so easily. However this only affects
non-StringBuffer-backed strings, and it was misused (some of the callers
used it with a temporary string which is clearly wrong). Also most
callers can be trivially tweaked to avoid the copy anyways.
Differential Revision: https://phabricator.services.mozilla.com/D288003
2026-04-13 16:51:46 +00:00
Sylvestre Ledru
9eb1a31a98
Bug 2023419 - Remove Emacs/Vim modelines from dom/ r=emilio,media-playback-reviewers,webidl,padenot
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287843
2026-03-16 21:02:32 +00:00
Atila Butkovits
b658ab450f
Revert "Bug 2012568: return TypeError for sendBeacon when used with ReadableStream r=webidl,saschanaz" for causing failures at contenttype.any.worker.html.
...
This reverts commit 770ee8d295 .
Revert "Bug 2008613: SendBeacon maximum size fixed to limit at 64K r=dom-core,smaug"
This reverts commit 5a616227e5 .
2026-02-04 15:59:43 +00:00
Randell Jesup
770ee8d295
Bug 2012568: return TypeError for sendBeacon when used with ReadableStream r=webidl,saschanaz
...
Differential Revision: https://phabricator.services.mozilla.com/D280473
2026-02-04 15:04:11 +00:00
Sandor Molnar
06c37cd018
Revert "Bug 2012568: return TypeError for sendBeacon when used with ReadableStream r=webidl,saschanaz" for causing wpt failures
...
This reverts commit cda7cdf36d .
2026-02-04 05:36:02 +00:00
Randell Jesup
cda7cdf36d
Bug 2012568: return TypeError for sendBeacon when used with ReadableStream r=webidl,saschanaz
...
Differential Revision: https://phabricator.services.mozilla.com/D280473
2026-02-04 04:31:25 +00:00
Alexandru Marc
70af599110
Revert (Bug 2012568, Bug 2008613) for causing wpt failures @ fetch-event.https.h2.html
...
This reverts commit 1d9121a222 .
Revert "Bug 2008613: SendBeacon maximum size fixed to limit at 64K r=dom-core,smaug"
This reverts commit 35b8e1aa98 .
2026-01-27 21:45:52 +00:00
Randell Jesup
1d9121a222
Bug 2012568: return TypeError for sendBeacon when used with ReadableStream r=webidl,saschanaz
...
Differential Revision: https://phabricator.services.mozilla.com/D280473
2026-01-27 19:46:57 +00:00
Emilio Cobos Álvarez
791917d8af
Bug 1976665 - Sort headers in dom/. r=dom-core,media-playback-reviewers,webrtc-reviewers,dom-storage-reviewers,padenot,janv,smaug,jesup,jib
...
Most changes are automated. Relevant bit is dom/.clang-format. I had to
manually disable clang-format in a few places where importing external
files and so on that aren't self-contained, and fix a couple includes /
forward declarations.
Differential Revision: https://phabricator.services.mozilla.com/D256800
2025-08-05 11:47:34 +00:00
Emilio Cobos Álvarez
de09ab0dd6
Bug 1887719 - More consistently use UTF8String/nsCString for URLs. r=necko-reviewers,webidl,anti-tracking-reviewers,places-reviewers,jari,kershaw,janv,smaug,hsivonen
...
Sorry for the massive patch but I found it hard to split without
introducing a bunch of copies around...
This mostly makes necko and DOM agree on which strings to use, which
should result on less copies and conversions.
Differential Revision: https://phabricator.services.mozilla.com/D205601
2024-04-04 11:49:57 +00:00
Thomas Wisniewski
a4b603d341
Bug 1842488 - do not add an empty-string content-type header when constructing a Response with a ReadableStream; r=kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D183104
2023-07-11 19:36:24 +00:00
Iulian Moraru
b9d4a656d5
Backed out changeset b3b53ca8393c (bug 1842488) for causing wpt failures on audioworklet.https.sub.html. CLOSED TREE
2023-07-11 18:51:27 +03:00
Thomas Wisniewski
e7c203f287
Bug 1842488 - do not add an empty-string content-type header when constructing a Response with a ReadableStream; r=kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D183104
2023-07-11 12:46:29 +00:00
Kagami Sascha Rosylight
fc11681f1d
Bug 1811882 - Part 4: Use NonAsyncInputToReadableStreamAlgorithms for FetchBody::GetBody() r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D179075
2023-06-06 13:07:46 +00:00
Kagami Sascha Rosylight
45f0f3457c
Bug 1811882 - Part 2: Implement ReadableStream::MaybeGetInputStreamIfUnread r=smaug
...
All existing GetBodyStreamHolder call is consciously done on unread streams, either to simply detect nsIInputStream-based streams or to get the internal nsIInputStream. The function can directly return nsIInputStream to fulfill the existing purposes.
Differential Revision: https://phabricator.services.mozilla.com/D178359
2023-06-06 13:07:46 +00:00
Kagami Sascha Rosylight
2229973496
Bug 1832326 - Part 2: Remove FetchBody::mReadableStreamReader r=smaug
...
FetchBody does nothing with the strong reference. Both ReadableStream and FetchStreamReader have their strong references and corresponding cycle collection, so this one can go away.
Depends on D177904
Differential Revision: https://phabricator.services.mozilla.com/D178098
2023-05-16 00:08:01 +00:00
Kagami Sascha Rosylight
ae70098952
Bug 1832333 - Remove unused ErrorResult in GetBodyUsed r=smaug
...
It was added by bug 1385890 (D8450) to properly interact with JS ReadableStream and is not needed anymore.
Differential Revision: https://phabricator.services.mozilla.com/D177635
2023-05-10 20:11:13 +00:00
Ms2ger
5b5af90f5c
Bug 1758943 - Implement Response.json static method; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D171217
2023-05-08 14:40:55 +00:00
Kagami Sascha Rosylight
702f60f947
Bug 1815431 - Remove BlobBodyStreamHolder r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D169069
2023-02-09 07:01:10 +00:00
Kagami Sascha Rosylight
48d0a87dff
Bug 1803386 - Part 1: Replace ReadableStream::mNativeUnderlyingSource with GetBodyStreamHolder() r=smaug
...
The underlying source algorithms class already has strong ref, so just use it.
Differential Revision: https://phabricator.services.mozilla.com/D166533
2023-01-12 13:43:58 +00:00
Matthew Gaudet
ad845e0b67
Bug 1757241 - Remove !MOZ_DOM_STREAMS code from most files r=smaug
...
I've also tested to verify that JS Streams remains enabled in the JS Shell package
Differential Revision: https://phabricator.services.mozilla.com/D142620
2022-04-13 18:57:48 +00:00
Kagami Sascha Rosylight
14c00e5e01
Bug 1751453 - Part 1: Remove AbortFollower::Unlink() r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D136658
2022-01-24 13:18:33 +00:00
Kagami Sascha Rosylight
5af4408463
Bug 1660555 - Make AbortFollower::mFollowingSignal a WeakPtr r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D136446
2022-01-21 14:40:38 +00:00
Jan Varga
f064e6e5a2
Bug 1750931 - Fix non-unified-build bustage in dom/events, dom/fetch and dom/streams; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D136315
2022-01-19 11:09:55 +00:00
Matthew Gaudet
7cf26082b1
Bug 1734873 - Fetch/Response/Blob ReadableStream integration r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D131550
2022-01-14 21:09:20 +00:00
Eden Chuang
d545418095
Bug 1577346 - P3 Make InternalResponse be SafeRefcounted. r=dom-worker-reviewers,ytausky
...
Depends on D126243
Differential Revision: https://phabricator.services.mozilla.com/D126244
2021-11-08 13:29:32 +00:00
Matthew Gaudet
616369e40b
Bug 1730589 - Initial Implementation of ReadableStreams using WebIDL and DOM technologies r=smaug
...
This patch begins re-implements ReadableStreams using WebIDL and DOM technology (vs the existing JS streams implementation). Some more background is [here](https://docs.google.com/document/d/1MWRkF32KV60ngOY-Ip4PnKbCMvl6VK_Y9QLED8MJJxg/edit# )
This is guarded under a configure flag `--enable-dom-streams`
1. ByteStreams and ReadableStream.tee will come in future patches.
2. I intentionally crash in other parts of the DOM that require streams (Fetch, Response, Blob), until the integration work is done in future patches.
My current plan for that integration doesn't involve re-creating the alternative 'external streams' API from SpiderMonkey's implementation, but I have yet to do enough development to verify that will work.
Differential Revision: https://phabricator.services.mozilla.com/D122643
2021-10-06 18:43:01 +00:00
Tom Schuster
6da014df91
Bug 1684634 - Use InternalHeaders for MimeType instead of caching in the Response/Request constructor. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D101159
2021-01-12 10:38:25 +00:00
Simon Giesecke
46908cfb51
Bug 1660470 - Add missing include directives/forward declarations. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Sylvestre Ledru
68b806d604
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 17:04:01 +00:00
Butkovits Atila
a6e7dcc53f
Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE
2020-11-04 10:54:36 +02:00
Sylvestre Ledru
8f709b39e8
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 08:29:00 +00:00
Jeff Walden
17b7a1950e
Bug 1660555 - Move traverse/unlink operations on |AbortFollower| and |AbortSignalImpl| into static member functions. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D92322
2020-10-29 08:02:58 +00:00
Simon Giesecke
a69d79b6db
Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Boris Zbarsky
19cf87ee1e
Bug 1619112 part 5. Stop accepting nsAString in ErrorResult error-throwing. r=smaug
...
Callers should pass in UTF-8, since that's what the JS engine ends up with in the end anyway.
The various URL changes are because NS_NewURI converts incoming nsAString to
UTF-8 anyway. So we might as well do that up-front and then use the UTF-8
string for both the NS_NewURI call and the error-reporting if it fails.
Differential Revision: https://phabricator.services.mozilla.com/D65543
2020-03-06 21:08:02 +00:00
Boris Zbarsky
e62a6fc4d1
Bug 1619112 part 2. Pass char literals instead of char16_t literals into ErrorResult throwing methods. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D65538
2020-03-06 21:04:58 +00:00
Boris Zbarsky
2df1df0176
Bug 1517588. Use nsIPrincipal::IsSystemPrincipal instead of nsContentUtils::IsSystemPrincipal r=bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D53067
2019-12-05 04:44:32 +00:00
Kagami Sascha Rosylight
a4eca894f1
Bug 824857: Support IDL stringifier attributes r=bzbarsky
...
Differential Revision: https://phabricator.services.mozilla.com/D48355
2019-10-23 04:55:54 +00:00
Boris Zbarsky
ebaf6de379
Bug 1581173 part 1. Add a way to more easily throw TypeErrors and RangeErrors with custom message strings via ErrorResult. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D45932
2019-09-20 02:19:18 +00:00
Boris Zbarsky
beb41e769e
Bug 1580082. Align Response constructor IDL with spec. r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D45411
2019-09-11 11:06:58 +00:00
Boris Zbarsky
011222050d
Bug 1565767 part 4. Remove some unnecesary refcounting at Document::GetBaseURI callsites. r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D37972
2019-07-15 18:28:43 +00:00
Andrea Marchesini
229026c8bf
Bug 1557781 - Better life-time management for BodyStream/FetchStream - part 2 - BodyStream, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D35529
2019-07-01 20:01:17 +00:00
Andrea Marchesini
2af1292e26
Bug 1558923 - Simplify URL API, r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D34766
2019-06-13 19:45:19 +00:00