The methods CloseEntirePopoverList, HidePopoverStackUntil, AutoPopoverList,
GetTopmostAutoPopover, and IsAutoPopover all either take a popover list (of hint
or auto) or have equivalent methods (e.g. HintPopoverList). In order to
introduce popover=hint, this change refactors these methods to take a
PopoverAttributeState which determines the "opened in mode" to filter the
popover list by, ensuring that these methods can act on either Auto or Hint
popovers.
This change has no behavioural changes - everything should function the
same - but it is preparatory work for popover=hint.
Differential Revision: https://phabricator.services.mozilla.com/D276372
This uses the implicit "invoker" from each element to set the
ToggleEvent Source, so that toggle events dispatched from Dialogs &
Popovers include the `source` attribute.
Differential Revision: https://phabricator.services.mozilla.com/D265435
This reverts commit 4c94fd990e.
Revert "Bug 1968987 - Part 2 - Set ToggleEvent source on Popover/Dialog r=smaug,dom-core"
This reverts commit f322cfc77f.
Revert "Bug 1968987 - Part 1 - Add Source to ToggleEvent, no longer generate. r=smaug,dom-core,webidl,saschanaz"
This reverts commit 7df5d3019b.
This uses the implicit "invoker" from each element to set the
ToggleEvent Source, so that toggle events dispatched from Dialogs &
Popovers include the `source` attribute.
Differential Revision: https://phabricator.services.mozilla.com/D265435
This uses the implicit "invoker" from each element to set the
ToggleEvent Source, so that toggle events dispatched from Dialogs &
Popovers include the `source` attribute.
Differential Revision: https://phabricator.services.mozilla.com/D265435
This reverts commit f66dd32b15.
Revert "Bug 1968987 - Part 1 - Add Source to ToggleEvent, no longer generate. r=smaug,dom-core,webidl,saschanaz"
This reverts commit 89ee599ac8.
This uses the implicit "invoker" from each element to set the
ToggleEvent Source, so that toggle events dispatched from Dialogs &
Popovers include the `source` attribute.
Differential Revision: https://phabricator.services.mozilla.com/D265435
This mostly adds code comments, slightly reorganises some code (in
non-user impacting ways) and removes some TODOs which are now done.
Differential Revision: https://phabricator.services.mozilla.com/D264097
This mostly adds code comments, slightly reorganises some code (in
non-user impacting ways) and removes some TODOs which are now done.
Differential Revision: https://phabricator.services.mozilla.com/D264097
This mostly adds code comments, slightly reorganises some code (in
non-user impacting ways) and removes some TODOs which are now done.
Differential Revision: https://phabricator.services.mozilla.com/D264097
Most changes are automated. Relevant bit is dom/.clang-format. I had to
manually disable clang-format in a few places where importing external
files and so on that aren't self-contained, and fix a couple includes /
forward declarations.
Differential Revision: https://phabricator.services.mozilla.com/D256800
iframe tests neeeded tweak because the changes for about:blank haven't landed quite yet.
Render blocking and such aren't supported, so the .ini files are still there.
Selection test seemed to be very chromium specific.
Differential Revision: https://phabricator.services.mozilla.com/D255463
iframe tests neeeded tweak because the changes for about:blank haven't landed quite yet.
Render blocking and such aren't supported, so the .ini files are still there.
Selection test seemed to be very chromium specific.
Differential Revision: https://phabricator.services.mozilla.com/D255463
This allows us to add more capabilities to this routine (such as
notifying other classes that there is an active CloseWatcher) without
needing to add too much duplication to the codebase.
Differential Revision: https://phabricator.services.mozilla.com/D249647
This reverts commit d33dcda2c6.
Revert "Bug 1950338 - Part 8: Rename invoketarget->commandfor, invokeaction->command r=webidl,devtools-reviewers,nchevobbe,smaug"
This reverts commit 0fe8930d32.
Revert "Bug 1950338 - Part 7: Move command&commandfor logic to HTMLButtonElement r=smaug"
This reverts commit 5a9255cd0b.
Revert "Bug 1950338 - Part 6: Rename invoker functions to command functions r=dom-core,masayuki"
This reverts commit 76f840a55a.
Revert "Bug 1950338 - Part 5: Remove InvokeEvent, migrate .invoker to CommandEvent .source r=webidl,devtools-reviewers,nchevobbe,emilio,smaug"
This reverts commit f7d2727969.
Revert "Bug 1950338 - Part 4: Move invokeTargetElement, invokeAction to HTMLButtonElement IDL r=webidl,smaug"
This reverts commit a7a025a843.
Revert "Bug 1950338 - Part 3: Expose CommandEvent in commandfor pref; move from chrome-webidl to webidl r=webidl,emilio"
This reverts commit eb133a45e6.
Revert "Bug 1950338 - Part 2: Move invokers meta ini to correct directory r=dom-core,sefeng"
This reverts commit face866adb.
Revert "Bug 1950338 - Part 1: Rename `dom.element.invokers` flag to `dom.element.commandfor` r=webidl,devtools-reviewers,nchevobbe,smaug"
This reverts commit 532bb887b5.
This patch makes the usage of `EnumTable`s safer
by using `Span`s instead of relying on an empty
element at the end.
Also the name has been changed from `EnumTable`
to `EnumTableEntry` to be more precise.
Differential Revision: https://phabricator.services.mozilla.com/D247453
This patch makes the usage of `EnumTable`s safer
by using `Span`s instead of relying on an empty
element at the end.
Also the name has been changed from `EnumTable`
to `EnumTableEntry` to be more precise.
Differential Revision: https://phabricator.services.mozilla.com/D247453
Keith Cirkel