HeyPuter/firefox
1
0 Fork 0
mirror of https://github.com/HeyPuter/firefox.git synced 2026-11-13 20:14:57 -10:00
Code Issues Packages Projects Releases Wiki Activity
976,508 Commits 2 Branches 0 Tags
singlethreaded
Commit Graph
106 Commits
Author SHA1 Message Date
Emilio Cobos Álvarez 1bd0da8bf7 Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug 
As per the HTML terminology (https://html.spec.whatwg.org/#relevant)

Automatic rename using sed + lints.

Differential Revision: https://phabricator.services.mozilla.com/D297184
 2026-05-02 22:04:17 +00:00
iulian moraru 480fc572da Revert "Bug 2036439, Bug 2033243 - Deal with ownerGlobal -> documentGlobal rename in extensions. r=robwu,home-newtab-reviewers,mconley" for causing newtab failures. 
This reverts commit 4f62279d01.

Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug"

This reverts commit 91a4ece356.

Revert "Bug 2033243 - BindToOwner -> BindToGlobal. r=dom-core,smaug"

This reverts commit 5a95a889e1.

Revert "Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug"

This reverts commit 7177a68e67.

Revert "Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop"

This reverts commit 5263254690.
 2026-05-02 16:43:35 +00:00
Emilio Cobos Álvarez 7177a68e67 Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug 
As per the HTML terminology (https://html.spec.whatwg.org/#relevant)

Automatic rename using sed + lints.

Differential Revision: https://phabricator.services.mozilla.com/D297184
 2026-05-02 15:33:23 +00:00
rperta d4cc71008d Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug" on developer request 
This reverts commit e58e122135.

This reverts commit 84ca206f3e.

This reverts commit a7945292ed.

This reverts commit 367d83d299.
 2026-05-02 06:20:30 +00:00
Emilio Cobos Álvarez a7945292ed Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug 
As per the HTML terminology (https://html.spec.whatwg.org/#relevant)

Automatic rename using sed + lints.

Differential Revision: https://phabricator.services.mozilla.com/D297184
 2026-05-01 11:58:14 +00:00
agoloman c814da612d Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug" for causing multiple failures. 
This reverts commit c7246654bc.

Revert "Bug 2033243 - BindToOwner -> BindToGlobal. r=dom-core,smaug"

This reverts commit 8873ddf33c.

Revert "Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug"

This reverts commit 8bf999e03c.

Revert "Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop"

This reverts commit 7dea1af2e0.
 2026-04-30 20:13:14 +00:00
Emilio Cobos Álvarez 8bf999e03c Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug 
As per the HTML terminology (https://html.spec.whatwg.org/#relevant)

Automatic rename using sed + lints.

Differential Revision: https://phabricator.services.mozilla.com/D297184
 2026-04-30 17:47:11 +00:00
Lars Eggert 07aa6e6d0b Bug 2027481 - Propagate SetSocketOption errors before STS attachment. r=kershaw,necko-reviewers 
`nsUDPSocket::SetSocketOption` dispatches a fire-and-forget runnable to
the STS thread when called off-thread, silently discarding any error from
the underlying `PR_SetSocketOption` call. This caused `InitLocal` to
resolve the `opened` promise even when `setsockopt(IP_ADD_MEMBERSHIP)`
failed (e.g. no multicast-capable interface on CI), leaving the multicast
test waiting indefinitely for a loopback packet that never arrived.

Before attachment to STS, the socket FD is only accessed from the calling
thread, so `PR_SetSocketOption` can be called directly. Add
`Atomic<bool, ReleaseAcquire> mAttached` and use it in `SetSocketOption`
to choose: dispatch when attached (existing behaviour), call directly when
not (new, with real error propagation).

Also move `DoPendingMcastCommand()` before `AsyncListen()` in `InitLocal`
so pending multicast joins execute while the socket is still unattached,
and extend `CloseWithReason` to reject `mOpened` in the `Open` state as
well as `Opening`, since `InitLocal` sets the state to `Open` before
calling `DoPendingMcastCommand`.

Differential Revision: https://phabricator.services.mozilla.com/D293867
 2026-04-13 13:15:38 +00:00
Kershaw Chang 89d90af068 Bug 2024468 - Ensure UDPSocket remains alive during CloseWithReason, r=necko-reviewers,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D290384
 2026-03-27 16:09:12 +00:00
Nika Layzell 5f0f9dd22a Bug 2020817 - Part 4: Annotate & clean up nsACString callers of BeginReading/Data, r=xpcom-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,toolkit-telemetry-reviewers-rotation,layout-reviewers,dom-worker-reviewers,gfx-reviewers,webgpu-reviewers,necko-reviewers,dom-core,smaug,handyman,emilio,pehrsons,kershaw,timhuang,edenchuang,padenot,bradwerth 
This is a large number of largely mechanical changes. When possible, the code
was called to directly call `.get()` instead, performing the assertions
manually. In many places PromiseFlatCString() calls were added to dynamically
copy the strings into null terminated buffers if the string was not null
terminated.

Differential Revision: https://phabricator.services.mozilla.com/D286158
 2026-03-25 08:23:04 +00:00
Sylvestre Ledru 9eb1a31a98 Bug 2023419 - Remove Emacs/Vim modelines from dom/ r=emilio,media-playback-reviewers,webidl,padenot 
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287843
 2026-03-16 21:02:32 +00:00
serge-sans-paille b093ca6e20 Bug 2020581 - Replace copy assignment by move assignment in dom/ r=media-playback-reviewers,webrtc-reviewers,dom-worker-reviewers,dom-core,asuth,padenot,smaug,bwc 
Commit automatically generated through clang-tidy's
performance-use-std-move new pass.

- Maybe type has a dedicated move operator
- And TimingParams also have a dedicated move operator because of Maybe
  members
- OwningAnimationTarget benefits from being moved
- nsCOMPtr benefits from being moved
- std::vector benefits from being moved
- std::string benefits from being moved
- SMILTimeValueSpecParams benefits from being moved

Differential Revision: https://phabricator.services.mozilla.com/D285674
 2026-03-05 00:58:38 +00:00
Andreea Silaghi df905fef77 Revert "Bug 2020587 - Replace copy assignment by move assignment in xpcom/ r=xpcom-reviewers,jstutte" for causing failures at TestFileSystemHelpers This reverts commit d3c7b9c4d1. 
This reverts commit 38c02da27e.
 2026-03-04 08:20:03 +00:00
serge-sans-paille 38c02da27e Bug 2020581 - Replace copy assignment by move assignment in dom/ r=media-playback-reviewers,webrtc-reviewers,dom-worker-reviewers,dom-core,asuth,padenot,smaug,bwc 
Commit automatically generated through clang-tidy's
performance-use-std-move new pass.

- Maybe type has a dedicated move operator
- And TimingParams also have a dedicated move operator because of Maybe
  members
- OwningAnimationTarget benefits from being moved
- nsCOMPtr benefits from being moved
- std::vector benefits from being moved
- std::string benefits from being moved
- SMILTimeValueSpecParams benefits from being moved

Differential Revision: https://phabricator.services.mozilla.com/D285674
 2026-03-04 07:00:30 +00:00
Emilio Cobos Álvarez 791917d8af Bug 1976665 - Sort headers in dom/. r=dom-core,media-playback-reviewers,webrtc-reviewers,dom-storage-reviewers,padenot,janv,smaug,jesup,jib 
Most changes are automated. Relevant bit is dom/.clang-format. I had to
manually disable clang-format in a few places where importing external
files and so on that aren't self-contained, and fix a couple includes /
forward declarations.

Differential Revision: https://phabricator.services.mozilla.com/D256800
 2025-08-05 11:47:34 +00:00
Nika Layzell e45c9840d1 Bug 1935714 - Part 1: Improve handling of large nsStringStream streams at the API level, r=mccr8,webdriver-reviewers,necko-reviewers,valentin,extension-reviewers,devtools-reviewers,robwu,ochameau 
This changes how the `nsIStringInputStream` interface is initialized in
C++ code to make it support larger stream sizes better. This involved
moving away from using nsCString in some cases, as it has a maximum
string length of approximately 2GiB.

This also required changing the signature of one of the methods making
it no longer JS-compatible. As the `setData` method was awkward to use
from JS anyway, the method was split into two (one for C++ callers, and
one for JS callers), and renamed. This required changes to the various
JS callers.

Differential Revision: https://phabricator.services.mozilla.com/D231982
 2024-12-16 20:21:58 +00:00
Peter Van der Beken 39d1a604a6 Bug 1900930 - Add WouldReportJSException() calls. r=dom-core,farre,necko-reviewers,kershaw 
TypedArray::Create will put exceptions on the ErrorResult, so signal that we're
dealing with them in various callsites.

Differential Revision: https://phabricator.services.mozilla.com/D214794
 2024-08-21 08:43:09 +00:00
Stanca Serban 68116687ca Backed out 6 changesets (bug 1900930) for causing xpcshell assertion failures in ErrorResult.h. CLOSED TREE 
Backed out changeset 5234a13894b2 (bug 1900930)
Backed out changeset 638842494167 (bug 1900930)
Backed out changeset 36695bae43ed (bug 1900930)
Backed out changeset 23ab72aa4589 (bug 1900930)
Backed out changeset c89109c12d59 (bug 1900930)
Backed out changeset 2d3f52edb98a (bug 1900930)
 2024-07-25 13:53:53 +03:00
Peter Van der Beken f86b2c795d Bug 1900930 - Add WouldReportJSException() calls. r=dom-core,farre 
TypedArray::Create will put exceptions on the ErrorResult, so signal that we're
dealing with them in various callsites.

Differential Revision: https://phabricator.services.mozilla.com/D214794
 2024-07-25 07:40:41 +00:00
Emilio Cobos Álvarez 71bf77b3fe Bug 1904442 - Rename GlobalTeardownObserver::GetOwner to GetOwnerWindow. r=smaug,media-playback-reviewers,dom-storage-reviewers,aosmond,padenot,asuth 
Also HasOrHasHadOwner to HasOrHasHadOwnerWindow.

Differential Revision: https://phabricator.services.mozilla.com/D214772
 2024-07-01 11:49:59 +00:00
Peter Van der Beken 4a7386597a Bug 1849037 - Add ErrorResult to TypedArray::Create. r=necko-reviewers,extension-reviewers,media-playback-reviewers,webidl,profiler-reviewers,farre,padenot,smaug,robwu,jesup,aabh 
Differential Revision: https://phabricator.services.mozilla.com/D191418
 2023-11-11 08:24:05 +00:00
Peter Van der Beken 64b9731b0e Bug 1849037 - Pass objects that support conversion to a Span directly to TypedArray::Create as a Span. r=necko-reviewers,extension-reviewers,media-playback-reviewers,profiler-reviewers,farre,padenot,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D191416
 2023-11-11 08:24:04 +00:00
Stanca Serban fa9cf4e6a5 Backed out 3 changesets (bug 1849037) for causing mochitests failures in test_gamepad_extensions.html. 
Backed out changeset 27fd9f6f57ea (bug 1849037)
Backed out changeset 89aa49de2473 (bug 1849037)
Backed out changeset c336a8c78928 (bug 1849037)
 2023-11-08 17:12:40 +02:00
Peter Van der Beken d0efcee341 Bug 1849037 - Add ErrorResult to TypedArray::Create. r=necko-reviewers,extension-reviewers,media-playback-reviewers,webidl,profiler-reviewers,farre,padenot,smaug,robwu,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D191418
 2023-11-08 11:29:05 +00:00
Peter Van der Beken 5b25b370be Bug 1849037 - Pass objects that support conversion to a Span directly to TypedArray::Create as a Span. r=necko-reviewers,extension-reviewers,media-playback-reviewers,profiler-reviewers,farre,padenot,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D191416
 2023-11-08 11:29:04 +00:00
Emilio Cobos Álvarez 3bbfb2e943 Bug 1817122 - Make AsyncEventDispatcher(Event) take ownership of the event. r=smaug,media-playback-reviewers,padenot 
Differential Revision: https://phabricator.services.mozilla.com/D190059
 2023-10-04 19:37:39 +00:00
Peter Van der Beken 2ba4663c86 Bug 1690111 - Use new TypedArray APIs for appending data to a container. r=farre,extension-reviewers,media-playback-reviewers,kmag,alwu,padenot 
Depends on D152494

Differential Revision: https://phabricator.services.mozilla.com/D152495
 2023-09-20 09:42:01 +00:00
Cosmin Sabou c3effd7450 Backed out 13 changesets (bug 1690111) for causing fetch related crashes. 
Backed out changeset 5f2c25d194ad (bug 1690111)
Backed out changeset 76c408bcd053 (bug 1690111)
Backed out changeset 6d0649fdafff (bug 1690111)
Backed out changeset c1330b5e8c43 (bug 1690111)
Backed out changeset 5fa36d8fd2a5 (bug 1690111)
Backed out changeset daf7d747853a (bug 1690111)
Backed out changeset f70e09a7f5c6 (bug 1690111)
Backed out changeset 40c6d6eed7f8 (bug 1690111)
Backed out changeset 692f2a759573 (bug 1690111)
Backed out changeset 7140866dd9f6 (bug 1690111)
Backed out changeset 2865fe682139 (bug 1690111)
Backed out changeset 9dcd2416f8a5 (bug 1690111)
Backed out changeset 9c411bf84079 (bug 1690111)
 2023-09-11 17:55:24 +03:00
Peter Van der Beken e953841f74 Bug 1690111 - Use new TypedArray APIs for appending data to a container. r=farre,extension-reviewers,media-playback-reviewers,kmag,alwu,padenot 
Depends on D152494

Differential Revision: https://phabricator.services.mozilla.com/D152495
 2023-09-11 12:52:20 +00:00
Nika Layzell dc116daf53 Bug 1749059 - Remove Quantum DOM support from IPDL, r=ipc-reviewers,mccr8 
This is no longer necessary as the Quantum DOM project is no longer
happening, and removing support simplifies various components inside of
IPDL.

As some code used the support to get a `nsISerialEventTarget` for an
actor's worker thread, that method was replaced with a method which
instead pulls the nsISerialEventTarget from the MessageChannel and
should work on all actors.

Differential Revision: https://phabricator.services.mozilla.com/D135411
 2022-01-25 20:29:46 +00:00
Andi-Bogdan Postelnicu 4bbf229571 Bug 1725145 - header files fixes in the hybrid build env. r=valentin 
Differential Revision: https://phabricator.services.mozilla.com/D122343
 2021-08-22 10:21:55 +00:00
Valentin Gosu bf46812563 Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana 
Differential Revision: https://phabricator.services.mozilla.com/D113752
 2021-05-10 09:26:01 +00:00
Brindusan Cristian 7160a8c9c4 Backed out 2 changesets (bug 1708116) for causing xpcshell failures in test_udpsocket_offline.js and bc failures in browser_cookies_ipv6.js. CLOSED TREE 
Backed out changeset 0c9b303226f1 (bug 1708116)
Backed out changeset e3be13d3c045 (bug 1708116)
 2021-05-06 16:35:48 +03:00
Valentin Gosu 9050e8f69b Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana 
Differential Revision: https://phabricator.services.mozilla.com/D113752
 2021-05-06 10:06:46 +00:00
Sandor Molnar 7cf808420e Backed out 2 changesets (bug 1708116) for causing build bustages. CLOSED TREE 
Backed out changeset d1488e9d64a6 (bug 1708116)
Backed out changeset 44ed91f0b7b4 (bug 1708116)
 2021-05-04 18:41:36 +03:00
Valentin Gosu 5ec2d7d670 Bug 1708116 - Use NetAddr::InitFromString instead of PR_StringToNetAddr r=necko-reviewers,dragana 
Differential Revision: https://phabricator.services.mozilla.com/D113752
 2021-05-04 14:05:59 +00:00
Sylvestre Ledru 68b806d604 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi 
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
 2020-11-04 17:04:01 +00:00
Butkovits Atila a6e7dcc53f Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE 2020-11-04 10:54:36 +02:00
Sylvestre Ledru 8f709b39e8 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi 
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
 2020-11-04 08:29:00 +00:00
Simon Giesecke ab6f0a7137 Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi 
Differential Revision: https://phabricator.services.mozilla.com/D82325
 2020-09-23 15:17:15 +00:00
Nathan Froyd 55437f2e0c Bug 1662251 - stop assigning from NS_Convert* values, mostly; r=sg 
This patch was generated by running:

```
perl -p -i \
     -e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF8toUTF16\((.*)\);/\1CopyUTF8toUTF16(\3, \2);/;' \
     -e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF16toUTF8\((.*)\);/\1CopyUTF16toUTF8(\3, \2);/;' \
     $FILE
```

against every .cpp and .h in mozilla-central, and then fixing up the
inevitable errors that happen as a result of matching C++ expressions with
regexes.  The errors fell into three categories:

1. Calling the convert functions with `std::string::c_str()`; these were
   changed to simply pass the string instead, relying on implicit conversion
   to `mozilla::Span`.
2. Calling the convert functions with raw pointers, which is not permitted
   with the copy functions; these were changed to invoke `MakeStringSpan` first.
3. Other miscellaneous errors resulting from over-eager regexes and/or the
   replacement not being type-aware.  These changes were reverted.

Differential Revision: https://phabricator.services.mozilla.com/D88903
 2020-09-02 09:54:37 +00:00
Valentin Gosu 4284e1d4f0 Bug 1659132 - Make AddrInfo immutable r=dragana,necko-reviewers 
Also adds constructors for NetAddr to avoid it being uninitialized.

Differential Revision: https://phabricator.services.mozilla.com/D87091
 2020-09-01 07:22:14 +00:00
Butkovits Atila f3fb580a61 Backed out 2 changesets (bug 1659132) for failures at browser_cleanFlow.js. CLOSED TREE 
Backed out changeset 7952fd59f59b (bug 1659132)
Backed out changeset fa8ce4af10a0 (bug 1659132)
 2020-08-25 13:02:33 +03:00
Valentin Gosu 226f76e4f4 Bug 1659132 - Make AddrInfo immutable r=dragana,necko-reviewers 
Also adds constructors for NetAddr to avoid it being uninitialized.

Differential Revision: https://phabricator.services.mozilla.com/D87091
 2020-08-25 08:02:22 +00:00
Butkovits Atila 9b1999f2d4 Backed out 2 changesets (bug 1659132) for build bustage. CLOSED TREE 
Backed out changeset 1caace74f89e (bug 1659132)
Backed out changeset 58fdbfbe05a1 (bug 1659132)
 2020-08-25 09:43:01 +03:00
Valentin Gosu dac4f3d4d6 Bug 1659132 - Make AddrInfo immutable r=dragana,necko-reviewers 
Also adds constructors for NetAddr to avoid it being uninitialized.

Differential Revision: https://phabricator.services.mozilla.com/D87091
 2020-08-24 12:23:06 +00:00
Simon Giesecke a69d79b6db Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D80860
 2020-07-01 08:29:29 +00:00
Jean-Yves Avenard 8e18348f93 Bug 1647133 - P1. Use nsISerialEventTarget where it's actually that. r=nika 
Differential Revision: https://phabricator.services.mozilla.com/D80419
 2020-06-23 03:21:14 +00:00
Edgar Chen ac8c576f36 bug 1610296 - Rename TypedArray_base::ComputeLengthAndData to TypedArray_base::ComputeState; r=bzbarsky 
Differential Revision: https://phabricator.services.mozilla.com/D60514
 2020-01-23 03:22:06 +00:00
Boris Zbarsky b5a80177f7 Bug 927610 part 1. Stop using NS_ERROR_TYPE_ERR in UDPSocket. r=smaug 
The only ways DispatchReceivedData can fail are if our scope is torn down, we
OOM when creating a typed array, or we fail to queue a runnable.  These all
seem like pretty unexpected situations, so NS_ERROR_UNEXPECTED seems
appropriate if we don't want to just propagate through the error from
DispatchReceivedData.

Differential Revision: https://phabricator.services.mozilla.com/D46483
 2019-09-24 16:53:44 +00:00