Adds an Open Tabs panel to the revamped sidebar, gated behind the new
sidebar.openTabsPanel.enabled pref (default false) until the feature is
complete.
The panel reuses the existing Firefox View OpenTabs infrastructure
(getTabsTargetForWindow and OpenTabsController) and renders the current
window's tabs into the sidebar's sidebar-tab-list component. It listens
for TabChange events to stay in sync, and selecting a row activates the
corresponding tab.
Please Note: the panel is registered via registerPrefSidebar() rather than a
static generateSidebarsMap() entry, so its availability follows the
pref, consistent with the other pref-gated panels in the sidebar.
This also needed a label mapping in sidebar-customize.mjs and a
sidebar-menu-open-tabs-header string.
I am happy to adjust if you'd prefer a
different approach.
Search, sorting, multi-window grouping, the context menu, and telemetry
are deferred to follow-up bugs.
Differential Revision: https://phabricator.services.mozilla.com/D301981
And apply the auto-fix from the linter. Note that we exclude RefPtr from
the check as it plays badly with our CanRunScriptChecker's linter.
We also explicitly silent warning for loops on nsTObserverArray, as their
iterator is designed to support invalidation.
Differential Revision: https://phabricator.services.mozilla.com/D293497
- Adds a website context chips header to the input box in sidebar mode. The header will always include current tab as context and updates the chip on navigation.
- Refactors website-chip-container to render website chips from a data array
Differential Revision: https://phabricator.services.mozilla.com/D281290
- Adds a website context chips header to the input box in sidebar mode. The header will always include current tab as context and updates the chip on navigation.
- Refactors website-chip-container to render website chips from a data array
Differential Revision: https://phabricator.services.mozilla.com/D281290
- Adds a website context chips header to the input box in sidebar mode. The header will always include current tab as context and updates the chip on navigation.
- Refactors website-chip-container to render website chips from a data array
Differential Revision: https://phabricator.services.mozilla.com/D281290
This moves the Smartbar into the AI Window page. To support this, the SmartbarInput now falls back to getting the browser window when gBrowser is not available in the current window context.
The Smartbar currently dependents on global Urlbar and browser styles. Making it independent for in-page use will be addressed with Bug 2008938.
Differential Revision: https://phabricator.services.mozilla.com/D278113
This moves the Smartbar into the AI Window page. To support this, the SmartbarInput now falls back to getting the browser window when gBrowser is not available in the current window context.
The Smartbar currently dependents on global Urlbar and browser styles. Making it independent for in-page use will be addressed with Bug 2008938.
Differential Revision: https://phabricator.services.mozilla.com/D278113
Removes dead code referencing the old clear history dialog:
- Backup component: removed useOldClearHistoryDialog pref checks and old v1 shutdown prefs
- C++ allowlist: removed entries for deleted sanitize.xhtml and clearSiteData.xhtml files
Differential Revision: https://phabricator.services.mozilla.com/D279160
Adds a Migrate button to profiles in about:profiles that are elligible for migration. This is profiles
that are not currently in use and don't already have multiple profiles grouped with them.
Differential Revision: https://phabricator.services.mozilla.com/D270525
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
DrSeed Lu