Daniel Holbert
a70a6fc1d0
Bug 2038802: Use MakeRefPtr to do allocation for local RefPtr variables, in image/. r=tnikkel
...
(And remove one unnecessary null-check for 'progressproxy' which is
infallibly-allocated.)
Differential Revision: https://phabricator.services.mozilla.com/D299853
2026-05-12 19:54:00 +00:00
Sylvestre Ledru
f6f356ae0b
Bug 2036400 - Initialize uninitialized scalar fields in image to fix Coverity uninitialized-scalar defects r=gfx-reviewers,tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D298134
2026-05-05 06:47:29 +00:00
Sylvestre Ledru
2f632434a3
Bug 2036402 - Apply std::move in editor where values can be moved instead of copied r=dom-core,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D298107
2026-05-04 11:13:42 +00:00
Sylvestre Ledru
8f90026828
Bug 2023419 - Remove Emacs/Vim modelines from image/ r=emilio
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287848
2026-03-17 07:58:04 +00:00
Timothy Nikkel
70b5fa47a1
Bug 2017759. Pack imgRequest better. r=gfx-reviewers,lsalzman
...
mCORSMode is 1 byte, we can pack it with these other 1 byte fields instead of wasting an 8 byte aligned slot.
Differential Revision: https://phabricator.services.mozilla.com/D283987
2026-02-19 03:17:48 +00:00
phigl
ef13588add
Bug 1973003 - The length of the original request is now also saved. r=bomsy,necko-reviewers,devtools-reviewers,jesup
...
The content length of the original request is now also saved and passed
as new content length for cached images when notifying the observers.
Differential Revision: https://phabricator.services.mozilla.com/D280311
2026-02-10 22:05:57 +00:00
Alexandru Marc
5532798fcc
Backed out changeset b5d9c8b42014 (bug 1917901) for causing crashes. ( Bug 1924737 ) a=backout
2024-10-15 16:56:37 +03:00
Randell Jesup
9c79b915b2
Bug 1917901: Make it ok to retarget OnDataAvailable multiple times until the first ODA is received r=necko-reviewers,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D223651
2024-10-14 19:56:20 +00:00
Stanca Serban
e8ed83c212
Backed out changeset 34295cdf7c5a (bug 1917901) for causing multiple failures. CLOSED TREE
2024-10-11 05:11:22 +03:00
Randell Jesup
4c01dede62
Bug 1917901: Make it ok to retarget OnDataAvailable multiple times until the first ODA is received r=necko-reviewers,kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D223651
2024-10-10 19:46:43 +00:00
Tooru Fujisawa
adec9d4fda
Bug 1907009 - Part 1: Add CacheExpirationTime type. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D217957
2024-08-06 05:38:23 +00:00
Timothy Nikkel
2e9224d316
Bug 1895211. Get the image in imgRequest::OnStopRequest after calling OnDataAvailable because that might create the image. r=gfx-reviewers,nical
...
Differential Revision: https://phabricator.services.mozilla.com/D209522
2024-05-17 23:26:18 +00:00
Tooru Fujisawa
87e7efb482
Bug 1893402 - Part 2: Use minimum cache expiration time in image cache. r=tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D208979
2024-05-17 11:20:59 +00:00
Tamas Szentpeteri
4214cd6de9
Backed out 2 changesets (bug 1893402) for causing mochitest failures regarding nsGlobalWindowInner. CLOSED TREE
...
Backed out changeset e909b94c1280 (bug 1893402)
Backed out changeset beef636e1562 (bug 1893402)
2024-05-17 00:16:25 +03:00
Tooru Fujisawa
289001626d
Bug 1893402 - Part 2: Use minimum cache expiration time in image cache. r=tnikkel
...
Differential Revision: https://phabricator.services.mozilla.com/D208979
2024-05-16 15:40:41 +00:00
Randell Jesup
b32ead2406
Bug 1356686 - Ensure that imgRequest::CheckListenerChain returns the correct value r=tnikkel
...
SVGs must be coded on MainThread because they need to access the LoadGroup,
etc, while other images can be decoded via the decode pool. This ensures
that CheckListenerChain() will return the right value for this instance.
Differential Revision: https://phabricator.services.mozilla.com/D203181
2024-03-19 17:27:23 +00:00
Sandor Molnar
36dcd21ffb
Backed out 4 changesets (bug 1356686) for causing build bustages @ netwerk/protocol/http/HttpChannelChild.cpp CLOSED TREE
...
Backed out changeset 63dc52c69902 (bug 1356686)
Backed out changeset 6e9726c26d07 (bug 1356686)
Backed out changeset 3b150d676b31 (bug 1356686)
Backed out changeset 54754a50d992 (bug 1356686)
2024-03-19 08:29:08 +02:00
Randell Jesup
753e683d88
Bug 1356686 - Ensure that imgRequest::CheckListenerChain returns the correct value r=tnikkel
...
SVGs must be coded on MainThread because they need to access the LoadGroup,
etc, while other images can be decoded via the decode pool. This ensures
that CheckListenerChain() will return the right value for this instance.
Differential Revision: https://phabricator.services.mozilla.com/D203181
2024-03-18 20:04:01 +00:00
Timothy Nikkel
6cf9261d16
Bug 1880054. Simplify some imagelib event target code. r=gfx-reviewers,lsalzman
...
This code was added before we decided to do fission, when we wanted to separate out different sites that were in the same process so we could prioritize them better. We are not going down that path so we can simplify this code. There should be no change in functionality with this patch, just simpler code.
Differential Revision: https://phabricator.services.mozilla.com/D201705
2024-02-25 04:54:33 +00:00
Sean Feng
2d6e584e05
Bug 1722322 - Implement LargestContentfulPaint r=emilio
...
Spec: https://w3c.github.io/largest-contentful-paint
Differential Revision: https://phabricator.services.mozilla.com/D151079
2023-11-02 20:53:36 +00:00
Sandor Molnar
d23e2827b7
Backed out 7 changesets (bug 1722322) for causing bp-nu bustages
...
Backed out changeset 0ebd32e273b8 (bug 1722322)
Backed out changeset 7a75717f127c (bug 1722322)
Backed out changeset c2a6440a83d7 (bug 1722322)
Backed out changeset 9955756855bd (bug 1722322)
Backed out changeset 37fccb407777 (bug 1722322)
Backed out changeset f52b1f28f753 (bug 1722322)
Backed out changeset 0121c8cf5d2f (bug 1722322)
2023-11-02 21:27:24 +02:00
Sean Feng
cacfa492a8
Bug 1722322 - Implement LargestContentfulPaint r=emilio
...
Spec: https://w3c.github.io/largest-contentful-paint
Differential Revision: https://phabricator.services.mozilla.com/D151079
2023-11-02 17:04:47 +00:00
sunil mayya
8fc5324936
Bug 1851992 - implement nsIThreadRetargetableStreamListener::OnDataFinished to multiple listeners. r=necko-reviewers,extension-reviewers,jesup,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D187833
2023-10-27 13:30:11 +00:00
Narcis Beleuzu
a71d185ff5
Backed out 6 changesets (bug 1851992) for DT failure on browser_net_image_cache.js . CLOSED TREE
...
Backed out changeset 3ceaf46f8f55 (bug 1851992)
Backed out changeset c9d322362e22 (bug 1851992)
Backed out changeset 673df3f83249 (bug 1851992)
Backed out changeset 46e18c56dd39 (bug 1851992)
Backed out changeset f9f9143ac713 (bug 1851992)
Backed out changeset 38c40d735ab7 (bug 1851992)
2023-10-24 13:16:40 +03:00
sunil mayya
69ed451168
Bug 1851992 - implement nsIThreadRetargetableStreamListener::OnDataFinished to multiple listeners. r=necko-reviewers,extension-reviewers,jesup,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D187833
2023-10-24 01:48:09 +00:00
Cristina Horotan
c792918ab6
Backed out 5 changesets (bug 1851992) for causing multiple failures
...
Backed out changeset d28399b3d947 (bug 1851992)
Backed out changeset 95e4df69007a (bug 1851992)
Backed out changeset fa61d4e76827 (bug 1851992)
Backed out changeset 79969d9eb5cd (bug 1851992)
Backed out changeset 03c17255f1af (bug 1851992)
2023-10-17 14:48:23 +03:00
sunil mayya
40a8c4d35c
Bug 1851992 - implement nsIThreadRetargetableStreamListener::OnDataFinished to multiple listeners. r=necko-reviewers,extension-reviewers,jesup,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D187833
2023-10-17 08:27:49 +00:00
Nika Layzell
a51fa32bd1
Bug 1826206 - Require nsISerialEventTarget for RetargetDeliveryTo, r=necko-reviewers,valentin
...
This avoids potential issues where multiple OnDataAvailable callbacks or
similar could theoretically be called concurrently on different
StreamTransportService threads when targeting the STS - these cases will
now target a TaskQueue on the STS instead, structurally ensuring serial
execution.
Differential Revision: https://phabricator.services.mozilla.com/D179984
2023-06-07 14:48:38 +00:00
Sean Feng
b8c8157d3c
Bug 1816287 - Always exit fullscreen when triggering on external protocol r=edgar
...
It's a security risk such that the maximized external program can obscure
the fullscreen notification and the malicious site can use this trick
to load a spoofed page in the background without user notices it.
This patch minimized the risk by always exit the fullscreen mode when
an external protocol is triggered.
Differential Revision: https://phabricator.services.mozilla.com/D177771
2023-05-17 18:00:18 +00:00
Norisz Fay
e476e08413
Backed out changeset 6fa00ccfe7e0 (bug 1816287) for causing bustages on LocationBase.cpp CLOSED TREE
2023-05-17 20:11:39 +03:00
Sean Feng
79b4c118c0
Bug 1816287 - Always exit fullscreen when triggering on external protocol r=edgar
...
It's a security risk such that the maximized external program can obscure
the fullscreen notification and the malicious site can use this trick
to load a spoofed page in the background without user notices it.
This patch minimized the risk by always exit the fullscreen mode when
an external protocol is triggered.
Differential Revision: https://phabricator.services.mozilla.com/D177771
2023-05-17 16:34:57 +00:00
nicklas boman
4114a8d7f7
Bug 1724649 - Followup to remove #include plstr.h r=necko-reviewers,xpcom-reviewers,valentin,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D177690
2023-05-15 14:53:02 +00:00
Kershaw Chang
cf37719831
Bug 1794766 - Use CancelWithReason in imgRequest and nsLoadGroup, r=necko-reviewers,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D159148
2022-10-13 08:54:12 +00:00
Dan Robertson
130ee7fffe
Bug 1655598 - Cross origin image request should not respect image orientation. r=emilio
...
A cross origin image request should not respect the given style image
orientation, but should use any image orientation provided by the image.
Differential Revision: https://phabricator.services.mozilla.com/D156919
2022-09-28 03:56:57 +00:00
Butkovits Atila
fd6ff06db9
Backed out 2 changesets (bug 1655598) for causing Bug 1792435. a=backout
...
Backed out changeset 9eb3b3e7295b (bug 1655598)
Backed out changeset 052c6f05c623 (bug 1655598)
2022-09-27 12:37:10 +03:00
Dan Robertson
337ae55b7b
Bug 1655598 - Cross origin image request should not respect image orientation. r=emilio
...
A cross origin image request should not respect the given style image
orientation, but should use any image orientation provided by the image.
Differential Revision: https://phabricator.services.mozilla.com/D156919
2022-09-25 00:07:56 +00:00
Fabrice Desré
e29be44cb7
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-03 16:39:41 +00:00
Andreea Pavel
fc724b92fc
Backed out changeset b9d2965591b9 (bug 1761040) for landing with wrong author CLOSED TREE DONTBUILD
2022-08-03 18:55:00 +03:00
Andreea Pavel
eda47f3911
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-03 15:27:43 +00:00
Andreea Pavel
c2e97d2e06
Backed out changeset a907159a482f (bug 1761040) for causing build bustages on a CLOSED TREE
2022-08-02 04:59:08 +03:00
Fabrice Desré
d2d02e8493
Bug 1761040 - Prefix thread safety macros with MOZ_ r=geckoview-reviewers,media-playback-reviewers,alwu,jesup,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D152575
2022-08-02 00:49:41 +00:00
Neil Deakin
f773c03d8d
Bug 1746052, add a means to get the filename that should be used for saving an image to disk, r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D135950
2022-05-06 10:00:52 +00:00
Noemi Erli
7690ca54a5
Backed out 14 changesets (bug 1746052) for causing build bustages in nsExternalHelperAppService.cpp CLOSED TREE
...
Backed out changeset bf46b0add531 (bug 1746052)
Backed out changeset 684b2aca10bb (bug 1746052)
Backed out changeset d4796eeeaf64 (bug 1746052)
Backed out changeset 5cf2378f6eb4 (bug 1746052)
Backed out changeset 2055ec1e9a57 (bug 1746052)
Backed out changeset 1398fc0669d2 (bug 1746052)
Backed out changeset 1f979899c843 (bug 1746052)
Backed out changeset 561a24801d4d (bug 1746052)
Backed out changeset 73e4689120f0 (bug 1746052)
Backed out changeset 9891f3b0229b (bug 1746052)
Backed out changeset 4c1ab30de0bd (bug 1746052)
Backed out changeset 108e14122e53 (bug 1746052)
Backed out changeset 1ee59c52578a (bug 1746052)
Backed out changeset 41fe77c5f4b2 (bug 1746052)
2022-05-05 23:13:33 +03:00
Neil Deakin
eb602c21b3
Bug 1746052, add a means to get the filename that should be used for saving an image to disk, r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D135950
2022-05-05 19:46:45 +00:00
Csoregi Natalia
cc401bfc0c
Backed out 13 changesets (bug 1746052) for causing failures on uriloader/exthandler/tests/. CLOSED TREE
...
Backed out changeset d19cc58e3cab (bug 1746052)
Backed out changeset 229edc158a2b (bug 1746052)
Backed out changeset b0ef7c68abcf (bug 1746052)
Backed out changeset 30de4b77f242 (bug 1746052)
Backed out changeset ebc6720fdab3 (bug 1746052)
Backed out changeset daccb796a093 (bug 1746052)
Backed out changeset 5b76d8d76b2b (bug 1746052)
Backed out changeset a698068d078f (bug 1746052)
Backed out changeset 73d17535d8d1 (bug 1746052)
Backed out changeset 94c95f004221 (bug 1746052)
Backed out changeset 1a389759585a (bug 1746052)
Backed out changeset c91230a8ea90 (bug 1746052)
Backed out changeset 7665f02c114e (bug 1746052)
2022-05-04 01:15:12 +03:00
Neil Deakin
31ddd2f5bc
Bug 1746052, add a means to get the filename that should be used for saving an image to disk, r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D135950
2022-05-03 19:44:24 +00:00
Randell Jesup
d56b10faef
Bug 1207753 - image thread-safety annotations r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D132641
2022-03-21 20:04:39 +00:00
Randell Jesup
b9776b252c
Bug 1207753 - gfx & image thread-safety annotations r=gfx-reviewers,aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D130600
2022-03-21 18:05:31 +00:00
Timothy Nikkel
3809ff9d1d
Bug 1756551. Parameter aInnerWindowId on PrepareForNewPart in imgRequest.cpp is uint64_t not uint32_t. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D139370
2022-02-24 09:40:34 +00:00
Timothy Nikkel
567f382206
Bug 1755032. Fix data race on imgRequest::mInnerWindowId. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D138623
2022-02-14 10:00:40 +00:00