Sylvestre Ledru
55481ac4b5
Bug 2023419 - Remove Emacs/Vim modelines from layout/ r=emilio,firefox-style-system-reviewers,layout-reviewers
...
replaced by .editorconfig
Differential Revision: https://phabricator.services.mozilla.com/D287852
2026-03-17 12:05:43 +00:00
Emilio Cobos Álvarez
a8a2311474
Bug 1976457 - Sort includes in layout/. r=janv,dshin
...
Interesting bit is layout/.clang-format, the rest is all automated.
Differential Revision: https://phabricator.services.mozilla.com/D256616
2025-07-09 13:24:00 +00:00
Andrea Marchesini
4122537ef1
Bug 1876470 - AddEventListener/RemoveEventListener should not throw, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D226337
2024-10-21 20:45:39 +00:00
Emilio Cobos Álvarez
3b1bd6b3ce
Bug 1451717 - Fix scheduling of media query list events to match the spec. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D185662
2023-08-16 09:07:14 +00:00
Emilio Cobos Álvarez
7b6e5a4fb7
Bug 1011468 - Flush parent document layout if needed for viewport dependent media queries. r=dshin
...
This is necessary to properly report changes in our document.
The remaining failures are about change event scheduling, which is a
pre-existing issue. Will fix, but in a separate bug.
Differential Revision: https://phabricator.services.mozilla.com/D178917
2023-05-24 15:33:01 +00:00
Gabriele Svelto
43291aeded
Bug 1745950 - Remove the string-based KeepAliveIfHasListenersFor() implementation and convert all callers to use the atoms-based one instead r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D133748
2021-12-14 16:54:50 +00:00
Emilio Cobos Álvarez
fe2b95e111
Bug 1682003 - Avoid UTF-8 -> UTF-16 conversion during CSSOM serialization. r=heycam
...
This lifts a bunch of string conversions higher up the stack, but allows
us to make the servo code use utf-8 unconditionally, and seemed faster
in my benchmarking (see comment 0).
It should also make a bunch of attribute setters faster too (like
setting .cssText), now that we use UTF8String for them (we couldn't
because we couldn't specify different string types for the getter and
setters).
Differential Revision: https://phabricator.services.mozilla.com/D99590
2020-12-17 14:04:35 +00:00
Emilio Cobos Álvarez
451f5024b5
Bug 1648839 - Evaluate changes in all media queries, then fire change events. r=jwatt
...
This ensures that you can't observe an inconsistent state while we go
through the list.
It should also be marginally better as we don't build an array with all
the media queries unconditionally.
Differential Revision: https://phabricator.services.mozilla.com/D82260
2020-07-10 01:21:53 +00:00
Simon Giesecke
a69d79b6db
Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Simon Giesecke
e613597e90
Bug 1613985 - Use default for equivalent-to-default constructors/destructors in layout. r=dholbert
...
Differential Revision: https://phabricator.services.mozilla.com/D66016
2020-03-17 09:38:32 +00:00
Emilio Cobos Álvarez
3fb159a0de
Bug 1603160 - Allow MediaQueryList::AddListener to receive untrusted events. r=bzbarsky
...
I was looking into MediaQueryList tests in the context of:
https://github.com/w3c/csswg-drafts/issues/4531
And this seemed reasonably easy to fix.
I don't see anything in:
https://drafts.csswg.org/cssom-view/#dom-mediaquerylist-addlistener
Which doesn't mention anything about untrusted listeners.
I haven't investigated the remaining failure, it seems we call the capture
listener after the regular one...
Differential Revision: https://phabricator.services.mozilla.com/D56771
2019-12-11 18:37:14 +00:00
Emilio Cobos Álvarez
6684c66f3a
Bug 1490401 - MatchMedia should work inside display: none iframes. r=heycam
...
Differential Revision: https://phabricator.services.mozilla.com/D25926
2019-04-04 11:25:31 +00:00
Emilio Cobos Álvarez
dc336a73ba
Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug
...
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.
Overall it's not a very interesting patch I think.
nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.
I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.
While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.
2019-01-03 17:48:33 +01:00
Emilio Cobos Álvarez
b26d7730f0
Bug 1516366 - Move base classes from nsDocument to nsIDocument. r=smaug
...
This is a big step in order to merge both.
Also allows to remove some very silly casts, though it causes us to add some
ToSupports around to deal with ambiguity of casts from nsIDocument to
nsISupports, and add a dummy nsISupports implementation that will go away later
in the series.
Differential Revision: https://phabricator.services.mozilla.com/D15352
2018-12-29 20:41:28 +01:00
Sylvestre Ledru
e5a134f73a
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Emilio Cobos Álvarez
512aed2ec5
Bug 1490012 - Don't flush on the parent document if we already have a pres context. r=xidorn
...
I think conceptually we should flush layout instead of frames and do it
unconditionally, but everyone agrees on not doing that, and it can be really
slow, so will raise it to the CSSWG and get this spec'd.
See the test-case in bug 1458816, which tracks that.
I don't want to uplift this, but I think it's worth landing.
Differential Revision: https://phabricator.services.mozilla.com/D5562
2018-09-12 15:45:18 +02:00
Cameron McCormack
18202c31bb
Bug 1473735 - Add memory reporting for MediaQueryLists. r=emilio
...
MozReview-Commit-ID: 87rgRtQOOyG
2018-07-06 11:09:12 +10:00
Jeff Gilbert
70a22b2878
Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
...
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Olli Pettay
c6028c1403
bug 1457867, store DOMEventTargetHelper objects in global object as a linked list, r=bkelly
2018-05-04 19:25:05 +03:00
Emilio Cobos Álvarez
08bea7e24f
Bug 1456471: Remove nsCSSParser.h. r=xidorn
...
MozReview-Commit-ID: 4qa7llzCXeR
2018-04-25 10:38:37 +02:00
Boris Zbarsky
d54406240d
Bug 1449631 part 6. Remove nsIDOMEventTarget::DispatchEvent. r=smaug
...
MozReview-Commit-ID: 8YMgmMwZkAL
2018-04-05 13:42:41 -04:00
Boris Zbarsky
451de18e8e
Bug 1451199. Fix the handling of .onchange in MediaQueryList to match the handling of addEventListener('change'). r=emilio
...
MozReview-Commit-ID: 4YvJ0m0BOnQ
2018-04-05 08:34:46 -04:00
Ben Kelly
486145e67d
Bug 1450271 Make MediaQueryList bind to its document's inner window. r=baku
2018-04-02 08:35:52 -07:00
Xidorn Quan
e9cb7cd42d
Bug 1447828 part 3 - Remove StyleBackendType uses from MediaList. r=emilio
...
MozReview-Commit-ID: 9sG73iLeBw4
2018-03-29 02:31:46 +11:00
Hiroyuki Ikezoe
b1da8534e8
Bug 1417354 - Introduce nsIDocument::GetPresContext(). r=smaug
...
It would be convenient to get nsPresContext from nsIDocument.
MozReview-Commit-ID: Ei6V3UE8XGr
2018-02-21 07:00:10 +09:00
Emilio Cobos Álvarez
99a4381f5d
Bug 1436240: Make sure to always initialize mMatches to something meaningful. r=xidorn
...
MozReview-Commit-ID: 1FpAZIzyLOU
2018-02-07 03:31:40 +01:00
Daniel Holbert
8fea3c215f
Bug 1412346 part 5: (automated patch) Switch a bunch of C++ files in layout to use our standard mode lines. r=jfkthame
...
This patch was generated automatically by the "modeline.py" script, available
here: https://github.com/amccreight/moz-source-tools/blob/master/modeline.py
For every file that is modified in this patch, the changes are as follows:
(1) The patch changes the file to use the exact C++ mode lines from the
Mozilla coding style guide, available here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Mode_Line
(2) The patch deletes any blank lines between the mode line & the MPL
boilerplate comment.
(3) If the file previously had the mode lines and MPL boilerplate in a
single contiguous C++ comment, then the patch splits them into
separate C++ comments, to match the boilerplate in the coding style.
MozReview-Commit-ID: EuRsDue63tK
2017-10-27 10:33:53 -07:00
Emilio Cobos Álvarez
4752927341
Bug 1410074: Make the caller type from MatchMedia arrive to the CSS code. r=xidorn,bz
...
MozReview-Commit-ID: LUiobfHSUq1
2017-10-25 16:04:48 +02:00
Andrew McCreight
84ee98de3c
Bug 1391005 - Eliminate NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED. r=peterv
...
Replace it with NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION, because it
has been the same for a while.
MozReview-Commit-ID: 5agRGFyUry1
2017-08-29 16:02:48 -07:00
Sumit Tiwari
4a179064e0
Fix for bug 1142497 - change mDOMMediaQueryLists to use mozilla::LinkedList;r=erahm
...
MozReview-Commit-ID: G9RtgdYudqA
2017-04-06 20:45:16 -04:00
Andrea Marchesini
8e633b1d5f
Bug 1354599 - Use of DOMEventTargetHelper::KeepAliveIfHasListenersFor in MediaQueryList, r=smaug
2017-04-18 13:53:15 +02:00
Emilio Cobos Álvarez
562e75fef9
Bug 1356074: Use Servo for window.matchMedia and MediaQueryList. r=xidorn
...
MozReview-Commit-ID: I6uufe48JZq
2017-04-14 13:00:29 +08:00
Emilio Cobos Álvarez
60ba1d4997
Bug 1325878: followup - cleanup MediaList::Matches callers. r=me
...
MozReview-Commit-ID: Ck9hlZ0qkxj
2017-04-14 11:31:47 +08:00
Emilio Cobos Álvarez
186d6d903f
Bug 1325878: Create less hardcoded nsMediaList instances. r=xidorn
...
MozReview-Commit-ID: K6T3MM1ZrFb
Signed-off-by: Emilio Cobos Álvarez <[email protected] >
2017-04-13 00:30:03 +08:00
Andrea Marchesini
5029e7e133
Bug 1354441 - Update MediaQueryList to the latest version of the spec, r=jwatt
2017-04-10 16:29:06 +02:00
Cameron McCormack
5f9911da79
Bug 1328832 - Part 2: Rename mozFlushType to mozilla::FlushType and make it an enum class. r=bzbarsky
...
MozReview-Commit-ID: D3fIngSHSsl
2017-01-05 15:31:56 +08:00
Olli Pettay
3898f7d882
Bug 1326507, remove NS_IMPL_CYCLE_COLLECTION_TRAVERSE_SCRIPT_OBJECTS, r=mccr8
2017-01-03 21:47:55 +02:00
Xidorn Quan
1125f5e9ab
Bug 1323919 - Rename nsIMediaList.h to nsMediaList.h. r=heycam
...
MozReview-Commit-ID: Ake5srkKJbf
2016-12-16 14:50:36 +11:00
Emilio Cobos Álvarez
4afebc68ce
Bug 1029867: Remove useless nsCSSParser::mHTMLMediaMode. r=heycam
...
MozReview-Commit-ID: AFtd0G4oP3R
2016-12-13 11:39:32 +01:00
Birunthan Mohanathas
279d68bd86
Bug 1167418 - Check AppendElement call in MediaQueryList. r=heycam
...
This preemptively silences an unused result warning.
2015-07-12 23:19:12 -07:00
Birunthan Mohanathas
8da5c94f46
Bug 1167418 - Use nsTArray instead of FallibleTArray in MediaQueryList. r=heycam
...
We already use the mozilla::fallible parameter when we want fallibility so
this doesn't actually change anything.
2015-07-12 23:19:12 -07:00
Birunthan Mohanathas
956e8c7eca
Bug 968520 - Add mozilla::fallible to FallibleTArray::AppendElement calls. r=froydnj
2015-05-28 11:07:44 -07:00
Boris Zbarsky
3a822d99b4
Bug 1117172 part 3. Change the wrappercached WrapObject methods to allow passing in aGivenProto. r=peterv
...
The only manual changes here are to BindingUtils.h, BindingUtils.cpp,
Codegen.py, Element.cpp, IDBFileRequest.cpp, IDBObjectStore.cpp,
dom/workers/Navigator.cpp, WorkerPrivate.cpp, DeviceStorageRequestChild.cpp,
Notification.cpp, nsGlobalWindow.cpp, MessagePort.cpp, nsJSEnvironment.cpp,
Sandbox.cpp, XPCConvert.cpp, ExportHelpers.cpp, and DataStoreService.cpp. The
rest of this diff was generated by running the following commands:
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObject\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(Binding(?:_workers)?::Wrap\((?:aCx|cx|aContext|aCtx|js), [^,)]+)\)/\1, aGivenProto)/g'
2015-03-19 10:13:33 -04:00
Nicholas Nethercote
0247de46d8
Bug 1127201 (attempt 2, part 1) - Replace most NS_ABORT_IF_FALSE calls with MOZ_ASSERT. r=Waldo.
2015-02-09 14:34:50 -08:00
Andrew McCreight
e048a7df33
Back out Bug 1127201 (part 2) for various problems.
2015-02-06 15:04:32 -08:00
Nicholas Nethercote
40ab0270d5
Bug 1127201 (part 2) - Convert all NS_ABORT_IF_FALSE calls to MOZ_ASSERT. r=Waldo.
2015-02-04 20:05:36 -08:00
Boris Zbarsky
cd136aaf91
Bug 771043. Move MediaQueryList tracking from the prescontext to the document, so they will correctly outlive prescontext changes. r=dbaron
2014-10-03 14:15:25 -04:00
Peter Van der Beken
3467274091
Bug 1078744 - Replace SetIsDOMBinding with SetIsNonDOMBinding, remove nsWrapperCache::SetIsDOMBinding. r=bz.
2014-10-07 11:44:49 +02:00
Ryan VanderMeulen
0ad775023d
Backed out changeset cb3fd4a4b7c5 (bug 771043) for Android mochitest-8 failures.
...
CLOSED TREE
2014-10-03 15:26:06 -04:00
Boris Zbarsky
7c2de11f77
Bug 771043. Move MediaQueryList tracking from the prescontext to the document, so they will correctly outlive prescontext changes. r=dbaron
2014-10-03 14:15:25 -04:00