Paul Bone
1879025654
Bug 2014781 - Restore the sub-page size class r=glandium
...
This reverts Bug 1980056 part 6.
Differential Revision: https://phabricator.services.mozilla.com/D297237
2026-05-31 23:27:24 +00:00
serge-sans-paille
03b0f2574c
Bug 2040876 - Activate modernize-use-bool-literals clang-tidy check r=emilio,webrtc-reviewers,cookie-reviewers,places-reviewers,layout-reviewers,mak,bwc
...
Differential Revision: https://phabricator.services.mozilla.com/D301473
2026-05-25 21:13:49 +00:00
Silaghi
688b962a0b
Revert "Bug 2014781 - gPageSize follows gRealPageSize r=glandium" for causing mochitests failures at toolkit/content
...
This reverts commit 3c629953cf606f7ea614
2026-05-14 07:39:36 +00:00
Paul Bone
606f7ea614
Bug 2014781 - Restore the sub-page size class r=glandium
...
This reverts Bug 1980056 part 6.
Differential Revision: https://phabricator.services.mozilla.com/D297237
2026-05-14 03:15:33 +00:00
serge-sans-paille
f81328e365
Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio
...
The changeset has been generated automatically through:
./mach static-analysis check --output ./clang-tidy-bugprone.json --format json --fix
followed by manual adjustment when needed or when the auto-fixer bailed out.
This paves the way for Bug 2023527
Differential Revision: https://phabricator.services.mozilla.com/D287941
2026-03-22 08:35:47 +00:00
Alexandru Marc
04e5f74151
Revert "Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio"
...
This reverts commit a64dec2665
2026-03-19 17:29:58 +00:00
serge-sans-paille
a64dec2665
Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio
...
The changeset has been generated automatically through:
./mach static-analysis check --output ./clang-tidy-bugprone.json --format json --fix
followed by manual adjustment when needed or when the auto-fixer bailed out.
This paves the way for Bug 2023527
Differential Revision: https://phabricator.services.mozilla.com/D287941
2026-03-18 17:25:01 +00:00
Sylvestre Ledru
f7691d9032
Bug 2023419 - Remove Emacs/Vim modelines from memory/ r=emilio
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287854
2026-03-17 12:05:51 +00:00
Paul Bone
2ec92a906e
Bug 1980056 - pt 6. Remove the sub-page size class r=glandium
...
With page size limited to 4KiB and the quantum-wide class covering the
range from 512 bytes to 4KiB, the sub-page size class is unused and can
be removed.
Differential Revision: https://phabricator.services.mozilla.com/D259220
2026-02-03 04:14:10 +00:00
serge-sans-paille
9db08d3f52
Bug 2009953 - Do not use reserved identifiers for macro guard in identifiers r=emilio,geckoview-reviewers,media-playback-reviewers,devtools-reviewers,win-reviewers,ochameau,gstoll,keeler,mccr8,padenot,alwu,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D278766
2026-01-22 17:49:59 +00:00
pstanciu
bc297a68a0
Revert "Bug 2009953 - Do not use reserved identifiers for macro guard in identifiers r=emilio,geckoview-reviewers,media-playback-reviewers,devtools-reviewers,win-reviewers,ochameau,gstoll,keeler,mccr8,padenot,alwu,m_kato" for causing build bustages @ CParserContext.h
...
This reverts commit afd052662d
2026-01-21 16:23:10 +00:00
serge-sans-paille
afd052662d
Bug 2009953 - Do not use reserved identifiers for macro guard in identifiers r=emilio,geckoview-reviewers,media-playback-reviewers,devtools-reviewers,win-reviewers,ochameau,gstoll,keeler,mccr8,padenot,alwu,m_kato
...
Also remove security/manager/ssl/nsVerificationJob.h per request of
@keeler instead of changing its guard.
Differential Revision: https://phabricator.services.mozilla.com/D278766
2026-01-21 15:46:08 +00:00
agoloman
15e87a3496
Revert "Bug 1980056 - pt 2. Remove the sub-page size class r=glandium" for causing Bug 2010505.
...
This reverts commit 784e006a3401d083e3c6
2026-01-16 04:20:26 +00:00
Paul Bone
784e006a34
Bug 1980056 - pt 2. Remove the sub-page size class r=glandium
...
With page size limited to 4KiB and the quantum-wide class covering the
range from 512 bytes to 4KiB, the sub-page size class is unused and can
be removed.
Differential Revision: https://phabricator.services.mozilla.com/D259220
2026-01-15 03:30:13 +00:00
Alex Hochheiden
02333707ab
Bug 2006716 - Reformat entire repo with ruff-format (black replacement) r=ahal,sylvestre,linter-reviewers,perftest-reviewers,mozperftest-reviewers,geckoview-reviewers,extension-reviewers,media-playback-reviewers,webrtc-reviewers,releng-reviewers,sessionstore-reviewers,win-reviewers,dom-storage-reviewers,translations-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,layout-reviewers,dom-worker-reviewers,geckodriver-reviewers,Sasha,emz,fchasen,sthompson,dholbert,sparky,padenot,emilio,Gijs,mconley,tcampbell,mjf,emcminn,willdurand,gstoll,jgraham,asuth
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D276894
2026-01-08 21:15:53 +00:00
Atila Butkovits
ce6aff66e2
Revert "Bug 2006716 - Remove unused default_bindir() from ruff.py r=ahal,linter-reviewers" for causing failures at tp5n-pageset.manifest.
...
This reverts commit a198379dd78e2f1e924b857218c417da4a569cfb0781186b2eb2b8db2859
2026-01-07 21:34:31 +00:00
Alex Hochheiden
b2b8db2859
Bug 2006716 - Reformat entire repo with ruff-format (black replacement) r=ahal,sylvestre,linter-reviewers,perftest-reviewers,mozperftest-reviewers,geckoview-reviewers,extension-reviewers,media-playback-reviewers,webrtc-reviewers,releng-reviewers,sessionstore-reviewers,win-reviewers,dom-storage-reviewers,translations-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,layout-reviewers,dom-worker-reviewers,geckodriver-reviewers,Sasha,emz,fchasen,sthompson,dholbert,sparky,padenot,emilio,Gijs,mconley,tcampbell,mjf,emcminn,willdurand,gstoll,jgraham,asuth
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D276894
2026-01-07 18:08:27 +00:00
Alexandru Marc
d296caccba
Revert "Bug 2006716 - Remove unused default_bindir() from ruff.py r=ahal,linter-reviewers" for causing toolchain bustages
...
This reverts commit 76033c983e19fd8c23ca0b01c783a672cab75517a434d066ce3ed06912eb
2026-01-07 00:54:28 +00:00
Alex Hochheiden
3ed06912eb
Bug 2006716 - Reformat entire repo with ruff-format (black replacement) r=ahal,sylvestre,linter-reviewers,perftest-reviewers,mozperftest-reviewers,geckoview-reviewers,extension-reviewers,media-playback-reviewers,webrtc-reviewers,releng-reviewers,sessionstore-reviewers,win-reviewers,dom-storage-reviewers,translations-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,layout-reviewers,dom-worker-reviewers,geckodriver-reviewers,Sasha,emz,fchasen,sthompson,dholbert,sparky,padenot,emilio,Gijs,mconley,tcampbell,mjf,emcminn,willdurand,gstoll,jgraham,asuth
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D276894
2026-01-07 00:32:15 +00:00
Alex Hochheiden
7054a1ab49
Bug 2003412 - PLR warnings auto-fixed by ./mach lint --fix . r=emilio,geckoview-reviewers,taskgraph-reviewers,releng-reviewers,toolkit-telemetry-reviewers,layout-reviewers,jdescottes,bhearsum,nalexander,perftest-reviewers,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D274687
2025-12-10 06:05:48 +00:00
Alex Hochheiden
2bb010077c
Bug 2003412 - Fix UP030 warnings: Use implicit references for positional format fields r=emilio,perftest-reviewers,jdescottes,sparky
...
https://docs.astral.sh/ruff/rules/format-literals/
Differential Revision: https://phabricator.services.mozilla.com/D274686
2025-12-10 06:05:45 +00:00
Tom Marble
5ce09d7446
Bug 1995583 - test manifest cleanup for idiomatic usage r=jmaher,necko-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,sessionstore-reviewers,tabbrowser-reviewers,translations-reviewers,omc-reviewers,browser-installer-reviewers,twisniewski,masayuki,dom-core,smaug,nalexander,emcminn,sthompson,alwu,ai-ondevice-reviewers,valentin
...
For TOML manifests:
1. Change processor -> arch
2. Use arch instead of bits bits == '64' =>
aarch64 (default on mac 15.30) or x86_64 bits == '32' => x86
3. Replace android_version with corresponding os_version
4. Remove conditions with linux os_version=="18.04"
(unless they contain verify or verify-standalone)
5. Remove conditions with mac os_version=='11.20',
(unless they contain verify or verify-standalone)
6. Remove conditions with win os_version=='11.2009' or win11_2009,
(unless they contain verify or verify-standalone)
7. Linux conditions should have os_version, arch and display
(simple "os == 'linux'" will get expanded to these two)
"os == 'linux' && os_version == '22.04' && arch == 'x86_64' && display == 'wayland'"
"os == 'linux' && os_version == '24.04' && arch == 'x86_64' && display == 'x11'"
8. Mac conditions should have os_version and arch
(simple "os == 'mac'" will get expanded to these three)
"os == 'mac' && os_version == '10.15' && arch == 'x86_64'",
"os == 'mac' && os_version == '14.70' && arch == 'x86_64'",
"os == 'mac' && os_version == '15.30' && arch == 'aarch64'",
9. Replace apple_catalina with
os == 'mac' && os_version == '10.15' && arch == 'x86_64'
10. Replace apple_silicon with
os == 'mac' && os_version = '15.30' && arch == 'aarch64'
11. Replace win10_2009 with
os == 'win' && os_version = '10.2009' && arch == 'x86_64'
12. Replace "!debug" with three conditions "asan", "opt", or "tsan"
13. Replace literal boolean comparison with variables
(e.g. "debug == false" => "!debug)
Resolves 2000285
Signed-off-by: Tom Marble <[email protected] https://phabricator.services.mozilla.com/D272815
2025-11-22 00:30:39 +00:00
serge-sans-paille
51da93ac26
Bug 1997204 - Remove unused mfbt inclusion in mfbt/** r=emilio
...
As a side effect, also move content of JSONWriter.cpp as a static
constexpr local variable in JSONWriter.h.
Differential Revision: https://phabricator.services.mozilla.com/D270617
2025-10-31 08:06:03 +00:00
serge-sans-paille
2680f1aa2a
Bug 1995938 - Remove unused inclusion of DebugOnly.h r=emilio,necko-reviewers,application-update-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,toolkit-telemetry-reviewers,firefox-svg-reviewers,layout-reviewers,dom-worker-reviewers,bytesized,gstoll,mstange,TYLin,chunmin,jesup,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D269780
2025-10-27 10:48:42 +00:00
Cristian Tuns
6f66cdf3c7
Revert "Bug 1995938 - Remove unused inclusion of DebugOnly.h r=emilio,necko-reviewers,application-update-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,toolkit-telemetry-reviewers,firefox-svg-reviewers,layout-reviewers,dom-worker-reviewers,bytesized,gstoll,mstange,TYLin,chunmin,jesup,asuth" for causing build bustages in TargetFunction.h
...
This reverts commit 10e5184168
2025-10-27 08:58:03 +00:00
serge-sans-paille
10e5184168
Bug 1995938 - Remove unused inclusion of DebugOnly.h r=emilio,necko-reviewers,application-update-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,toolkit-telemetry-reviewers,firefox-svg-reviewers,layout-reviewers,dom-worker-reviewers,bytesized,gstoll,mstange,TYLin,chunmin,jesup,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D269780
2025-10-27 08:00:43 +00:00
serge-sans-paille
483b850523
Bug 1996047 - Remove unused inclusion of Types.h r=emilio,necko-reviewers,media-playback-reviewers,webrtc-reviewers,win-reviewers,firefox-style-system-reviewers,gstoll,chunmin,pehrsons,jesup
...
Differential Revision: https://phabricator.services.mozilla.com/D269777
2025-10-26 13:04:07 +00:00
serge-sans-paille
7662b3abdc
Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
...
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 19:36:01 +00:00
Cristina Horotan
8a1b1970b7
Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing Gtest failures on AlreadyAddRefed.h
...
This reverts commit e98adca292
2025-10-21 16:16:29 +00:00
serge-sans-paille
e98adca292
Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
...
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 15:05:17 +00:00
Cristina Horotan
aab924e90d
Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing build bustage at nsBrowserApp.cpp
...
This reverts commit fd0ffa193c
2025-10-21 10:44:13 +00:00
serge-sans-paille
fd0ffa193c
Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
...
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 09:44:11 +00:00
Narcis Beleuzu
e1e6bbb1c9
Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing bustages on Document.cpp
...
This reverts commit b23c15e927
2025-10-21 06:34:58 +00:00
serge-sans-paille
b23c15e927
Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
...
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 06:01:36 +00:00
Ryan VanderMeulen
f6ae20842d
Bug 1991644 - Set the minimum Android version to 26 for LLVM & NDK. r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D268815
2025-10-18 00:55:26 +00:00
serge-sans-paille
6f55e56805
Bug 1982008 - Move logalloc test to memory/replace/logalloc/replay/moz.build r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D260458
2025-10-15 07:06:41 +00:00
serge-sans-paille
9dece22663
Bug 1991455 - Harmonize __builin_(add|sub|mul)_overflow usage r=emilio,nbp,profiler-reviewers,canaltinova
...
We used to have __builtin_(...) wrapped as MOZ_ADD_OVERFLOW, SafeAdd or
used directly. Get rid of MOZ_ADD_OVERFLOW, promotes SafeAdd et cie to
mfbt and use the mfbt version everywhere.
Differential Revision: https://phabricator.services.mozilla.com/D266685
2025-10-02 05:14:07 +00:00
serge-sans-paille
77667f23c9
Bug 1990262 - Obsolete mozilla::MulOverflowMask r=emilio,profiler-reviewers,canaltinova
...
Promote usage of __builtin_mul_overflow instead, which is supported by
all the compilers we support.
Differential Revision: https://phabricator.services.mozilla.com/D265839
2025-09-25 21:13:23 +00:00
Florian Quèze
adb44fa5a4
Bug 1989356 - Add run-if = ["os != 'android'"] conditions in desktop only xpcshell test manifests, r=jmaher,application-update-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,places-reviewers,profiler-reviewers,win-reviewers,omc-reviewers,migration-reviewers,urlbar-reviewers,browser-installer-reviewers,profiles-reviewers,layout-reviewers,mossop,mstange,dholbert,gstoll,bytesized,scunnane,nchevobbe,aminomancer.
...
Differential Revision: https://phabricator.services.mozilla.com/D265322
2025-09-19 20:56:51 +00:00
serge-sans-paille
aeee883896
Bug 1986593 - Obsolete mfbt/TemplateLib.h r=emilio,webrtc-reviewers,profiler-reviewers,layout-reviewers,canaltinova
...
The content of TemplateLib can be obsoleted in favor of constexpr
functions already available in mfbt/MathAlgorithms.h
- tl::Max -> std::max(x, y) or std::max({x, y, z})
- tl::Min -> std::min(x, y) or std::min({x, y, z})
- tl::FloorLog2<X>::value -> mozilla::FloorLog2(X)
- tl::CeilLog2<X>::value -> mozilla::CeilLog2(X)
- tl::RoundUpPow2<X>::value -> mozilla::RoundUpPow2(X)
- tl::BitSize<X>::value -> std::numeric_limits<X>::digits (for unsigned integral types)
- tl::MulOverflowMask<X>::value -> mozilla::MulOverflowMask(X)
the latter has been moved to mfbt/MulOverflowMask.h because it's used in
mozalloc.h and is required to have few dependencies.
also drop Windows specific code as we always build windows target with
clang-cl or mingw
Please note that the implementation of tl::CeilLog2 was incorrect for
very large numbers (typically 2**64 - 1), which impacted MulOverflowMask for those values.
This patch fixes that behavior and test it.
Differential Revision: https://phabricator.services.mozilla.com/D263523
2025-09-05 06:08:21 +00:00
Atila Butkovits
3fcad999e4
Revert "Bug 1986593 - Obsolete mfbt/TemplateLib.h r=emilio,webrtc-reviewers,profiler-reviewers,layout-reviewers,canaltinova" for causing bustages at FuzzingTraits.
...
This reverts commit 1a8ee563a7
2025-09-05 00:31:46 +00:00
serge-sans-paille
1a8ee563a7
Bug 1986593 - Obsolete mfbt/TemplateLib.h r=emilio,webrtc-reviewers,profiler-reviewers,layout-reviewers,canaltinova
...
The content of TemplateLib can be obsoleted in favor of constexpr
functions already available in mfbt/MathAlgorithms.h
- tl::Max -> std::max(x, y) or std::max({x, y, z})
- tl::Min -> std::min(x, y) or std::min({x, y, z})
- tl::FloorLog2<X>::value -> mozilla::FloorLog2(X)
- tl::CeilLog2<X>::value -> mozilla::CeilLog2(X)
- tl::RoundUpPow2<X>::value -> mozilla::RoundUpPow2(X)
- tl::BitSize<X>::value -> std::numeric_limits<X>::digits (for unsigned integral types)
- tl::MulOverflowMask<X>::value -> mozilla::MulOverflowMask(X)
the latter has been moved to mfbt/MulOverflowMask.h because it's used in
mozalloc.h and is required to have few dependencies.
also drop Windows specific code as we always build windows target with
clang-cl or mingw
Please note that the implementation of tl::CeilLog2 was incorrect for
very large numbers (typically 2**64 - 1), which impacted MulOverflowMask for those values.
This patch fixes that behavior and test it.
Differential Revision: https://phabricator.services.mozilla.com/D263523
2025-09-04 23:34:17 +00:00
Sandor Molnar
cf2854bd7e
Revert "Bug 1986593 - Obsolete mfbt/TemplateLib.h r=emilio,webrtc-reviewers,profiler-reviewers,layout-reviewers,canaltinova" for causing build bustages
...
This reverts commit 05a72e4b10
2025-09-04 07:47:30 +00:00
serge-sans-paille
05a72e4b10
Bug 1986593 - Obsolete mfbt/TemplateLib.h r=emilio,webrtc-reviewers,profiler-reviewers,layout-reviewers,canaltinova
...
The content of TemplateLib can be obsoleted in favor of constexpr
functions already available in mfbt/MathAlgorithms.h
- tl::Max -> std::max(x, y) or std::max({x, y, z})
- tl::Min -> std::min(x, y) or std::min({x, y, z})
- tl::FloorLog2<X>::value -> mozilla::FloorLog2(X)
- tl::CeilLog2<X>::value -> mozilla::CeilLog2(X)
- tl::RoundUpPow2<X>::value -> mozilla::RoundUpPow2(X)
- tl::BitSize<X>::value -> std::numeric_limits<X>::digits (for unsigned integral types)
- tl::MulOverflowMask<X>::value -> mozilla::MulOverflowMask(X)
the latter has been moved to mfbt/MulOverflowMask.h because it's used in
mozalloc.h and is required to have few dependencies.
also drop Windows specific code as we always build windows target with
clang-cl or mingw
Please note that the implementation of tl::CeilLog2 was incorrect for
very large numbers (typically 2**64 - 1), which impacted MulOverflowMask for those values.
This patch fixes that behavior and test it.
Differential Revision: https://phabricator.services.mozilla.com/D263523
2025-09-04 05:43:25 +00:00
Narcis Beleuzu
5bcef56629
Revert "Bug 1974864 - Cannot build memory after changes to Timestamp.h r=firefox-build-system-reviewers,ahochheiden" for causing build bustages
...
This reverts commit 2e7e617051
2025-07-22 22:22:00 +00:00
Nick Alexander
2e7e617051
Bug 1974864 - Cannot build memory after changes to Timestamp.h r=firefox-build-system-reviewers,ahochheiden
...
Differential Revision: https://phabricator.services.mozilla.com/D255559
2025-07-22 21:55:48 +00:00
Paul Bone
cc9959f87e
Bug 1928254 - pt 3b. Time the purge operation in mozjemalloc r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D227442
2025-05-27 08:04:13 +00:00
Paul Bone
f20cfedd00
Bug 1928254 - pt 2. Add profiler callbacks for mozjemalloc r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D227441
2025-05-27 08:04:05 +00:00
Serban Stanca
72ddd15355
Revert "Bug 1928254 - pt 8. Improve the idle purge markers r=jstutte" for causing multiple failures.
...
This reverts commit 1de23dc2a6dc7de1e1700891965b1052c855715afcdc85d6b41fa61503c2df279eb40edd4278a7d5
2025-05-16 08:52:29 +00:00
Paul Bone
df279eb40e
Bug 1928254 - pt 2. Add profiler callbacks for mozjemalloc r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D227441
2025-05-16 07:32:51 +00:00
Paul Bone