Commit Graph
404 Commits
Author SHA1 Message Date
serge-sans-paille 03b0f2574c Bug 2040876 - Activate modernize-use-bool-literals clang-tidy check r=emilio,webrtc-reviewers,cookie-reviewers,places-reviewers,layout-reviewers,mak,bwc
Differential Revision: https://phabricator.services.mozilla.com/D301473
2026-05-25 21:13:49 +00:00
serge-sans-paille f81328e365 Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio
The changeset has been generated automatically through:

    ./mach static-analysis check --output ./clang-tidy-bugprone.json --format json --fix

followed by manual adjustment when needed or when the auto-fixer bailed out.

This paves the way for Bug 2023527

Differential Revision: https://phabricator.services.mozilla.com/D287941
2026-03-22 08:35:47 +00:00
Alexandru Marc 04e5f74151 Revert "Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio"
This reverts commit a64dec2665.
2026-03-19 17:29:58 +00:00
serge-sans-paille a64dec2665 Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio
The changeset has been generated automatically through:

    ./mach static-analysis check --output ./clang-tidy-bugprone.json --format json --fix

followed by manual adjustment when needed or when the auto-fixer bailed out.

This paves the way for Bug 2023527

Differential Revision: https://phabricator.services.mozilla.com/D287941
2026-03-18 17:25:01 +00:00
Sylvestre Ledru f7691d9032 Bug 2023419 - Remove Emacs/Vim modelines from memory/ r=emilio
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287854
2026-03-17 12:05:51 +00:00
serge-sans-paille 9db08d3f52 Bug 2009953 - Do not use reserved identifiers for macro guard in identifiers r=emilio,geckoview-reviewers,media-playback-reviewers,devtools-reviewers,win-reviewers,ochameau,gstoll,keeler,mccr8,padenot,alwu,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D278766
2026-01-22 17:49:59 +00:00
pstanciu bc297a68a0 Revert "Bug 2009953 - Do not use reserved identifiers for macro guard in identifiers r=emilio,geckoview-reviewers,media-playback-reviewers,devtools-reviewers,win-reviewers,ochameau,gstoll,keeler,mccr8,padenot,alwu,m_kato" for causing build bustages @ CParserContext.h
This reverts commit afd052662d.
2026-01-21 16:23:10 +00:00
serge-sans-paille afd052662d Bug 2009953 - Do not use reserved identifiers for macro guard in identifiers r=emilio,geckoview-reviewers,media-playback-reviewers,devtools-reviewers,win-reviewers,ochameau,gstoll,keeler,mccr8,padenot,alwu,m_kato
Also remove security/manager/ssl/nsVerificationJob.h per request of
@keeler instead of changing its guard.

Differential Revision: https://phabricator.services.mozilla.com/D278766
2026-01-21 15:46:08 +00:00
Alex Hochheiden 02333707ab Bug 2006716 - Reformat entire repo with ruff-format (black replacement) r=ahal,sylvestre,linter-reviewers,perftest-reviewers,mozperftest-reviewers,geckoview-reviewers,extension-reviewers,media-playback-reviewers,webrtc-reviewers,releng-reviewers,sessionstore-reviewers,win-reviewers,dom-storage-reviewers,translations-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,layout-reviewers,dom-worker-reviewers,geckodriver-reviewers,Sasha,emz,fchasen,sthompson,dholbert,sparky,padenot,emilio,Gijs,mconley,tcampbell,mjf,emcminn,willdurand,gstoll,jgraham,asuth
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D276894
2026-01-08 21:15:53 +00:00
Atila Butkovits ce6aff66e2 Revert "Bug 2006716 - Remove unused default_bindir() from ruff.py r=ahal,linter-reviewers" for causing failures at tp5n-pageset.manifest.
This reverts commit a198379dd7.

Revert "Bug 2006716 - Add `ruff-format` linter r=ahal,linter-reviewers"

This reverts commit 8e2f1e924b.

Revert "Bug 2006716 - Remove `black` linter r=ahal,linter-reviewers"

This reverts commit 857218c417.

Revert "Bug 2006716 - Fix `ruff` linter `stderr` callback broken in D190696 r=ahal,linter-reviewers"

This reverts commit da4a569cfb.

Revert "Bug 2006716 - Update `ruff` to version `0.14.9` and use consistent versions in `lint.txt` and `python-test.txt` r=ahal,linter-reviewers"

This reverts commit 0781186b2e.

Revert "Bug 2006716 - Reformat entire repo with `ruff-format` (`black` replacement) r=ahal,sylvestre,linter-reviewers,perftest-reviewers,mozperftest-reviewers,geckoview-reviewers,extension-reviewers,media-playback-reviewers,webrtc-reviewers,releng-reviewers,sessionstore-reviewers,win-reviewers,dom-storage-reviewers,translations-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,layout-reviewers,dom-worker-reviewers,geckodriver-reviewers,Sasha,emz,fchasen,sthompson,dholbert,sparky,padenot,emilio,Gijs,mconley,tcampbell,mjf,emcminn,willdurand,gstoll,jgraham,asuth"

This reverts commit b2b8db2859.
2026-01-07 21:34:31 +00:00
Alex Hochheiden b2b8db2859 Bug 2006716 - Reformat entire repo with ruff-format (black replacement) r=ahal,sylvestre,linter-reviewers,perftest-reviewers,mozperftest-reviewers,geckoview-reviewers,extension-reviewers,media-playback-reviewers,webrtc-reviewers,releng-reviewers,sessionstore-reviewers,win-reviewers,dom-storage-reviewers,translations-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,layout-reviewers,dom-worker-reviewers,geckodriver-reviewers,Sasha,emz,fchasen,sthompson,dholbert,sparky,padenot,emilio,Gijs,mconley,tcampbell,mjf,emcminn,willdurand,gstoll,jgraham,asuth
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D276894
2026-01-07 18:08:27 +00:00
Alexandru Marc d296caccba Revert "Bug 2006716 - Remove unused default_bindir() from ruff.py r=ahal,linter-reviewers" for causing toolchain bustages
This reverts commit 76033c983e.

Revert "Bug 2006716 - Add `ruff-format` linter r=ahal,linter-reviewers"

This reverts commit 19fd8c23ca.

Revert "Bug 2006716 - Remove `black` linter r=ahal,linter-reviewers"

This reverts commit 0b01c783a6.

Revert "Bug 2006716 - Fix `ruff` linter `stderr` callback broken in D190696 r=ahal,linter-reviewers"

This reverts commit 72cab75517.

Revert "Bug 2006716 - Update `ruff` to version `0.14.9` and use consistent versions in `lint.txt` and `python-test.txt` r=ahal,linter-reviewers"

This reverts commit a434d066ce.

Revert "Bug 2006716 - Reformat entire repo with `ruff-format` (`black` replacement) r=ahal,sylvestre,linter-reviewers,perftest-reviewers,mozperftest-reviewers,geckoview-reviewers,extension-reviewers,media-playback-reviewers,webrtc-reviewers,releng-reviewers,sessionstore-reviewers,win-reviewers,dom-storage-reviewers,translations-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,layout-reviewers,dom-worker-reviewers,geckodriver-reviewers,Sasha,emz,fchasen,sthompson,dholbert,sparky,padenot,emilio,Gijs,mconley,tcampbell,mjf,emcminn,willdurand,gstoll,jgraham,asuth"

This reverts commit 3ed06912eb.
2026-01-07 00:54:28 +00:00
Alex Hochheiden 3ed06912eb Bug 2006716 - Reformat entire repo with ruff-format (black replacement) r=ahal,sylvestre,linter-reviewers,perftest-reviewers,mozperftest-reviewers,geckoview-reviewers,extension-reviewers,media-playback-reviewers,webrtc-reviewers,releng-reviewers,sessionstore-reviewers,win-reviewers,dom-storage-reviewers,translations-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,layout-reviewers,dom-worker-reviewers,geckodriver-reviewers,Sasha,emz,fchasen,sthompson,dholbert,sparky,padenot,emilio,Gijs,mconley,tcampbell,mjf,emcminn,willdurand,gstoll,jgraham,asuth
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D276894
2026-01-07 00:32:15 +00:00
Alex Hochheiden 7054a1ab49 Bug 2003412 - PLR warnings auto-fixed by ./mach lint --fix . r=emilio,geckoview-reviewers,taskgraph-reviewers,releng-reviewers,toolkit-telemetry-reviewers,layout-reviewers,jdescottes,bhearsum,nalexander,perftest-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D274687
2025-12-10 06:05:48 +00:00
Alex Hochheiden 2bb010077c Bug 2003412 - Fix UP030 warnings: Use implicit references for positional format fields r=emilio,perftest-reviewers,jdescottes,sparky
https://docs.astral.sh/ruff/rules/format-literals/

Differential Revision: https://phabricator.services.mozilla.com/D274686
2025-12-10 06:05:45 +00:00
Tom Marble 5ce09d7446 Bug 1995583 - test manifest cleanup for idiomatic usage r=jmaher,necko-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,sessionstore-reviewers,tabbrowser-reviewers,translations-reviewers,omc-reviewers,browser-installer-reviewers,twisniewski,masayuki,dom-core,smaug,nalexander,emcminn,sthompson,alwu,ai-ondevice-reviewers,valentin
For TOML manifests:

1. Change processor -> arch
2. Use arch instead of bits bits == '64' =>
   aarch64 (default on mac 15.30) or x86_64 bits == '32' => x86
3. Replace android_version with corresponding os_version
4. Remove conditions with linux os_version=="18.04"
   (unless they contain verify or verify-standalone)
5. Remove conditions with mac os_version=='11.20',
   (unless they contain verify or verify-standalone)
6. Remove conditions with win os_version=='11.2009' or win11_2009,
   (unless they contain verify or verify-standalone)
7. Linux conditions should have os_version, arch and display
   (simple "os == 'linux'" will get expanded to these two)
   "os == 'linux' && os_version == '22.04' && arch == 'x86_64' && display == 'wayland'"
   "os == 'linux' && os_version == '24.04' && arch == 'x86_64' && display == 'x11'"
8. Mac conditions should have os_version and arch
   (simple "os == 'mac'" will get expanded to these three)
   "os == 'mac' && os_version == '10.15' && arch == 'x86_64'",
   "os == 'mac' && os_version == '14.70' && arch == 'x86_64'",
   "os == 'mac' && os_version == '15.30' && arch == 'aarch64'",
9. Replace apple_catalina with
   os == 'mac' && os_version == '10.15' && arch == 'x86_64'
10. Replace apple_silicon with
   os == 'mac' && os_version = '15.30' && arch == 'aarch64'
11. Replace win10_2009 with
   os == 'win' && os_version = '10.2009' && arch == 'x86_64'
12. Replace "!debug" with three conditions "asan", "opt", or "tsan"
13. Replace literal boolean comparison with variables
    (e.g. "debug == false" => "!debug)

Resolves 2000285

Signed-off-by: Tom Marble <[email protected]>

Differential Revision: https://phabricator.services.mozilla.com/D272815
2025-11-22 00:30:39 +00:00
serge-sans-paille 51da93ac26 Bug 1997204 - Remove unused mfbt inclusion in mfbt/** r=emilio
As a side effect, also move content of JSONWriter.cpp as a static
constexpr local variable in JSONWriter.h.

Differential Revision: https://phabricator.services.mozilla.com/D270617
2025-10-31 08:06:03 +00:00
serge-sans-paille 2680f1aa2a Bug 1995938 - Remove unused inclusion of DebugOnly.h r=emilio,necko-reviewers,application-update-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,toolkit-telemetry-reviewers,firefox-svg-reviewers,layout-reviewers,dom-worker-reviewers,bytesized,gstoll,mstange,TYLin,chunmin,jesup,asuth
Differential Revision: https://phabricator.services.mozilla.com/D269780
2025-10-27 10:48:42 +00:00
Cristian Tuns 6f66cdf3c7 Revert "Bug 1995938 - Remove unused inclusion of DebugOnly.h r=emilio,necko-reviewers,application-update-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,toolkit-telemetry-reviewers,firefox-svg-reviewers,layout-reviewers,dom-worker-reviewers,bytesized,gstoll,mstange,TYLin,chunmin,jesup,asuth" for causing build bustages in TargetFunction.h
This reverts commit 10e5184168.
2025-10-27 08:58:03 +00:00
serge-sans-paille 10e5184168 Bug 1995938 - Remove unused inclusion of DebugOnly.h r=emilio,necko-reviewers,application-update-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,toolkit-telemetry-reviewers,firefox-svg-reviewers,layout-reviewers,dom-worker-reviewers,bytesized,gstoll,mstange,TYLin,chunmin,jesup,asuth
Differential Revision: https://phabricator.services.mozilla.com/D269780
2025-10-27 08:00:43 +00:00
serge-sans-paille 483b850523 Bug 1996047 - Remove unused inclusion of Types.h r=emilio,necko-reviewers,media-playback-reviewers,webrtc-reviewers,win-reviewers,firefox-style-system-reviewers,gstoll,chunmin,pehrsons,jesup
Differential Revision: https://phabricator.services.mozilla.com/D269777
2025-10-26 13:04:07 +00:00
serge-sans-paille 9dece22663 Bug 1991455 - Harmonize __builin_(add|sub|mul)_overflow usage r=emilio,nbp,profiler-reviewers,canaltinova
We used to have __builtin_(...) wrapped as MOZ_ADD_OVERFLOW, SafeAdd or
used directly. Get rid of MOZ_ADD_OVERFLOW, promotes SafeAdd et cie to
mfbt and use the mfbt version everywhere.

Differential Revision: https://phabricator.services.mozilla.com/D266685
2025-10-02 05:14:07 +00:00
serge-sans-paille 77667f23c9 Bug 1990262 - Obsolete mozilla::MulOverflowMask r=emilio,profiler-reviewers,canaltinova
Promote usage of __builtin_mul_overflow instead, which is supported by
all the compilers we support.

Differential Revision: https://phabricator.services.mozilla.com/D265839
2025-09-25 21:13:23 +00:00
Florian Quèze adb44fa5a4 Bug 1989356 - Add run-if = ["os != 'android'"] conditions in desktop only xpcshell test manifests, r=jmaher,application-update-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,places-reviewers,profiler-reviewers,win-reviewers,omc-reviewers,migration-reviewers,urlbar-reviewers,browser-installer-reviewers,profiles-reviewers,layout-reviewers,mossop,mstange,dholbert,gstoll,bytesized,scunnane,nchevobbe,aminomancer.
Differential Revision: https://phabricator.services.mozilla.com/D265322
2025-09-19 20:56:51 +00:00
serge-sans-paille aeee883896 Bug 1986593 - Obsolete mfbt/TemplateLib.h r=emilio,webrtc-reviewers,profiler-reviewers,layout-reviewers,canaltinova
The content of TemplateLib can be obsoleted in favor of constexpr
functions already available in mfbt/MathAlgorithms.h

- tl::Max -> std::max(x, y) or std::max({x, y, z})
- tl::Min -> std::min(x, y) or std::min({x, y, z})
- tl::FloorLog2<X>::value -> mozilla::FloorLog2(X)
- tl::CeilLog2<X>::value -> mozilla::CeilLog2(X)
- tl::RoundUpPow2<X>::value -> mozilla::RoundUpPow2(X)
- tl::BitSize<X>::value -> std::numeric_limits<X>::digits (for unsigned integral types)
- tl::MulOverflowMask<X>::value -> mozilla::MulOverflowMask(X)

the latter has been moved to mfbt/MulOverflowMask.h because it's used in
mozalloc.h and is required to have few dependencies.

also drop Windows specific code as we always build windows target with
clang-cl or mingw

Please note that the implementation of tl::CeilLog2 was incorrect for
very large numbers (typically 2**64 - 1), which impacted MulOverflowMask for those values.

This patch fixes that behavior and test it.

Differential Revision: https://phabricator.services.mozilla.com/D263523
2025-09-05 06:08:21 +00:00
Atila Butkovits 3fcad999e4 Revert "Bug 1986593 - Obsolete mfbt/TemplateLib.h r=emilio,webrtc-reviewers,profiler-reviewers,layout-reviewers,canaltinova" for causing bustages at FuzzingTraits.
This reverts commit 1a8ee563a7.
2025-09-05 00:31:46 +00:00
serge-sans-paille 1a8ee563a7 Bug 1986593 - Obsolete mfbt/TemplateLib.h r=emilio,webrtc-reviewers,profiler-reviewers,layout-reviewers,canaltinova
The content of TemplateLib can be obsoleted in favor of constexpr
functions already available in mfbt/MathAlgorithms.h

- tl::Max -> std::max(x, y) or std::max({x, y, z})
- tl::Min -> std::min(x, y) or std::min({x, y, z})
- tl::FloorLog2<X>::value -> mozilla::FloorLog2(X)
- tl::CeilLog2<X>::value -> mozilla::CeilLog2(X)
- tl::RoundUpPow2<X>::value -> mozilla::RoundUpPow2(X)
- tl::BitSize<X>::value -> std::numeric_limits<X>::digits (for unsigned integral types)
- tl::MulOverflowMask<X>::value -> mozilla::MulOverflowMask(X)

the latter has been moved to mfbt/MulOverflowMask.h because it's used in
mozalloc.h and is required to have few dependencies.

also drop Windows specific code as we always build windows target with
clang-cl or mingw

Please note that the implementation of tl::CeilLog2 was incorrect for
very large numbers (typically 2**64 - 1), which impacted MulOverflowMask for those values.

This patch fixes that behavior and test it.

Differential Revision: https://phabricator.services.mozilla.com/D263523
2025-09-04 23:34:17 +00:00
Sandor Molnar cf2854bd7e Revert "Bug 1986593 - Obsolete mfbt/TemplateLib.h r=emilio,webrtc-reviewers,profiler-reviewers,layout-reviewers,canaltinova" for causing build bustages
This reverts commit 05a72e4b10.
2025-09-04 07:47:30 +00:00
serge-sans-paille 05a72e4b10 Bug 1986593 - Obsolete mfbt/TemplateLib.h r=emilio,webrtc-reviewers,profiler-reviewers,layout-reviewers,canaltinova
The content of TemplateLib can be obsoleted in favor of constexpr
functions already available in mfbt/MathAlgorithms.h

- tl::Max -> std::max(x, y) or std::max({x, y, z})
- tl::Min -> std::min(x, y) or std::min({x, y, z})
- tl::FloorLog2<X>::value -> mozilla::FloorLog2(X)
- tl::CeilLog2<X>::value -> mozilla::CeilLog2(X)
- tl::RoundUpPow2<X>::value -> mozilla::RoundUpPow2(X)
- tl::BitSize<X>::value -> std::numeric_limits<X>::digits (for unsigned integral types)
- tl::MulOverflowMask<X>::value -> mozilla::MulOverflowMask(X)

the latter has been moved to mfbt/MulOverflowMask.h because it's used in
mozalloc.h and is required to have few dependencies.

also drop Windows specific code as we always build windows target with
clang-cl or mingw

Please note that the implementation of tl::CeilLog2 was incorrect for
very large numbers (typically 2**64 - 1), which impacted MulOverflowMask for those values.

This patch fixes that behavior and test it.

Differential Revision: https://phabricator.services.mozilla.com/D263523
2025-09-04 05:43:25 +00:00
Joel Maher 98ece24bd5 Bug 1959821 - cleanup and standardize remaining xpcshell.toml files. r=aryx,sync-reviewers,markh
Differential Revision: https://phabricator.services.mozilla.com/D245147
2025-04-15 20:24:35 +00:00
Alex Hochheiden 9e91a1f021 Bug 1715287 - [lint] Enable remaining pyupgrade rules and lint tree r=linter-reviewers,webdriver-reviewers,translations-reviewers,whimboo,sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D245320
2025-04-13 17:48:23 +00:00
Sylvestre Ledru 2ca9d22cf4 Bug 1921433 - reformat with black 24.8.0 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,taskgraph-reviewers,releng-reviewers,dom-storage-reviewers,janv,jmaher,whimboo,afinder,ahal
Differential Revision: https://phabricator.services.mozilla.com/D223963
2024-11-03 20:28:59 +00:00
serge-sans-paille 5946338a6a Bug 1920718 - Annotate all global variable with runtime initialization attributes r=glandium,application-update-reviewers,media-playback-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,gfx-reviewers,aosmond,lina,nalexander,aabh,geckoview-reviewers,win-reviewers,gstoll,m_kato
MOZ_RUNINIT => initialized at runtime
MOZ_CONSTINIT => initialized at compile time
MOZ_GLOBINIT => initialized either at runtime or compile time, depending on template parameter, macro parameter etc
This annotation is only understood by our clang-tidy plugin. It has no
effect on regular compilation.

Differential Revision: https://phabricator.services.mozilla.com/D223341
2024-10-30 11:05:24 +00:00
Tamas Szentpeteri 8285dfaab8 Backed out changeset 4b1409597101 (bug 1920718) for causing bp bustages on rapl.cpp. 2024-10-08 23:27:18 +03:00
serge-sans-paille 1966f9a43c Bug 1920718 - Annotate all global variable with runtime initialization as MOZ_RUNINIT r=application-update-reviewers,media-playback-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,gfx-reviewers,aosmond,lina,nalexander,aabh
This annotation is only understood by our clang-tidy plugin. It has no
effect on regular compilation.

Differential Revision: https://phabricator.services.mozilla.com/D223341
2024-10-08 16:49:51 +00:00
Andrew McCreight 3053112bf4 Bug 1904685 - Output the addresses in dmd.py, when present. r=pbone
With heap scan mode, the DMD log includes the address of every block.
This patch includes the addresses in the output, if they are present.
This is useful when no cycle collected objects are leaked.

Differential Revision: https://phabricator.services.mozilla.com/D214880
2024-06-26 23:25:15 +00:00
Iulian Moraru 4bd967cbee Backed out changeset 55f412f509f8 (bug 1904685) for causing xpcshell failures on test_dmd.js. CLOSED TREE 2024-06-27 01:02:57 +03:00
Andrew McCreight df00335a21 Bug 1904685 - Output the addresses in dmd.py, when present. r=pbone
With heap scan mode, the DMD log includes the address of every block.
This patch includes the addresses in the output, if they are present.
This is useful when no cycle collected objects are leaked.

Differential Revision: https://phabricator.services.mozilla.com/D214880
2024-06-26 18:10:29 +00:00
Joel Maher 5c87a37896 Bug 1859893 - batch 15 - migrate xpcshell.ini -> .toml. r=aryx,geckoview-reviewers,extension-reviewers,valentin,cookie-reviewers,pbz,owlish,robwu
Differential Revision: https://phabricator.services.mozilla.com/D194384
2023-11-24 14:41:35 +00:00
Paul Bone e2b461d62c Bug 1854550 - pt 2. Move PHC into memory/build r=glandium
We want to link PHC directly alongside jemalloc so move its code into the
memory/build/ directory.  This means that it's always statically linked even
when other replace_malloc libraries aren't.

The following patch will remove it from the replace_malloc configuration.

Differential Revision: https://phabricator.services.mozilla.com/D188983
2023-10-19 06:38:39 +00:00
Sylvestre Ledru e19d8da8b9 Bug 1856795 - ride along: use = default; on some recently modified files r=emilio
More on:
https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html

Command:
L=$(hg export -r tip|grep +++|cut -d/ -f2-)
./mach static-analysis check --checks="-*, modernize-use-equals-default" --fix $L

Differential Revision: https://phabricator.services.mozilla.com/D191016
2023-10-15 15:29:03 +00:00
Sylvestre Ledru b0fe72dee5 Bug 1856795 - Remove redundant member init r=emilio
Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .

https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html

Differential Revision: https://phabricator.services.mozilla.com/D190002
2023-10-15 15:29:02 +00:00
Cristina Horotan 7388749830 Backed out 2 changesets (bug 1856795) for causing build bustage at BasicEvents.h CLOSED TREE
Backed out changeset 1d98b028923a (bug 1856795)
Backed out changeset eae2ac93e17c (bug 1856795)
2023-10-14 21:42:14 +03:00
Sylvestre Ledru ba5da021b1 Bug 1856795 - ride along: use = default; on some recently modified files r=emilio
More on:
https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html

Command:
L=$(hg export -r tip|grep +++|cut -d/ -f2-)
./mach static-analysis check --checks="-*, modernize-use-equals-default" --fix $L

Differential Revision: https://phabricator.services.mozilla.com/D191016
2023-10-14 17:34:27 +00:00
Sylvestre Ledru 4a97019e39 Bug 1856795 - Remove redundant member init r=emilio
Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .

https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html

Differential Revision: https://phabricator.services.mozilla.com/D190002
2023-10-14 17:34:26 +00:00
Logan Rosen 45be05a920 Bug 1786490 - reformat the tree using black 23.3.0 r=sylvestre,webdriver-reviewers,taskgraph-reviewers,whimboo,jmaher,ahal,perftest-reviewers,geckoview-reviewers,afinder,m_kato
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D186092
2023-09-06 16:14:30 +00:00
Paul Bone 27ff28f4ae Bug 1829125 - Align the PHC area to the jemalloc chunk size r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D179533
2023-07-12 09:29:02 +00:00
Barret Rennie 53f069237c Bug 1747469 - Remove FileUtils.getFile from memory/ r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D180463
2023-06-13 15:57:45 +00:00
Mark Banner 0fadbc1ec4 Bug 1829618 - Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D176336
2023-05-09 16:14:51 +00:00
Andrew McCreight c189c07295 Bug 1828994 - Fix blank line printing in block_analyzer.py. r=pbone
Differential Revision: https://phabricator.services.mozilla.com/D175946
2023-04-19 23:31:33 +00:00