Commit Graph
83 Commits
Author SHA1 Message Date
Randell Jesup e6baf9d9a8 Bug 2010968: Dictionary cleanup, and handle errors better r=necko-reviewers,valentin
In particular, if we Suspend for 5+ seconds and timeout

Differential Revision: https://phabricator.services.mozilla.com/D279944
2026-01-22 23:06:38 +00:00
Randell Jesup 7c8c5134d5 Bug 1917976: Compression Dictionary match-dest support r=necko-reviewers,valentin,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D258169
2025-10-07 19:05:05 +00:00
agoloman 09c39febaf Revert (Bug 1917965, Bug 1984198, Bug 1917970, Bug 1978496, Bug 1917974, Bug 1917965, Bug 1988076, Bug 1918741, Bug 1984157, Bug 1979087, Bug 1978494, Bug 1917976, Bug 1950965, Bug 1978495, Bug 1949981, Bug 1950972, Bug 1917975, Bug 1918013, Bug 1975014, Bug 1917982, Bug 1917963, Bug 1975024) - for causing build bustages @CacheIndex.cpp
This reverts commit 26c4a68ff7.

Revert "Bug 1978495: Make clear-site-data synchronous r=necko-reviewers,valentin"

This reverts commit 19e809294c.

Revert "Bug 1917965: Bug Fix for AddStandardHeaders and an await in TRR r=necko-reviewers,valentin"

This reverts commit 4c4a17eaeb.

Revert "Bug 1984198: Fix for ipv6 clear by principal for Compression Dictionaries r=edgul"

This reverts commit da9fc176ae.

Revert "Bug 1917970: Update handling of removing encodings for CompressionDictionaries r=necko-reviewers,valentin,kershaw"

This reverts commit 4c73126208.

Revert "Bug 1978496: Add markers for Compression Dictionaries #necko-reviewers! r=necko-reviewers,valentin"

This reverts commit d7cb9a5e0b.

Revert "Bug 1917974: Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=necko-reviewers,kershaw,devtools-reviewers,bomsy"

This reverts commit df63d60f8f.

Revert "Bug 1917965: Update cache listener changes to ensure data is cached in compressed form r=necko-reviewers,kershaw"

This reverts commit 46c6d977d7.

Revert "Bug 1917970: only remove dcb and dcz Content-Encodings r=necko-reviewers,kershaw"

This reverts commit bc645c1e24.

Revert "Bug 1988076: Shutdown cleanup issues for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 22c04bad81.

Revert "Bug 1918741: Add unit tests for Compression Dictionaries r=necko-reviewers,kershaw,valentin"

This reverts commit b09a89245a.

Revert "Bug 1917974: Clean up call to GetDictionaryFor() r=valentin,necko-reviewers"

This reverts commit b4d8ad3a34.

Revert "Bug 1917965: Minor Compression Dictionary cleanup r=necko-reviewers,valentin"

This reverts commit 9ef82139ca.

Revert "Bug 1978496: Add more logs for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit a85f97ac8c.

Revert "Bug 1984157: Vary support for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 780bddc945.

Revert "Bug 1917965: Add design doc r=necko-reviewers,kershaw"

This reverts commit cf09ea9257.

Revert "Bug 1979087: Use URLPattern for matching Compression Dictionary entries r=edgul,necko-reviewers,kershaw"

This reverts commit 69720d6199.

Revert "Bug 1978494: Fix GetOriginalHeader to account for new header type r=necko-reviewers,valentin"

This reverts commit 0939a45626.

Revert "Bug 1978494: Don't use stale dictionaries, more logs, improve handling of dictionary origin reading r=necko-reviewers,valentin"

This reverts commit a2c00deb4d.

Revert "Bug 1917976: Compression Dictionary match-dest support r=necko-reviewers,valentin,kershaw"

This reverts commit bf874cae0d.

Revert "Bug 1950965: about:cache support for Compression Dictionaries and cleanup r=necko-reviewers,valentin"

This reverts commit 115be236bf.

Revert "Bug 1978495: Compression Dictionaries clear-site and clear cookies support r=necko-reviewers,valentin"

This reverts commit 62d7f7168e.

Revert "Bug 1917974: Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=necko-reviewers,valentin"

This reverts commit 5076f7a779.

Revert "Bug 1917974: Hook in Prefetching of cache entries for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 77f0cd1912.

Revert "Bug 1949981: Add code to clear Compression Dictionary entries r=necko-reviewers,valentin"

This reverts commit 515eb81e07.

Revert "Bug 1978494: Read and write of per-origin compression dictionary cache entries/metadata r=necko-reviewers,valentin"

This reverts commit 32fb24708c.

Revert "Bug 1950972: Allow changing Content-Encoding header when we decompress for cache storage r=necko-reviewers,valentin"

This reverts commit c7c5e2b800.

Revert "Bug 1917974: Add OnCacheEntryCallbacks for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit e599730050.

Revert "Bug 1917974: Make GetDictionaryFor async since we need to query the cache r=necko-reviewers,valentin"

This reverts commit 33cb96b72f.

Revert "Bug 1917975: Compression Dictionary initial metadata parsing r=necko-reviewers,valentin"

This reverts commit 2f04f4d43c.

Revert "Bug 1917975: Read dictionaries from cache for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 23e72a7efc.

Revert "Bug 1918013: Compression Dictionaries link rel= support r=smaug,necko-reviewers,kershaw"

This reverts commit f45f89e188.

Revert "Bug 1975014: Add a pref for Compression Dictionaries r=necko-reviewers,kershaw"

This reverts commit 0042928354.

Revert "Bug 1978496: Add logs for CompressionDictionaries r=necko-reviewers,sunil,kershaw"

This reverts commit 15dec18026.

Revert "Bug 1917970: Support decoding brotli & zstd dictionary-encoded streams r=necko-reviewers,valentin"

This reverts commit 3dfc96583b.

Revert "Bug 1917965: Add support for dcb and dcz content-encoding r=necko-reviewers,valentin"

This reverts commit fec1a197f4.

Revert "Bug 1917974: Accumulate Dictionary hash values r=necko-reviewers,sunil"

This reverts commit 5cdbe885bc.

Revert "Bug 1917982: Support use_as_dictionary response headers r=necko-reviewers,kershaw"

This reverts commit 642c049998.

Revert "Bug 1917965: Add initial Dictionary in-memory structures r=necko-reviewers,kershaw"

This reverts commit 19ab2d5af8.

Revert "Bug 1917963: Add Cache flags for Compression Dictionaries r=necko-reviewers,kershaw"

This reverts commit e31fee5400.

Revert "Bug 1917963: Break out adding Accept-Encoding headers r=necko-reviewers,sunil,kershaw"

This reverts commit 93bd84a618.

Revert "Bug 1918741: Change Compression Dictionary WPTs to assume pass r=necko-reviewers,kershaw"

This reverts commit e83caa2c66.

Revert "Bug 1975024: Cleanup Cache code and locks in prep for Compression Dictionaries #necko-reviewers r=necko-reviewers,kershaw"

This reverts commit 5dd4896f18.
2025-10-07 17:29:13 +00:00
Randell Jesup bf874cae0d Bug 1917976: Compression Dictionary match-dest support r=necko-reviewers,valentin,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D258169
2025-10-07 15:38:50 +00:00
Atila Butkovits 59187fbc73 Revert "Bug 1917982, Bug 1917965, Bug 1984198, Bug 1917970, Bug 1978496, Bug 1917974, Bug 1988076, Bug 1918741, Bug 1978496, Bug 1984157, Bug 1979087, Bug 1978494, Bug 1917976, Bug 1950965, Bug 1978495, Bug 1949981, Bug 1950972, Bug 1917975, Bug 1918013, Bug 1975014, Bug 1978496, Bug 1917982, Bug 1917963, Bug 1975024 - Bustage fix for Compression Dictionaries" for causing failures /dictionary-compressed.tentative.https.html.
This reverts commit fed0875f9c.

Revert "Bug 1917965: Bug Fix for AddStandardHeaders and an await in TRR r=necko-reviewers,valentin"

This reverts commit 6b674e258c.

Revert "Bug 1984198: Fix for ipv6 clear by principal for Compression Dictionaries r=edgul"

This reverts commit 368f63d711.

Revert "Bug 1917970: Update handling of removing encodings for CompressionDictionaries r=necko-reviewers,valentin,kershaw"

This reverts commit e820181a13.

Revert "Bug 1978496: Add markers for Compression Dictionaries #necko-reviewers! r=necko-reviewers,valentin"

This reverts commit f28af4e893.

Revert "Bug 1917974: Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=necko-reviewers,kershaw,devtools-reviewers,bomsy"

This reverts commit 1c5e6866db.

Revert "Bug 1917965: Update cache listener changes to ensure data is cached in compressed form r=necko-reviewers,kershaw"

This reverts commit 61b10d9023.

Revert "Bug 1917970: only remove dcb and dcz Content-Encodings r=necko-reviewers,kershaw"

This reverts commit de8a7623b8.

Revert "Bug 1988076: Shutdown cleanup issues for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 029f476c05.

Revert "Bug 1918741: Add unit tests for Compression Dictionaries r=necko-reviewers,kershaw,valentin"

This reverts commit fef96f00d6.

Revert "Bug 1917974: Clean up call to GetDictionaryFor() r=valentin,necko-reviewers"

This reverts commit dd77492425.

Revert "Bug 1917965: Minor Compression Dictionary cleanup r=necko-reviewers,valentin"

This reverts commit 0c8682ebee.

Revert "Bug 1978496: Add more logs for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 37389b2704.

Revert "Bug 1984157: Vary support for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit fa25812c95.

Revert "Bug 1917965: Add design doc r=necko-reviewers,kershaw"

This reverts commit c234e14284.

Revert "Bug 1979087: Use URLPattern for matching Compression Dictionary entries r=edgul,necko-reviewers,kershaw"

This reverts commit 894b391c09.

Revert "Bug 1978494: Fix GetOriginalHeader to account for new header type r=necko-reviewers,valentin"

This reverts commit 15b1e288ee.

Revert "Bug 1978494: Don't use stale dictionaries, more logs, improve handling of dictionary origin reading r=necko-reviewers,valentin"

This reverts commit 08db8b11eb.

Revert "Bug 1917976: Compression Dictionary match-dest support r=necko-reviewers,valentin,kershaw"

This reverts commit 12e8ea415d.

Revert "Bug 1950965: about:cache support for Compression Dictionaries and cleanup r=necko-reviewers,valentin"

This reverts commit 308c182b39.

Revert "Bug 1978495: Compression Dictionaries clear-site and clear cookies support r=necko-reviewers,valentin"

This reverts commit ccced9f287.

Revert "Bug 1917974: Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=necko-reviewers,valentin"

This reverts commit aabfdecb3a.

Revert "Bug 1917974: Hook in Prefetching of cache entries for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit c9e18bdf3b.

Revert "Bug 1949981: Add code to clear Compression Dictionary entries r=necko-reviewers,valentin"

This reverts commit 17923efc19.

Revert "Bug 1978494: Read and write of per-origin compression dictionary cache entries/metadata r=necko-reviewers,valentin"

This reverts commit eb6c192657.

Revert "Bug 1950972: Allow changing Content-Encoding header when we decompress for cache storage r=necko-reviewers,valentin"

This reverts commit 6ffc1d8f59.

Revert "Bug 1917974: Add OnCacheEntryCallbacks for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 179b725f16.

Revert "Bug 1917974: Make GetDictionaryFor async since we need to query the cache r=necko-reviewers,valentin"

This reverts commit 719a8a0e61.

Revert "Bug 1917975: Compression Dictionary initial metadata parsing r=necko-reviewers,valentin"

This reverts commit f136e15168.

Revert "Bug 1917975: Read dictionaries from cache for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit b0311449f9.

Revert "Bug 1918013: Compression Dictionaries link rel= support r=smaug,necko-reviewers,kershaw"

This reverts commit fe57630b1d.

Revert "Bug 1975014: Add a pref for Compression Dictionaries r=necko-reviewers,kershaw"

This reverts commit 3ce6095849.

Revert "Bug 1978496: Add logs for CompressionDictionaries r=necko-reviewers,sunil,kershaw"

This reverts commit b1edef3cef.

Revert "Bug 1917970: Support decoding brotli & zstd dictionary-encoded streams r=necko-reviewers,valentin"

This reverts commit d4c735d662.

Revert "Bug 1917965: Add support for dcb and dcz content-encoding r=necko-reviewers,valentin"

This reverts commit 24da1c66cf.

Revert "Bug 1917974: Accumulate Dictionary hash values r=necko-reviewers,sunil"

This reverts commit ed3b6cd3ec.

Revert "Bug 1917982: Support use_as_dictionary response headers r=necko-reviewers,kershaw"

This reverts commit 193a608480.

Revert "Bug 1917965: Add initial Dictionary in-memory structures r=necko-reviewers,kershaw"

This reverts commit fb79c5cf99.

Revert "Bug 1917963: Add Cache flags for Compression Dictionaries r=necko-reviewers,kershaw"

This reverts commit defcbb1ecb.

Revert "Bug 1917963: Break out adding Accept-Encoding headers r=necko-reviewers,sunil,kershaw"

This reverts commit 805e20dc69.

Revert "Bug 1918741: Change Compression Dictionary WPTs to assume pass r=necko-reviewers,kershaw"

This reverts commit c15147919a.
2025-10-02 10:47:07 +00:00
Randell Jesup 12e8ea415d Bug 1917976: Compression Dictionary match-dest support r=necko-reviewers,valentin,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D258169
2025-10-01 18:49:48 +00:00
pstanciu ae99b0b77a Revert (Bug 1917976, Bug 1975024, Bug 1918741, Bug 1917963, Bug 1917965, Bug 1917982, Bug 1917974, Bug 1917965, Bug 1917970, Bug 1978496, Bug 1975014, Bug 1918013, Bug 1950972, Bug 1978494, Bug 1949981, Bug 1978495, Bug 1950965) : for causing bustages at Dictionary.h and xpc failures.
This reverts commit 514a56ce7c.

Revert "Bug 1984198: Fix for ipv6 clear by principal for Compression Dictionaries r=edgul"

This reverts commit 49e75644bb.

Revert "Bug 1917970: Update handling of removing encodings for CompressionDictionaries r=necko-reviewers,valentin,kershaw"

This reverts commit 753967e2d6.

Revert "Bug 1978496: Add markers for Compression Dictionaries #necko-reviewers! r=necko-reviewers,valentin"

This reverts commit 19f91b61eb.

Revert "Bug 1917974: Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=necko-reviewers,kershaw,devtools-reviewers,bomsy"

This reverts commit f178e71d24.

Revert "Bug 1917965: Update cache listener changes to ensure data is cached in compressed form r=necko-reviewers,kershaw"

This reverts commit 25abb43ee9.

Revert "Bug 1917970: only remove dcb and dcz Content-Encodings r=necko-reviewers,kershaw"

This reverts commit bc04c2d7a0.

Revert "Bug 1988076: Shutdown cleanup issues for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 5d0db3ea2e.

Revert "Bug 1918741: Add unit tests for Compression Dictionaries r=necko-reviewers,kershaw,valentin"

This reverts commit 82843be7c5.

Revert "Bug 1917974: Clean up call to GetDictionaryFor() r=valentin,necko-reviewers"

This reverts commit 97c3a788a8.

Revert "Bug 1917965: Minor Compression Dictionary cleanup r=necko-reviewers,valentin"

This reverts commit 6367b70657.

Revert "Bug 1978496: Add more logs for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 66b2d52697.

Revert "Bug 1984157: Vary support for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 1288fcf5b7.

Revert "Bug 1917965: Add design doc r=necko-reviewers,kershaw"

This reverts commit b420476321.

Revert "Bug 1979087: Use URLPattern for matching Compression Dictionary entries r=edgul,necko-reviewers,kershaw"

This reverts commit 806745b1b8.

Revert "Bug 1978494: Fix GetOriginalHeader to account for new header type r=necko-reviewers,valentin"

This reverts commit e3673c58e0.

Revert "Bug 1978494: Don't use stale dictionaries, more logs, improve handling of dictionary origin reading r=necko-reviewers,valentin"

This reverts commit e682425023.

Revert "Bug 1917976: Compression Dictionary match-dest support r=necko-reviewers,valentin,kershaw"

This reverts commit a5b3788a8a.

Revert "Bug 1950965: about:cache support for Compression Dictionaries and cleanup r=necko-reviewers,valentin"

This reverts commit f55e2fd4e4.

Revert "Bug 1978495: Compression Dictionaries clear-site and clear cookies support r=necko-reviewers,valentin"

This reverts commit 81b73f489d.

Revert "Bug 1917974: Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=necko-reviewers,valentin"

This reverts commit f320951077.

Revert "Bug 1917974: Hook in Prefetching of cache entries for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 8dc5e144c1.

Revert "Bug 1949981: Add code to clear Compression Dictionary entries r=necko-reviewers,valentin"

This reverts commit f5038a3aec.

Revert "Bug 1978494: Read and write of per-origin compression dictionary cache entries/metadata r=necko-reviewers,valentin"

This reverts commit cf88b3debf.

Revert "Bug 1950972: Allow changing Content-Encoding header when we decompress for cache storage r=necko-reviewers,valentin"

This reverts commit 8804a2dac8.

Revert "Bug 1917974: Add OnCacheEntryCallbacks for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 3ce506bc4b.

Revert "Bug 1917974: Make GetDictionaryFor async since we need to query the cache r=necko-reviewers,valentin"

This reverts commit a6a46a5458.

Revert "Bug 1917975: Compression Dictionary initial metadata parsing r=necko-reviewers,valentin"

This reverts commit ca97899007.

Revert "Bug 1917975: Read dictionaries from cache for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit ec1bb860f9.

Revert "Bug 1918013: Compression Dictionaries link rel= support r=smaug,necko-reviewers,kershaw"

This reverts commit 5ade563439.

Revert "Bug 1975014: Add a pref for Compression Dictionaries r=necko-reviewers,kershaw"

This reverts commit a57404e2ad.

Revert "Bug 1978496: Add logs for CompressionDictionaries r=necko-reviewers,sunil,kershaw"

This reverts commit 14ec12fcb5.

Revert "Bug 1917970: Support decoding brotli & zstd dictionary-encoded streams r=necko-reviewers,valentin"

This reverts commit dd343a079f.

Revert "Bug 1917965: Add support for dcb and dcz content-encoding r=necko-reviewers,valentin"

This reverts commit c780e137ed.

Revert "Bug 1917974: Accumulate Dictionary hash values r=necko-reviewers,sunil"

This reverts commit 33dee2c198.

Revert "Bug 1917982: Support use_as_dictionary response headers r=necko-reviewers,kershaw"

This reverts commit f69e983309.

Revert "Bug 1917965: Add initial Dictionary in-memory structures r=necko-reviewers,kershaw"

This reverts commit eb2fad282b.

Revert "Bug 1917963: Add Cache flags for Compression Dictionaries r=necko-reviewers,kershaw"

This reverts commit b57a4024b3.

Revert "Bug 1917963: Break out adding Accept-Encoding headers r=necko-reviewers,sunil,kershaw"

This reverts commit 684a2582ad.

Revert "Bug 1918741: Change Compression Dictionary WPTs to assume pass r=necko-reviewers,kershaw"

This reverts commit a6aa9be773.

Revert "Bug 1975024: Cleanup Cache code and locks in prep for Compression Dictionaries #necko-reviewers r=necko-reviewers,kershaw"

This reverts commit a6c4d697d2.
2025-09-30 05:52:17 +00:00
Randell Jesup a5b3788a8a Bug 1917976: Compression Dictionary match-dest support r=necko-reviewers,valentin,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D258169
2025-09-30 04:12:14 +00:00
Atila Butkovits 623b31bc82 Revert "Bug 1917976, Bug 1975024, Bug 1918741, Bug 1917963, Bug 1917965, Bug 1917982, Bug 1917974, Bug 1917965, Bug 1917970, Bug 1978496, Bug 1975014, Bug 1918013, Bug 1950972, Bug 1978494, Bug 1949981, Bug 1978495, Bug 1950965 : Compression Dictionary match-dest support r=necko-reviewers,valentin,kershaw" for causing bustages at Dictionary.h.
This reverts commit 7eac16fc33.

Revert "Bug 1950965: about:cache support for Compression Dictionaries and cleanup r=necko-reviewers,valentin"

This reverts commit f20cb3c054.

Revert "Bug 1978495: Compression Dictionaries clear-site and clear cookies support r=necko-reviewers,valentin"

This reverts commit a71b23dedd.

Revert "Bug 1917974: Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=necko-reviewers,valentin"

This reverts commit 31007cf1b0.

Revert "Bug 1917974: Hook in Prefetching of cache entries for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 5b21f619d7.

Revert "Bug 1949981: Add code to clear Compression Dictionary entries r=necko-reviewers,valentin"

This reverts commit 5d226cc697.

Revert "Bug 1978494: Read and write of per-origin compression dictionary cache entries/metadata r=necko-reviewers,valentin"

This reverts commit b9b9ce5b59.

Revert "Bug 1950972: Allow changing Content-Encoding header when we decompress for cache storage r=necko-reviewers,valentin"

This reverts commit 3b93754dc8.

Revert "Bug 1917974: Add OnCacheEntryCallbacks for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 685cec0da4.

Revert "Bug 1917974: Make GetDictionaryFor async since we need to query the cache r=necko-reviewers,valentin"

This reverts commit 7e8b87dc92.

Revert "Bug 1917975: Compression Dictionary initial metadata parsing r=necko-reviewers,valentin"

This reverts commit 3c2ce1610d.

Revert "Bug 1917975: Read dictionaries from cache for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 3cff08788b.

Revert "Bug 1918013: Compression Dictionaries link rel= support r=smaug,necko-reviewers,kershaw"

This reverts commit dbf44c8056.

Revert "Bug 1975014: Add a pref for Compression Dictionaries r=necko-reviewers,kershaw"

This reverts commit 3a51e8f6a3.

Revert "Bug 1978496: Add logs for CompressionDictionaries r=necko-reviewers,sunil,kershaw"

This reverts commit 2c840b92cf.

Revert "Bug 1917970: Support decoding brotli & zstd dictionary-encoded streams r=necko-reviewers,valentin"

This reverts commit c9dbb0f0b8.

Revert "Bug 1917965: Add support for dcb and dcz content-encoding r=necko-reviewers,valentin"

This reverts commit 30d93ba900.

Revert "Bug 1917974: Accumulate Dictionary hash values r=necko-reviewers,sunil"

This reverts commit ea0cf24187.

Revert "Bug 1917982: Support use_as_dictionary response headers r=necko-reviewers,kershaw"

This reverts commit a123a402bc.

Revert "Bug 1917965: Add initial Dictionary in-memory structures r=necko-reviewers,kershaw"

This reverts commit dbfc0f17a5.

Revert "Bug 1917963: Add Cache flags for Compression Dictionaries r=necko-reviewers,kershaw"

This reverts commit 44d7a55455.

Revert "Bug 1917963: Break out adding Accept-Encoding headers r=necko-reviewers,sunil,kershaw"

This reverts commit 9dc491894a.

Revert "Bug 1918741: Change Compression Dictionary WPTs to assume pass r=necko-reviewers,kershaw"

This reverts commit 3dd0937b01.

Revert "Bug 1975024: Cleanup Cache code and locks in prep for Compression Dictionaries #necko-reviewers r=necko-reviewers,kershaw"

This reverts commit 06538c79f3.
2025-09-29 23:50:20 +00:00
Randell Jesup 7eac16fc33 Bug 1917976: Compression Dictionary match-dest support r=necko-reviewers,valentin,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D258169
2025-09-29 22:40:51 +00:00
Alexandru Marc d3c24eb0c8 Revert (Bug 1917965, Bug 1984198, Bug 1917970, Bug 1978496, Bug 1917974, Bug 1917965, Bug 1988076, Bug 1918741, Bug 1984157, Bug 1979087, Bug 1978494, Bug 1917976, Bug 1950965, Bug 1978495, Bug 1949981, Bug 1950972, Bug 1917975, Bug 1918013, Bug 1975014, Bug 1917982, Bug 1917963, Bug 1975024) for causing multiple failures
This reverts commit a62de19085.

Revert "Bug 1984198: Fix for ipv6 clear by principal for Compression Dictionaries r=edgul"

This reverts commit b8431ff2c9.

Revert "Bug 1917970: Update handling of removing encodings for CompressionDictionaries r=necko-reviewers,valentin"

This reverts commit 3fc14c6c42.

Revert "Bug 1978496: Add markers for Compression Dictionaries #necko-reviewers! r=necko-reviewers,valentin"

This reverts commit 9e82d0a532.

Revert "Bug 1917974: Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=necko-reviewers,kershaw,devtools-reviewers,bomsy"

This reverts commit f358804607.

Revert "Bug 1917965: Update cache listener changes to ensure data is cached in compressed form r=necko-reviewers,kershaw"

This reverts commit e4b0ee01ef.

Revert "Bug 1917970: only remove dcb and dcz Content-Encodings r=necko-reviewers,kershaw"

This reverts commit 8856e191eb.

Revert "Bug 1988076: Shutdown cleanup issues for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 298f2719ca.

Revert "Bug 1918741: Add unit tests for Compression Dictionaries r=necko-reviewers,kershaw,valentin"

This reverts commit d0be459d57.

Revert "Bug 1917974: Clean up call to GetDictionaryFor() r=valentin,necko-reviewers"

This reverts commit e2a5d4310e.

Revert "Bug 1917965: Minor Compression Dictionary cleanup r=necko-reviewers,valentin"

This reverts commit fb15b15ecc.

Revert "Bug 1978496: Add more logs for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 76b5d5bfa9.

Revert "Bug 1984157: Vary support for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 683c7f75bb.

Revert "Bug 1917965: Add design doc r=necko-reviewers,kershaw"

This reverts commit bbb367ba0f.

Revert "Bug 1979087: Use URLPattern for matching Compression Dictionary entries r=edgul,necko-reviewers,kershaw"

This reverts commit 1bd9f8c4cd.

Revert "Bug 1978494: Fix GetOriginalHeader to account for new header type r=necko-reviewers,valentin"

This reverts commit b26eaba8f2.

Revert "Bug 1978494: Don't use stale dictionaries, more logs, improve handling of dictionary origin reading r=necko-reviewers,valentin"

This reverts commit 20e14f4d49.

Revert "Bug 1917976: Compression Dictionary match-dest support r=necko-reviewers,valentin"

This reverts commit 1c5baa2cd3.

Revert "Bug 1950965: about:cache support for Compression Dictionaries and cleanup r=necko-reviewers,valentin"

This reverts commit 4e477f6d6b.

Revert "Bug 1978495: Compression Dictionaries clear-site and clear cookies support r=necko-reviewers,valentin"

This reverts commit aa0c36b471.

Revert "Bug 1917974: Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=necko-reviewers,valentin"

This reverts commit b112c8033c.

Revert "Bug 1917974: Hook in Prefetching of cache entries for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 92e5123e80.

Revert "Bug 1949981: Add code to clear Compression Dictionary entries r=necko-reviewers,valentin"

This reverts commit 74138e9d5a.

Revert "Bug 1978494: Read and write of per-origin compression dictionary cache entries/metadata r=necko-reviewers,valentin"

This reverts commit 335f2c9fbb.

Revert "Bug 1950972: Allow changing Content-Encoding header when we decompress for cache storage r=necko-reviewers,valentin"

This reverts commit 39204f248f.

Revert "Bug 1917974: Add OnCacheEntryCallbacks for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit f98d53f3d8.

Revert "Bug 1917974: Make GetDictionaryFor async since we need to query the cache r=necko-reviewers,valentin"

This reverts commit a7a3926186.

Revert "Bug 1917975: Compression Dictionary initial metadata parsing r=necko-reviewers,valentin"

This reverts commit 9f9ea602f2.

Revert "Bug 1917975: Read dictionaries from cache for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit f09139041d.

Revert "Bug 1918013: Compression Dictionaries link rel= support r=smaug,necko-reviewers,kershaw"

This reverts commit 65fd9e3ed6.

Revert "Bug 1975014: Add a pref for Compression Dictionaries r=necko-reviewers,kershaw"

This reverts commit e7d7622f1f.

Revert "Bug 1978496: Add logs for CompressionDictionaries r=necko-reviewers,sunil,kershaw"

This reverts commit 571cd66ff1.

Revert "Bug 1917970: Support decoding brotli & zstd dictionary-encoded streams r=necko-reviewers,valentin"

This reverts commit 824777a5bd.

Revert "Bug 1917965: Add support for dcb and dcz content-encoding r=necko-reviewers,valentin"

This reverts commit eb9526c598.

Revert "Bug 1917974: Accumulate Dictionary hash values r=necko-reviewers,sunil"

This reverts commit 015daa433c.

Revert "Bug 1917982: Support use_as_dictionary response headers r=necko-reviewers,kershaw"

This reverts commit b56fb26d92.

Revert "Bug 1917965: Add initial Dictionary in-memory structures r=necko-reviewers,kershaw"

This reverts commit 54ccef454d.

Revert "Bug 1917963: Add Cache flags for Compression Dictionaries r=necko-reviewers,kershaw"

This reverts commit 6ab1d8ea49.

Revert "Bug 1917963: Break out adding Accept-Encoding headers r=necko-reviewers,sunil,kershaw"

This reverts commit 88f0f57e8c.

Revert "Bug 1918741: Change Compression Dictionary WPTs to assume pass r=necko-reviewers,kershaw"

This reverts commit 678a1957f2.

Revert "Bug 1975024: Cleanup Cache code and locks in prep for Compression Dictionaries #necko-reviewers r=necko-reviewers,kershaw"

This reverts commit 564fa92834.
2025-09-29 06:44:40 +00:00
Randell Jesup 1c5baa2cd3 Bug 1917976: Compression Dictionary match-dest support r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D258169
2025-09-29 05:04:33 +00:00
Sandor Molnar cb358f86a6 Revert "Bug 1984198: Fix for ipv6 clear by principal for Compression Dictionaries r=edgul" for causing multiple failures.
This reverts commit 226f13bbaa.

Revert "Bug 1917970: Update handling of removing encodings for CompressionDictionaries r=necko-reviewers,valentin"

This reverts commit 34075340a1.

Revert "Bug 1978496: Add markers for Compression Dictionaries #necko-reviewers! r=necko-reviewers,valentin"

This reverts commit 9bd8f245ed.

Revert "Bug 1917974: Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=necko-reviewers,kershaw,devtools-reviewers,bomsy"

This reverts commit 1e9c6f2132.

Revert "Bug 1917965: Update cache listener changes to ensure data is cached in compressed form r=necko-reviewers,kershaw"

This reverts commit 282dc849ce.

Revert "Bug 1917970: only remove dcb and dcz Content-Encodings r=necko-reviewers,kershaw"

This reverts commit 9a96ce3cf6.

Revert "Bug 1988076: Shutdown cleanup issues for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 0174e07469.

Revert "Bug 1918741: Add unit tests for Compression Dictionaries r=necko-reviewers,kershaw,valentin"

This reverts commit 59404a79bc.

Revert "Bug 1917974: Clean up call to GetDictionaryFor() r=valentin,necko-reviewers"

This reverts commit b62c076aa4.

Revert "Bug 1917965: Minor Compression Dictionary cleanup r=necko-reviewers,valentin"

This reverts commit cd0280c5ac.

Revert "Bug 1978496: Add more logs for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 7839774cd9.

Revert "Bug 1984157: Vary support for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit fa667bc385.

Revert "Bug 1917965: Add design doc r=necko-reviewers,kershaw"

This reverts commit 61fdb8a09b.

Revert "Bug 1979087: Use URLPattern for matching Compression Dictionary entries r=edgul,necko-reviewers,kershaw"

This reverts commit 35d7f5a214.

Revert "Bug 1978494: Fix GetOriginalHeader to account for new header type r=necko-reviewers,valentin"

This reverts commit 5a5a9a0958.

Revert "Bug 1978494: Don't use stale dictionaries, more logs, improve handling of dictionary origin reading r=necko-reviewers,valentin"

This reverts commit 44958040fe.

Revert "Bug 1917976: Compression Dictionary match-dest support r=necko-reviewers,valentin"

This reverts commit d9cd937a33.

Revert "Bug 1950965: about:cache support for Compression Dictionaries and cleanup r=necko-reviewers,valentin"

This reverts commit e9b14c6d0e.

Revert "Bug 1978495: Compression Dictionaries clear-site and clear cookies support r=necko-reviewers,valentin"

This reverts commit 2663be7031.

Revert "Bug 1917974: Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=necko-reviewers,valentin"

This reverts commit 695c5efddd.

Revert "Bug 1917974: Hook in Prefetching of cache entries for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 66d6a7822d.

Revert "Bug 1949981: Add code to clear Compression Dictionary entries r=necko-reviewers,valentin"

This reverts commit cc4dedfaa4.

Revert "Bug 1978494: Read and write of per-origin compression dictionary cache entries/metadata r=necko-reviewers,valentin"

This reverts commit 3ba403a61b.

Revert "Bug 1950972: Allow changing Content-Encoding header when we decompress for cache storage r=necko-reviewers,valentin"

This reverts commit 2cf713afef.

Revert "Bug 1917974: Add OnCacheEntryCallbacks for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 7cab0d4a55.

Revert "Bug 1917974: Make GetDictionaryFor async since we need to query the cache r=necko-reviewers,valentin"

This reverts commit f9141e066c.

Revert "Bug 1917975: Compression Dictionary initial metadata parsing r=necko-reviewers,valentin"

This reverts commit 662b14aa21.

Revert "Bug 1917975: Read dictionaries from cache for Compression Dictionaries r=necko-reviewers,valentin"

This reverts commit 30550b7b7e.

Revert "Bug 1918013: Compression Dictionaries link rel= support r=smaug,necko-reviewers,kershaw"

This reverts commit d5761cadb5.

Revert "Bug 1975014: Add a pref for Compression Dictionaries r=necko-reviewers,kershaw"

This reverts commit 124a4b4fc1.

Revert "Bug 1978496: Add logs for CompressionDictionaries r=necko-reviewers,sunil,kershaw"

This reverts commit d59c44aa80.

Revert "Bug 1917970: Support decoding brotli & zstd dictionary-encoded streams r=necko-reviewers,valentin"

This reverts commit da5fa5f46a.

Revert "Bug 1917965: Add support for dcb and dcz content-encoding r=necko-reviewers,valentin"

This reverts commit f7d7f70e67.

Revert "Bug 1917974: Accumulate Dictionary hash values r=necko-reviewers,sunil"

This reverts commit e51d5b97d8.

Revert "Bug 1917982: Support use_as_dictionary response headers r=necko-reviewers,kershaw"

This reverts commit cce783fbec.

Revert "Bug 1917965: Add initial Dictionary in-memory structures r=necko-reviewers,kershaw"

This reverts commit b33fb96b0a.

Revert "Bug 1917963: Add Cache flags for Compression Dictionaries r=necko-reviewers,kershaw"

This reverts commit 97b52209a1.

Revert "Bug 1917963: Break out adding Accept-Encoding headers r=necko-reviewers,sunil,kershaw"

This reverts commit 0e13d73649.

Revert "Bug 1918741: Change Compression Dictionary WPTs to assume pass r=necko-reviewers,kershaw"

This reverts commit 5f59bcdc64.

Revert "Bug 1975024: Cleanup Cache code and locks in prep for Compression Dictionaries #necko-reviewers r=necko-reviewers,kershaw"

This reverts commit f275cacfa2.
2025-09-27 00:03:58 +00:00
Randell Jesup d9cd937a33 Bug 1917976: Compression Dictionary match-dest support r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D258169
2025-09-26 22:24:51 +00:00
Florian Quèze 9885783942 Bug 1956726 - remove leftover Telemetry.h includes in .cpp files, r=chutten,geckoview-reviewers,cookie-reviewers,win-reviewers,dom-storage-reviewers,gstoll,valentin,m_kato,janv.
Differential Revision: https://phabricator.services.mozilla.com/D244351
2025-04-08 13:03:02 +00:00
smayya c2304e4ce5 Bug 1928382 - Doom cache file on metadata corruption. r=necko-reviewers,jesup,valentin
Differential Revision: https://phabricator.services.mozilla.com/D242937
2025-04-03 03:25:25 +00:00
Florian Quèze 9609e47f62 Bug 1879329 - script generated replacement of the GleanMetrics.h includes, r=chutten,valentin,media-playback-reviewers,cookie-reviewers,anti-tracking-reviewers,profiler-reviewers,win-reviewers,rkraesig,emz,aabh,padenot.
Differential Revision: https://phabricator.services.mozilla.com/D234744
2025-01-21 11:21:45 +00:00
Sean c728db78f3 Bug 1908994 - Migrate NETWORK_CACHE_METADATA_* probes to Glean r=kershaw,acreskey,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D217177
2024-07-25 16:39:48 +00:00
Kershaw Chang b1346aabfe Bug 1893075 - Refactor CacheFileIOManager::Write, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D208739
2024-05-03 07:50:38 +00:00
Valentin Gosu 83def1272f Bug 1827504 - Remove last files of netwerk/cache/ r=sunil,geckoview-reviewers,zeid,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D175177
2023-04-13 09:04:24 +00:00
Kershaw Chang a1b5fc5bcb Bug 1615017 - Use a wrapped lock to protect data in CacheFileMetadata, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D126650
2021-09-27 20:59:17 +00:00
Valentin Gosu 9560d62d63 Bug 1714307 - Run modernize-use-default-member-init --fix check on netwerk r=necko-reviewers,kershaw
This changeset is the result of adding modernize-use-default-member-init to
tools/clang-tidy/config.yaml then proceeding to run
`./mach static-analysis check netwerk/ --fix`
I then went through the resulting fix and manually updated all of the member
variables which were missed due to them having a non-trivial constructor.

Note that the tool was only run on Linux, so code that only runs on some
platforms may have been missed.

The member variables that are still initialized in the contructor definition
are:
  - bitfields (not all currently supported compilers allow default-member-init
  - variables that are initialized via a parameter
  - variables that use code not visible in the header file

There are a few advantages to landing this change:
- fewer lines of code - now declaration is in the same place as initialization
  this also makes it easier to see when looking at the header.
- it makes it harder to miss initializing a member when adding a new contructor
- variables that depend on an include guard look much nicer now

Additionally I removed some unnecessary reinitialization of NetAddr members
(it has a constructor that does that now), and changed nsWifiScannerDBus to
use the thread-safe strtok_r instead of strtok.

Differential Revision: https://phabricator.services.mozilla.com/D116980
2021-06-11 07:10:41 +00:00
Csoregi Natalia e88581b300 Backed out changeset 6e00f8bd2acc (bug 1714307) for causing hazard bustage. CLOSED TREE 2021-06-09 21:50:03 +03:00
Valentin Gosu c01e585de7 Bug 1714307 - Run modernize-use-default-member-init --fix check on netwerk r=necko-reviewers,kershaw
This changeset is the result of adding modernize-use-default-member-init to
tools/clang-tidy/config.yaml then proceeding to run
`./mach static-analysis check netwerk/ --fix`
I then went through the resulting fix and manually updated all of the member
variables which were missed due to them having a non-trivial constructor.

Note that the tool was only run on Linux, so code that only runs on some
platforms may have been missed.

The member variables that are still initialized in the contructor definition
are:
  - bitfields (not all currently supported compilers allow default-member-init
  - variables that are initialized via a parameter
  - variables that use code not visible in the header file

There are a few advantages to landing this change:
- fewer lines of code - now declaration is in the same place as initialization
  this also makes it easier to see when looking at the header.
- it makes it harder to miss initializing a member when adding a new contructor
- variables that depend on an include guard look much nicer now

Additionally I removed some unnecessary reinitialization of NetAddr members
(it has a constructor that does that now), and changed nsWifiScannerDBus to
use the thread-safe strtok_r instead of strtok.

Differential Revision: https://phabricator.services.mozilla.com/D116980
2021-06-09 10:20:04 +00:00
Valentin Gosu 56cd5036af Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D116701
2021-06-04 12:35:16 +00:00
Butkovits Atila 1f3e4dc865 Backed out changeset c4b44c4ef15b (bug 1714307) for causing build bustages on nsHTTPCompressConv.h. CLOSED TREE 2021-06-04 13:53:37 +03:00
Valentin Gosu 5b4ead87fd Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D116701
2021-06-04 10:00:55 +00:00
Emilio Cobos Álvarez 3f4ce376a6 Bug 1599615 - Make some necko code less nsresult-happy. r=kershaw,valentin
Stuff that's infallible and not virtual has no reason to return an nsresult.

Differential Revision: https://phabricator.services.mozilla.com/D54831
2019-12-02 13:21:06 +00:00
Sylvestre Ledru ad31adba4c Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan
# ignore-this-changeset

Depends on D28954

Differential Revision: https://phabricator.services.mozilla.com/D28956
2019-05-01 08:47:10 +00:00
Michal Novotny f5eaaf384f Bug 1495336 - High limit of NETWORK_CACHE_METADATA_SIZE and NETWORK_CACHE_METADATA_FIRST_READ_SIZE probes is too low. r=chutten
Maximum size of elements in metadata is 64kB, the rest (URL, hashes and few uint32_t members) should normally fit into 1kB, so I set new high value of NETWORK_CACHE_METADATA_SIZE_2 to 65kB. With 66 buckets each bucket should be exactly 1kB wide.
NETWORK_CACHE_METADATA_FIRST_READ_SIZE doesn't provide any useful information and this patch removes the probe.
2019-01-09 10:27:00 +02:00
Sylvestre Ledru e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Michal Novotny 810c774a1f Bug 1418028 - UBSan: null pointer passed to memcpy in CacheFileMetadata::WriteMetadata. r=honzab 2018-01-18 07:50:00 -05:00
Michal Novotny 079cf3b66f Bug 1414046 - Skip copying mHashArray in CacheFileMetadata::WriteMetadata if it's empty. r=valentin 2017-11-03 03:17:00 -04:00
Michal Novotny 850c895915 Bug 1403010 - Crash due to race condition in CacheFileMetadata::SizeOfExcludingThis when reading or writing metadata, r=valentin 2017-10-03 16:49:39 +02:00
Michal Novotny ccfdf28635 Bug 1352916 - Add release asserts to try to narrow down the source of the reported crashes. r=valentin 2017-04-05 08:13:00 -04:00
Michal Novotny 357c6b94e1 Bug 1343916 - CacheFile::Truncate doesn't update hashes in CacheFileMetadata, r=valentin 2017-03-09 17:28:56 +01:00
Tom Tromey a4b717ab39 Bug 1060419 - make log_print use Printf.h, r=froydnj
MozReview-Commit-ID: BIZ1GQEZ1vs
2016-12-15 20:16:31 -07:00
Andrew McCreight 209d4ee048 Bug 1323042 - forbid MOZ_COUNT_{CTOR,DTOR} for nsISupports classes; r=froydnj 2016-12-12 09:27:58 -05:00
Nathan Froyd f2d50c26f4 Backout aba6c73511a2 (bug 1307961) for massive test bustage resulting in a CLOSED TREE; r=alltheorange 2016-12-12 08:45:46 -05:00
Andrew McCreight 2f93d6e48d Bug 1307961 - require consistent bloatview reporting for nsISupports classes; r=froydnj 2016-12-12 07:58:33 -05:00
Michal Novotny 6265bfdf2d Bug 1258747 - Support for alternative data in CacheFile, r=honzab 2016-08-17 12:58:44 +02:00
Honza Bambas e1eaf2084a Bug 1292509 - Mark CacheFileHandles invalid ASAP we can't read metadata, r=michal 2016-08-05 11:10:00 +02:00
Michal Novotny 911d646438 Bug 1267980 - Leak buffers in CacheFileChunk and CacheFileMetadata during shutdown, r=honzab 2016-05-11 11:46:54 +02:00
Honza Bambas 88d540ea21 Bug 1032254 - Generic way to pin reasource in the HTTP cache, r=michal
* * *
Bug NNNNNNN - message, r=reviewer
2015-10-22 12:11:00 +02:00
Honza Bambas 213ca181dd Bug 1165269 - Use OriginAttributes in nsILoadContextInfo, r=michal+allstars 2015-10-11 18:13:09 +02:00
Michal Novotny a290271052 Bug 1177278 - Large OOMs in CacheFileMetadata::WriteMetadata, r=honzab 2015-07-22 15:23:16 +02:00
Birunthan Mohanathas a29151dc87 Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
The bulk of this commit was generated by running:

  run-clang-tidy.py \
    -checks='-*,llvm-namespace-comment' \
    -header-filter=^/.../mozilla-central/.* \
    -fix
2015-07-13 08:25:42 -07:00
Michal Novotny 3338621c85 Bug 1171724 - Large OOMs in CacheFileMetadata, r=honzab 2015-06-24 06:33:37 +02:00
Michal Novotny 2ef0ebc4df Bug 1141555 - HTTP cache v2 generates corrupted entries, r=jduell 2015-03-26 23:05:34 +01:00
Michal Novotny 0d57d2fe51 Bug 1139014 - Optimize memory allocations in CacheFileMetadata, r=honzab 2015-03-06 15:49:04 +01:00