Commit Graph
25 Commits
Author SHA1 Message Date
Tim Huang 790103b777 Bug 2035515 - Part 1: Change the ContentClassifierService::CancelChannel() to use ChannelClassifierUtils::MaybeBlockChannel(). r=bvandersloot
Differential Revision: https://phabricator.services.mozilla.com/D301723
2026-05-22 15:53:08 +00:00
Tim Huang f532bb49ed Bug 2038663 - Part 2: Move a common logic of handling channel cancellation into ClassifierChannelUtils. r=bvandersloot
This patch moves a common logic for blocking URLClassifier features into
the ClassifierChannelUtils.

Differential Revision: https://phabricator.services.mozilla.com/D301028
2026-05-22 07:57:57 +00:00
Tim Huang 21a72ace6c Bug 2038663 - Part 1: Introduce ClassifierChannelUtils and move relevant APIs. r=bvandersloot
This patch moves relevant APIs that interact with the channel to a
separate ClassifierChannelUtils class from the URLClassifierCommon.

The ClassifierChannelUtils shares between the UrlClassifier and
the ContentClassifier.

Differential Revision: https://phabricator.services.mozilla.com/D301027
2026-05-22 07:57:54 +00:00
Manuel Bucher bf6eb8d867 Bug 2020289 - Reduce Page Protection: Expand to other tracker-blocking categories r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D289269
2026-03-25 14:27:45 +00:00
Sylvestre Ledru a22215a2f9 Bug 2023419 - Remove Emacs/Vim modelines from netwerk/ r=emilio,cookie-reviewers,valentin
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287861
2026-03-17 12:06:31 +00:00
serge-sans-paille 7662b3abdc Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 19:36:01 +00:00
Cristina Horotan 8a1b1970b7 Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing Gtest failures on AlreadyAddRefed.h
This reverts commit e98adca292.
2025-10-21 16:16:29 +00:00
serge-sans-paille e98adca292 Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 15:05:17 +00:00
Cristina Horotan aab924e90d Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing build bustage at nsBrowserApp.cpp
This reverts commit fd0ffa193c.
2025-10-21 10:44:13 +00:00
serge-sans-paille fd0ffa193c Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 09:44:11 +00:00
Narcis Beleuzu e1e6bbb1c9 Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing bustages on Document.cpp
This reverts commit b23c15e927.
2025-10-21 06:34:58 +00:00
serge-sans-paille b23c15e927 Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 06:01:36 +00:00
William Wen e7cdbaba87 Bug 1950985 - Add tracking protection skip for channels annotated as a consent manager. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D241468
2025-03-25 14:58:20 +00:00
Benjamin VanderSloot 8720bf9ed4 Bug 1930467 - Channel classification should not be performed on foreign channels that are same site to the top level - r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D230420
2024-12-13 12:53:55 +00:00
Stanca Serban 82618833ab Backed out changeset 1ae3ac5ab2be (bug 1930467) for causing mochitests failures in browser_storageAccessThirdPartyChecks_alwaysPartition.js. 2024-12-12 19:46:39 +02:00
Benjamin VanderSloot 00f4a76108 Bug 1930467 - Channel classification should not be performed on foreign channels that are same site to the top level - r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D230420
2024-12-12 15:28:40 +00:00
Norisz Fay 28ea0857e7 Backed out changeset 320415b14dee (bug 1930467) for causing bc failures on browser_doublyNestedTracker.js CLOSED TREE 2024-12-10 19:18:35 +02:00
Benjamin VanderSloot 54dfe6b5bd Bug 1930467 - Channel classification should not be performed on foreign channels that are same site to the top level - r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D230420
2024-12-10 13:10:27 +00:00
Harshit Sohaney eecfddb912 Bug 1826418 - Part 2: Added a clause to check for replaced shims scripts when classifying for other event types. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D178853
2023-05-26 08:10:50 +00:00
Tim Huang a39802126c Bug 1818583 - Add a pref to control Email Tracking Protection in private windows. r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D170822
2023-02-28 09:12:13 +00:00
Noemi Erli b47a332c25 Backed out 2 changesets (bug 1818313, bug 1818583) for causing bustage in UrlClassifierFeatureEmailTrackingProtection.cpp CLOSED TREE
Backed out changeset 18e789b52610 (bug 1818313)
Backed out changeset 61ba31a1183a (bug 1818583)
2023-02-24 23:53:11 +02:00
Tim Huang eeb8db4e28 Bug 1818583 - Add a pref to control Email Tracking Protection in private windows. r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D170822
2023-02-24 20:07:48 +00:00
Tim Huang bfb1d45e20 Bug 1773695 - Part 3: Implement email tracking url classifier feature. r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D151050
2022-07-18 21:48:15 +00:00
criss 484b56d791 Backed out 6 changesets (bug 1773691, bug 1773695) for causing Bp-hybrid bustages on UrlClassifierFeatureEmailTrackingProtection
Backed out changeset f402f1bd4caa (bug 1773695)
Backed out changeset 001c38822c53 (bug 1773695)
Backed out changeset 8ef4d3597d92 (bug 1773695)
Backed out changeset f4770b2fe53d (bug 1773695)
Backed out changeset fb625ae08f73 (bug 1773695)
Backed out changeset 6c23adf9184f (bug 1773691)
2022-07-14 23:41:50 +03:00
Tim Huang f528b7afcb Bug 1773695 - Part 3: Implement email tracking url classifier feature. r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D151050
2022-07-14 19:39:32 +00:00