Commit Graph
43 Commits
Author SHA1 Message Date
Tim Huang 21a72ace6c Bug 2038663 - Part 1: Introduce ClassifierChannelUtils and move relevant APIs. r=bvandersloot
This patch moves relevant APIs that interact with the channel to a
separate ClassifierChannelUtils class from the URLClassifierCommon.

The ClassifierChannelUtils shares between the UrlClassifier and
the ContentClassifier.

Differential Revision: https://phabricator.services.mozilla.com/D301027
2026-05-22 07:57:54 +00:00
Sylvestre Ledru a22215a2f9 Bug 2023419 - Remove Emacs/Vim modelines from netwerk/ r=emilio,cookie-reviewers,valentin
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287861
2026-03-17 12:06:31 +00:00
Paul Zuehlcke 23f053a50d Bug 1683165 - Add a pref to control anti-tracking webcompat features. r=timhuang,twisniewski,webcompat-reviewers,dimi
Differential Revision: https://phabricator.services.mozilla.com/D123614
2021-08-26 15:13:10 +00:00
Simon Giesecke 46908cfb51 Bug 1660470 - Add missing include directives/forward declarations. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Dimi Lee be2f616d08 Bug 1652927 - Refine URL Classifier logging r=baku
This patch does the following:
1. Introduce a new log module "nsChannelClassifierLeak" for less
   important debug message
2. Sync the format of debug message - "ClassName::FunctionName - description [this]"
3. Print uri and top-level uri in the entry point of
   AsyncChannelClassifier, remove logging uri in some functions

Differential Revision: https://phabricator.services.mozilla.com/D83610
2020-07-20 10:09:37 +00:00
Butkovits Atila 5ead4ef319 Backed out changeset 2c0c87130a49 (bug 1652927) for bustage at nsChannelClassifier.cpp. CLOSED TREE 2020-07-20 12:48:06 +03:00
Dimi Lee a536a15457 Bug 1652927 - Refine URL Classifier logging r=baku
This patch does the following:
1. Introduce a new log module "nsChannelClassifierLeak" for less
   important debug message
2. Sync the format of debug message - "ClassName::FunctionName - description [this]"
3. Print uri and top-level uri in the entry point of
   AsyncChannelClassifier, remove logging uri in some functions

Differential Revision: https://phabricator.services.mozilla.com/D83610
2020-07-17 18:45:52 +00:00
Simon Giesecke c7bc939952 Bug 1652960 - Remove unnecessary includes from Document.h. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D83634
2020-07-15 15:48:53 +00:00
Dimi Lee 92eb1b5c05 Bug 1437626 - P5. Only call ShouldEnableClassifier for protection features. r=baku
ShouldEnableClassifier checks two things:
1. If AddOn can load the channel
2. If the classified channel is top-level.

For the first point, we added the check in Bug 1308640, and I think the
idea is only for tracking protection to not block channels when
extensions have permission on the channels' domain.
For annotation features, we should always annotate a channel regardless of whether
it is controlled by extensions (also for ETP).

And since we use first-party classification flag in channels, so we
should also annotate channel no matter it is top-level, first-party or
third-party.

So this patch removes calling ShouldEnableClassifier in annotation
features and also rename ShouldEnableClassifier to
ShouldEnableProtectionForChannel to make the idea more clear.

Differential Revision: https://phabricator.services.mozilla.com/D82504
2020-07-08 12:26:53 +00:00
Andrea Marchesini 50a6d0f5ed Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D82497
2020-07-07 16:17:11 +00:00
Simon Giesecke a69d79b6db Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Ehsan Akhgari ad14267240 Bug 1620322 - Part 8: Rename AntiTrackingCommon to ContentBlocking; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D65821
2020-03-09 23:36:39 +00:00
Narcis Beleuzu 422807b8e0 Backed out 8 changesets (bug 1620322) for bustages on nsContentSink.cpp . CLOSED TREE
Backed out changeset f41739c64dff (bug 1620322)
Backed out changeset be942a7f329e (bug 1620322)
Backed out changeset a916987c7c71 (bug 1620322)
Backed out changeset ead3484ffb5f (bug 1620322)
Backed out changeset 4e1e8b9afa1a (bug 1620322)
Backed out changeset 473bba698e5a (bug 1620322)
Backed out changeset 0e5e5d41597d (bug 1620322)
Backed out changeset 31b24d79db3d (bug 1620322)
2020-03-09 22:18:36 +02:00
Ehsan Akhgari d7d656e700 Bug 1620322 - Part 8: Rename AntiTrackingCommon to ContentBlocking; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D65821
2020-03-09 18:12:40 +00:00
Noemi Erli f3729f347c Backed out 8 changesets (bug 1620322) for causing bustages in ContentBlockingLog.cpp CLOSED TREE
Backed out changeset 3dcf513e36cb (bug 1620322)
Backed out changeset 46714855ce1d (bug 1620322)
Backed out changeset 0eb2b5f7322f (bug 1620322)
Backed out changeset 72d640fa0740 (bug 1620322)
Backed out changeset 4533bb4e5177 (bug 1620322)
Backed out changeset 659270edd419 (bug 1620322)
Backed out changeset 6802c18b1914 (bug 1620322)
Backed out changeset 60ff34db9f15 (bug 1620322)
2020-03-09 19:19:41 +02:00
Ehsan Akhgari eaebe39024 Bug 1620322 - Part 8: Rename AntiTrackingCommon to ContentBlocking; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D65821
2020-03-09 10:23:07 +00:00
Ehsan Akhgari 4f80b43251 Bug 1589476 - Emit a separate notification when a tracker from the Level 2 Disconnect blocklist is observed on a page and use this code to avoid using the URL classifer service in the front-end; r=nhnt11,droeh
Differential Revision: https://phabricator.services.mozilla.com/D49660
2019-11-18 20:56:36 +00:00
Jean-Yves Avenard ddeb965a06 Bug 1588899 - P1. Move classification flags related method to nsIClassifiedChannel. r=Ehsan,baku
This is where it should have been in the first place. Those attributes belong there.

Differential Revision: https://phabricator.services.mozilla.com/D49577
2019-10-19 04:30:24 +00:00
DimiL c33830dad9 Bug 1580416 - P1. Use a different fragment method when the URI is a pairwiseWhitelistedURI. r=Ehsan
This patch does the following to support matching a whitelisted URI when
its domain is eTLD+1:

1. add an URIType to indicate whether a URI is generated by
   UrlClassifierCommoon::CreatePairwiseWhiteListURI(), which crafts a
   whitelist URL like "toplevel.page/?resource=third.party.domain"

2. call LookupCache::GetLookupWhitelistFragments() if URIType is
   nsIUrlClassifierFeature::pairwiseWhitelistedURI before initiating
   a lookup.

3. implement LookupCache::GetLookupWhitelistFragments() which creates
   an additional fragment by removing the leading component of
   third.party.domain

Differential Revision: https://phabricator.services.mozilla.com/D47212
2019-09-27 13:22:18 +00:00
Ehsan Akhgari a7582e4689 Bug 1571893 - Remove the prefs that can cause Gecko to stop honouring the Content Blocking allow list; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D40895
2019-08-07 15:54:54 +00:00
Nicholas Nethercote c4aacd8403 Bug 1563139 - Remove StaticPrefs.h. r=glandium
This requires replacing inclusions of it with inclusions of more specific prefs
files.

The exception is that StaticPrefsAll.h, which is equivalent to StaticPrefs.h,
and is used in `Codegen.py` because doing something smarter is tricky and
suitable for a follow-up. As a result, any change to StaticPrefList.yaml will
still trigger recompilation of all the generated DOM bindings files, but that's
still a big improvement over trigger recompilation of every file that uses
static prefs.

Most of the changes in this commit are very boring. The only changes that are
not boring are modules/libpref/*, Codegen.py, and ServoBindings.toml.

Differential Revision: https://phabricator.services.mozilla.com/D39138
2019-07-26 01:10:23 +00:00
dlee 52172cb855 Bug 1545033 - P3. SetTrackingInfo in UrlClassifierFeatureTrackingAnnotation. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D28791
2019-04-26 13:04:41 +00:00
dlee 0c2f748408 Bug 1545033 - P1. Pass matched hash values to ProcessChannel. r=baku
In origin telemetry, we want to record the matching statistic of each entry
in our tracking tables. To identify which entry a given URL matches, it needs
the hash value that matches the safe browsing database.

This patch passes the hash value to ProcessChannel so Features can obtain the
information and pass it.

Note that it is possible that an URL may find multiple matches. If an URL matches
hash A of list 1 and hash B of list 2, the parameter in ProcessChannel looks like:
aList = [list 1, list2]
aHashes = [hash A, hash B]

Differential Revision: https://phabricator.services.mozilla.com/D28789
2019-04-26 13:02:35 +00:00
Andrea Marchesini 274f921416 Bug 1539637 - Make cryptomining and fingerprinting annotations use the "strict" list always, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D25266
2019-04-04 05:31:44 +00:00
Andrea Marchesini d0e1f9a95c Bug 1536488 - Tracking-annotation should use strict list always, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D24053
2019-03-27 13:51:27 +00:00
Andrea Marchesini 88a2b94f06 Bug 1533312 - Expose tracking annotation categories, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D22475
2019-03-15 18:38:27 +00:00
Andrea Marchesini 8aefcca1ab Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 2 - Fingerprinting-annotation, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D22342
2019-03-14 17:48:20 +00:00
Andrea Marchesini 9244a75f08 Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 1 - Classification flags in nsIHttpChannel, r=valentin,dimi
Differential Revision: https://phabricator.services.mozilla.com/D22341
2019-03-14 17:47:59 +00:00
Dorel Luca 16206f7e66 Backed out 5 changesets (bug 1533074) for eslint failure
Backed out changeset 36c6a7178a5c (bug 1533074)
Backed out changeset 7e6a8fadff5b (bug 1533074)
Backed out changeset 2a0494fed543 (bug 1533074)
Backed out changeset 38470d2dd98c (bug 1533074)
Backed out changeset af4e03d1f5c8 (bug 1533074)
2019-03-14 09:14:15 +02:00
Andrea Marchesini 61d38ac414 Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 2 - Fingerprinting-annotation, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D22342
2019-03-14 06:32:33 +00:00
Andrea Marchesini bb69a9567a Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 1 - Classification flags in nsIHttpChannel, r=valentin,dimi
Differential Revision: https://phabricator.services.mozilla.com/D22341
2019-03-14 06:31:17 +00:00
Ryan Hunt 6e1157c288 Bug 1523969 part 19 - Move method definition inline comments to new line in 'netwerk/'. r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D21120
2019-02-25 16:11:11 -06:00
Ehsan Akhgari 06cae1f084 Bug 1525458 - Part 1: Only emit the loaded events for various content blocking categories in the presence of an allow-list entry for the top-level document when content would have been blocked otherwise; r=baku,dimi
Previously the code here used to emit the loaded events for every
resource examined by the URL Classifier Features (in other words, every
third party resource).  But we only need to emit the events in cases
where without the presence of the allow-list we would have blocked the
content.

Differential Revision: https://phabricator.services.mozilla.com/D20874
2019-02-28 17:10:16 -05:00
Andrea Marchesini 01f7228886 Bug 1522210 - Fingerprinting and cryptomining classifiers must have separate nsIWebProgressListener blocking state codes - part 4 - abstract blocking state codes, r=ehsan
Differential Revision: https://phabricator.services.mozilla.com/D17639
2019-01-28 16:43:15 +01:00
Andrea Marchesini 15f4f03de9 Bug 1513298 - Fingerprinting url-classifier feature, r=dimi 2019-01-09 12:16:04 +01:00
Noemi Erli 710e43c415 Backed out changeset 76f3be6b25e1 (bug 1513298) for ES lint failure in test_fingerprinting.html CLOSED TREE 2019-01-09 12:15:44 +02:00
Andrea Marchesini 47607ea561 Bug 1513298 - Fingerprinting url-classifier feature, r=dimi 2019-01-08 23:05:41 +01:00
Andrea Marchesini a45e910940 Bug 1517308 - Add a search field in about:url-classifier - part 1 - nsIUrlClassifier.getFeatureNames(), r=dimi 2019-01-08 23:05:40 +01:00
Andrea Marchesini 5da42219b0 Bug 1514697 - Lazy loading for URL-Classifier features, r=dimi 2019-01-05 09:11:06 +01:00
Andrea Marchesini d5625220f1 Bug 1515286 - Introduce nsIURIClassifier.getFeatureByName() and nsIURIClassifier.createFeatureWithTables(), r=dimi 2019-01-05 09:10:45 +01:00
Andrea Marchesini 1eb4df4dfe Bug 1514202 - Port flash url-classifier to nsIUrlClassifierFeature - part 1 - Flash feature, r=dimi, r=edgar, r=valentin 2019-01-04 14:45:42 +01:00
Andrea Marchesini d2ac02202c Bug 1511436 - Cleanup URL-Classifier code - part 3 - AsyncUrlChannelClassifier, r=dimi 2018-12-14 12:40:17 +01:00
Andrea Marchesini a5aa66ee92 Bug 1511436 - Cleanup URL-Classifier code - part 1 - nsIUrlClassifierFeature, r=dimi 2018-12-14 12:40:16 +01:00