Commit Graph
71 Commits
Author SHA1 Message Date
Tim Huang 790103b777 Bug 2035515 - Part 1: Change the ContentClassifierService::CancelChannel() to use ChannelClassifierUtils::MaybeBlockChannel(). r=bvandersloot
Differential Revision: https://phabricator.services.mozilla.com/D301723
2026-05-22 15:53:08 +00:00
Tim Huang f532bb49ed Bug 2038663 - Part 2: Move a common logic of handling channel cancellation into ClassifierChannelUtils. r=bvandersloot
This patch moves a common logic for blocking URLClassifier features into
the ClassifierChannelUtils.

Differential Revision: https://phabricator.services.mozilla.com/D301028
2026-05-22 07:57:57 +00:00
Tim Huang 21a72ace6c Bug 2038663 - Part 1: Introduce ClassifierChannelUtils and move relevant APIs. r=bvandersloot
This patch moves relevant APIs that interact with the channel to a
separate ClassifierChannelUtils class from the URLClassifierCommon.

The ClassifierChannelUtils shares between the UrlClassifier and
the ContentClassifier.

Differential Revision: https://phabricator.services.mozilla.com/D301027
2026-05-22 07:57:54 +00:00
Sylvestre Ledru a22215a2f9 Bug 2023419 - Remove Emacs/Vim modelines from netwerk/ r=emilio,cookie-reviewers,valentin
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287861
2026-03-17 12:06:31 +00:00
Manuel Bucher abd0c22f06 Bug 1994682 - Reduce Page Protection: Adjust Tracking-Protection to decide whether it is active upon module r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D276217
2026-03-13 12:48:37 +00:00
Andreea Silaghi a6128b3d4c Revert "Bug 1994682 - Reduce Page Protection: Adjust Tracking-Protection to decide whether it is active upon module r=timhuang"
This reverts commit 64b61baebd.
2026-03-03 09:50:25 +00:00
Manuel Bucher 64b61baebd Bug 1994682 - Reduce Page Protection: Adjust Tracking-Protection to decide whether it is active upon module r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D276217
2026-03-02 11:02:51 +00:00
serge-sans-paille 7662b3abdc Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 19:36:01 +00:00
Cristina Horotan 8a1b1970b7 Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing Gtest failures on AlreadyAddRefed.h
This reverts commit e98adca292.
2025-10-21 16:16:29 +00:00
serge-sans-paille e98adca292 Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 15:05:17 +00:00
Cristina Horotan aab924e90d Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing build bustage at nsBrowserApp.cpp
This reverts commit fd0ffa193c.
2025-10-21 10:44:13 +00:00
serge-sans-paille fd0ffa193c Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 09:44:11 +00:00
Narcis Beleuzu e1e6bbb1c9 Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing bustages on Document.cpp
This reverts commit b23c15e927.
2025-10-21 06:34:58 +00:00
serge-sans-paille b23c15e927 Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 06:01:36 +00:00
William Wen e7cdbaba87 Bug 1950985 - Add tracking protection skip for channels annotated as a consent manager. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D241468
2025-03-25 14:58:20 +00:00
Benjamin VanderSloot 8720bf9ed4 Bug 1930467 - Channel classification should not be performed on foreign channels that are same site to the top level - r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D230420
2024-12-13 12:53:55 +00:00
Stanca Serban 82618833ab Backed out changeset 1ae3ac5ab2be (bug 1930467) for causing mochitests failures in browser_storageAccessThirdPartyChecks_alwaysPartition.js. 2024-12-12 19:46:39 +02:00
Benjamin VanderSloot 00f4a76108 Bug 1930467 - Channel classification should not be performed on foreign channels that are same site to the top level - r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D230420
2024-12-12 15:28:40 +00:00
Norisz Fay 28ea0857e7 Backed out changeset 320415b14dee (bug 1930467) for causing bc failures on browser_doublyNestedTracker.js CLOSED TREE 2024-12-10 19:18:35 +02:00
Benjamin VanderSloot 54dfe6b5bd Bug 1930467 - Channel classification should not be performed on foreign channels that are same site to the top level - r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D230420
2024-12-10 13:10:27 +00:00
Harshit Sohaney eecfddb912 Bug 1826418 - Part 2: Added a clause to check for replaced shims scripts when classifying for other event types. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D178853
2023-05-26 08:10:50 +00:00
Valentin Gosu d61af52f71 Bug 1733356 - Fix non-unified build errors in netwerk/url-classifier/ r=necko-reviewers,kershaw
Depends on D129498

Differential Revision: https://phabricator.services.mozilla.com/D129499
2021-10-27 08:52:25 +00:00
Paul Zuehlcke 23f053a50d Bug 1683165 - Add a pref to control anti-tracking webcompat features. r=timhuang,twisniewski,webcompat-reviewers,dimi
Differential Revision: https://phabricator.services.mozilla.com/D123614
2021-08-26 15:13:10 +00:00
Paul Zuehlcke 88fb2c09c2 Bug 1661330 - Log STATE_ALLOWED_TRACKING_CONTENT to the ContentBlockingLog if a channel is allowed. r=geckoview-reviewers,dimi,droeh
Differential Revision: https://phabricator.services.mozilla.com/D109716
2021-04-13 16:11:20 +00:00
Simon Giesecke 46908cfb51 Bug 1660470 - Add missing include directives/forward declarations. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Dimi Lee 6746fe3a9e Bug 1669731 - P3. Add Allow API to ChannelClassifierService. r=timhuang,nhnt11
UI needs to distinguish the cases when a channel is shimmed and is
unshimmed.
When a channel is unshimmed, we unblock the channel and simply treat the channel as a
non-tracking channel.
When a channel is shimmed, although the channel is unblocked by
URLCLassifier, we still want to show it in the UI. For this case,
URLClassifier will notify a content blocking event when a channel is
unblocked.

This patch adds a new allow API, so the caller can use unblock() or
allow() depending upon the case it requires.

Differential Revision: https://phabricator.services.mozilla.com/D93271
2020-10-14 09:17:04 +00:00
Dimi Lee 57ebc6279b Bug 1669731 - P1. Rename STATE_UNBLOCKED_UNSAFE_CONTENT to STATE_UNBLOCKED_TRACKING_CONTENT r=timhuang
unsafe content is for Safe Browsing(phishing, malware, etc), we should use tracking content instead.

Differential Revision: https://phabricator.services.mozilla.com/D93269
2020-10-14 09:16:39 +00:00
Simon Giesecke ab6f0a7137 Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D82325
2020-09-23 15:17:15 +00:00
Dimi Lee f0b519ef09 Bug 1662362 - Record STATE_UNBLOCKED_UNSAFE_CONTENT event to content blocking log when unblock API of URL Classifier is called r=nhnt11,timhuang
Differential Revision: https://phabricator.services.mozilla.com/D88957
2020-09-11 17:48:29 +00:00
Dimi Lee be2f616d08 Bug 1652927 - Refine URL Classifier logging r=baku
This patch does the following:
1. Introduce a new log module "nsChannelClassifierLeak" for less
   important debug message
2. Sync the format of debug message - "ClassName::FunctionName - description [this]"
3. Print uri and top-level uri in the entry point of
   AsyncChannelClassifier, remove logging uri in some functions

Differential Revision: https://phabricator.services.mozilla.com/D83610
2020-07-20 10:09:37 +00:00
Butkovits Atila 5ead4ef319 Backed out changeset 2c0c87130a49 (bug 1652927) for bustage at nsChannelClassifier.cpp. CLOSED TREE 2020-07-20 12:48:06 +03:00
Dimi Lee a536a15457 Bug 1652927 - Refine URL Classifier logging r=baku
This patch does the following:
1. Introduce a new log module "nsChannelClassifierLeak" for less
   important debug message
2. Sync the format of debug message - "ClassName::FunctionName - description [this]"
3. Print uri and top-level uri in the entry point of
   AsyncChannelClassifier, remove logging uri in some functions

Differential Revision: https://phabricator.services.mozilla.com/D83610
2020-07-17 18:45:52 +00:00
Dimi Lee 5ceef5f8c3 Bug 1447935 - P2. Use fission-compatible third-party checks r=baku
Differential Revision: https://phabricator.services.mozilla.com/D80187
2020-07-09 20:10:18 +00:00
Razvan Maries 4bac4a4a49 Backed out 2 changesets (bug 1447935) for perma failures on test_headless.js. CLOSED TREE
Backed out changeset 0332d1b01f63 (bug 1447935)
Backed out changeset bcf6ab4e4f50 (bug 1447935)
2020-07-09 15:53:12 +03:00
Dimi Lee 11c982856f Bug 1447935 - P2. Use fission-compatible third-party checks r=baku
Differential Revision: https://phabricator.services.mozilla.com/D80187
2020-07-09 11:32:45 +00:00
Dimi Lee 92eb1b5c05 Bug 1437626 - P5. Only call ShouldEnableClassifier for protection features. r=baku
ShouldEnableClassifier checks two things:
1. If AddOn can load the channel
2. If the classified channel is top-level.

For the first point, we added the check in Bug 1308640, and I think the
idea is only for tracking protection to not block channels when
extensions have permission on the channels' domain.
For annotation features, we should always annotate a channel regardless of whether
it is controlled by extensions (also for ETP).

And since we use first-party classification flag in channels, so we
should also annotate channel no matter it is top-level, first-party or
third-party.

So this patch removes calling ShouldEnableClassifier in annotation
features and also rename ShouldEnableClassifier to
ShouldEnableProtectionForChannel to make the idea more clear.

Differential Revision: https://phabricator.services.mozilla.com/D82504
2020-07-08 12:26:53 +00:00
Dimi Lee a7bb46bf30 Bug 1437626 - P3. Use global tracking Protection pref when a channel doesn't have a loadcontext r=baku
Channels loaded by service worker don't have loadcontext, so we don't
apply tracking protection on them.

Depends on D80183

Differential Revision: https://phabricator.services.mozilla.com/D80184
2020-07-08 12:12:09 +00:00
Andrea Marchesini 50a6d0f5ed Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D82497
2020-07-07 16:17:11 +00:00
Noemi Erli 3abcd21207 Backed out 4 changesets (bug 1437626) for causing ES lint failure CLOSED TREE
Backed out changeset c9a432ac1964 (bug 1437626)
Backed out changeset 905916b5ee1a (bug 1437626)
Backed out changeset c692ce0d363a (bug 1437626)
Backed out changeset fcd023c403bc (bug 1437626)
2020-07-02 11:05:40 +03:00
Dimi Lee 5dcc6b03af Bug 1437626 - P3. Use global tracking Protection pref when a channel doesn't have a loadcontext r=baku
Channels loaded by service worker don't have loadcontext, so we don't
apply tracking protection on them.

Depends on D80183

Differential Revision: https://phabricator.services.mozilla.com/D80184
2020-07-02 07:20:52 +00:00
Simon Giesecke a69d79b6db Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Dimi Lee 55c6bbb861 Bug 1639718 - P2. Protection features call OnBeforeBlockChannel before blocking the channel. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D76837
2020-05-28 09:51:23 +00:00
Ehsan Akhgari ad14267240 Bug 1620322 - Part 8: Rename AntiTrackingCommon to ContentBlocking; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D65821
2020-03-09 23:36:39 +00:00
Narcis Beleuzu 422807b8e0 Backed out 8 changesets (bug 1620322) for bustages on nsContentSink.cpp . CLOSED TREE
Backed out changeset f41739c64dff (bug 1620322)
Backed out changeset be942a7f329e (bug 1620322)
Backed out changeset a916987c7c71 (bug 1620322)
Backed out changeset ead3484ffb5f (bug 1620322)
Backed out changeset 4e1e8b9afa1a (bug 1620322)
Backed out changeset 473bba698e5a (bug 1620322)
Backed out changeset 0e5e5d41597d (bug 1620322)
Backed out changeset 31b24d79db3d (bug 1620322)
2020-03-09 22:18:36 +02:00
Ehsan Akhgari d7d656e700 Bug 1620322 - Part 8: Rename AntiTrackingCommon to ContentBlocking; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D65821
2020-03-09 18:12:40 +00:00
Noemi Erli f3729f347c Backed out 8 changesets (bug 1620322) for causing bustages in ContentBlockingLog.cpp CLOSED TREE
Backed out changeset 3dcf513e36cb (bug 1620322)
Backed out changeset 46714855ce1d (bug 1620322)
Backed out changeset 0eb2b5f7322f (bug 1620322)
Backed out changeset 72d640fa0740 (bug 1620322)
Backed out changeset 4533bb4e5177 (bug 1620322)
Backed out changeset 659270edd419 (bug 1620322)
Backed out changeset 6802c18b1914 (bug 1620322)
Backed out changeset 60ff34db9f15 (bug 1620322)
2020-03-09 19:19:41 +02:00
Ehsan Akhgari eaebe39024 Bug 1620322 - Part 8: Rename AntiTrackingCommon to ContentBlocking; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D65821
2020-03-09 10:23:07 +00:00
Honza Bambas d6f315220b Bug 1584183 - Set nsILoadInfo.requestBlockingReason in UrlClassifierCommon::SetBlockedContent, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D47243
2019-09-27 07:50:17 +00:00
DimiL c33830dad9 Bug 1580416 - P1. Use a different fragment method when the URI is a pairwiseWhitelistedURI. r=Ehsan
This patch does the following to support matching a whitelisted URI when
its domain is eTLD+1:

1. add an URIType to indicate whether a URI is generated by
   UrlClassifierCommoon::CreatePairwiseWhiteListURI(), which crafts a
   whitelist URL like "toplevel.page/?resource=third.party.domain"

2. call LookupCache::GetLookupWhitelistFragments() if URIType is
   nsIUrlClassifierFeature::pairwiseWhitelistedURI before initiating
   a lookup.

3. implement LookupCache::GetLookupWhitelistFragments() which creates
   an additional fragment by removing the leading component of
   third.party.domain

Differential Revision: https://phabricator.services.mozilla.com/D47212
2019-09-27 13:22:18 +00:00
Ehsan Akhgari a7582e4689 Bug 1571893 - Remove the prefs that can cause Gecko to stop honouring the Content Blocking allow list; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D40895
2019-08-07 15:54:54 +00:00