agoloman
c75e2e420f
Revert "Bug 2020707, Bug 2020704 - Part 6: Update test expectations now that speculationrules scripts are supported. r=dom-core-reviewers,jjaschke" for causing bc failures @browser_misused_characters_in_strings.js.
...
This reverts commit 524a1fc191 .
Revert "Bug 2020707 - Part 5: Gate speculation rules script support behind a pref. r=dom-core-reviewers,jjaschke"
This reverts commit 11741d18ad .
Revert "Bug 2020707 - Part 4: Unregister speculation rules when their script element is removed. r=dom-core-reviewers,hsivonen"
This reverts commit 5202943dc9 .
Revert "Bug 2020707 - Part 3: Report an exception if speculation rules parsing fails. r=dom-core-reviewers,jjaschke"
This reverts commit 70c5aa5425 .
Revert "Bug 2020707 - Part 2: Add support for speculationrules script type. r=dom-core-reviewers,jjaschke"
This reverts commit 65b30a350b .
Revert "Bug 2020707 - Part 1: Allow speculation rules to be registered to the document from scripts. r=hsivonen,jjaschke"
This reverts commit 28c7050de9 .
Revert "Bug 2020704 - Part 2: Add parser for speculation rule sets. r=hsivonen,jjaschke"
This reverts commit eabb8c6eb3 .
Revert "Bug 2020704 - Part 1: Add speculation rules crate. r=dom-core-reviewers,jjaschke"
This reverts commit cd65bed005 .
2026-06-12 06:28:05 +00:00
Adam Vandolder
65b30a350b
Bug 2020707 - Part 2: Add support for speculationrules script type. r=dom-core-reviewers,jjaschke
...
Differential Revision: https://phabricator.services.mozilla.com/D286178
2026-06-12 04:48:27 +00:00
serge-sans-paille
53e5242f30
Bug 2041298 - Comply with clang-tidy's modernize-use-nullptr check for parser/ r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D301771
2026-06-10 07:08:36 +00:00
Daniel Holbert
cb1c37d98e
Bug 2044510: Pass already_AddRefed types by-value instead of by rvalue reference, in parser/. r=dom-core-reviewers,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D304375
2026-06-05 21:06:55 +00:00
Emilio Cobos Álvarez
cc359d1aa9
Bug 2044618 - Remove SheetParsingMode. r=layout-reviewers,dholbert
...
It's a 1:1 mapping for the origin that we cache in the
StyleSheetContents, so use that.
PreloadHashKey only cares about author loads, within a document, so
doesn't really need to deal with user / user-agent ones.
Differential Revision: https://phabricator.services.mozilla.com/D304400
2026-06-05 01:03:23 +00:00
Henri Sivonen
0124daca51
Bug 2038124 addendum - Simplify the attribute holder in the HTML parser. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D302278
2026-06-02 09:12:41 +00:00
Henri Sivonen
d13776d321
Bug 2038124 - Optimize setting attributes on non-custom HTML elements from parser. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D302276
2026-06-02 09:12:39 +00:00
Henri Sivonen
ea04eba8aa
Bug 2041856. r=smaug,edgar
...
Differential Revision: https://phabricator.services.mozilla.com/D303280
2026-06-02 08:51:28 +00:00
Alexandru Marc
16e384440d
Revert "Bug 2038124 addendum - Simplify the attribute holder in the HTML parser. r=smaug" for causing build bustages @ Element.cpp
...
This reverts commit 82b2e13b45 .
Revert "Bug 2038124 - Optimize setting attributes on non-custom HTML elements from parser. r=smaug"
This reverts commit 2d1ee1cd69 .
2026-06-02 07:41:40 +00:00
Henri Sivonen
82b2e13b45
Bug 2038124 addendum - Simplify the attribute holder in the HTML parser. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D302278
2026-06-02 07:07:28 +00:00
Henri Sivonen
2d1ee1cd69
Bug 2038124 - Optimize setting attributes on non-custom HTML elements from parser. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D302276
2026-06-02 07:07:26 +00:00
Atila Butkovits
d68e85e91d
Revert "Bug 2038124 addendum - Simplify the attribute holder in the HTML parser. r=smaug" for causing bustages at Element.cpp.
...
This reverts commit 9dd3f6b595 .
Revert "Bug 2038124 - Optimize setting attributes on non-custom HTML elements from parser. r=smaug"
This reverts commit b1774ce65e .
2026-06-01 21:47:14 +00:00
Henri Sivonen
9dd3f6b595
Bug 2038124 addendum - Simplify the attribute holder in the HTML parser. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D302278
2026-06-01 20:50:19 +00:00
Henri Sivonen
b1774ce65e
Bug 2038124 - Optimize setting attributes on non-custom HTML elements from parser. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D302276
2026-06-01 20:50:16 +00:00
Henri Sivonen
9ec57df41d
Bug 2038800 - Check that the parser does not insert a node into its own descendant. r=dom-core,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D302716
2026-05-27 15:42:59 +00:00
Henri Sivonen
9986518e26
Bug 2037935 - Special-case the most common element and attribute names in Speedometer3 innerHTML/DOMParser parsing. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D302275
2026-05-27 06:30:15 +00:00
Keith Cirkel
95d7a5a7b1
Bug 2028401 - Part 4 - Resync htmlparser to b09277d r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D299704
2026-05-22 19:34:29 +00:00
Keith Cirkel
6480e61671
Bug 2019979 - Clean up dom.lift_select_parser_restrictions.enabled r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D299703
2026-05-22 19:34:26 +00:00
rperta
e9d08d36dd
Revert "Bug 2028401, Bug 2019979 - Part 4 - Resync htmlparser to b09277d r=hsivonen" for causing wpt failures at html5lib_innerHTML_tests_innerHTML_1.html
...
This reverts commit 9c3f1a9500 .
Revert "Bug 2019979 - Clean up dom.lift_select_parser_restrictions.enabled r=hsivonen"
This reverts commit 05ce1fb123 .
2026-05-22 16:40:04 +00:00
Keith Cirkel
9c3f1a9500
Bug 2028401 - Part 4 - Resync htmlparser to b09277d r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D299704
2026-05-22 14:52:33 +00:00
Keith Cirkel
05ce1fb123
Bug 2019979 - Clean up dom.lift_select_parser_restrictions.enabled r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D299703
2026-05-22 14:52:30 +00:00
Alexandru Marc
eef30b2ead
Revert (Bug 2028401, Bug 2019979) for causing mochitest failures @ test_bug922681
...
This reverts commit 9cfeccd372 .
Revert "Bug 2019979 - Clean up dom.lift_select_parser_restrictions.enabled r=hsivonen"
This reverts commit 7c2ee56e70 .
2026-05-21 21:26:19 +00:00
Keith Cirkel
9cfeccd372
Bug 2028401 - Part 4 - Resync htmlparser to bd7f0f7 r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D299704
2026-05-21 20:15:23 +00:00
Keith Cirkel
7c2ee56e70
Bug 2019979 - Clean up dom.lift_select_parser_restrictions.enabled r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D299703
2026-05-21 20:15:20 +00:00
Alexandru Marc
a74cb95f65
Revert (Bug 2028401, Bug 2019979) for causing mochitest failures @ test_html5_tree_construction_part2
...
This reverts commit 8cea467d1c .
Revert "Bug 2019979 - Clean up dom.lift_select_parser_restrictions.enabled r=hsivonen"
This reverts commit 03d82311a4 .
2026-05-21 18:23:44 +00:00
Keith Cirkel
8cea467d1c
Bug 2028401 - Part 4 - Resync htmlparser to bd7f0f7 r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D299704
2026-05-21 16:56:17 +00:00
Keith Cirkel
03d82311a4
Bug 2019979 - Clean up dom.lift_select_parser_restrictions.enabled r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D299703
2026-05-21 16:56:14 +00:00
Jan-Niklas Jaeschke
10781ef5fa
Bug 1974276 - Customizable Select: Implement stub for the selectedcontent element. r=keithamus,emilio,dom-core,webidl,hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D290553
2026-05-11 12:31:16 +00:00
Keith Cirkel
2e02b372fb
Bug 2028401 - Part 3 - Add optionElementPopped code from upstream r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D298819
2026-05-08 15:23:10 +00:00
Keith Cirkel
d4aa3e5004
Bug 2028401 - Part 2 - Resync htmlparser to 69af110 r=hsivonen
...
This sync htmlparser to the contents of its 69af110 commit (just before
changes to select parsing).
Differential Revision: https://phabricator.services.mozilla.com/D298818
2026-05-08 15:23:05 +00:00
Keith Cirkel
2ac86b61e1
Bug 2028401 - Part 1 - Remove errenous merge conflict characters from code r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D298817
2026-05-08 15:23:01 +00:00
agoloman
8c53ba442e
Revert "Bug 2028401 - Part 3 - Add optionElementPopped code from upstream r=hsivonen" for causing build bustages @nsHtml5TreeBuilder.cpp.
...
This reverts commit 852a19fbda .
Revert "Bug 2028401 - Part 2 - Resync htmlparser to 69af110 r=hsivonen"
This reverts commit e52d12eb8c .
Revert "Bug 2028401 - Part 1 - Remove errenous merge conflict characters from code r=hsivonen"
This reverts commit 403fdc1292 .
2026-05-08 12:37:17 +00:00
Keith Cirkel
852a19fbda
Bug 2028401 - Part 3 - Add optionElementPopped code from upstream r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D298819
2026-05-08 12:21:25 +00:00
Keith Cirkel
e52d12eb8c
Bug 2028401 - Part 2 - Resync htmlparser to 69af110 r=hsivonen
...
This sync htmlparser to the contents of its 69af110 commit (just before
changes to select parsing).
Differential Revision: https://phabricator.services.mozilla.com/D298818
2026-05-08 12:21:21 +00:00
Keith Cirkel
403fdc1292
Bug 2028401 - Part 1 - Remove errenous merge conflict characters from code r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D298817
2026-05-08 12:21:17 +00:00
Daniel Holbert
10725540f6
Bug 2037754: Use 'MakeAndAddRef' instead of 'new' when allocating runnable for nsContentUtils::AddScriptRunner. r=dom-core,smaug
...
MakeAndAddRef ensures that the freshly-allocated object immediately gets a
refcount of 1 (before it's even passed to AddScriptRunner). This avoids
several potential footguns that otherwise exist with a zero-refcount
freshly-allocated object.
It also makes the ownership-transfer semantics more clear
(via the already_AddRefed type that it produces) - AddScriptRunner is taking
ownership of the object, rather than using it temporarily while the caller
maintains ownership.
Differential Revision: https://phabricator.services.mozilla.com/D299039
2026-05-07 06:35:57 +00:00
serge-sans-paille
f61ddf531d
Bug 2034832 - Make parser/ headers compatible with current static analysis r=hsivonen
...
- use = default when relevant
- use = delete on public method instead of unimplemented private
- use range-based loop
This matches the clang-tidy rules:
- https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html
- https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-delete.html
- https://clang.llvm.org/extra/clang-tidy/checks/modernize/loop-convert.html
Also had to do minor header tweaking to cope with std::size_t with
size_t in the process.
That we already use on source files
Differential Revision: https://phabricator.services.mozilla.com/D296635
2026-04-29 10:40:25 +00:00
Keith Cirkel
edf2167941
Bug 2023824 - Implement shadowrootslotassignment r=webidl,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D288343
2026-04-11 09:14:11 +00:00
Edgar Chen
e896afd4b8
Bug 2029071 - Handle foster parenting properly; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D293070
2026-04-10 17:47:13 +00:00
serge-sans-paille
d58c18b09a
Bug 2030235 - Decouple ServoStyleConsts from nsGkAtoms.h r=emilio,necko-reviewers,geckoview-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,kershaw,m_kato
...
And remove unused includes of nsGkAtoms.h in the process. The few
dependencies have been moved to ServoStyleConstsInlines.h
The used command to remove the now unused dependency was:
git grep -l nsGkAtoms.h | while read line; do grep -v nsGkAtoms.h $line | grep -q -E '\<nsGkAtoms\>' || sed -i -e '/nsGkAtoms.h/d' $line ; done
Differential Revision: https://phabricator.services.mozilla.com/D292697
2026-04-09 10:05:25 +00:00
Silaghi
81930b22ee
Revert "Bug 2030235 - Decouple ServoStyleConsts from nsGkAtoms.h r=emilio,necko-reviewers,geckoview-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,kershaw,m_kato" for causing build bustages at style/nsStyleUtil
...
This reverts commit b97e69b590 .
2026-04-09 08:09:15 +00:00
serge-sans-paille
b97e69b590
Bug 2030235 - Decouple ServoStyleConsts from nsGkAtoms.h r=emilio,necko-reviewers,geckoview-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,kershaw,m_kato
...
And remove unused includes of nsGkAtoms.h in the process. The few
dependencies have been moved to ServoStyleConstsInlines.h
The used command to remove the now unused dependency was:
git grep -l nsGkAtoms.h | while read line; do grep -v nsGkAtoms.h $line | grep -q -E '\<nsGkAtoms\>' || sed -i -e '/nsGkAtoms.h/d' $line ; done
Differential Revision: https://phabricator.services.mozilla.com/D292697
2026-04-09 06:41:33 +00:00
Henri Sivonen
5e2f9d0c14
Bug 2028289. r=avandolder
...
Differential Revision: https://phabricator.services.mozilla.com/D291479
2026-04-08 02:33:56 +00:00
Keith Cirkel
3fee12d5fe
Bug 2027425 - Set frameset for select fragments with noInSelectMode r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D290873
2026-04-07 08:43:10 +00:00
Henri Sivonen
5f33bf94d0
Bug 1362365 - Stop autodetecting ISO-2022-JP. r=supply-chain-reviewers,emk
...
Differential Revision: https://phabricator.services.mozilla.com/D290980
2026-04-02 05:05:03 +00:00
serge-sans-paille
b931b9dec7
Bug 2027664 - Mark nsTArray::ClearAndRetainStorage() with [[clang::reinitializes]] as MOZ_REINITIALIZES r=emilio,necko-reviewers,janerik
...
Quoting https://clang.llvm.org/docs/AttributeReference.html#reinitializes :
The reinitializes attribute can be applied to a non-static, non-const
C++ member function to indicate that this member function reinitializes
the entire object to a known state, independent of the previous state of
the object.
Which is exactly what we need for clang-tidy's bugprone-use-after-move analysis
Differential Revision: https://phabricator.services.mozilla.com/D290811
2026-03-30 11:30:47 +00:00
Emilio Cobos Álvarez
5016086e1a
Bug 2025089 - Remove some includes from nsINode.h and Element.h. r=dom-core,dom-storage-reviewers,firefox-svg-reviewers,janv,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D289049
2026-03-22 23:45:55 +00:00
serge-sans-paille
f81328e365
Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio
...
The changeset has been generated automatically through:
./mach static-analysis check --output ./clang-tidy-bugprone.json --format json --fix
followed by manual adjustment when needed or when the auto-fixer bailed out.
This paves the way for Bug 2023527
Differential Revision: https://phabricator.services.mozilla.com/D287941
2026-03-22 08:35:47 +00:00
Alexandru Marc
04e5f74151
Revert "Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio"
...
This reverts commit a64dec2665 .
2026-03-19 17:29:58 +00:00
serge-sans-paille
a64dec2665
Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio
...
The changeset has been generated automatically through:
./mach static-analysis check --output ./clang-tidy-bugprone.json --format json --fix
followed by manual adjustment when needed or when the auto-fixer bailed out.
This paves the way for Bug 2023527
Differential Revision: https://phabricator.services.mozilla.com/D287941
2026-03-18 17:25:01 +00:00