Commit Graph
167 Commits
Author SHA1 Message Date
Ryan VanderMeulen 768ac42006 Bug 2024039 - Use XML_SetHashSalt16Bytes for 128-bit libexpat hash salt entropy. r=mccr8,shravanrn
Upstream deprecated XML_SetHashSalt in libexpat 2.8.0 (CVE-2026-41080)
because it only carries 4-8 bytes of entropy into what is a 128-bit
SipHash salt. Switch to XML_SetHashSalt16Bytes, which takes a full
16 bytes, and feed it with GenerateRandomBytesFromOS. Also drop the
now-unused MOZ_XML_SetHashSalt wrapper and update the comments in
03_dont_generate_salt.patch to match.

The wrapper takes const char[16] rather than const uint8_t[16] so the
buffer can be transferred through RLBox's sandbox boundary, which only
permits memcpy of char/short/wchar_t/char16_t/float/double.

Differential Revision: https://phabricator.services.mozilla.com/D296437
2026-04-26 22:46:40 +00:00
Andrew McCreight 780af88752 Bug 2029813 - Add evenness checks for attribute counts. r=hsivonen,shravanrn
Differential Revision: https://phabricator.services.mozilla.com/D294025
2026-04-14 18:14:57 +00:00
Sylvestre Ledru 49209e1b2f Bug 2023419 - Remove Emacs/Vim modelines from parser/ r=emilio
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287864
2026-03-18 14:35:02 +00:00
Alexandru Marc a0233d91a7 Revert "Bug 2023419 - Remove Emacs/Vim modelines from python/ r=emilio" for causing py failures @ test_configure
This reverts commit 4d755fe4de.

Revert "Bug 2023419 - Remove Emacs/Vim modelines from parser/ r=emilio"

This reverts commit e2035c4a10.

Revert "Bug 2023419 - Remove Emacs/Vim modelines from other-licenses/ r=emilio"

This reverts commit 1f7da58772.
2026-03-17 12:43:27 +00:00
Sylvestre Ledru e2035c4a10 Bug 2023419 - Remove Emacs/Vim modelines from parser/ r=emilio
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287864
2026-03-17 12:08:44 +00:00
Andrew McCreight 1d14786041 Bug 2010275 - Pass XML_Status and XML_Error across the RLBox barrier as int. r=hsivonen
For functions where we don't use the return value, return void instead.

Differential Revision: https://phabricator.services.mozilla.com/D279192
2026-01-16 17:24:50 +00:00
Andrew McCreight 54feb2c049 Bug 2010288 - Update the XML parser's error_verifier method. r=hsivonen
Three new enum values have been added since this was last updated.

Also, add the second test case from bug 1192544.

Differential Revision: https://phabricator.services.mozilla.com/D279091
2026-01-15 17:08:07 +00:00
Henri Sivonen 8cfad39176 Bug 2002189 - Remove nsIDTD. r=dom-core,edgar,smaug
Differential Revision: https://phabricator.services.mozilla.com/D273975
2025-11-25 15:49:23 +00:00
Simon Pieters 6afa1531af Bug 1995971 - Add 2 WAPFORUM public ids that enable the XHTML entities (update test expectations). r=dom-core,smaug
Differential Revision: https://phabricator.services.mozilla.com/D271368
2025-11-05 10:04:52 +00:00
Serban Stanca 0834332cfd Revert "Bug 1995971 - Add 2 WAPFORUM public ids that enable the XHTML entities. r=dom-core,smaug" for causing wpt failures in xhtml-mathml-dtd-entity-11.htm.
This reverts commit a9112dba70.
2025-11-04 23:23:00 +00:00
Simon Pieters a9112dba70 Bug 1995971 - Add 2 WAPFORUM public ids that enable the XHTML entities. r=dom-core,smaug
Differential Revision: https://phabricator.services.mozilla.com/D269749
2025-11-04 19:08:26 +00:00
serge-sans-paille 26ad5eb1cb Bug 1996767 - Remove unused mfbt inclusion in parser/** r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D270301
2025-10-28 12:38:01 +00:00
serge-sans-paille 1667ec582b Bug 1995723 - Remove unused inclusion of mozilla/ArrayUtils.h r=necko-reviewers,application-update-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,firefox-svg-reviewers,layout-reviewers,gstoll,canaltinova,bytesized,alwu,dholbert
Differential Revision: https://phabricator.services.mozilla.com/D269573
2025-10-23 07:30:37 +00:00
serge-sans-paille 7662b3abdc Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 19:36:01 +00:00
Cristina Horotan 8a1b1970b7 Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing Gtest failures on AlreadyAddRefed.h
This reverts commit e98adca292.
2025-10-21 16:16:29 +00:00
serge-sans-paille e98adca292 Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 15:05:17 +00:00
Cristina Horotan aab924e90d Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing build bustage at nsBrowserApp.cpp
This reverts commit fd0ffa193c.
2025-10-21 10:44:13 +00:00
serge-sans-paille fd0ffa193c Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 09:44:11 +00:00
Narcis Beleuzu e1e6bbb1c9 Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing bustages on Document.cpp
This reverts commit b23c15e927.
2025-10-21 06:34:58 +00:00
serge-sans-paille b23c15e927 Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 06:01:36 +00:00
serge-sans-paille 43831fc5ea Bug 1990296 - Remove unused mozilla/Array.h inclusion r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D265933
2025-09-25 23:36:51 +00:00
Tom Schuster 761f25981c Bug 1963545 - Replace nsContentUtils::SpoofLocaleEnglish with ShouldResistFingerprinting(RFPTarget::JSLocale). r=fkilic
Differential Revision: https://phabricator.services.mozilla.com/D247246
2025-05-02 14:25:01 +00:00
Shravan Narayan e4a8b56009 Bug 1948620: Part 2 - Use library names for rlbox_wasm2c memory allocations r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D241897
2025-03-21 03:44:43 +00:00
Peter Van der Beken 084494aa3f Bug 1950575 - Change support code for Expat 2.6.4. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D239720
2025-03-07 14:15:31 +00:00
Peter Van der Beken e5aa95ebae Bug 1950575 - Call MOZ_-prefixed Expat APIs. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D239715
2025-03-07 14:15:28 +00:00
Goloman Adrian 2173040a18 Backed out 8 changesets (bug 1950575) for causing hazard build bustages @xmlparse.c. CLOSED TREE
Backed out changeset 25640f99bd79 (bug 1950575)
Backed out changeset d89235faa03b (bug 1950575)
Backed out changeset 15d874fb36d4 (bug 1950575)
Backed out changeset b2c8d52c7796 (bug 1950575)
Backed out changeset c7c54b187d06 (bug 1950575)
Backed out changeset d85df49f8cce (bug 1950575)
Backed out changeset 4d20d3f45aef (bug 1950575)
Backed out changeset 43bb9e7e6b4f (bug 1950575)
2025-03-07 05:16:30 +02:00
Peter Van der Beken 2d3d672738 Bug 1950575 - Change support code for Expat 2.6.4. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D239720
2025-03-06 21:15:14 +00:00
Peter Van der Beken b906d66929 Bug 1950575 - Call MOZ_-prefixed Expat APIs. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D239715
2025-03-06 21:15:12 +00:00
Sandor Molnar 2c8af57a8e Backed out 9 changesets (bug 1950575) for causing Mn unit failures.
Backed out changeset 7f8e427fc6ef (bug 1950575)
Backed out changeset 71c721a61dcf (bug 1950575)
Backed out changeset 0971a520b79e (bug 1950575)
Backed out changeset 293d06b6c5d3 (bug 1950575)
Backed out changeset 06385670e857 (bug 1950575)
Backed out changeset ece179ed0db5 (bug 1950575)
Backed out changeset d1b830c50b02 (bug 1950575)
Backed out changeset 562b71b0a272 (bug 1950575)
Backed out changeset 73231c49f98b (bug 1950575)
2025-03-05 20:51:55 +02:00
Otto Länd 1cb79fac96 Bug 1950575: apply code formatting via Lando
# ignore-this-changeset
2025-03-05 17:04:45 +00:00
Peter Van der Beken 2f7ea2b284 Bug 1950575 - Change support code for Expat 2.6.4. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D239720
2025-03-05 16:28:23 +00:00
Peter Van der Beken e80cae6ec2 Bug 1950575 - Call MOZ_-prefixed Expat APIs. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D239715
2025-03-05 16:28:21 +00:00
Florian Quèze 9609e47f62 Bug 1879329 - script generated replacement of the GleanMetrics.h includes, r=chutten,valentin,media-playback-reviewers,cookie-reviewers,anti-tracking-reviewers,profiler-reviewers,win-reviewers,rkraesig,emz,aabh,padenot.
Differential Revision: https://phabricator.services.mozilla.com/D234744
2025-01-21 11:21:45 +00:00
serge-sans-paille 262f78c07f Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-28 08:21:19 +00:00
Alexandru Marc a5eb905bf4 Backed out changeset d92f391b3b0c (bug 1922838) for backing out bug 1915351 2024-10-25 16:42:33 +03:00
serge-sans-paille 07101ac24d Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-24 09:06:01 +00:00
Alexandru Marc 004e704b22 Backed out changeset 448597bce69d (bug 1922838) for causing build bustages. CLOSED TREE 2024-10-24 11:37:49 +03:00
serge-sans-paille 2c916d4973 Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-24 07:38:30 +00:00
Chris H-C 2e43bfd712 Bug 1920562 - Remove C++ Telemetry::SetEventRecordingEnabled r=florian,necko-reviewers,valentin
We leave the network.trr.confirmation_telemetry_enabled pref intact because
removing it causes failures in test_prefs_tracker.js

Differential Revision: https://phabricator.services.mozilla.com/D223832
2024-10-08 20:14:41 +00:00
Sandor Molnar 92076e16a7 Backed out 5 changesets (bug 1920562) for causing xpc assertion failures. CLOSED TREE
Backed out changeset 8f085ab589a8 (bug 1920562)
Backed out changeset 4405387ae770 (bug 1920562)
Backed out changeset a68fd13a33ae (bug 1920562)
Backed out changeset cd3672fc08ed (bug 1920562)
Backed out changeset 62ab18879eea (bug 1920562)
2024-10-08 00:16:13 +03:00
Chris H-C a1dab7d33b Bug 1920562 - Remove C++ Telemetry::SetEventRecordingEnabled r=florian,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D223832
2024-10-07 17:29:56 +00:00
Chris H-C 01c5657ba6 Bug 1918226 - Use Glean APIs for ysod.shown#ysod r=gregtatum,eemeli
Differential Revision: https://phabricator.services.mozilla.com/D221498
2024-09-20 18:43:08 +00:00
Emilio Cobos Álvarez 77c40caac6 Bug 1910698 - Remove nsIScriptError.sourceLine. r=smaug,devtools-reviewers,webdriver-reviewers,necko-reviewers,nchevobbe,kershaw,jdescottes,credential-management-reviewers,dimi
Afaict the source lines are not exposed anywhere in the UI.

Differential Revision: https://phabricator.services.mozilla.com/D218115
2024-08-01 17:12:48 +00:00
Emilio Cobos Álvarez a44b49af0b Bug 1910698 - Add a struct to represent JS caller location and more general warning source location. r=smaug,necko-reviewers,anti-tracking-reviewers,dom-storage-reviewers,pbz,kershaw,janv
Use it liberally across the tree. This could be cleaned up even more in the future.

Differential Revision: https://phabricator.services.mozilla.com/D218114
2024-08-01 17:12:48 +00:00
Sylvestre Ledru a3ea006705 Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,necko-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,devtools-reviewers,anti-tracking-reviewers,profiler-reviewers,win-reviewers,migration-reviewers,padenot,mconley,nchevobbe,kershaw,gstoll,mstange,bytesized,m_kato
This new version of clang 17 also slightly changed the formatting.

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D215914
2024-07-17 11:15:31 +00:00
Shravan Narayan 5767360484 Bug 1831654 - Graceful failures for out of range column number in expat error handling r=glandium,peterv
Differential Revision: https://phabricator.services.mozilla.com/D177311
2023-06-02 20:45:17 +00:00
Shravan Narayan 57e638ed99 Bug 1824892: Fix tainting use in the nsExpatDriver r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D175433
2023-04-26 20:15:15 +00:00
Shravan Narayan c62a90cbdc Bug 1827704 - Migrate to the upstream wasm2c for RLBox sandboxing r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D175439
2023-04-21 01:31:35 +00:00
Narcis Beleuzu 088eb27bf2 Backed out changeset 4b412f721080 (bug 1824892) for crashes on nsExpatDriver.cpp . CLOSED TREE 2023-04-20 05:12:27 +03:00
Shravan Narayan d1f6b927cf Bug 1824892: Fix tainting use in the nsExpatDriver r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D175433
2023-04-20 01:40:07 +00:00