Tom Schuster
dce5371c0a
Bug 2029840 - Tests. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D292702
2026-06-02 12:12:38 +00:00
Emilio Cobos Álvarez
a83498440f
Bug 2025740 - Pass the right sanitization kind through SanitizeInlineStyle. r=tschuster
...
This only affects the conditional CSS stuff that thunderbird uses. Test
that @keyframes is preserved as intended.
Differential Revision: https://phabricator.services.mozilla.com/D289534
2026-03-26 09:21:38 +00:00
Emilio Cobos Álvarez
02ce0fb9da
Bug 2025740 - Require all nested rules to be acceptable for sanitization. r=firefox-style-system-reviewers,dshin
...
This is not ideal, but should do for now.
Ideally we'd sanitize child rules individually or so, but doing so
breaks how we sanitize and requires doing significant surgery on the
original input, or re-serialize (which is also not wanted,
see bug 1602843).
Differential Revision: https://phabricator.services.mozilla.com/D289533
2026-03-26 09:21:36 +00:00
Silaghi
35bada9b2b
Revert "Bug 2025740 - Pass the right sanitization kind through SanitizeInlineStyle. r=tschuster" for causing reftest and bc failures
...
This reverts commit 8c8d2900b8 .
Revert "Bug 2025740 - Require all nested rules to be acceptable for sanitization. r=firefox-style-system-reviewers,dshin"
This reverts commit 41b16f5d95 .
2026-03-26 03:07:35 +00:00
Emilio Cobos Álvarez
8c8d2900b8
Bug 2025740 - Pass the right sanitization kind through SanitizeInlineStyle. r=tschuster
...
This only affects the conditional CSS stuff that thunderbird uses. Test
that @keyframes is preserved as intended.
Differential Revision: https://phabricator.services.mozilla.com/D289534
2026-03-26 01:35:07 +00:00
Emilio Cobos Álvarez
41b16f5d95
Bug 2025740 - Require all nested rules to be acceptable for sanitization. r=firefox-style-system-reviewers,dshin
...
This is not ideal, but should do for now.
Ideally we'd sanitize child rules individually or so, but doing so
breaks how we sanitize and requires doing significant surgery on the
original input, or re-serialize (which is also not wanted,
see bug 1602843).
Differential Revision: https://phabricator.services.mozilla.com/D289533
2026-03-26 01:35:04 +00:00
Alexandru Marc
fef8de03c8
Revert "Bug 2025740 - Pass the right sanitization kind through SanitizeInlineStyle. r=tschuster" for causing multiple failures
...
This reverts commit ad00cac75e .
Revert "Bug 2025740 - Require all nested rules to be acceptable for sanitization. r=firefox-style-system-reviewers,dshin"
This reverts commit 2e6ba9f86e .
2026-03-25 22:16:49 +00:00
Emilio Cobos Álvarez
ad00cac75e
Bug 2025740 - Pass the right sanitization kind through SanitizeInlineStyle. r=tschuster
...
This only affects the conditional CSS stuff that thunderbird uses. Test
that @keyframes is preserved as intended.
Differential Revision: https://phabricator.services.mozilla.com/D289534
2026-03-25 21:21:47 +00:00
Emilio Cobos Álvarez
2e6ba9f86e
Bug 2025740 - Require all nested rules to be acceptable for sanitization. r=firefox-style-system-reviewers,dshin
...
This is not ideal, but should do for now.
Ideally we'd sanitize child rules individually or so, but doing so
breaks how we sanitize and requires doing significant surgery on the
original input, or re-serialize (which is also not wanted,
see bug 1602843).
Differential Revision: https://phabricator.services.mozilla.com/D289533
2026-03-25 21:21:44 +00:00
Sylvestre Ledru
49209e1b2f
Bug 2023419 - Remove Emacs/Vim modelines from parser/ r=emilio
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287864
2026-03-18 14:35:02 +00:00
Alexandru Marc
a0233d91a7
Revert "Bug 2023419 - Remove Emacs/Vim modelines from python/ r=emilio" for causing py failures @ test_configure
...
This reverts commit 4d755fe4de .
Revert "Bug 2023419 - Remove Emacs/Vim modelines from parser/ r=emilio"
This reverts commit e2035c4a10 .
Revert "Bug 2023419 - Remove Emacs/Vim modelines from other-licenses/ r=emilio"
This reverts commit 1f7da58772 .
2026-03-17 12:43:27 +00:00
Sylvestre Ledru
e2035c4a10
Bug 2023419 - Remove Emacs/Vim modelines from parser/ r=emilio
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287864
2026-03-17 12:08:44 +00:00
Gijs Kruitbosch
9c5be039df
Bug 1971751 - update tests that misuse Assert.ok after no-comparison-or-assignment-inside-ok update, r=frontend-codestyle-reviewers,webdriver-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,profiler-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,permissions-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,robwu,julienw,bytesized,sthompson,valentin,jhirsch,markh,twisniewski,Standard8,dimi,nbarrett,mconley,timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D253662
2025-06-26 10:33:09 +00:00
agoloman
fd1e9e499d
Revert "Bug 1971751 - update no-comparison-or-assignment-inside-ok to also cover Assert.ok, r=frontend-codestyle-reviewers,Standard8" for causing lint failures @test_maybeCapExpiry.js.
...
This reverts commit 2744165954 .
Revert "Bug 1971751 - update tests that misuse Assert.ok after no-comparison-or-assignment-inside-ok update, r=frontend-codestyle-reviewers,webdriver-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,profiler-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,permissions-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,robwu,julienw,bytesized,sthompson,valentin,jhirsch,markh,twisniewski,Standard8,dimi,nbarrett,mconley,timhuang"
This reverts commit ba7298d756 .
Revert "Bug 1971751 - manual test updates where linter autofix creates issues, r=frontend-codestyle-reviewers,Standard8"
This reverts commit e12e0d3181 .
2025-06-26 01:11:00 +00:00
Gijs Kruitbosch
ba7298d756
Bug 1971751 - update tests that misuse Assert.ok after no-comparison-or-assignment-inside-ok update, r=frontend-codestyle-reviewers,webdriver-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,profiler-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,permissions-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,robwu,julienw,bytesized,sthompson,valentin,jhirsch,markh,twisniewski,Standard8,dimi,nbarrett,mconley,timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D253662
2025-06-26 00:07:43 +00:00
Joel Maher
5c87a37896
Bug 1859893 - batch 15 - migrate xpcshell.ini -> .toml. r=aryx,geckoview-reviewers,extension-reviewers,valentin,cookie-reviewers,pbz,owlish,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D194384
2023-11-24 14:41:35 +00:00
Mark Banner
0666077666
Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
...
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Emilio Cobos Álvarez
603af64849
Bug 1830757 - Prevent node removal during iteration in conditional css sanitization. r=smaug
...
When the whole block is sanitized away, we remove the text node
altogether, triggering the assert. While it's not worrisome in this
case, the right thing to do is not mutating the DOM during iteration.
Differential Revision: https://phabricator.services.mozilla.com/D176917
2023-05-02 14:52:23 +00:00
Mark Banner
5407bdffa8
Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
...
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.
Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Andreea Pavel
91896cd9f3
Bug 1770888 - fix prettier lint failure on a CLOSED TREE
2022-09-20 11:56:52 +03:00
Frederik Braun
aff0b0fac0
Bug 1770888 - tests r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D156800
2022-09-20 08:29:55 +00:00
Emilio Cobos Álvarez
6e3ffe28f3
Bug 1780361 - Split conditional CSS sanitization into its own function. r=evilpie
...
Differential Revision: https://phabricator.services.mozilla.com/D152258
2022-07-21 08:18:46 +00:00
Mark Banner
d026f430f6
Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 22:34:21 +00:00
smolnar
ee079d37e2
Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE
...
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
2022-07-20 22:43:53 +03:00
Mark Banner
8715b062f5
Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 15:50:40 +00:00
Iulian Moraru
bc13570de5
Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE
...
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
2022-07-20 15:44:53 +03:00
Mark Banner
2bd76952c1
Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 10:36:49 +00:00
Frederik Braun
2b7fe4e48f
Bug 1691621 - fix bad cast r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D104501
2021-02-10 12:36:59 +00:00
Frederik Braun
f190109e82
Bug 1690984 - Allow data, dialog, main, picture, and template in nsTreeSanitizer r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D104153
2021-02-05 12:34:58 +00:00
Emilio Cobos Álvarez
659f2dc9e1
Bug 1680084 - Tests. r=freddyb
...
Differential Revision: https://phabricator.services.mozilla.com/D98745
2021-01-27 22:45:00 +00:00
Ricky Stewart
31b8ca9716
Bug 1654103: Standardize on Black for Python code in mozilla-central.
...
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
612312a64c
Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
...
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart
065d2eb893
Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
...
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca
95b44c982f
Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE
2020-10-22 03:51:06 +03:00
Ricky Stewart
43baed3c18
Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
...
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Frederik Braun
971a02a66d
Bug 1644070 - add missing URLish attributes to TreeSanitizer r=hsivonen
...
This adds the elements `formaction`, `data`, `ping`, `poster`.
We can't really add a test for the `<object data>`, since we never
allow `<object>` elements in the first place and we don't allow
settings exceptions for temporarily allowed elements.
Same for `poster` elements, since it's only used in media elements
and those are either all allowed or none.
Differential Revision: https://phabricator.services.mozilla.com/D78638
2020-06-10 07:24:05 +00:00
Sebastian Hengst
22e7ccf4b1
Bug 1594981 - update Core::DOM* and Core::Storage* bugzilla product and component meta data in moz.build files after reorganization in bug 1594717. r=annevk
...
Differential Revision: https://phabricator.services.mozilla.com/D52345
2019-11-08 12:17:57 +00:00
Victor Porof
906aebddb3
Bug 1561435 - Format parser/, a=automatic-formatting
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D35923
2019-07-05 10:56:19 +02:00
Gijs Kruitbosch
5d963c894c
Bug 1540170 - release assert if something tries to start the history service before profile startup, r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D24910
2019-03-26 15:17:42 +00:00
Mark Banner
d5029e0dae
Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D23850
2019-03-28 09:38:14 +00:00
Henri Sivonen
1e445d4f70
Bug 1447707 - Remove the XPIDL SAX interface to the XML parser. r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D14724
2018-12-19 16:49:31 +00:00
reimu
5fdcf7e4d4
Bug 1501931 - Enable ESLint for parser/ (manual fixes) r=Standard8,mrbkap
...
Depends on D11920
Differential Revision: https://phabricator.services.mozilla.com/D11921
2018-12-06 20:30:32 +00:00
reimu
5bd6f38d89
Bug 1501931 - Enable ESLint for parser/ (automatic fixes) r=Standard8,mrbkap
...
Differential Revision: https://phabricator.services.mozilla.com/D11920
2018-12-06 20:34:29 +00:00
Sylvestre Ledru
e5a134f73a
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Mark Banner
7d4edb9c5a
Bug 1501662 - Add more .eslintrc.js files for test directories (dom, modules, netwerk and parser). r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D9661
2018-10-24 19:11:17 +00:00
Andrea Marchesini
c2055bb4ff
Bug 1476306 - Moving NullPrincipal/ContentPrincipal/SystemPrincipal under mozilla namespace - part 1 - NullPrincipal, r=ckerschb
2018-07-17 21:37:48 +02:00
Andrea Marchesini
e4ccc82e67
Bug 1418246 - Return valid columnNumber value in CSP violation events, r=ckerschb
2018-07-05 08:21:04 +02:00
Boris Zbarsky
7b635a8ba9
Bug 1455676 part 19. Remove some remaining nsIDOMNode uses. r=qdot
2018-05-29 22:58:50 -04:00
Chris Peterson
5d6b16ea3b
Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
...
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent
MozReview-Commit-ID: KuUsnVe2h8L
2018-04-28 12:50:58 -07:00
Tom Ritter
44f320f9c3
Bug 1448010 Remove unused nsSAXXML IDL methods r=Gijs
...
MozReview-Commit-ID: GFdx6Sjuq36
2018-03-21 11:52:57 -05:00