This reverts commit e5ef1c9835.
Revert "Bug 1934096 - Use `uv` in `mozharness/base/python.py` r=ahal"
This reverts commit 48b3d309b5.
Revert "Bug 1968593 - Upgrade `uv` toolchain version to `0.7.2` r=firefox-build-system-reviewers,sergesanspaille"
This reverts commit 8b828d5f58.
Revert "Bug 1968592 - Fix `test_site_activation.py` test in CI after `uv` enable r=firefox-build-system-reviewers,sergesanspaille"
This reverts commit 8cfd9ee70b.
Revert "Bug 1968592: Enable `use-uv` by default for `test` and `source-test` kinds r=ahal,taskgraph-reviewers"
This reverts commit 994220ef5d.
Revert "Bug 1962485 - Fix `jj` tests in `mozversioncontrol` r=sfink,ahal"
This reverts commit 52e5f009bd.
Revert "Bug 1962485 - Add `jj` toolchain to `mozversioncontrol` Python source test r=firefox-build-system-reviewers,nalexander"
This reverts commit f0c553f479.
Revert "Bug 1962485 - Add `jj` toolchain tasks r=firefox-build-system-reviewers,nalexander"
This reverts commit 166ddbd3fe.
Revert "Bug 1967634 - Bump vendored `pyyaml` version to `6.0.2` to match mozharness and grizzly r=ahal,mach-reviewers"
This reverts commit 495e3e0a95.
Revert "Bug 1967634 - Apply fixes from `python-sites` lint r=ahal,mach-reviewers"
This reverts commit 5953da8cb8.
Revert "Bug 1967634 - Add `python-sites` lint to facilitate adding rules specific to `python/sites/` r=ahal"
This reverts commit 83917ff26d.
Revert "Bug 1965907 - Re-enable `test_vendor.py` r=ahal"
This reverts commit 6777024795.
This reverts commit 779b2feecd.
Revert "Bug 1899960 - P2: Imply an unavailable state if focusable is in unavailable subtree. r=Jamie"
This reverts commit 6e4b35e663.
Revert "Bug 1899960 - P1: Don't cache implicit states. r=Jamie"
This reverts commit eacb22ed13.
Revert "Bug 1967813 - Check menu's frame IsOpen to determine if menu is active. r=ayeddi"
This reverts commit f1f8ac785d.
Revert "Bug 1934096 - Minimize differences between `site.py` and `python.py` implementations of `pip_command` functions r=ahal"
This reverts commit e5ef1c9835.
Revert "Bug 1934096 - Use `uv` in `mozharness/base/python.py` r=ahal"
This reverts commit 48b3d309b5.
Revert "Bug 1968593 - Upgrade `uv` toolchain version to `0.7.2` r=firefox-build-system-reviewers,sergesanspaille"
This reverts commit 8b828d5f58.
Revert "Bug 1968592 - Fix `test_site_activation.py` test in CI after `uv` enable r=firefox-build-system-reviewers,sergesanspaille"
This reverts commit 8cfd9ee70b.
Revert "Bug 1968592: Enable `use-uv` by default for `test` and `source-test` kinds r=ahal,taskgraph-reviewers"
This reverts commit 994220ef5d.
Revert "Bug 1962485 - Fix `jj` tests in `mozversioncontrol` r=sfink,ahal"
This reverts commit 52e5f009bd.
Revert "Bug 1962485 - Add `jj` toolchain to `mozversioncontrol` Python source test r=firefox-build-system-reviewers,nalexander"
This reverts commit f0c553f479.
Revert "Bug 1962485 - Add `jj` toolchain tasks r=firefox-build-system-reviewers,nalexander"
This reverts commit 166ddbd3fe.
Revert "Bug 1967634 - Bump vendored `pyyaml` version to `6.0.2` to match mozharness and grizzly r=ahal,mach-reviewers"
This reverts commit 495e3e0a95.
Revert "Bug 1969203 - Fix `.gitignore` pattern regarding `.egg-info` for vendored packages in `jj` r=ahal"
This reverts commit b993509711.
Revert "Bug 1967634 - Apply fixes from `python-sites` lint r=ahal,mach-reviewers"
This reverts commit 5953da8cb8.
Revert "Bug 1967634 - Add `python-sites` lint to facilitate adding rules specific to `python/sites/` r=ahal"
This reverts commit 83917ff26d.
Revert "Bug 1965907 - Re-enable `test_vendor.py` r=ahal"
This reverts commit 6777024795.
Initially I implemented this feature to solve the problem about how to
make a path absolute to protect against a task changing the working
directory. This is a problem because generic-worker creates a random
task user for each task, so the absolute path can't be known at runtime.
Before my patches, we "solved" this by hardcoding a set of envs in the
`run-task` script, and then calling `os.path.abspath` on them. This
worked for the most part, except for Windows tasks that don't run
through a shell. In that case, the paths would remain relative, which
tbh, mostly just works.
Still, I thought it would be best if we could guarantee that paths are
absolute, and also would be best to avoid hardcoding specific envs in
`run-task`. To that end, I introduced a `{task_workdir}` substitution
where any env containing this string would be interpolated with the
task user's home directory.
In hindsight, this was a bad idea. My patch got backed out 4-5 times due
to subtle errors it introduced to miscellaneous tasks. Then after
finally getting it landed, it started causing havoc in Thunderbird.
What's more is I still had to avoid using `{task_workdir}` in the
Windows without a shell case and rely on relative paths. So the feature
didn't even accomplish what I originally intended it to.
Instead, I recently landed a patch to generic-worker, so *it* will
populate the $TASK_WORKDIR env. this will be available across all
platforms, whether the task is using a shell or not.
So for all these reasons, I'm reverting the `{task_workdir}` change and
returning to using `os.path.abspath`. It's not perfect, but it's good
enough for now. Once we have a modern generic-worker in all our pools,
we can start relying on $TASK_WORKDIR and get the best of both worlds.
Differential Revision: https://phabricator.services.mozilla.com/D238217
Work around a docker-worker bug where it overrides the docker image's
entry point for interactive tasks, and doesn't seem to actually run the
original one as we'd expect.
Differential Revision: https://phabricator.services.mozilla.com/D229127
The robustcheckout.py that is in-tree ends up in docker images, used by
tasks running on docker-worker, but for tasks running on generic-worker,
we currently rely on whatever version of robustcheckout.py is there.
It currently seems out of date, but whenever we make changes to the
in-tree version, we don't end up with the fix on these jobs without some
additional manual work.
With this change, we do the same as with run-task and fetch-content: we
pull the in-tree version that we store as an artifact of the decision
task.
Differential Revision: https://phabricator.services.mozilla.com/D214234
The robustcheckout.py that is in-tree ends up in docker images, used by
tasks running on docker-worker, but for tasks running on generic-worker,
we currently rely on whatever version of robustcheckout.py is there.
It currently seems out of date, but whenever we make changes to the
in-tree version, we don't end up with the fix on these jobs without some
additional manual work.
With this change, we do the same as with run-task and fetch-content: we
pull the in-tree version that we store as an artifact of the decision
task.
Differential Revision: https://phabricator.services.mozilla.com/D214234
Instead of trying to find the system certificates, something that may
depend on the running system, use the certifi package and have ssl point
to it.
Differential Revision: https://phabricator.services.mozilla.com/D201596
This patch introduces:
1. A new task property named use-system-python, defaults to true
2. Task transform to add the appropriate python dependency and set the
PATH accordingly when use-system-python is set to False
3. A new environment variable MOZ_PYTHON_ROOT that can be used in task
to refer to the local python environment (when available).
Differential Revision: https://phabricator.services.mozilla.com/D165171
This patch introduces:
1. A new task property named use-system-python, defaults to true
2. Task transform to add the appropriate python dependency and set the
PATH accordingly when use-system-python is set to False
3. A new environment variable MOZ_PYTHON_ROOT that can be used in task
to refer to the local python environment (when available).
Differential Revision: https://phabricator.services.mozilla.com/D165171
All the workers that had hg under /tools/python27-mercurial are gone.
This also fixes run-task for workers running > 10.14.
Differential Revision: https://phabricator.services.mozilla.com/D92867
All the workers that had hg under /tools/python27-mercurial are gone.
This also fixes run-task for workers running > 10.14.
Differential Revision: https://phabricator.services.mozilla.com/D92867
In Bug 1466660, we started deleting the fetches after a task had run, to avoid
interference between tasks. It turns out the only tasks this was for were the
`source-test-jsshell` tasks, which were changed to use an absolute directory in
Bug 1465181. However, since Bug 1568460 we've always used a per-task directory
for fetches, so can remove the work-around of removing fethes.
Differential Revision: https://phabricator.services.mozilla.com/D86670
Jonathan Moss