Commit Graph
107 Commits
Author SHA1 Message Date
Manuel Bucher 446ffade62 Bug 1918337 - Rename cookieBehavior BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN to BEHAVIOR_PARTITION_FOREIGN r=mkaply,extension-reviewers,devtools-reviewers,cookie-reviewers,dom-worker-reviewers,Sasha,Gijs,farre,nchevobbe,robwu,asuth,timhuang
The cookie behavior was changed in bug 1918342. Lets update the
constant name to reflect the new behavior.

This adds new string constants for enterprise policy while keeping the
old constant for backwards compatibilty.
"reject-tracker-and-partition-foreign" is now deprecated and aliases to
the new "partition-foreign"

Addons API keeps the current "reject_trackers_and_partition_foreign"[1]
string constant for compatibility.

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/privacy/websites#cookieconfig

Differential Revision: https://phabricator.services.mozilla.com/D300794
2026-05-26 15:01:08 +00:00
Tom Schuster 1d8f13905d Bug 2035784 - More strongly type StorageAccessPermissionGrantPromise. r=bvandersloot
Differential Revision: https://phabricator.services.mozilla.com/D297300
2026-05-13 08:58:34 +00:00
Silaghi 3cdbd5ac84 Revert "Bug 2013178: Add ValidatePrincipal calls r=cookie-reviewers,necko-reviewers,nika,timhuang,sunil"
This reverts commit 80634ccb3d.
2026-04-16 23:23:57 +00:00
Silaghi 2456fe1275 Revert "Bug 2013178: apply code formatting via Lando"
This reverts commit a89cd67864.
2026-04-16 23:23:53 +00:00
Lando a89cd67864 Bug 2013178: apply code formatting via Lando
# ignore-this-changeset
2026-04-16 22:17:44 +00:00
Randell Jesup 80634ccb3d Bug 2013178: Add ValidatePrincipal calls r=cookie-reviewers,necko-reviewers,nika,timhuang,sunil
Differential Revision: https://phabricator.services.mozilla.com/D290485
2026-04-16 22:17:21 +00:00
pstanciu 6ffcb05044 Revert "Bug 2013178: apply code formatting via Lando" for causing mochitest failures @browser_fpiServiceWorkers_fingerprinting.js
This reverts commit 21fcd6035a.

Revert "Bug 2013178: Add ValidatePrincipal calls r=cookie-reviewers,necko-reviewers,nika,timhuang,sunil"

This reverts commit 9b86859a03.

Revert "Bug 2013178: Validate CookieJarSettings r=cookie-reviewers,timhuang"

This reverts commit cc32d45063.
2026-04-16 14:17:07 +00:00
Lando 21fcd6035a Bug 2013178: apply code formatting via Lando
# ignore-this-changeset
2026-04-16 13:01:25 +00:00
Randell Jesup 9b86859a03 Bug 2013178: Add ValidatePrincipal calls r=cookie-reviewers,necko-reviewers,nika,timhuang,sunil
Differential Revision: https://phabricator.services.mozilla.com/D290485
2026-04-16 13:01:05 +00:00
Sylvestre Ledru 6be5ec2fff Bug 2023419 - Remove Emacs/Vim modelines from toolkit/ r=emilio,mkaply,extension-reviewers,credential-management-reviewers,desktop-theme-reviewers,win-reviewers,webcompat-reviewers,core-sessionstore-reviewers,profiles-reviewers,ai-platform-reviewers,mconley,twisniewski,gstoll,jhirsch,rpl,dimi,akulyk
Differential Revision: https://phabricator.services.mozilla.com/D287874
2026-04-14 12:56:19 +00:00
agoloman ae99dfb565 Revert "Bug 2023419: apply code formatting via Lando" for causing bc failures @browser_sendQuery.js.
This reverts commit aa15b809d9.

Revert "Bug 2023419 - Remove Emacs/Vim modelines from toolkit/ - follow up r=emilio"

This reverts commit c659385796.

Revert "Bug 2023419 - Remove Emacs/Vim modelines from toolkit/ r=emilio,mkaply,extension-reviewers,credential-management-reviewers,desktop-theme-reviewers,win-reviewers,webcompat-reviewers,core-sessionstore-reviewers,profiles-reviewers,ai-platform-reviewers,mconley,twisniewski,gstoll,jhirsch,rpl,dimi,akulyk"

This reverts commit 1e55e9bf9b.
2026-04-13 13:06:21 +00:00
Sylvestre Ledru 1e55e9bf9b Bug 2023419 - Remove Emacs/Vim modelines from toolkit/ r=emilio,mkaply,extension-reviewers,credential-management-reviewers,desktop-theme-reviewers,win-reviewers,webcompat-reviewers,core-sessionstore-reviewers,profiles-reviewers,ai-platform-reviewers,mconley,twisniewski,gstoll,jhirsch,rpl,dimi,akulyk
Differential Revision: https://phabricator.services.mozilla.com/D287874
2026-04-13 11:30:51 +00:00
Manuel Bucher 7f081dcb02 Bug 2027330 - Use local variable for BrowsingContext in storePermission callback r=bvandersloot
Differential Revision: https://phabricator.services.mozilla.com/D291275
2026-04-10 12:45:53 +00:00
Emilio Cobos Álvarez 5016086e1a Bug 2025089 - Remove some includes from nsINode.h and Element.h. r=dom-core,dom-storage-reviewers,firefox-svg-reviewers,janv,smaug
Differential Revision: https://phabricator.services.mozilla.com/D289049
2026-03-22 23:45:55 +00:00
rperta f5848b1deb Revert "Bug 2023419: apply code formatting via Lando" for causing bc failures at browser_sendQuery.js and browser_console_to_mozlog.js
This reverts commit f8a9770c7d.

This reverts commit 47e16fbdd2.

This reverts commit 9f363abaef.
2026-03-20 06:37:54 +00:00
Sylvestre Ledru 9f363abaef Bug 2023419 - Remove Emacs/Vim modelines from toolkit/ r=emilio,mkaply,extension-reviewers,credential-management-reviewers,desktop-theme-reviewers,win-reviewers,webcompat-reviewers,profiles-reviewers,ai-ondevice-reviewers,mconley,twisniewski,gstoll,jhirsch,rpl,dimi,akulyk
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287874
2026-03-20 04:55:48 +00:00
Benjamin VanderSloot 06fe7d5098 Bug 2013885 - Remove the forward-declared storage access API - r=emz,webidl,emilio,saschanaz,permissions-reviewers,smaug
This removes the code/prefs/tests for this prototype. We hardly knew ye.

Differential Revision: https://phabricator.services.mozilla.com/D281451
2026-02-11 18:27:06 +00:00
serge-sans-paille 7662b3abdc Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 19:36:01 +00:00
Cristina Horotan 8a1b1970b7 Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing Gtest failures on AlreadyAddRefed.h
This reverts commit e98adca292.
2025-10-21 16:16:29 +00:00
serge-sans-paille e98adca292 Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 15:05:17 +00:00
Cristina Horotan aab924e90d Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing build bustage at nsBrowserApp.cpp
This reverts commit fd0ffa193c.
2025-10-21 10:44:13 +00:00
serge-sans-paille fd0ffa193c Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 09:44:11 +00:00
Narcis Beleuzu e1e6bbb1c9 Revert "Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch" for causing bustages on Document.cpp
This reverts commit b23c15e927.
2025-10-21 06:34:58 +00:00
serge-sans-paille b23c15e927 Bug 1994397 - Remove obsolete Unused.h header r=emilio,tschuster,geckoview-reviewers,extension-reviewers,application-update-reviewers,media-playback-reviewers,webrtc-reviewers,cookie-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,permissions-reviewers,profiles-reviewers,toolkit-telemetry-reviewers,firefox-style-system-reviewers,firefox-svg-reviewers,layout-reviewers,timhuang,gstoll,TravisLong,bytesized,mstange,karlt,robwu,pehrsons,m_kato,jari,jhirsch
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.

In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.

One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.

Most of the heavy lifting was done through:

    $ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
    $ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'

Differential Revision: https://phabricator.services.mozilla.com/D268706
2025-10-21 06:01:36 +00:00
Tim Huang e7064cfc3b Bug 1943536 - Part 4: Exclude third-party trackers from triggering the opener heuristics. r=bvandersloot,anti-tracking-reviewers
We excludes third-party trackers to trigger the opener heuristic.

First, we don't allow a third-party tracking window to trigger the
heuristic. Second, we don't trigger opener heuristic if the opened URL
is a tracking URL.

Differential Revision: https://phabricator.services.mozilla.com/D238943
2025-03-04 13:16:09 +00:00
Benjamin VanderSloot 895d3c31d6 Bug 1947480 - Fix telemetry code to work for Navigation heuristic - r=timhuang,anti-tracking-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239008
2025-02-24 12:06:48 +00:00
Cristina Horotan 9975b38430 Backed out 5 changesets (bug 1949804, bug 1947480, bug 1949805) for causing mass failures. CLOSED TREE
Backed out changeset 835e4940c930 (bug 1947480)
Backed out changeset a48286b80385 (bug 1949804)
Backed out changeset b809946b04a9 (bug 1949805)
Backed out changeset e1d491ba00eb (bug 1947480)
Backed out changeset b2dc603aeb74 (bug 1947480)
2025-02-23 16:26:15 +02:00
Benjamin VanderSloot c2839cbb75 Bug 1947480 - Fix telemetry code to work for Navigation heuristic - r=timhuang,anti-tracking-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239008
2025-02-23 13:40:19 +00:00
Butkovits Atila c7e8b2807a Backed out 5 changesets (bug 1947480, bug 1949804, bug 1949805) for causing build bustages. CLOSED TREE
Backed out changeset 50e0c799bfa8 (bug 1947480)
Backed out changeset 4f6f7fdd87bd (bug 1949804)
Backed out changeset d3d2625285aa (bug 1949805)
Backed out changeset 71c974d05b82 (bug 1947480)
Backed out changeset c67515b6e9e9 (bug 1947480)
2025-02-21 23:38:48 +02:00
Benjamin VanderSloot aefcae7ce2 Bug 1947480 - Fix telemetry code to work for Navigation heuristic - r=timhuang,anti-tracking-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239008
2025-02-21 20:12:12 +00:00
Benjamin VanderSloot 6e743bc762 Bug 1940904 - Add IPC to test trackers in Client process without nsIURIClassifierFeature - r=timhuang,anti-tracking-reviewers
That's how the other IPC used to work until ~*~refactoring~*~ removed it

Differential Revision: https://phabricator.services.mozilla.com/D238273
2025-02-19 17:23:13 +00:00
Benjamin VanderSloot 12fc4abe37 Bug 1940904 - Add telemetry for storage access grants to trackers - r=timhuang,anti-tracking-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D235346
2025-02-19 17:23:12 +00:00
Butkovits Atila 6af79c8913 Backed out 2 changesets (bug 1940904) for causing bustages at ipc_message_utils.h.
Backed out changeset 5719d9a76fc9 (bug 1940904)
Backed out changeset 64fdbcc5ff75 (bug 1940904)
2025-02-19 17:05:16 +02:00
Benjamin VanderSloot 2c2168d6eb Bug 1940904 - Add IPC to test trackers in Client process without nsIURIClassifierFeature - r=timhuang,anti-tracking-reviewers
That's how the other IPC used to work until ~*~refactoring~*~ removed it

Differential Revision: https://phabricator.services.mozilla.com/D238273
2025-02-19 13:46:29 +00:00
Benjamin VanderSloot 143fcee2ec Bug 1940904 - Add telemetry for storage access grants to trackers - r=timhuang,anti-tracking-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D235346
2025-02-19 13:46:29 +00:00
Norisz Fay a454ce8f9c Backed out changeset f00508a9725b (bug 1940904) for causing mochitest failures on UrlClassifierFeatureEmailTrackingProtection.cpp CLOSED TREE 2025-02-13 18:51:46 +02:00
Benjamin VanderSloot 801e52f69a Bug 1940904 - Add telemetry for storage access grants to trackers - r=timhuang,anti-tracking-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D235346
2025-02-13 15:35:25 +00:00
Stanca Serban 9915d1a5c6 Backed out 2 changesets (bug 1940904) for causing build bustages in StorageAccessAPIHelper.cpp. CLOSED TREE
Backed out changeset 5d9ca7eb41d8 (bug 1940904)
Backed out changeset 2a7fdc530e19 (bug 1940904)
2025-02-13 00:40:15 +02:00
Benjamin VanderSloot 7864e806cf Bug 1940904 - Add telemetry for storage access grants to trackers - r=timhuang,anti-tracking-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D235346
2025-02-12 18:27:02 +00:00
Florian Quèze b4b0d27e43 Bug 1935420 - Migrate histograms to use Glean APIs in toolkit/components/antitracking, r=chutten,anti-tracking-reviewers,firefox-desktop-core-reviewers ,emz,mossop.
Differential Revision: https://phabricator.services.mozilla.com/D234069
2025-01-27 13:42:15 +00:00
Jens Stutte 706548fa4f Bug 1745056 - Make PermissionManager lifecycle truely thread safe. r=asuth,cookie-reviewers,anti-tracking-reviewers,permissions-reviewers,valentin,timhuang
This patch makes PermissionManager::GetInstance do the instantiation
work and GetXPCOMSingleton just uses it.
We always acquire the creation mutex and return an already_AddRefed to
avoid any possible race. We count on callers of GetInstance to
(shortly) keep a local reference if they have more work to do.
On async shutdown in the parent process, we first mark our singleton
dead, then close all our resources async and finally null our instance
holder only after the async shutdown has finished.

Differential Revision: https://phabricator.services.mozilla.com/D233816
2025-01-15 17:00:25 +00:00
Paul Zuehlcke 01af2372d9 Bug 1902319 - Separate BTP user interaction tracking from ContentBlockingUserInteraction and record user interaction for iframes. r=anti-tracking-reviewers,manuel
Differential Revision: https://phabricator.services.mozilla.com/D214622
2024-06-30 12:39:58 +00:00
Norisz Fay 92f25aed32 Backed out 2 changesets (bug 1902319) for causing bustages on BounceTrackingProtection.h CLOSED TREE
Backed out changeset b2f40abb0309 (bug 1902319)
Backed out changeset 530b43559b31 (bug 1902319)
2024-06-28 16:18:01 +03:00
Paul Zuehlcke 55770b3b49 Bug 1902319 - Separate BTP user interaction tracking from ContentBlockingUserInteraction and record user interaction for iframes. r=anti-tracking-reviewers,manuel
Differential Revision: https://phabricator.services.mozilla.com/D214622
2024-06-28 12:43:52 +00:00
Christian Holler 8c50e5b883 Bug 1904018 - Add missing null check in antitracking code. r=bvandersloot,anti-tracking-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D214536
2024-06-28 08:37:25 +00:00
Benjamin VanderSloot f9b6578ac7 Bug 1876575, part 1 - Make AntiTracking::IsThirdParty* aware of ABA case - r=anti-tracking-reviewers,cookie-reviewers,timhuang
Differential Revision: https://phabricator.services.mozilla.com/D203180
2024-04-02 18:53:26 +00:00
Cristian Tuns 16ac4d3300 Backed out 6 changesets (bug 1876574, bug 1876575) for causing multiple failures in TestGetPrincipalCookieBehavior5 CLOSED TREE
Backed out changeset f00e9fde550f (bug 1876575)
Backed out changeset ca1c6f8819f7 (bug 1876575)
Backed out changeset d65ac05bd9f8 (bug 1876575)
Backed out changeset 5dcfe3aa8497 (bug 1876575)
Backed out changeset 9ae9252761ac (bug 1876575)
Backed out changeset 704e94d28ad7 (bug 1876574)
2024-04-02 09:58:52 -04:00
Benjamin VanderSloot f6fa95ad96 Bug 1876575, part 1 - Make AntiTracking::IsThirdParty* aware of ABA case - r=anti-tracking-reviewers,cookie-reviewers,timhuang
Differential Revision: https://phabricator.services.mozilla.com/D203180
2024-04-02 12:50:01 +00:00
Stanca Serban d963aee96b Backed out 6 changesets (bug 1876574, bug 1876575) for causing multiple failures. CLOSED TREE
Backed out changeset 8c7a9f405031 (bug 1876575)
Backed out changeset 49739f9ec590 (bug 1876575)
Backed out changeset 1c49f0c3b677 (bug 1876575)
Backed out changeset 1ca7a0f27bc0 (bug 1876575)
Backed out changeset bfa9862e3480 (bug 1876575)
Backed out changeset 58576ed7eb22 (bug 1876574)
2024-03-29 20:52:30 +02:00
Benjamin VanderSloot 2692fa6d2b Bug 1876575, part 1 - Make AntiTracking::IsThirdParty* aware of ABA case - r=anti-tracking-reviewers,cookie-reviewers,timhuang
Differential Revision: https://phabricator.services.mozilla.com/D203180
2024-03-29 17:12:13 +00:00