Sylvestre Ledru
6be5ec2fff
Bug 2023419 - Remove Emacs/Vim modelines from toolkit/ r=emilio,mkaply,extension-reviewers,credential-management-reviewers,desktop-theme-reviewers,win-reviewers,webcompat-reviewers,core-sessionstore-reviewers,profiles-reviewers,ai-platform-reviewers,mconley,twisniewski,gstoll,jhirsch,rpl,dimi,akulyk
...
Differential Revision: https://phabricator.services.mozilla.com/D287874
2026-04-14 12:56:19 +00:00
agoloman
ae99dfb565
Revert "Bug 2023419: apply code formatting via Lando" for causing bc failures @browser_sendQuery.js.
...
This reverts commit aa15b809d9 .
Revert "Bug 2023419 - Remove Emacs/Vim modelines from toolkit/ - follow up r=emilio"
This reverts commit c659385796 .
Revert "Bug 2023419 - Remove Emacs/Vim modelines from toolkit/ r=emilio,mkaply,extension-reviewers,credential-management-reviewers,desktop-theme-reviewers,win-reviewers,webcompat-reviewers,core-sessionstore-reviewers,profiles-reviewers,ai-platform-reviewers,mconley,twisniewski,gstoll,jhirsch,rpl,dimi,akulyk"
This reverts commit 1e55e9bf9b .
2026-04-13 13:06:21 +00:00
Sylvestre Ledru
1e55e9bf9b
Bug 2023419 - Remove Emacs/Vim modelines from toolkit/ r=emilio,mkaply,extension-reviewers,credential-management-reviewers,desktop-theme-reviewers,win-reviewers,webcompat-reviewers,core-sessionstore-reviewers,profiles-reviewers,ai-platform-reviewers,mconley,twisniewski,gstoll,jhirsch,rpl,dimi,akulyk
...
Differential Revision: https://phabricator.services.mozilla.com/D287874
2026-04-13 11:30:51 +00:00
Moritz Beier
61a4fc738e
Bug 2030983 - Convert XUL in UrlbarInput to HTML except search mode switcher. r=dao,desktop-theme-reviewers,urlbar-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D289160
2026-04-10 19:28:46 +00:00
japeter
a41db07855
Bug 2011343 - Show reading time in hours for reader mode on long documents. r=eemeli,fluent-reviewers,bolsson
...
When we estimate a document to have a reading time over 120 minutes, display in hours instead.
Also update from Fluent to JS internationalization tools.
Differential Revision: https://phabricator.services.mozilla.com/D289846
2026-04-07 16:18:44 +00:00
rperta
f5848b1deb
Revert "Bug 2023419: apply code formatting via Lando" for causing bc failures at browser_sendQuery.js and browser_console_to_mozlog.js
...
This reverts commit f8a9770c7d .
This reverts commit 47e16fbdd2 .
This reverts commit 9f363abaef .
2026-03-20 06:37:54 +00:00
Sylvestre Ledru
9f363abaef
Bug 2023419 - Remove Emacs/Vim modelines from toolkit/ r=emilio,mkaply,extension-reviewers,credential-management-reviewers,desktop-theme-reviewers,win-reviewers,webcompat-reviewers,profiles-reviewers,ai-ondevice-reviewers,mconley,twisniewski,gstoll,jhirsch,rpl,dimi,akulyk
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287874
2026-03-20 04:55:48 +00:00
Adam Vandolder
dd7184fd48
Bug 1892551 - Part 2: Remove SessionHistoryInParent conditionals. r=dom-core,farre,core-sessionstore-reviewers,devtools-reviewers,nchevobbe
...
Differential Revision: https://phabricator.services.mozilla.com/D208061
2026-03-18 17:26:15 +00:00
Mark Banner
c2693fb168
Bug 2004680 - Fix ESLint rule jsdoc/check-tag-names issues in toolkit. r=firefox-desktop-core-reviewers ,extension-reviewers,credential-management-reviewers,toolkit-telemetry-reviewers,Gijs,mkennedy,dimi,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D275756
2025-12-22 12:41:33 +00:00
Mark Banner
a24203b520
Bug 2004684 - Replace promiseTabLoadEvent functions in head files with BrowserTestUtils.loadURIString. r=firefox-desktop-core-reviewers ,tabbrowser-reviewers,timhuang,Gijs,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D275433
2025-12-09 15:36:14 +00:00
Mark Banner
93b92e2659
Bug 1998787 - Manually fixes for enabling ESLint jsdoc/tag-line rule everywhere. r=frontend-codestyle-reviewers,media-playback-reviewers,devtools-reviewers,tabbrowser-reviewers,omc-reviewers,layout-reviewers,manuel,tnikkel,nchevobbe,home-newtab-reviewers,dao,mconley,aosmond,Gijs,mimi
...
Differential Revision: https://phabricator.services.mozilla.com/D271744
2025-11-10 21:27:09 +00:00
Tom Schuster
75101d5ffb
Bug 1586083 - Send raster favicons as one or more VideoFrame blobs. r=mossop,sessionstore-reviewers,urlbar-reviewers,sthompson,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D269948
2025-11-10 09:52:52 +00:00
Mason
a982c54cf9
Bug 1958780 - <pre>s use monospace without effecting plain text documents. r=desktop-theme-reviewers,Gijs,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D259318
2025-10-22 21:05:05 +00:00
Gijs Kruitbosch
dcde5aa701
Bug 1968706 - fix debug flakiness in browser_readerMode_refresh.js, r=reader-mode-reviewers,sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D253197
2025-06-11 02:25:04 +00:00
Fred Chasen
8fdcb97660
Bug 1967558 - Remove Pocket icon button in Reader Mode r=kpatenio,rking
...
Differential Revision: https://phabricator.services.mozilla.com/D250461
2025-06-09 18:33:06 +00:00
Atila Butkovits
42caad537b
Revert "Bug 1968126 — Remove pktTelemetry.sys.js and metrics r=fchasen,rking" for causing Docker Images failures.
...
This reverts commit 0105138029 .
Revert "Bug 1968287 - remove aboutPocket.ftl r=fchasen"
This reverts commit d11ffeba38 .
Revert "Bug 1969995 - Remove Pocket Webpack and Node configs r=frontend-codestyle-reviewers,kpatenio,rking"
This reverts commit 6cc8cf06ad .
Revert "Bug 1968124 - Remove pktUI.js and panels directory r=sylvestre,fchasen,rking,desktop-theme-reviewers,frontend-codestyle-reviewers,emilio"
This reverts commit 34f3d79d15 .
Revert "Bug 1967594 - remove pocket.svg r=fchasen,rking,desktop-theme-reviewers,home-newtab-reviewers,urlbar-reviewers,mconley,mak,emilio"
This reverts commit 788e6c1aa2 .
Revert "Bug 1968146 - Remove Pocket globals r=kpatenio,rking"
This reverts commit 66570c3534 .
Revert "Bug 1967559 - clean up pocket in context menu r=fchasen,rking"
This reverts commit b521db7b46 .
Revert "Bug 1967558 - Remove Pocket icon button in Reader Mode r=kpatenio,rking"
This reverts commit 06111ee947 .
Revert "Bug 1968123 - Remove Pocket actors r=frontend-codestyle-reviewers,kpatenio,rking"
This reverts commit 9e4a78dbb2 .
Revert "Bug 1968034 - Update insertBeforeFirstItemInOverflow test to use the download button - r=fchasen"
This reverts commit 1987a39c17 .
Revert "Bug 1967557 - Remove Pocket icon button in the toolbar - r=fchasen,fluent-reviewers,desktop-theme-reviewers,omc-reviewers,emilio,flod,mimi"
This reverts commit 17ac49e871 .
Revert "Bug 1967788 - Remove pocket component tests - r=fchasen"
This reverts commit 2e6b779e5f .
2025-06-06 22:33:52 +00:00
Fred Chasen
06111ee947
Bug 1967558 - Remove Pocket icon button in Reader Mode r=kpatenio,rking
...
Differential Revision: https://phabricator.services.mozilla.com/D250461
2025-06-06 21:38:04 +00:00
Joel Maher
2717dc1a58
Bug 1969523 - Initial greenup of mochitests for Ubuntu 24.04 x11. r=aryx,mtigley,extension-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,tabbrowser-reviewers,omc-reviewers,sidebar-reviewers,urlbar-reviewers,nchevobbe,emcminn,nsharpley
...
Differential Revision: https://phabricator.services.mozilla.com/D251979
2025-06-05 20:42:26 +00:00
Florian Quèze
9786bbf2ab
Bug 1702637 - set the test.wait300msAfterTabSwitch pref to true in tests that failed on try, r=jmaher,necko-reviewers,webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,tabbrowser-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,home-newtab-reviewers,urlbar-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,alwu,janv,twisniewski,scunnane,kershaw,robwu,dimi,mconley,nsharpley,jteow,mossop.
...
Differential Revision: https://phabricator.services.mozilla.com/D251051
2025-06-03 12:04:37 +00:00
Sandor Molnar
70ee915078
Revert "Bug 1968146 - Remove Pocket globals r=kpatenio,rking" for causing bc failures.
...
This reverts commit cd77c51e5c .
Revert "Bug 1967559 - clean up pocket in context menu r=fchasen,rking"
This reverts commit 423574737d .
Revert "Bug 1967558 - Remove Pocket icon button in Reader Mode r=kpatenio,rking"
This reverts commit 60fba1fa40 .
Revert "Bug 1968123 - Remove Pocket actors r=frontend-codestyle-reviewers,kpatenio,rking"
This reverts commit b84d3ac2f9 .
Revert "Bug 1967557 - Remove Pocket icon button in the toolbar - r=fchasen,fluent-reviewers,desktop-theme-reviewers,omc-reviewers,emilio,flod,mimi"
This reverts commit 58ecec91ba .
Revert "Bug 1967788 - Remove Pocket component tests - r=fchasen"
This reverts commit d9b111ac1b .
2025-05-29 19:37:51 +00:00
Fred Chasen
60fba1fa40
Bug 1967558 - Remove Pocket icon button in Reader Mode r=kpatenio,rking
...
Differential Revision: https://phabricator.services.mozilla.com/D250461
2025-05-29 18:13:33 +00:00
Mark Banner
c46af4df18
Bug 1881702 - Fix no-unused-vars issues raised by the upgrade to ESLint v9. r=frontend-codestyle-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,devtools-reviewers,migration-reviewers,android-reviewers,webcompat-reviewers,nchevobbe,mossop,sparky,twisniewski,ohall
...
This disables caughtErrors from everywhere. This is enabled by default in v9. We should work to enable this later.
This also changes the exported comments - ESLint is more strict about what it can handle, and doesn't like a star
in the middle of the comment.
Also tidies up some rules where they are no longer needed.
Differential Revision: https://phabricator.services.mozilla.com/D251253
2025-05-29 08:30:32 +00:00
hannajones
54594e5c8e
Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio
...
Differential Revision: https://phabricator.services.mozilla.com/D249182
2025-05-28 02:31:27 +00:00
Mark Banner
876c545813
Bug 1881701 - Change new .eslintrc.mjs files to modules (toolkit/), and export as flat config. r=frontend-codestyle-reviewers,extension-reviewers,credential-management-reviewers,Gijs,mossop,dimi,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D249950
2025-05-24 17:11:06 +00:00
Mark Banner
d7c7c5369b
Bug 1881701 - Rename many ESLint files to use .mjs. r=frontend-codestyle-reviewers,perftest-reviewers,Gijs,sparky,webcompat-reviewers,twisniewski
...
This is separate to help preserve history of the files.
Differential Revision: https://phabricator.services.mozilla.com/D249945
2025-05-24 17:10:51 +00:00
Aristide Tossou
26bdba4561
Bug 1967767 - Use isProbabablyReadable properly to keep Reader Mode and Link Preview in sync - r=txia,firefox-ai-ml-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D250846
2025-05-24 00:24:31 +00:00
Gijs Kruitbosch
3240f6ca95
Bug 1965860 - stop reader mode setting broken lang attributes leading to the wrong font being used, r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D250434
2025-05-22 11:29:55 +00:00
agoloman
63c83deb26
Revert "Bug 1606785 - Enable Prettier for CSS files r=desktop-theme-reviewers,Standard8,frontend-codestyle-reviewers,emilio" for causing multiple failures.
...
This reverts commit ec5fa1d4c0 .
Revert "Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio"
This reverts commit baa5d72bbd .
Revert "Bug 1606785 - Format browser/themes and toolkit/themes CSS files with Prettier r=desktop-theme-reviewers,pip-reviewers,tabbrowser-reviewers,places-reviewers,dao,mconley"
This reverts commit 9604b0a8ae .
Revert "Bug 1606785 - Format browser/themes/preferences CSS files with Prettier r=settings-reviewers,desktop-theme-reviewers,dao,mconley"
This reverts commit 686c1cf85f .
Revert "Bug 1606785 - Format urlbar CSS files with Prettier r=urlbar-reviewers,desktop-theme-reviewers,dao"
This reverts commit a7a4f31251 .
Revert "Bug 1606785 - Format webcompat CSS files with Prettier r=webcompat-reviewers,denschub"
This reverts commit 41bc4d5237 .
Revert "Bug 1606785 - Format search CSS files with Prettier r=search-reviewers,jteow"
This reverts commit 7bb7f82374 .
Revert "Bug 1606785 - Format dom CSS files with Prettier r=emilio"
This reverts commit c22e910235 .
Revert "Bug 1606785 - Format android CSS files with Prettier r=geckoview-reviewers,hiro"
This reverts commit c08e43fc3d .
Revert "Bug 1606785 - Format layout CSS files with Prettier r=layout-reviewers,dholbert"
This reverts commit 4f2a32d1a4 .
Revert "Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers"
This reverts commit c05f675ddf .
Revert "Bug 1606785 - Format recomp CSS files with Prettier r=reusable-components-reviewers,desktop-theme-reviewers,dao,mkennedy"
This reverts commit b10c7de8d0 .
Revert "Bug 1606785 - Format sidebar CSS files with Prettier r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley"
This reverts commit d32c555e37 .
Revert "Bug 1606785 - Format shopping CSS files with Prettier r=shopping-reviewers,desktop-theme-reviewers,dao,rking"
This reverts commit 965887a708 .
Revert "Bug 1606785 - Format profiles CSS files with Prettier r=profiles-reviewers,desktop-theme-reviewers,dao,mossop"
This reverts commit 8338860f74 .
Revert "Bug 1606785 - Format genai and ml CSS files with Prettier r=firefox-ai-ml-reviewers,Mardak"
This reverts commit d66681f553 .
Revert "Bug 1606785 - Format firefoxview CSS files with Prettier r=fxview-reviewers,desktop-theme-reviewers,dao,jsudiaman"
This reverts commit 530b815cad .
Revert "Bug 1606785 - Format aboutlogins, megalist, and form autofill CSS files with Prettier r=credential-management-reviewers,mtigley,desktop-theme-reviewers,dao"
This reverts commit 813c864381 .
2025-05-21 04:49:28 +00:00
hannajones
baa5d72bbd
Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio
...
Differential Revision: https://phabricator.services.mozilla.com/D249182
2025-05-21 03:55:13 +00:00
camachoh
fce9ba1bc5
Bug 1323331 - Improve reader mode code dealing with detected language/direction. r=Gijs,firefox-ai-ml-reviewers,Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D244820
2025-04-22 18:17:32 +00:00
Goloman Adrian
bffc2fcd37
Backed out changeset 86d8129309e2 (bug 1323331) for causing bc failures @browser_link_preview.js. CLOSED TREE
2025-04-10 21:24:22 +03:00
camachoh
f4e0d2f900
Bug 1323331 - Improve reader mode code dealing with detected language/direction. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D244820
2025-04-10 16:19:31 +00:00
Mike Conley
d3b978d6d0
Bug 1949964 - Use proper language codes for Japanese and Slovenian articles when calculating reading times in reader mode. r=nordzilla
...
Differential Revision: https://phabricator.services.mozilla.com/D240183
2025-03-06 18:13:03 +00:00
Gijs Kruitbosch
8c703a7db2
Bug 1951072 - switch reader mode modules to use moz-src URLs, r=firefox-desktop-core-reviewers ,sync-reviewers,urlbar-reviewers,mossop,jteow,markh
...
Differential Revision: https://phabricator.services.mozilla.com/D240004
2025-03-04 21:20:35 +00:00
Gijs Kruitbosch
57db82ee48
Bug 1951537 - update readability to 0.6.0 to improve reader mode functionality, r=reader-mode-reviewers,cmkm
...
Differential Revision: https://phabricator.services.mozilla.com/D240232
2025-03-04 10:02:08 +00:00
Greg Tatum
121327c607
Bug 1859081 - Move cld2 from toolkit/component/translation to translations; r=translations-reviewers,zeid,frontend-codestyle-reviewers,nordzilla
...
We developed the new translations codebase using an "s" at the end, and
retained the old translations code under "translation". At this point
I'm unifying it so that it's all under "translations", which involves a
rename of the existing code. This way we will be consistent in our
naming practice.
Differential Revision: https://phabricator.services.mozilla.com/D239047
2025-02-26 20:06:25 +00:00
Irene Ni
07d89221e6
Bug 1921185 - Add an option for justified text alignment. r=reader-mode-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D235362
2025-02-26 19:27:52 +00:00
Florian Quèze
e32d38afa6
Bug 1944631 - Migrate histograms to use Glean APIs for READER_MODE_* histograms, r=chutten.
...
Differential Revision: https://phabricator.services.mozilla.com/D238027
2025-02-17 15:10:53 +00:00
Norisz Fay
6e0dd7eb4a
Bug 1937640 - Fix lint failure in browser_readerMode_colorSchemePref.js r=lint-fix" CLOSED TREE
2025-02-05 23:23:24 +02:00
mark
c7b20ad135
Bug 1937640 - Refactor moz-input-color component r=reusable-components-reviewers,desktop-theme-reviewers,mstriemer,hjones,fluent-reviewers,bolsson
...
Refactors the `<moz-input-color>` picker component to use our design tokens,
simplifies its functionality, adds missing states, and enhances its reusability.
Differential Revision: https://phabricator.services.mozilla.com/D233878
2025-02-05 17:10:47 +00:00
mark
8073df6e0f
Bug 1937639 - Migrate color-input element to moz-color-input reusable component r=reusable-components-reviewers,desktop-theme-reviewers,hjones
...
Differential Revision: https://phabricator.services.mozilla.com/D232402
2025-02-05 17:10:47 +00:00
Goloman Adrian
df17a3a023
Backed out 3 changesets (bug 1938208, bug 1937640, bug 1937639) for causing bc failures @browser_readerMode_colorSchemePref.js. CLOSED TREE
...
Backed out changeset 384db71e99ca (bug 1938208)
Backed out changeset 3578647f0b39 (bug 1937640)
Backed out changeset 80f0617a229b (bug 1937639)
2025-02-04 21:15:00 +02:00
mark
a59fdfe42a
Bug 1937640 - Refactor moz-input-color component r=reusable-components-reviewers,desktop-theme-reviewers,mstriemer,hjones,fluent-reviewers,bolsson
...
Refactors the `<moz-input-color>` picker component to use our design tokens,
simplifies its functionality, adds missing states, and enhances its reusability.
Differential Revision: https://phabricator.services.mozilla.com/D233878
2025-02-04 15:43:31 +00:00
mark
423924a3d0
Bug 1937639 - Migrate color-input element to moz-color-input reusable component r=reusable-components-reviewers,desktop-theme-reviewers,hjones
...
Differential Revision: https://phabricator.services.mozilla.com/D232402
2025-02-04 15:43:31 +00:00
Florian Quèze
466d8c2170
Bug 1935420 - rewrite more JS code storing histograms in local variables (includes changes done by hand), r=chutten,search-reviewers,anti-tracking-reviewers,sessionstore-reviewers,dao.
...
Differential Revision: https://phabricator.services.mozilla.com/D234009
2025-01-24 16:18:32 +00:00
Jason Mui
0261eb8608
Bug 1888170 - reset default button in reader mode is now hidden until user changes colors. r=Gijs,desktop-theme-reviewers,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D232779
2025-01-16 14:21:33 +00:00
Irene Ni
ac979c8453
Bug 1903156 - Remove duplicate code from older menus once the new menus land. r=reader-mode-reviewers,desktop-theme-reviewers,dao,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D218772
2025-01-01 17:43:17 +00:00
Norisz Fay
a3fd0438a0
Backed out changeset d6fb7aed437c (bug 1903156) for causing bc failures on browser_readerMode_colorSchemePref.js
2024-12-12 23:41:44 +02:00
Irene Ni
9abbcda4ec
Bug 1903156 - Remove duplicate code from older menus once the new menus land. r=reader-mode-reviewers,desktop-theme-reviewers,dao,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D218772
2024-12-12 20:19:25 +00:00
Logan Rosen
d24c9d9ff4
Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00