Commit Graph
85 Commits
Author SHA1 Message Date
Jack Brown 9938597266 Bug 2035787 - Treat error page illustrations as decorative images - r=rking
Regarding the illustrations on the Felt Privacy error pages:
https://www.w3.org/WAI/tutorials/images/decision-tree/

>
> Does the image contribute meaning to the current page or context?

I'd argue it does, and in the "Yes" column there's: "it shows content that is redundant to real text nearby," which I think is also true. An empty alt attribute is called for in this case.

Differential Revision: https://phabricator.services.mozilla.com/D302386
2026-05-28 16:45:26 +00:00
Jack Brown 93b15b26be Bug 2028705 - Restore www suggestion and SUMO link on Felt Privacy dnsNotFound page - r=rking,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D299007
2026-05-14 20:57:51 +00:00
Lars Eggert e504e64895 Bug 2036005 - Show SSL error code on nssFailure2 fallback error pages r=kershaw,necko-reviewers
Unregistered SSL errors that fall through to the nssFailure2 config in the
error registry now show their error code (e.g. SSL_ERROR_DECRYPT_ERROR_ALERT)
on the "Secure Connection Failed" error page, consistent with how registered
errors like SSL_ERROR_NO_CYPHER_OVERLAP already behave. Also removes a broken
third descriptionParts entry in the nssFailure2 config that referenced a
Fluent string that was never defined.

Differential Revision: https://phabricator.services.mozilla.com/D297577
2026-05-12 11:22:23 +00:00
Jack Brown d6793148ce Bug 2031837 - Add new net error page illustrations with per-illustration sizing - r=niklas,rking,desktop-theme-reviewers,dao,gfx-reviewers,lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D295650
2026-05-12 02:04:44 +00:00
Silaghi c4ade994de Revert "Bug 2031837 - Add new net error page illustrations with per-illustration sizing - r=niklas,rking,desktop-theme-reviewers,dao,gfx-reviewers,lsalzman" for causing reftest failures at reftests/font-face
This reverts commit 55c035a4dc.
2026-05-11 17:44:28 +00:00
Jack Brown 55c035a4dc Bug 2031837 - Add new net error page illustrations with per-illustration sizing - r=niklas,rking,desktop-theme-reviewers,dao,gfx-reviewers,lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D295650
2026-05-11 15:49:12 +00:00
Jack Brown fb0fe14485 Bug 2035942 - Add Felt Privacy error page support for SEC_ERROR_CA_CERT_INVALID - r=rking
Differential Revision: https://phabricator.services.mozilla.com/D297519
2026-05-07 16:26:39 +00:00
agoloman 8b6198f56d Revert "Bug 2031837 - Add new net error page illustrations with per-illustration sizing - r=niklas,rking,desktop-theme-reviewers,dao" for causing valgrind failures.
This reverts commit 9ec50c10ec.
2026-05-01 03:47:47 +00:00
Jack Brown 9ec50c10ec Bug 2031837 - Add new net error page illustrations with per-illustration sizing - r=niklas,rking,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D295650
2026-04-30 18:27:24 +00:00
Jack Brown 1c1b301235 Bug 2027209 - Update connectionFailure and netTimeout Felt Privacy error page content - r=rking
Differential Revision: https://phabricator.services.mozilla.com/D295527
2026-04-28 15:20:45 +00:00
Jack Brown 614d04d430 Bug 2027209 - Update netInterrupt Felt Privacy error page content - r=rking,desktop-theme-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D294693
2026-04-28 01:30:24 +00:00
Jack Brown 677aa45084 Bug 2027209 - Show error code on customNetError pages - r=rking
Affected errors:

NS_ERROR_OFFLINE
NS_ERROR_DOM_COOP_FAILED (blockedByCOOP)
NS_ERROR_DOM_COEP_FAILED (blockedByCOEP)
NS_ERROR_NET_EMPTY_RESPONSE (netReset)

Differential Revision: https://phabricator.services.mozilla.com/D294024
2026-04-27 23:06:40 +00:00
Mathew Hodson b885f3a091 Bug 2032997 - Add HTTP error code to encoding error page r=jbrown
Differential Revision: https://phabricator.services.mozilla.com/D295066
2026-04-27 17:37:20 +00:00
Jack Brown 7a79d36631 Bug 2029027 - Establish a dedicated error resolution layer for Felt Privacy error pages - r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D292488
2026-04-20 23:00:37 +00:00
Jack Brown 8a540e7c99 Bug 2027209 - Update invalidHeaderValue and contentEncodingError Felt Privacy error page content - r=fluent-reviewers,bolsson,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D295031
2026-04-17 22:52:54 +00:00
Jack Brown 8ae2dfe2c7 Bug 2025049 - Implement clock skew detection in Felt Privacy error page - r=niklas,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D289020
2026-04-14 03:39:46 +00:00
Michael Kaply c3ad6470a6 Bug 2029040 - Add missing string and info about pages blocked by policy. r=jaws,fluent-reviewers,bolsson,emz
Differential Revision: https://phabricator.services.mozilla.com/D292013
2026-04-09 19:50:20 +00:00
Jack Brown 1848de0b8f Bug 2027494 - Fix no-connection illustration not showing on Work Offline error page - r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D291074
2026-04-09 03:58:10 +00:00
Jack Brown 42f75b4164 Bug 2024150 - Show new error page for SSL_ERROR_RX_RECORD_TOO_LONG and unregistered NSS errors, fix deniedPortAccess intro text - r=niklas,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D288545
2026-04-08 02:32:13 +00:00
Atila Butkovits 09773fcd04 Revert "Bug 2024150 - Show new error page for SSL_ERROR_RX_RECORD_TOO_LONG and unregistered NSS errors, fix deniedPortAccess intro text - r=niklas,fluent-reviewers,bolsson" for causing failures at browser_clientAuth_connection.js.
This reverts commit 71b2e73dc2.
2026-04-03 02:58:48 +00:00
Jack Brown 71b2e73dc2 Bug 2024150 - Show new error page for SSL_ERROR_RX_RECORD_TOO_LONG and unregistered NSS errors, fix deniedPortAccess intro text - r=niklas,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D288545
2026-04-03 00:12:30 +00:00
Silaghi 49341311d4 Revert "Bug 2024150 - Show new error page for SSL_ERROR_RX_RECORD_TOO_LONG and unregistered NSS errors, fix deniedPortAccess intro text - r=niklas,fluent-reviewers,bolsson" for causing bc failures at aboutCertError_mitm.js
This reverts commit 7b0d78e962.
2026-03-31 22:29:18 +00:00
Jack Brown 7b0d78e962 Bug 2024150 - Show new error page for SSL_ERROR_RX_RECORD_TOO_LONG and unregistered NSS errors, fix deniedPortAccess intro text - r=niklas,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D288545
2026-03-31 21:35:34 +00:00
Jack Brown 73bb510dbd Bug 2018850 - Show accurate messaging on file:// not-found error pages - r=niklas,fluent-reviewers,flod
Replace the generic network-error copy on the fileNotFound error card
with file-specific strings. The intro now shows the actual file path
instead of "local file", and the "What can you do?" section gives
file-oriented advice rather than website-oriented advice.

Differential Revision: https://phabricator.services.mozilla.com/D284735
2026-03-26 02:27:39 +00:00
Jack Brown 1b63ed2a3b Bug 2023800 - Show accurate server error message and status code on HTTP error pages - r=niklas,fluent-reviewers,flod,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D288540
2026-03-24 08:56:37 +00:00
Silaghi dd02407bc9 Revert "Bug 2018850 - Show accurate messaging on file:// not-found error pages - r=niklas,fluent-reviewers,flod" for causing xpcshell failures at rust/localization-ffi/src/lib.rs
This reverts commit 33befc4e9f.
2026-03-20 08:30:35 +00:00
Jack Brown 33befc4e9f Bug 2018850 - Show accurate messaging on file:// not-found error pages - r=niklas,fluent-reviewers,flod
Replace the generic network-error copy on the fileNotFound error card
with file-specific strings. The intro now shows the actual file path
instead of "local file", and the "What can you do?" section gives
file-oriented advice rather than website-oriented advice.

Differential Revision: https://phabricator.services.mozilla.com/D284735
2026-03-20 07:00:10 +00:00
Jack Brown a729ef7f53 Bug 2019611 - Fix netTimeout error to use correct l10n IDs and whole origin with subdomains - r=niklas,fluent-reviewers,bolsson,desktop-theme-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D285332
2026-03-20 02:02:12 +00:00
Jack Brown f42013f1bf Bug 2021449 - Restore Felt Privacy error pages for Work Offline mode - r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D286409
2026-03-18 14:35:25 +00:00
Jack Brown 0e0f8d4a8d Bug 2021126 - Increase test coverage and fix incorrect test assertion in error page registry - r=niklas
Fix an incorrect assertion in test_unknown_error_returns_default that
passed only by loose-equality coincidence (undefined == null). Add tests
for previously untested exports: getAllErrorIds, getErrorCount,
initializeRegistry, resolveDescriptionParts, resolveAdvancedConfig,
resolveManyL10nArgs, and l10n id/arg configurations defined as
functions.

Differential Revision: https://phabricator.services.mozilla.com/D286148
2026-03-17 23:37:45 +00:00
Jack Brown 08340647c7 Bug 2022033 - Refactor net error illustrations into a shared object and add alt text - r=niklas,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D287231
2026-03-17 23:37:14 +00:00
Serban Stanca 7fca5443ab Revert "Bug 2018850 - Show accurate messaging on file:// not-found error pages - r=niklas,fluent-reviewers,flod" for causing several mochitests failures.
This reverts commit 1c04cf3880.
2026-03-10 01:02:57 +00:00
Jack Brown 1c04cf3880 Bug 2018850 - Show accurate messaging on file:// not-found error pages - r=niklas,fluent-reviewers,flod
Replace the generic network-error copy on the fileNotFound error card
with file-specific strings. The intro now shows the actual file path
instead of "local file", and the "What can you do?" section gives
file-oriented advice rather than website-oriented advice.

Differential Revision: https://phabricator.services.mozilla.com/D284735
2026-03-09 20:54:32 +00:00
Alexandru Marc e293a152b5 Revert "Bug 2018850 - Show accurate messaging on file:// not-found error pages - r=niklas,fluent-reviewers,flod" for causing bc failures @ browser_aboutNetError_fileNotFound
This reverts commit 08946c444e.
2026-03-05 16:18:22 +00:00
Jack Brown 08946c444e Bug 2018850 - Show accurate messaging on file:// not-found error pages - r=niklas,fluent-reviewers,flod
Replace the generic network-error copy on the fileNotFound error card
with file-specific strings. The intro now shows the actual file path
instead of "local file", and the "What can you do?" section gives
file-oriented advice rather than website-oriented advice.

Differential Revision: https://phabricator.services.mozilla.com/D284735
2026-03-05 15:11:29 +00:00
Cristian Tuns 753e7952b6 Revert "Bug 2018850 - Show accurate messaging on file:// not-found error pages - r=niklas,fluent-reviewers,flod" for causing bc failures in browser_aboutNetError_fileNotFound.js
This reverts commit c3a3b09114.
2026-03-03 21:30:47 +00:00
Jack Brown c3a3b09114 Bug 2018850 - Show accurate messaging on file:// not-found error pages - r=niklas,fluent-reviewers,flod
Replace the generic network-error copy on the fileNotFound error card
with file-specific strings. The intro now shows the actual file path
instead of "local file", and the "What can you do?" section gives
file-oriented advice rather than website-oriented advice.

Differential Revision: https://phabricator.services.mozilla.com/D284735
2026-03-03 20:13:43 +00:00
Niklas Baumgardner 266417454a Bug 2012592 - Add error page for VPN errors. r=ip-protection-reviewers,fluent-reviewers,bolsson,fchasen,desktop-theme-reviewers,jbrown,hjones
Differential Revision: https://phabricator.services.mozilla.com/D282010
2026-02-19 01:43:02 +00:00
Jack Brown 733d866563 Bug 2009206 - Refactor description resolvers - r=niklas,devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D281699
2026-02-16 22:40:57 +00:00
Jack Brown a1dffeffbd Bug 2009206 - Remove advanced resolvers - r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D281690
2026-02-16 22:40:54 +00:00
Jack Brown a8ecadeea3 Bug 2009206 - Restore HSTS text that explains why error can't be bypassed - r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D281567
2026-02-16 22:40:51 +00:00
Jack Brown 0fe05ed57c Bug 2009206 - Rename context arguments in error-lookup.mjs - r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D281509
2026-02-16 22:40:45 +00:00
Jack Brown c2ce3a3baf Bug 2009206 - Refactor advanced section resolvers - r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D281504
2026-02-16 22:40:41 +00:00
Jack Brown c43a8cf178 Bug 2009206 - Remove findSupportedErrorCode - r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D281476
2026-02-16 22:40:38 +00:00
Jack Brown 39e3868ab3 Bug 2009206 - Rename introContent params - r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D281475
2026-02-16 22:40:35 +00:00
Jack Brown 7f05acefea Bug 2009206 - Migrate remaining legacy errors to Felt Privacy experience, remove useLegacy flag - r=niklas,hjones
Differential Revision: https://phabricator.services.mozilla.com/D280682
2026-02-16 22:40:32 +00:00
Jack Brown 6a2691c61f Bug 2009206 - Added id fields to all error configs, removed CUSTOM_ERROR_CODE_MAP - r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D280326
2026-02-16 22:40:29 +00:00
Jack Brown 7c38ea39d8 Bug 2009206 - Moved image selection to the error configs. - r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D280265
2026-02-16 22:40:25 +00:00
Jack Brown 49afd8e53f Bug 2009206 - Added an advancedResolver, fixed missing page content, added missing error configs, fixed tests. - r=niklas
**Advanced Content Resolver Refactoring**
- Replaced string-based resolver references with inline arrow functions directly in error configurations.
- Removed the `ADVANCED_RESOLVERS` lookup object from error-lookup.mjs.
- Updated expired certificate and not-yet-valid certificate configs to use inline `whyDangerousResolver` functions that dynamically determine date-based error messages.

**Array-Based Intro Content Support**
- Enhanced `resolveL10nArgs()` to handle arrays of l10n configurations.
- Updated SSL error configs (`SSL_ERROR_RX_MALFORMED_HANDSHAKE`, `SSL_ERROR_UNSUPPORTED_VERSION`, `SSL_ERROR_PROTOCOL_VERSION_ALERT`) to use array-based intro content.
- Modified NetErrorCard to render multiple localized spans when intro content is an array.

**Error Configuration Cleanup**
- Removed `pageTitleL10nId` field from all error configs across cert-errors.mjs, net-errors.mjs, pkix-errors.mjs, and ssl-errors.mjs.
- Added missing `whatCanYouDoL10nId` and `learnMoreL10nId` to `SEC_ERROR_CERT_SIGNATURE_ALGORITHM_DISABLED`.
- Added `SSL_ERROR_PROTOCOL_VERSION_ALERT` as a new supported error code.

**TLS Version Notice Support**
- Added showTlsNotice property and `tlsNoticeTemplate()` method to NetErrorCard.
- Updated `handleNSSFailure()` integration to detect version errors and show TLS notice.
- Added tlsNotice query selector for the notice element.

**Dynamic Title Resolution**
- Changed NetErrorCard to dynamically resolve bodyTitleL10nId from error config instead of hardcoding it.
- Added titleL10nId to default error config as fallback

Differential Revision: https://phabricator.services.mozilla.com/D279445
2026-02-16 22:40:19 +00:00
Jared Wein 5252de3729 Bug 2009206 - Add some more error codes to the registry, need to fix configurations for them - r=niklas
Adds three new error configurations to the error registry:
`SEC_ERROR_CERT_SIGNATURE_ALGORITHM_DISABLED`
`SSL_ERROR_RX_MALFORMED_HANDSHAKE`
`SSL_ERROR_UNSUPPORTED_VERSION`

Differential Revision: https://phabricator.services.mozilla.com/D279382
2026-02-16 22:40:16 +00:00