Daniel Holbert
61d9a712bc
Bug 2043068: Use MakeRefPtr to do allocation for various RefPtr variables in widget/. r=spohl
...
Differential Revision: https://phabricator.services.mozilla.com/D302922
2026-05-29 04:29:33 +00:00
Emilio Cobos Álvarez
1bd0da8bf7
Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug
...
As per the HTML terminology (https://html.spec.whatwg.org/#relevant )
Automatic rename using sed + lints.
Differential Revision: https://phabricator.services.mozilla.com/D297184
2026-05-02 22:04:17 +00:00
iulian moraru
480fc572da
Revert "Bug 2036439, Bug 2033243 - Deal with ownerGlobal -> documentGlobal rename in extensions. r=robwu,home-newtab-reviewers,mconley" for causing newtab failures.
...
This reverts commit 4f62279d01 .
Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug"
This reverts commit 91a4ece356 .
Revert "Bug 2033243 - BindToOwner -> BindToGlobal. r=dom-core,smaug"
This reverts commit 5a95a889e1 .
Revert "Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug"
This reverts commit 7177a68e67 .
Revert "Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop"
This reverts commit 5263254690 .
2026-05-02 16:43:35 +00:00
Emilio Cobos Álvarez
7177a68e67
Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug
...
As per the HTML terminology (https://html.spec.whatwg.org/#relevant )
Automatic rename using sed + lints.
Differential Revision: https://phabricator.services.mozilla.com/D297184
2026-05-02 15:33:23 +00:00
rperta
d4cc71008d
Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug" on developer request
...
This reverts commit e58e122135 .
This reverts commit 84ca206f3e .
This reverts commit a7945292ed .
This reverts commit 367d83d299 .
2026-05-02 06:20:30 +00:00
Emilio Cobos Álvarez
a7945292ed
Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug
...
As per the HTML terminology (https://html.spec.whatwg.org/#relevant )
Automatic rename using sed + lints.
Differential Revision: https://phabricator.services.mozilla.com/D297184
2026-05-01 11:58:14 +00:00
agoloman
c814da612d
Revert "Bug 2033243 - Other miscellaneous ownerGlobal-related naming removal. r=dom-core,smaug" for causing multiple failures.
...
This reverts commit c7246654bc .
Revert "Bug 2033243 - BindToOwner -> BindToGlobal. r=dom-core,smaug"
This reverts commit 8873ddf33c .
Revert "Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug"
This reverts commit 8bf999e03c .
Revert "Bug 2033243 - Replace ownerGlobal with documentGlobal, and stop exposing ownerGlobal to JS. r=firefox-desktop-core-reviewers ,webidl,joschmidt,perftest-reviewers,sparky,smaug,mossop"
This reverts commit 7dea1af2e0 .
2026-04-30 20:13:14 +00:00
Emilio Cobos Álvarez
8bf999e03c
Bug 2033243 - Rename GetOwnerGlobal to GetRelevantGlobal. r=dom-core,media-playback-reviewers,credential-management-reviewers,webrtc-reviewers,dom-storage-reviewers,firefox-style-system-reviewers,dimi,janv,dshin,aosmond,smaug
...
As per the HTML terminology (https://html.spec.whatwg.org/#relevant )
Automatic rename using sed + lints.
Differential Revision: https://phabricator.services.mozilla.com/D297184
2026-04-30 17:47:11 +00:00
Emilio Cobos Álvarez
f097472815
Bug 2022763 - Propagate owner global from input element to DOM files properly. r=dom-core,win-reviewers,smaug,gstoll,devtools-reviewers,jdescottes
...
This required some refactoring of the MockFilePicker to test somewhat (ugh)
reliably, but hopefully an improvement.
Differential Revision: https://phabricator.services.mozilla.com/D288166
2026-04-18 10:00:15 +00:00
rperta
2b400e7aa3
Revert "Bug 2022763 - Propagate owner global from input element to DOM files properly. r=dom-core,win-reviewers,smaug,gstoll,devtools-reviewers,jdescottes" for causing bc failures at browser_screenshots_test_downloads.js This reverts commit 0f75054261.
2026-04-18 02:20:17 +00:00
Emilio Cobos Álvarez
0f75054261
Bug 2022763 - Propagate owner global from input element to DOM files properly. r=dom-core,win-reviewers,smaug,gstoll,devtools-reviewers,jdescottes
...
This required some refactoring of the MockFilePicker to test somewhat (ugh)
reliably, but hopefully an improvement.
Differential Revision: https://phabricator.services.mozilla.com/D288166
2026-04-17 22:25:42 +00:00
Atila Butkovits
ffcaa992e6
Revert "Bug 2022763 - Clean up existing usages of MockFilePicker.init(). r=dom-core,mtigley,extension-reviewers,credential-management-reviewers,devtools-reviewers,omc-reviewers,migration-reviewers,profiles-reviewers,layout-reviewers,emz,fchasen,nchevobbe,mconley,smaug,mossop,robwu,hanna_a,jwatt" for causing multiple failures.
...
This reverts commit 85b2d0d3dd .
Revert "Bug 2022763 - Propagate owner global from input element to DOM files properly. r=dom-core,win-reviewers,smaug,gstoll"
This reverts commit ff40c521b2 .
2026-04-17 10:52:18 +00:00
Emilio Cobos Álvarez
ff40c521b2
Bug 2022763 - Propagate owner global from input element to DOM files properly. r=dom-core,win-reviewers,smaug,gstoll
...
This required some refactoring of the MockFilePicker to test somewhat (ugh)
reliably, but hopefully an improvement.
Differential Revision: https://phabricator.services.mozilla.com/D288166
2026-04-17 09:07:32 +00:00
Sylvestre Ledru
4f6b8b516d
Bug 2023419 - Remove Emacs/Vim modelines from widget/ r=emilio
...
replaced by .editorconfig
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D287877
2026-03-16 17:22:02 +00:00
Edgar Chen
e63758d5b1
Bug 1960003 - Stop including UnionTypes.h from some headers; r=saschanaz,core-sessionstore-reviewers,farre
...
Differential Revision: https://phabricator.services.mozilla.com/D245261
2025-06-07 21:01:07 +00:00
Makoto Kato
b441849346
Bug 1674428 - Part 2. Add method to collect files that is selected WebKitDirectory. r=dom-core,sefeng
...
When using Android 13 or later, there is no permission to enumerate
directories if on user storage. So `GetFilesHelper` and etc won't work on
Android.
We have to use content resolver APIs to enumerate files in directory.
So I have to add a method to collect files in FilePicker and return
DOM Files.
Differential Revision: https://phabricator.services.mozilla.com/D228761
2025-03-07 12:44:07 +00:00
Edgar Chen
e4cb522cb9
Bug 1930101 - Move AsyncShowFilePicker to cocoa/nsFilePicker; r=win-reviewers,mac-reviewers,emilio,rkraesig,bradwerth
...
Then other plaforms don't need to implement Show() method.
No functional changes.
Differential Revision: https://phabricator.services.mozilla.com/D228418
2024-11-18 23:38:16 +00:00
Emilio Cobos Álvarez
4c840d573b
Bug 1925866 - NS_NewLocalFile's aFollowSymlinks arg is unused. r=xpcom-reviewers,necko-reviewers,valentin,media-playback-reviewers,win-reviewers,karlt,nika,rkraesig
...
Remove it and related functions, and update the callers.
Differential Revision: https://phabricator.services.mozilla.com/D226261
2024-10-22 09:38:16 +00:00
Ray Kraesig
2a7b3b1db5
Bug 1881329 - Revert addition of nsIFilePicker::Close() r=emilio
...
This function can't be implemented for Win32 (yet?), partly due to
internal architectural issues. (See bug 1870660 for more details.)
Remove the existing stubs (and perfectly-functional Gtk implementation)
as dead code until such time as they can be made live.
(This commit also reverts a fix to this code from bug 1872834 , which
should be restored if and when the rest of it is.)
Differential Revision: https://phabricator.services.mozilla.com/D214317
2024-07-01 15:47:46 +00:00
Gregory Pappas
3a68660a11
Bug 1878401 - part 1 - Pass BrowsingContext to nsIFilePicker::Init instead of mozIDOMWindow r=geckoview-reviewers,win-reviewers,emilio,nika,m_kato,rkraesig
...
This will improve the situation in bug 1878336
Differential Revision: https://phabricator.services.mozilla.com/D200546
2024-02-28 21:29:37 +00:00
Sandor Molnar
c853f2f3e9
Backed out 8 changesets (bug 1878401, bug 1879041) for causing build bustages on widget/nsBaseFilePicker.cpp CLOSED TREE
...
Backed out changeset 2e2b8df3bdd6 (bug 1879041)
Backed out changeset 6d6952f9df2c (bug 1878401)
Backed out changeset 30b5bb590d3e (bug 1878401)
Backed out changeset 9a4b830334b9 (bug 1878401)
Backed out changeset 3c3d67f1fcb7 (bug 1878401)
Backed out changeset c83ba4026822 (bug 1878401)
Backed out changeset 6bcb670ce475 (bug 1878401)
Backed out changeset f263b196df96 (bug 1878401)
2024-02-28 17:56:48 +02:00
Gregory Pappas
44b053ba1a
Bug 1878401 - part 1 - Pass BrowsingContext to nsIFilePicker::Init instead of mozIDOMWindow r=geckoview-reviewers,win-reviewers,emilio,nika,m_kato,rkraesig
...
This will improve the situation in bug 1878336
Differential Revision: https://phabricator.services.mozilla.com/D200546
2024-02-28 15:07:44 +00:00
Greg Stoll
df896d7e12
Bug 1872179 - Part 3: File picker file uploads consult content analysis r=rkraesig,win-reviewers
...
File picker upload operations check with any connected content analysis
tool before giving access to the web page.
Differential Revision: https://phabricator.services.mozilla.com/D198456
2024-01-22 13:56:07 +00:00
Oliver Medhurst
9e312ddb6c
Bug 1866517 - Part 1: Start implementing close method for file picker r=emilio
...
Implements it in IPC/base/etc, and also in GTK. Win32 and Cocoa do not implement it yet in this initial patch.
Differential Revision: https://phabricator.services.mozilla.com/D194631
2023-12-13 15:10:33 +00:00
Ray Kraesig
b8fd10dd87
Bug 1838244 - [1/1] Resolve special directory paths in the parent process r=gstoll
...
Avoid (one instance of) loading `shell32.dll` in the content process by
delaying the resolution of special-directory names to paths until
they're passed up into the client process.
Differential Revision: https://phabricator.services.mozilla.com/D180988
2023-06-15 20:04:06 +00:00
Ray Kraesig
1b07ab5c30
Bug 1816740 [6/6] - remove ManualDealloc from ColorPicker and FilePicker r=ipc-reviewers,nika
...
The existing manual-deallocation code isn't actually doing anything
interesting. Strip it out.
(No functional changes.)
Differential Revision: https://phabricator.services.mozilla.com/D169855
2023-02-22 21:05:25 +00:00
Ray Kraesig
3641a399e3
Bug 1816740 [5/6] - convert nsIFilePicker::capture* to a proper enum r=ipc-reviewers,karlt,mstange,handyman,nika
...
Convert the various capture* constants in nsIFilePicker into a proper
enum, and perform validation when passing it across IPC.
Additionally, unlike the previous two enums, reduce the size of
CaptureTarget to 8 bits. This is a workaround for its use with
nsAttrValue, which at present very specifically requires that parseable
enums' values fit within an `int16_t` -- and a `uint16_t` does not.
Differential Revision: https://phabricator.services.mozilla.com/D169854
2023-02-22 21:05:24 +00:00
Ray Kraesig
eb8a5041cb
Bug 1816740 [4/6] - convert nsIFilePicker::mode* into a proper enum r=ipc-reviewers,karlt,mstange,handyman,nika
...
Convert the various mode* constants in nsIFilePicker into a proper
enum, and perform validation when passing it across IPC.
Differential Revision: https://phabricator.services.mozilla.com/D169853
2023-02-22 21:05:24 +00:00
Ray Kraesig
c192386b3f
Bug 1816740 [3/6] - convert nsIFilePicker::result* into a proper enum r=ipc-reviewers,karlt,mstange,handyman,nika
...
Convert the various result* constants in nsIFilePicker into a proper
enum, and perform validation when passing it across IPC.
Differential Revision: https://phabricator.services.mozilla.com/D169852
2023-02-22 21:05:23 +00:00
Emilio Cobos Álvarez
7a9e682999
Bug 1780788 - Use abstract strings as in-arguments for ipdl. r=nika,necko-reviewers,media-playback-reviewers,alwu,dragana
...
This prevents copies and avoids the hack we have to avoid this, which
right now is using nsDependent{C,}String.
Non-virtual actors can still use `nsString` if they need to on the
receiving end.
Differential Revision: https://phabricator.services.mozilla.com/D152519
2022-07-25 20:19:48 +00:00
Simon Giesecke
46908cfb51
Bug 1660470 - Add missing include directives/forward declarations. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Simon Giesecke
aeac584c39
Bug 1626570 - Improve handling of copying arrays in widget/. r=jhorak
...
Differential Revision: https://phabricator.services.mozilla.com/D72321
2020-04-30 09:38:38 +00:00
Simon Giesecke
1ee0a47195
Bug 1613985 - Use default for equivalent-to-default constructors/destructors in widget. r=jmathies
...
Differential Revision: https://phabricator.services.mozilla.com/D66012
2020-03-16 10:56:57 +00:00
Bogdan Tara
22b0fa7e80
Backed out 4 changesets (bug 1613985) for causing build bustages CLOSED TREE
...
Backed out changeset fba0caac746c (bug 1613985)
Backed out changeset 8605d7a19107 (bug 1613985)
Backed out changeset 41e858fbf235 (bug 1613985)
Backed out changeset 847433cf1e0a (bug 1613985)
2020-03-16 12:41:41 +02:00
Simon Giesecke
36f6c9d797
Bug 1613985 - Use default for equivalent-to-default constructors/destructors in widget. r=jmathies
...
Differential Revision: https://phabricator.services.mozilla.com/D66012
2020-03-16 09:14:12 +00:00
Andrea Marchesini
b80e4fd342
Bug 1585284 - Force global in Blob CTOR, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D49629
2019-10-21 05:33:19 +00:00
Andrea Marchesini
e5c5bd4530
Bug 1585284 - Use nsIGlobalObject in any Blob/File CTOR, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D49392
2019-10-21 05:33:33 +00:00
Sylvestre Ledru
3067b10938
Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D41559
2019-08-13 07:15:25 +00:00
Dylan Roeh
0de07492da
Bug 1553603 - Support "capture" attribute in Gecko and expose in GV. r=geckoview-reviewers,smaug,snorp,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D38746
2019-07-30 18:13:05 +00:00
Barret Rennie
061fb21add
Bug 1289211 - Rename InfallibleTArray to nsTArray in widget/ r=jmathies
...
Differential Revision: https://phabricator.services.mozilla.com/D36969
2019-07-10 03:33:42 +00:00
Ryan Hunt
7144ca54c8
Bug 1534395 - Rename TabChild to BrowserChild. r=nika
...
This commit renames TabChild to BrowserChild.
Differential Revision: https://phabricator.services.mozilla.com/D28135
2019-04-09 17:39:01 -05:00
Dylan Roeh
381eef3c36
Bug 1514364 - Add appendRawFilter to nsIFilePicker to expose actual accept filters to GV for onFilePrompt. r=snorp, smaug
2019-01-24 10:21:05 -06:00
Sylvestre Ledru
e5a134f73a
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Kris Maglione
f67d651497
Bug 1484496: Part 2 - Add common base class for all nsISimpleEnumerator implementations. r=froydnj
...
In order to allow JS callers to use nsISimpleEnumerator instances with the JS
iteration protocol, we'll need to additional methods to every instance. Since
we currently have a large number of unrelated implementations, it would be
best if they could share the same implementation for the JS portion of the
protocol.
This patch adds a stub nsSimpleEnumerator base class, and updates all existing
implementations to inherit from it. A follow-up will add a new base interface
to this class, and implement the additional functionality required for JS
iteration.
Differential Revision: https://phabricator.services.mozilla.com/D3725
2018-08-18 14:22:47 -07:00
Kris Maglione
7e3b82a9eb
Bug 1462964: Remove obsolete nsIDOMBlob interface. r=bz
...
MozReview-Commit-ID: 2HIlaSrvfBe
2018-05-21 17:32:44 -07:00
Masatoshi Kimura
0204c8f25e
Bug 1387800 - Remove [deprecated] nsIFilePicker.show(). r=qdot
...
MozReview-Commit-ID: 81ZkeYdSPVW
2017-08-06 13:15:31 +09:00
Andrea Marchesini
b8849e9429
Bug 1357846 - Introducing nsIFilePicker.displaySpecialDirectory, r=smaug
...
nsIFilePicker.displaySpecialDirectory is a string that can be set to TmpD,
Desk, or any other special directory value. The real value of this directory
will be read in the parent process.
2017-04-26 18:20:19 +02:00
Andrea Marchesini
05ebbc4d1e
Bug 1358109 - Use IPCBlob in PFilePicker, r=smaug
2017-04-25 14:07:30 +02:00
Sebastian Hengst
5467076f99
Backed out changeset dec83a85f824 (bug 1358109) for failing mochitest dom/indexedDB/test/test_blob_worker_xhr_read_slice.html. r=backout
2017-04-24 15:44:10 +02:00
Andrea Marchesini
91df0ae011
Bug 1358109 - Use IPCBlob in PFilePicker, r=smaug
2017-04-24 12:16:49 +02:00