This reverts commit 40c8cb96f7.
Revert "Bug 1963712 - Allow GIF images in Windows Toast Notifications, r=nrishel,win-reviewers,saschanaz,omc-reviewers,aminomancer"
This reverts commit 4cd7bc1434.
This reverts commit 446248523d.
Revert "Bug 1369833 - Part 4: Use initWithObject instead of showAlertNotification in browser/ r=firefox-desktop-core-reviewers ,Gijs"
This reverts commit 9ee3a6db7f.
Revert "Bug 1369833 - Part 3: Remove unused showAlertNotification in dom/notification/test r=asuth"
This reverts commit 153cd95271.
Revert "Bug 1369833 - Part 2: Use initWithObject instead of showAlertNotification for WebExtensions r=extension-reviewers,willdurand"
This reverts commit e36669b3f8.
Revert "Bug 1369833 - Part 1: Add a way to init with an object r=nalexander,tschuster"
This reverts commit 5e7addaf77.
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
Destructing a handler doesn't always mean the corresponding notification is dead.
Given this patch is making RemoveHandler not call SendFinishing, it's being added to a few functions where needed.
Differential Revision: https://phabricator.services.mozilla.com/D202330
Destructing a handler doesn't always mean the corresponding notification is dead.
Given this patch is making RemoveHandler not call SendFinishing, it's being added to a few functions where needed.
Differential Revision: https://phabricator.services.mozilla.com/D202330
Destructing a handler doesn't always mean the corresponding notification is dead.
Given this patch is making RemoveHandler not call SendFinishing, it's being added to a few functions where needed.
Differential Revision: https://phabricator.services.mozilla.com/D202330
Longer term we should move this tracking fully to nsAlertsService, but given that:
* currently it's different how each alert backend tracks notification (e.g. only Windows has IsPrivate() and macOS has separate lists for pending/active alerts)
* consolidating that would probably require bigger changes
it would be nice to first centralize how the teardown step is triggered and then try consolidating further. (See also bug 1953657.)
Differential Revision: https://phabricator.services.mozilla.com/D241477
This would allow more conservative approach as we'll be able to reuse existing topics.
* alertactioncallback is now removed and instead fires alertclickcallback with a non-null subject.
* alerterror is now removed as observing alertshow/alertfinished together should suffice for that purpose (already being used by PNotification)
Not having separate alertactioncallback would also simplify future web API work, as it'll use the same click event but with an extra member in the event object. (https://notifications.spec.whatwg.org/#ref-for-dom-notificationevent-action)
Differential Revision: https://phabricator.services.mozilla.com/D239176
Making ENSURE_SUCCESS return the result of StealNSResult() ensures that
exceptions in the ErrorResult are deal with. We can then signal that through
WouldReportJSException.
Differential Revision: https://phabricator.services.mozilla.com/D214792
Making ENSURE_SUCCESS return the result of StealNSResult() ensures that
exceptions in the ErrorResult are deal with. We can then signal that through
WouldReportJSException.
Differential Revision: https://phabricator.services.mozilla.com/D214792
When `nsIWindowsAlertNotification`'s `handleActions` property is set to true, actions are sent in the notification observer's `aData` field instead of the notification cookie.
Differential Revision: https://phabricator.services.mozilla.com/D196613
Daniel Holbert