This reverts commit 312ba34b1e.
Revert "Bug 2039903 - Use nsIWidget::NativeModifiers for SynthesizeNativeKeyEvent. r=masayuki,win-reviewers,gstoll"
This reverts commit cdcd922a07.
Revert "Bug 2039903 - Use proper types for PBrowser::SynthesizeNativeMouseEvent. r=masayuki"
This reverts commit 45369938ed.
Revert "Bug 2039903 - Change from nsIWidget::Modifiers to nsIWidget::NativeModifiers. r=masayuki,geckoview-reviewers,win-reviewers,m_kato,gstoll"
This reverts commit 479f174ddb.
This is yet another attempt to get reasonable-looking thumbnails in the
taskbar for restored windows after they get resized. This time we're
actually signaling to invalidate the current thumbnail after the window
gets restored, which I'm hopeful will fix the issue.
As usual, this all works on my machine with a dev build :-/
Differential Revision: https://phabricator.services.mozilla.com/D269422
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It is replaced by a standard-conforming cast to (void) which is
understood the same by the compiler.
In some cases this could be replaced by `[[maybe_unused]]` but for
expression whose value is ignored, this requires storing to a temporary
variable first, so not going that way.
One notable change is that marking an object of type already_AddRefed as
unused used to implicitly leak memory. This is now made explicit.
Most of the heavy lifting was done through:
$ git grep -l '\<Unused\> <<' | xargs sed -i -e 's/Unused << /(void)/g'
$ git grep -l mozilla/Unused.h | xargs sed -i -e '/mozilla\/Unused.h/ d'
Differential Revision: https://phabricator.services.mozilla.com/D268706
It's particularly interesting to test TABBEDWINDOW vs. MAINWINDOW, but
there's no harm in making acrylic (TRANSIENTWINDOW) work, so do that
too.
Differential Revision: https://phabricator.services.mozilla.com/D241751
Remove `WinUtils::GetNativeMessage()`, which is now effectively always
the identity function.
Also, remove `MouseScrollHandler::NeedsMessage()` as dead code.
No functional changes.
Differential Revision: https://phabricator.services.mozilla.com/D236595
Remove the MouseScrollHandler::ProcessNative{MouseWheel,Scroll}Message()
functions as dead code.
Similarly, remove the now-unused mIsWaitingInternalMessage flag, its
getter, and all associated conditionals.
No functional changes.
Differential Revision: https://phabricator.services.mozilla.com/D236592
Remove `WinUtils::GetNativeMessage()`, which is now effectively always
the identity function.
Also, remove `MouseScrollHandler::NeedsMessage()` as dead code.
No functional changes.
Differential Revision: https://phabricator.services.mozilla.com/D236595
Remove the MouseScrollHandler::ProcessNative{MouseWheel,Scroll}Message()
functions as dead code.
Similarly, remove the now-unused mIsWaitingInternalMessage flag, its
getter, and all associated conditionals.
No functional changes.
Differential Revision: https://phabricator.services.mozilla.com/D236592
Remove `WinUtils::GetNativeMessage()`, which is now effectively always
the identity function.
Also, remove `MouseScrollHandler::NeedsMessage()` as dead code.
No functional changes.
Differential Revision: https://phabricator.services.mozilla.com/D236595
Remove the MouseScrollHandler::ProcessNative{MouseWheel,Scroll}Message()
functions as dead code.
Similarly, remove the now-unused mIsWaitingInternalMessage flag, its
getter, and all associated conditionals.
No functional changes.
Differential Revision: https://phabricator.services.mozilla.com/D236592
These messages aren't really Widget-relevant, even if they are
Windows-OS-relevant. Push them off into their own logging channel.
Differential Revision: https://phabricator.services.mozilla.com/D232574
When Windows keeps us from getting access to the clipboard because another
application is using it, this will report the exe that currently holds the
mutex.
Differential Revision: https://phabricator.services.mozilla.com/D227742
When Windows keeps us from getting access to the clipboard because another
application is using it, this will report the exe that currently holds the
mutex.
Differential Revision: https://phabricator.services.mozilla.com/D227742
Win11's tablet mode is different from Win10's tablet mode in ways both
subtle and gross. Avoid unifying them implicitly, and make it clear that
they should not be unified _explicitly_ without testing.
Unfortunately, Windows 11's API for checking whether the device is in
tablet mode is broken -- it requires one to know whether the device is a
tablet to interpret the return value, but there is no documented API
providing that information. We use a heuristic partly borrowed from
Chromium and partly based on independent investigation.
As all of the code using WindowsUIUtils effectively only checked for
Win10's tablet mode, this commit technically has no functional
changes.
Differential Revision: https://phabricator.services.mozilla.com/D224244
Tom Schuster