HeyPuter/firefox
1
0 Fork 0
mirror of https://github.com/HeyPuter/firefox.git synced 2026-11-13 20:14:57 -10:00
Code Issues Packages Projects Releases Wiki Activity
976,508 Commits 2 Branches 0 Tags
singlethreaded
Commit Graph
390 Commits
Author SHA1 Message Date
serge-sans-paille fac0f5e1a8 Bug 2041298 - Comply with clang-tidy's modernize-use-nullptr check for xpcom/ r=xpcom-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D301767
 2026-05-25 15:20:21 +00:00
Josh Aas 11e4c1519a Bug 2029516 - Fix link following behavior for GetCreationTime and GetCreationTimeOfLink on Unix-like platforms. r=xpcom-reviewers,nika 
Differential Revision: https://phabricator.services.mozilla.com/D292100
 2026-04-10 01:33:28 +00:00
Marco Bonardo cc4c2052d4 Bug 2021749. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D291958
 2026-04-08 12:56:21 +00:00
Mike Hommey a1c8f324d1 Bug 2029051 - Mark GetDiskAvailableSpace and GetDiskCapacity as unimplemented when statfs is not available. r=xpcom-reviewers,emilio 
This is similar to what we do for GetDiskInfo.

Differential Revision: https://phabricator.services.mozilla.com/D291927
 2026-04-03 06:26:31 +00:00
serge-sans-paille f81328e365 Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio 
The changeset has been generated automatically through:

    ./mach static-analysis check --output ./clang-tidy-bugprone.json --format json --fix

followed by manual adjustment when needed or when the auto-fixer bailed out.

This paves the way for Bug 2023527

Differential Revision: https://phabricator.services.mozilla.com/D287941
 2026-03-22 08:35:47 +00:00
Alexandru Marc 04e5f74151 Revert "Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio" 
This reverts commit a64dec2665.
 2026-03-19 17:29:58 +00:00
serge-sans-paille a64dec2665 Bug 2023519 - Make our codebase modernize-use-equals-default + modernize-use-equals-delete -safe wrt. clang-tidy r=sylvestre,necko-reviewers,media-playback-reviewers,profiler-reviewers,dom-storage-reviewers,layout-reviewers,dom-worker-reviewers,valentin,jesup,padenot,edenchuang,emilio 
The changeset has been generated automatically through:

    ./mach static-analysis check --output ./clang-tidy-bugprone.json --format json --fix

followed by manual adjustment when needed or when the auto-fixer bailed out.

This paves the way for Bug 2023527

Differential Revision: https://phabricator.services.mozilla.com/D287941
 2026-03-18 17:25:01 +00:00
Sylvestre Ledru 6149f49299 Bug 2023419 - Remove Emacs/Vim modelines from xpcom/ r=emilio 
replaced by .editorconfig
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D287878
 2026-03-16 17:22:07 +00:00
Josh Aas 9730073052 Bug 2016303: nsLocalFileUnix.cpp: Replace usage of LSCopyItemInfoForURL with CFURLCopyResourcePropertyForKey. r=xpcom-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D282976
 2026-02-13 13:33:30 +00:00
Josh Aas 34e9674a5d Bug 2016004 - Replace nsDirEnumeratorUnix new/init with ::Create. r=xpcom-reviewers,jstutte 
Differential Revision: https://phabricator.services.mozilla.com/D282744
 2026-02-12 08:16:42 +00:00
Josh Aas b6204c8292 Bug 2012097 - quiet warnings about failed stat operations in unix file code. r=xpcom-reviewers,mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D280223
 2026-01-23 15:09:40 +00:00
Josh Aas 71614f0362 Bug 2007075 - improve stat code for unix localfiles r=xpcom-reviewers,emilio 
In bug 456435 we effectively got rid of the stat cache for unix systems (including macOS). We continued to keep the stat object memory as part of files objects, and we continued to call it a cache, but stopped using it as a cache. Calling "FillStatCache", including via ENSURE_STAT_CACHE, always does a stat.

As the comment in the code today says:

// This stat cache holds the last stat - it does not invalidate.
// Call "FillStatCache" whenever you want to stat our file.
struct STAT mCachedStat;

The earlier patch was good in that it got rid of the flawed caching behavior, but the code that remains is confusing because it's not really being used as a cache. It's unclear and prone to future errors.

We should get rid of the references to caching and stop storing the stat struct as a member of nsLocalFile. Just clearly stat files where that's what's happening. This would be more clear and less prone to errors in the future.

Differential Revision: https://phabricator.services.mozilla.com/D277149
 2026-01-16 17:29:25 +00:00
Josh Aas 2fe6bf0fc7 Bug 1779696 - make Unix behavior match Windows during recursive file deletion. r=xpcom-reviewers,nika 
Differential Revision: https://phabricator.services.mozilla.com/D270965
 2026-01-14 21:23:42 +00:00
serge-sans-paille da7ceec18d Bug 1999703 - Remove unused STL header inclusions in xpcom/** r=nika,xpcom-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D272276
 2025-11-12 18:37:37 +00:00
Josh Aas ad17dd8f62 Bug 1997024 - remove support for encoding alias records in macOS filesystem code. r=spohl 
Differential Revision: https://phabricator.services.mozilla.com/D270444
 2025-11-05 15:18:57 +00:00
Josh Aas 8762d77351 Bug 1997086 - clean up comments in macOS and unix file code. r=mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D270493
 2025-10-29 22:15:43 +00:00
Josh Aas b406c68668 Bug 1997179 - assert unreachability in Unix nsLocalFile::LocateNativeLeafName if no root found. r=mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D270589
 2025-10-29 22:15:23 +00:00
Josh Aas 675cd4b211 Bug 1996943 - Drop support for getting an FSSpec via nsILocalFileMac. r=spohl 
Differential Revision: https://phabricator.services.mozilla.com/D270388
 2025-10-29 01:45:18 +00:00
Josh Aas be57d48739 Bug 1996951 - use common implementation of nsIFile::InitWithFile on macOS. r=mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D270392
 2025-10-28 20:16:41 +00:00
Josh Aas 173a98cdaa Bug 1996502 - nsILocalFileMac: Remove fileSizeWithResFork, openDocWithApp, bundleIdentifier, bundleContentsLastModifiedTime. r=spohl 
Differential Revision: https://phabricator.services.mozilla.com/D270098
 2025-10-27 20:24:17 +00:00
serge-sans-paille c961fa4a0b Bug 1993127 - Remove unused inclusion of Attributes.h from xpcom/* r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D269714
 2025-10-24 09:33:39 +00:00
Josh Aas be35232bf3 Bug 1995830 - Use non-deprecated API to determine if something is an application on macOS. r=spohl 
Differential Revision: https://phabricator.services.mozilla.com/D269796
 2025-10-24 00:40:58 +00:00
serge-sans-paille 1667ec582b Bug 1995723 - Remove unused inclusion of mozilla/ArrayUtils.h r=necko-reviewers,application-update-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,firefox-svg-reviewers,layout-reviewers,gstoll,canaltinova,bytesized,alwu,dholbert 
Differential Revision: https://phabricator.services.mozilla.com/D269573
 2025-10-23 07:30:37 +00:00
Josh Aas 336c2a0143 Bug 1995670 - Simplify logic in nsLocalFileUnix.cpp nsLocalFile::InitWithNativePath. r=xpcom-reviewers,mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D269532
 2025-10-22 14:54:17 +00:00
serge-sans-paille 762c4e6f4f Bug 1988834 - Use Base64 implementation from xpcom instead of nspr r=emilio,webrtc-reviewers,ng 
The xpcom interface avoids some extra computation, and decreases the
coupling with nspr.

Differential Revision: https://phabricator.services.mozilla.com/D264989
 2025-09-22 06:36:26 +00:00
Cristian Tuns 5eff5451c8 Revert "Bug 1988834 - Use Base64 implementation from xpcom instead of nspr r=emilio,webrtc-reviewers,ng" for causing build bustages in nsLocalFileUnix.cpp 
This reverts commit c6a42645df.
 2025-09-19 20:38:40 +00:00
serge-sans-paille c6a42645df Bug 1988834 - Use Base64 implementation from xpcom instead of nspr r=emilio,webrtc-reviewers,ng 
The xpcom interface avoids some extra computation, and decreases the
coupling with nspr.

Differential Revision: https://phabricator.services.mozilla.com/D264989
 2025-09-19 20:14:42 +00:00
Gijs Kruitbosch 46729af4ef Bug 1964385 - improve handling of .terminal files, r=mak,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D250229
 2025-05-30 10:18:24 +00:00
Sylvestre Ledru 8ae54ea4f9 Bug 1519636 - Reformat recent changes to the Google coding style r=geckoview-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,nalexander,gstoll,tcampbell,janv,julienw 
Updated with clang-format version 19.1.7 (taskcluster-DYvBxDZJRVqTi8E7pTSJAQ)

Differential Revision: https://phabricator.services.mozilla.com/D249880
 2025-05-17 19:11:13 +00:00
Oliver Old 054846ec0f Bug 1240005 - Users of do_CreateInstance or InitWithNativePath/InitWithPath not checking return value r=necko-reviewers,xpcom-reviewers,media-playback-reviewers,emilio,karlt,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D227280
 2024-11-25 16:54:11 +00:00
Jan Grulich c74d8979c4 Bug 1882079 - Fix wrong newline indentation in debug output r=stransky 
A simple fix for a wrong newline in the middle of debug outputs.

Differential Revision: https://phabricator.services.mozilla.com/D227944
 2024-11-05 11:42:30 +00:00
Emilio Cobos Álvarez 4c840d573b Bug 1925866 - NS_NewLocalFile's aFollowSymlinks arg is unused. r=xpcom-reviewers,necko-reviewers,valentin,media-playback-reviewers,win-reviewers,karlt,nika,rkraesig 
Remove it and related functions, and update the callers.

Differential Revision: https://phabricator.services.mozilla.com/D226261
 2024-10-22 09:38:16 +00:00
Jan Grulich c8affaf5e8 Bug 1882079 - Display real path when choosing download directory over portal r=settings-reviewers,Gijs,emilio 
Use the new API addition to Document portal allowing clients to get real
path to the exported document. This allows to still use the same path as
provided by the document portal, but display the path as exists on the
host side.

Differential Revision: https://phabricator.services.mozilla.com/D202717
 2024-06-28 19:31:13 +00:00
Norisz Fay 31c6f1a617 Backed out changeset 032d22e94bd3 (bug 1882079) for causing bustages on nsLocalFileUnix.cpp CLOSED TREE 2024-06-28 18:10:16 +03:00
Jan Grulich a2c79faafd Bug 1882079 - Display real path when choosing download directory over portal r=settings-reviewers,Gijs,emilio 
Use the new API addition to Document portal allowing clients to get real
path to the exported document. This allows to still use the same path as
provided by the document portal, but display the path as exists on the
host side.

Differential Revision: https://phabricator.services.mozilla.com/D202717
 2024-06-28 14:33:04 +00:00
Barret Rennie b001e6ddcd Bug 1796023 - Compare return value of readlink in nsLocalFileUnix::GetNativeTarget r=xpcom-reviewers,nika 
Differential Revision: https://phabricator.services.mozilla.com/D190987
 2023-10-23 16:58:25 +00:00
Vinny Diehl 1a0e29bba1 Bug 1847572 - Expand home directory paths for arbitrary users r=xpcom-reviewers,nika 
Differential Revision: https://phabricator.services.mozilla.com/D185999
 2023-10-04 16:48:47 +00:00
Stanca Serban ef1fd21038 Backed out changeset 65e974428cdb (bug 1847572) for causing gtest crashes. CLOSED TREE 2023-09-07 22:42:14 +03:00
Vinny Diehl c975993482 Bug 1847572 - Expand home directory paths for arbitrary users r=xpcom-reviewers,nika 
Differential Revision: https://phabricator.services.mozilla.com/D185999
 2023-09-07 18:35:59 +00:00
Kagami Sascha Rosylight 40205d2cc2 Bug 1788986 - Part 4: Add a counter for nsIFile r=xpcom-reviewers,nika,barret,janv 
This adds `count` out parameter for recursive file remove calls to report the number of the removed entries.

  Having a lot of files removed by `::Remove(recursive=true)` has been a problem, as a slow disk can cause a hang with such call. A counter feature will help us knowing the situation better via telemetry.

  The use of out parameter here is to mark it optional and prevent unwanted changes in existing callers (because a return value can't be optional).

Differential Revision: https://phabricator.services.mozilla.com/D156940
 2023-02-06 11:32:48 +00:00
Iulian Moraru 968971693d Backed out 3 changesets (bug 1788986) for causing xpcshell failures on test_backgroundtask_removeDirectory.js. CLOSED TREE 
Backed out changeset d288a5d5cc3d (bug 1788986)
Backed out changeset 7f30102942bc (bug 1788986)
Backed out changeset 8c8026379e91 (bug 1788986)
 2023-02-02 20:58:26 +02:00
Kagami Sascha Rosylight dd74ef8410 Bug 1788986 - Part 4: Add a counter for nsIFile r=xpcom-reviewers,nika,barret,janv 
This adds `count` out parameter for recursive file remove calls to report the number of the removed entries.

  Having a lot of files removed by `::Remove(recursive=true)` has been a problem, as a slow disk can cause a hang with such call. A counter feature will help us knowing the situation better via telemetry.

  The use of out parameter here is to mark it optional and prevent unwanted changes in existing callers (because a return value can't be optional).

Differential Revision: https://phabricator.services.mozilla.com/D156940
 2023-02-02 15:23:47 +00:00
Marco Bonardo fdd885e3fa Bug 1786188. r=Gijs,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D163275
 2022-11-30 13:32:19 +00:00
Valentin Gosu dadbc104f2 Bug 1801270 - Rename tentativeResult to statfsResult and quotaResult in nsLocalFile::GetDiskInfo r=jstutte 
Depends on D162374

Differential Revision: https://phabricator.services.mozilla.com/D163315
 2022-11-30 12:14:45 +00:00
Valentin Gosu 61e3733d8b Bug 1801270 - Always set aResult when returning NS_OK from GetDiskInfo r=xpcom-reviewers,jstutte 
Differential Revision: https://phabricator.services.mozilla.com/D162374
 2022-11-30 12:14:45 +00:00
Barret Rennie a11ba90df1 Bug 1786608 - Add nsIFile::accessTime{,OfLink} r=xpcom-reviewers,nika 
Differential Revision: https://phabricator.services.mozilla.com/D155926
 2022-11-20 22:37:17 +00:00
Cristian Tuns 2fb90fc205 Backed out 3 changesets (bug 1786608) for causing mochitest failures in test_ioutils_stat_set_modification_time.html CLOSED TREE 
Backed out changeset ac137b0db467 (bug 1786608)
Backed out changeset e593e8e2696b (bug 1786608)
Backed out changeset a3fd1df20b66 (bug 1786608)
 2022-11-17 00:50:54 -05:00
Barret Rennie a1b048e1dc Bug 1786608 - Add nsIFile::accessTime{,OfLink} r=xpcom-reviewers,nika 
Differential Revision: https://phabricator.services.mozilla.com/D155926
 2022-11-17 05:09:18 +00:00
Cristian Tuns 092144c233 Backed out 3 changesets (bug 1786608) for causing build bustages CLOSED TREE 
Backed out changeset 8eb603c625f4 (bug 1786608)
Backed out changeset 0df0cf8f67b4 (bug 1786608)
Backed out changeset 2b3815684692 (bug 1786608)
 2022-11-16 13:58:36 -05:00
Barret Rennie 2a2272bcc1 Bug 1786608 - Add nsIFile::accessTime{,OfLink} r=xpcom-reviewers,nika 
Differential Revision: https://phabricator.services.mozilla.com/D155926
 2022-11-16 18:31:57 +00:00