Commit Graph
868 Commits
Author SHA1 Message Date
Nipun Shukla 8c339c2a58 Bug 1912790 - Prevent Windows pinning notification from being shown twice r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D219063
2024-08-26 20:34:57 +00:00
Dave Townsend 92efa10eef Bug 1892400: Windows remote client should send the intended command line. r=jhirsch,rkraesig
Currently the windows client sends the current process command line which is
potentially an issue since some of those arguments may have been consumed
already. It will also not support sending custom command lines after startup.

This also switches to sending the UTF-8 command line we already have since that
matches other platforms better and makes some arguments const.

Differential Revision: https://phabricator.services.mozilla.com/D216031
2024-08-15 13:45:57 +00:00
Sandor Molnar d7f53c7f93 Backed out 6 changesets (bug 1892400) for Gtest failures CLOSED TREE
Backed out changeset 25b37643e1fe (bug 1892400)
Backed out changeset 7c12bcdfd937 (bug 1892400)
Backed out changeset bf5862fa2a1d (bug 1892400)
Backed out changeset a0bb5ed531ce (bug 1892400)
Backed out changeset beb16099057e (bug 1892400)
Backed out changeset 82111a5fc831 (bug 1892400)
2024-08-14 11:53:24 +03:00
Dave Townsend bb48be5f26 Bug 1892400: Windows remote client should send the intended command line. r=jhirsch,rkraesig
Currently the windows client sends the current process command line which is
potentially an issue since some of those arguments may have been consumed
already. It will also not support sending custom command lines after startup.

This also switches to sending the UTF-8 command line we already have since that
matches other platforms better and makes some arguments const.

Differential Revision: https://phabricator.services.mozilla.com/D216031
2024-08-14 06:57:51 +00:00
Dave Townsend 8814ffd2ef Bug 1906260: Remove the -no-remote command line argument. r=glandium,webdriver-reviewers,perftest-reviewers,application-update-reviewers,taskgraph-reviewers,nalexander,bhearsum,jdescottes,sparky
Differential Revision: https://phabricator.services.mozilla.com/D217569
2024-08-13 14:13:10 +00:00
Nipun Shukla 9044371423 Bug 1794159 - Part 3: Enable MSIX pinning in nsWindowsShellService r=nrishel,nalexander,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D217763
2024-08-12 17:05:48 +00:00
Nipun Shukla 72d8c3e995 Bug 1794159 - Part 2: Add LAF unlocking and check for pinning status using new APIs r=nalexander,nrishel
Differential Revision: https://phabricator.services.mozilla.com/D213331
2024-08-12 17:05:47 +00:00
Nipun Shukla 43442a6c30 Bug 1794159 - Part 1: Change C-style strings to nsString classes in LimitedAccessFeatures r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D217762
2024-08-12 17:05:47 +00:00
Narcis Beleuzu bc91793ab3 Backed out changeset f0866652e65f (bug 1906260) for bc failure on /browser_startup_mainthreadio.js . CLOSED TREE 2024-08-09 12:33:45 +03:00
Alexandre Lissy 155be95bb9 Bug 1907512 - Remove duplicated desktop files r=stransky
Differential Revision: https://phabricator.services.mozilla.com/D216050
2024-08-08 20:48:01 +00:00
Dave Townsend 5d4ad37c57 Bug 1906260: Remove the -no-remote command line argument. r=glandium,webdriver-reviewers,perftest-reviewers,application-update-reviewers,taskgraph-reviewers,nalexander,bhearsum,jdescottes,sparky
Differential Revision: https://phabricator.services.mozilla.com/D217569
2024-08-08 19:35:41 +00:00
pstanciu 4aef4243c2 Backed out 3 changesets (bug 1794159) for causing bc failures on browser_browserGlue_telemetry.js CLOSED TREE
Backed out changeset 764e14e5df4a (bug 1794159)
Backed out changeset 76b8d6cebe8b (bug 1794159)
Backed out changeset f28a29199ba8 (bug 1794159)
2024-08-08 11:16:27 +03:00
Nipun Shukla 9f77b85299 Bug 1794159 - Part 3: Enable MSIX pinning in nsWindowsShellService r=nrishel,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D217763
2024-08-08 02:48:50 +00:00
Nipun Shukla 8ab6d14094 Bug 1794159 - Part 2: Add LAF unlocking and check for pinning status using new APIs r=nalexander,nrishel
Differential Revision: https://phabricator.services.mozilla.com/D213331
2024-08-08 02:48:50 +00:00
Nipun Shukla c85c9a467d Bug 1794159 - Part 1: Change C-style strings to nsString classes in LimitedAccessFeatures r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D217762
2024-08-08 02:48:49 +00:00
Nipun Shukla 5d442069c0 Bug 1904436 - Implement private browser pinning using new Windows taskbar APIs r=nrishel,win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D214757
2024-08-07 13:12:20 +00:00
Sandor Molnar f5c1f4fe7c Backed out changeset 82cd657ce425 (bug 1906260) for causing mochitest failures @ test_interactive_widget.html & pup wd test failures CLOSED TREE 2024-08-06 18:06:20 +03:00
Dave Townsend b3f84cff12 Bug 1906260: Remove the -no-remote command line argument. r=glandium,webdriver-reviewers,perftest-reviewers,application-update-reviewers,taskgraph-reviewers,nalexander,bhearsum,jdescottes,sparky
Differential Revision: https://phabricator.services.mozilla.com/D217569
2024-08-06 11:46:07 +00:00
Joel Maher bd1a0e2de3 Bug 1909759 - s/preferences/settings/ for >= macosx 13.x. r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D217835
2024-07-26 16:22:15 +00:00
Stanca Serban 973a3fec8c Backed out changeset 0218b28ab8ed (bug 1904436) for crashes related to taskbar pinning. a=backout 2024-07-25 17:28:14 +03:00
Nipun Shukla 93c6531ceb Bug 1900035 - Added Windows start menu pinning to MSIX set-to-default and taskbar pinning scenarios r=omc-reviewers,firefox-desktop-core-reviewers ,Gijs,mpohle,aminomancer,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D212461
2024-07-24 21:13:35 +00:00
Nipun Shukla 627adad1af Bug 1904436 - Implement private browser pinning using new Windows taskbar APIs r=nrishel,win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D214757
2024-07-24 18:40:33 +00:00
Sylvestre Ledru a3ea006705 Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,necko-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,devtools-reviewers,anti-tracking-reviewers,profiler-reviewers,win-reviewers,migration-reviewers,padenot,mconley,nchevobbe,kershaw,gstoll,mstange,bytesized,m_kato
This new version of clang 17 also slightly changed the formatting.

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D215914
2024-07-17 11:15:31 +00:00
Norisz Fay d75ebb2a50 Backed out changeset d06c14636494 (bug 1904436) as requested for crashes related to Windows pinning to taskbar CLOSED TREE 2024-07-10 22:27:46 +03:00
Nipun Shukla 34c75b3d57 Bug 1904436 - Implement private browser pinning using new Windows taskbar APIs r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D214757
2024-07-09 19:23:19 +00:00
Nipun Shukla 289ec4a1dd Bug 1898094 - Implemented Windows Start Menu pinning APIs in nsIWindowsShellService r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D211114
2024-07-09 19:13:47 +00:00
Joel Maher d70349f2c5 Bug 1903845 - Add 'os_integration' tags to test manifests for faster image verification. r=aryx,jgilbert,settings-reviewers,media-playback-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,padenot,dao,aminomancer,Standard8,mconley
Differential Revision: https://phabricator.services.mozilla.com/D214969
2024-07-09 13:01:55 +00:00
Meg 8f07351683 Bug 1905379 - Clean up set default guidance notification check and update tests r=nrishel,negin
- Remove redundant check for `regRename` pref when deciding whether to show set default guidance notification
- Update guidance notification test helper to set `setDefaultBrowserUserChoice` to the same value as `...regRename` to make tests that include one-click being enabled more accurate.

These updates should not change the user experience.

Differential Revision: https://phabricator.services.mozilla.com/D215218
2024-07-03 14:41:46 +00:00
Tamas Szentpeteri 93f27874e0 Backed out changeset 50043205a8aa (bug 1905379) for causing mochitest failures on browser_download_preferred_action.js. CLOSED TREE 2024-07-02 19:20:10 +03:00
Meg 4c468ff89d Bug 1905379 - Clean up set default guidance notification check and update tests r=nrishel
- Remove redundant check for `regRename` pref when deciding whether to show set default guidance notification
- Update guidance notification test helper to set `setDefaultBrowserUserChoice` to the same value as `...regRename` to make tests that include one-click being enabled more accurate.

These updates should not change the user experience.

Differential Revision: https://phabricator.services.mozilla.com/D215218
2024-07-02 12:57:53 +00:00
Meg Viar 212619a587 Bug 1903416 - Add a pref to control the display of set default guidance notification r=nrishel,negin
Add a pref and nimbus variable to control whether users see set to default guidance notifications when one-click set to default is disabled. Windows only.

This patch supports the [[ https://experimenter.services.mozilla.com/nimbus/one-click-set-to-default-new-users/summary | one-click set to default guidance experiment ]].

Differential Revision: https://phabricator.services.mozilla.com/D214700
2024-06-24 20:50:38 +00:00
Barret Rennie 871e74ca58 Bug 1829412 - Simplify NimbusTestUtils.enrollmentHelper r=chumphreys,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,omc-reviewers,home-newtab-reviewers,thecount,issammani,aminomancer,mconley
The enrollmentHelper was much more complicated than it needed to be. The
internal asynchrony that required awaiting an additional promise was fixed in
bug 1773583.

The returned cleanup function is no longer async, so unnecessary awaits have
been removed. This also applies to enrollWithFeatureConfig, as it is a wrapper
around enrollmentHelper.

Differential Revision: https://phabricator.services.mozilla.com/D212318
2024-06-06 14:42:00 +00:00
Joel Maher 3318408dfe Bug 1898801 - Fix tests on mac which use python2 to use python3 on macosx 14.x+. r=gbrown
Differential Revision: https://phabricator.services.mozilla.com/D211604
2024-05-24 19:45:19 +00:00
Barret Rennie 66225d624b Bug 1883686 - Migrate shellService to use setPref for setDefaultBrowserUserChoice r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D204526
2024-05-21 20:04:53 +00:00
Nicholas Rishel c38ebcec1e Bug 1894865 - Concat nsStrings to avoid issues converting wide characters to char and back again. r=bytesized
Differential Revision: https://phabricator.services.mozilla.com/D210247
2024-05-21 02:37:10 +00:00
Sandor Molnar 0f4b2c2a80 Backed out changeset 6c952a8ea651 (bug 1894865) for causing build bustages @ browser/components/shell/nsWindowsShellServiceInternal.h CLOSED TREE 2024-05-20 22:06:06 +03:00
Nicholas Rishel 2e90f2e33e Bug 1894865 - Concat nsStrings to avoid issues converting wide characters to char and back again. r=bytesized
Differential Revision: https://phabricator.services.mozilla.com/D210247
2024-05-20 18:49:11 +00:00
Barret Rennie 6dbf58c7e9 Bug 1790428 - Remove ExperimentFakes.enrollWithRollout r=chumphreys
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.

Differential Revision: https://phabricator.services.mozilla.com/D209936
2024-05-16 17:15:58 +00:00
Sandor Molnar 0881a06ac2 Backed out changeset c9a936171ae4 (bug 1790428) for causing bc failures @ browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about_nimbus_impressions.js CLOSED TREE 2024-05-16 01:29:10 +03:00
Barret Rennie eeaac588c8 Bug 1790428 - Remove ExperimentFakes.enrollWithRollout r=chumphreys
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.

Differential Revision: https://phabricator.services.mozilla.com/D209936
2024-05-15 19:19:29 +00:00
Nipun Shukla 8fa18f7f5e Bug 1895744 - Implemented WRL StartupTask for MSIX launch on login r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D209718
2024-05-15 15:34:42 +00:00
Tamas Szentpeteri 833395877b Backed out 2 changesets (bug 1893341, bug 1895744) for causing bc failures in browser_windows_launch_on_login_msix.js. CLOSED TREE
Backed out changeset ce5384469c24 (bug 1893341)
Backed out changeset 658645fa9303 (bug 1895744)
2024-05-15 11:24:17 +03:00
Nipun Shukla 51e5f06d08 Bug 1895744 - Implemented WRL StartupTask for MSIX launch on login r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D209718
2024-05-15 02:54:55 +00:00
Cristian Tuns fc78328f7f Backed out changeset 9db188aa6dac (bug 1790428) for causing bc failures in browser_remotesettingsexperimentloader_remote_defaults.js CLOSED TREE 2024-05-14 18:00:11 -04:00
Barret Rennie 58a50459f7 Bug 1790428 - Remove ExperimentFakes.enrollWithRollout r=chumphreys
enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.

Differential Revision: https://phabricator.services.mozilla.com/D209936
2024-05-14 16:18:01 +00:00
Stanca Serban 736584d690 Backed out changeset bb686c6fb6c1 (bug 1883686) for causing mochitests failures in browser_setDefaultBrowser.js. 2024-05-09 00:48:58 +03:00
Barret Rennie b43bca5b24 Bug 1883686 - Migrate shellService to use setPref for setDefaultBrowserUserChoice r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D204526
2024-05-08 16:20:21 +00:00
Sandor Molnar 1206986d67 Backed out changeset 778d4c789ab7 (bug 1883686) for causing build bustages @ deps/AccessibleText.h CLOSED TREE 2024-05-08 17:24:49 +03:00
Barret Rennie 6d07cab913 Bug 1883686 - Migrate shellService to use setPref for setDefaultBrowserUserChoice r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D204526
2024-05-08 14:08:38 +00:00
Butkovits Atila 99d0c239a5 Backed out 2 changesets (bug 1893458, bug 1890634) for causing bustages at TaskbarPinningMetricsTests.cpp. CLOSED TREE
Backed out changeset 29ad5906bfb0 (bug 1890634)
Backed out changeset bfcfe75b775a (bug 1893458)
2024-05-02 00:22:14 +03:00