Commit Graph
28594 Commits
Author SHA1 Message Date
Alexandre Poirot 5b05cf4097 Bug 1916533 - [devtools] Always use native codepath when recording JS traces to the profiler output. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D220936
2024-09-04 11:49:41 +00:00
Alexandre Poirot 7006fb6f69 Bug 1916462 - [devtools] Enable tracer debugger sidebar by default. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D220910
2024-09-04 11:49:40 +00:00
Nicolas Chevobbe 9af9aa5f85 Bug 1915804 - [devtools] Add AbortController in SourceEditor to control event listeners. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D220684
2024-09-04 06:14:17 +00:00
Nicolas Chevobbe 29edeb0049 Bug 1911733 - [devtools] Use light-dark in variables.css. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D218618
2024-09-03 22:03:52 +00:00
Boris Chiou febd7b261f Bug 1911216 - Part 1: Add CSS selector parsing support for view transition pseudo-elements. r=layout-reviewers,firefox-style-system-reviewers,emilio,devtools-reviewers,nchevobbe
This adds the pasring support for:
1. `::view-transition`
2. `::view-transition-group(name)`
3. `::view-transition-image-pair(name)`
4. `::view-transition-old(name)`
5. `::view-transition-new(name)`

The `name` here is a `<custom-ident>` or `*`.

Differential Revision: https://phabricator.services.mozilla.com/D219713
2024-09-03 19:29:32 +00:00
Mark Banner ea82bec0f5 Bug 1916093 - Enable more documentation generation warnings as fatal. r=sylvestre,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D220766
2024-09-03 18:48:46 +00:00
Nicolas Chevobbe cc7cd0c231 Bug 1915857 - [devtools] Compute waterfall ticks color in CSS. r=devtools-reviewers,ochameau.
We define the tick colors in CSS, using relative color syntax to
add the alpha we want.
We set the highlighter-* variables as registered properties so
the computed value will be the end color, even if we use
the light-dark function.

Differential Revision: https://phabricator.services.mozilla.com/D220706
2024-09-03 15:00:55 +00:00
Nicolas Chevobbe 3a3ae50758 Bug 1915872 - [devtools] Make getColor rely on CSS variables computed values. r=devtools-reviewers,ochameau.
The function used to parse the variables.css file and do some regex matching
on the light/dark theme rules to extract the declaration value of a variable.

This patch makes the function simpler by getting the computed value of the
CSS variable, which automatically adapt to the current theme since we do set
`color-scheme` value properly when setting a theme.

In order for this to work properly, the variables that might be used in this
function need to be registered so the engine know they are colors.

We take this as an opportunity to rename the function to `getCssVariableColor`,
which is more explicit, and also make it take the actual CSS variable name,
and not only the suffix part that comes after `--theme-` for better grep-ability.

The test in browser_theme.js is adapted to reflect those changes.

Differential Revision: https://phabricator.services.mozilla.com/D220718
2024-09-03 15:00:54 +00:00
Nicolas Chevobbe 582f536939 Bug 1916258 - [devtools] Add colorSwatchReadOnly option for OutputParser. r=devtools-reviewers,ochameau.
The computed panel was already read only, but this was done
by checking the swatch class name directly in the output parser,
which is not ideal.
Here we have a proper setting, that we can use in the computed panel,
as well as in the variable tooltip, where we can't interact with
the swatches.
The pointer cursor is only added onto swatches that are a button
or have a button role.
Tests are updated accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D220819
2024-09-03 13:22:14 +00:00
Alexandre Poirot 5f19b26230 Bug 1914239 - [devtools] Unhighlight the paused frame when selecting a JavaScript Tracer frame. r=devtools-reviewers,nchevobbe
The paused frame will still be considered as selected from the point of view of stepping buttons, and shown with a grey background,
but will no longer be highlighted with a blue background.

Differential Revision: https://phabricator.services.mozilla.com/D219779
2024-09-03 10:19:02 +00:00
Nicolas Chevobbe 7f16f148da Bug 1915800 - [devtools] Add new line in conditional breakpoint panel on shift+Enter instead of alt+Enter. r=devtools-reviewers,ochameau.
This better matches what we do in the console inline mode.

Differential Revision: https://phabricator.services.mozilla.com/D220682
2024-09-03 06:32:03 +00:00
Nicolas Chevobbe 2c6ba76a91 Bug 1915435 - [devtools] Show checker under transluscent colors in color swatch. r=devtools-reviewers,ochameau.
We used to show the checker but this regressed at some point.
A stacking context is needed to put the pseudo element which
contains the checker below the swatch, so we create it on
the swatch container.
We take this as an opportunity to cleanup the swatch rules,
using CSS variables to control swatch and background sizes.
This allows us to share the same classes for the computed panel
swatches, which only need a different size.

Differential Revision: https://phabricator.services.mozilla.com/D220525
2024-09-02 21:04:45 +00:00
Nicolas Chevobbe 44fc3f8644 Bug 1915382 - [devtools] Migrate --rule-highlight-background-color to inspector-shared.css and rename it. r=devtools-reviewers,ochameau.
The variable is being used in inspector-swatches.css,
so it should be set in a shared stylesheet too.
The highlight of shape points on hover was broken,
so I took the opportunity to fix it here.

Differential Revision: https://phabricator.services.mozilla.com/D220513
2024-09-02 21:04:45 +00:00
Nicolas Chevobbe e6864821e1 Bug 1915382 - [devtools] Replace ruleview prefix with inspector in inspector shared CSS files. r=devtools-reviewers,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D220392
2024-09-02 21:04:44 +00:00
Nicolas Chevobbe 35ff058224 Bug 1915382 - [devtools] Refactor ruleview-colorswatch CSS rule. r=Itiel,devtools-reviewers.
Use inset and variables.

Differential Revision: https://phabricator.services.mozilla.com/D220391
2024-09-02 21:04:44 +00:00
Butkovits Atila ea018e77a3 Backed out changeset 3152a219f274 (bug 1914239) for causing failures at browser_dbg-javascript-tracer-sidebar.js. 2024-09-02 18:45:18 +03:00
Emilio Cobos Álvarez f7551929f8 Bug 1916098 - Remove appcontent box. r=dao,desktop-theme-reviewers,devtools-reviewers,tabbrowser-reviewers,nchevobbe
gNotificationBox doesn't go there anymore (it goes inside the toolbox),
so we have really no use for that.

Simplify how the devtools theme is set on the browser, so that it is set
on the root.

Differential Revision: https://phabricator.services.mozilla.com/D220769
2024-09-02 13:47:45 +00:00
Alexandre Poirot f42f3dd9cb Bug 1914239 - [devtools] Unhighlight the paused frame when selecting a JavaScript Tracer frame. r=devtools-reviewers,nchevobbe
The paused frame will still be considered as selected from the point of view of stepping buttons, and shown with a grey background,
but will no longer be highlighted with a blue background.

Differential Revision: https://phabricator.services.mozilla.com/D219779
2024-09-02 13:43:54 +00:00
Alexandre Poirot 18b04bc7de Bug 1915619 - [devtools] Fix trace selection from the timeline while being zoomed-in. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D220564
2024-09-02 13:20:40 +00:00
Alexandre Poirot 4e77f872e4 Bug 1909548 - [devtools] Display jstracer function argument values in preview popups. r=bomsy,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D217501
2024-09-02 13:20:39 +00:00
Alexandre Poirot ad6d4585e7 Bug 1909548 - [devtools] Removing unused Preview.css file. r=devtools-reviewers,jdescottes
Only Popup.css is actually used for popup previews.

Differential Revision: https://phabricator.services.mozilla.com/D219090
2024-09-02 13:20:39 +00:00
Nicolas Chevobbe 98c94d5273 Bug 1912868 - [devtools] Emit property-updated-by-dragging once the value was actually set. r=devtools-reviewers,jdescottes.
This will help make browser_rules_edit-size-property-dragging.js more robust and
will help to land the changes from Bug 1885232.

The order of assertions in browser_rules_edit-size-property-dragging.js is modified
to circumvent Bug 1913358.

Differential Revision: https://phabricator.services.mozilla.com/D218921
2024-09-02 13:15:21 +00:00
Nicolas Chevobbe ceb2a1bbcf Bug 1912399 - [devtools] Make sure tooltip arrow is on top of the tooltip body. r=devtools-reviewers,ochameau.
The arrow is already a triangle, so we can just set its background with the
tooltip background color.

Differential Revision: https://phabricator.services.mozilla.com/D219028
2024-09-02 12:42:50 +00:00
Julian Descottes c6e7ad0994 Bug 1913529 - [devtools] Fix propTypes warnings when using the debugger r=devtools-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D219367
2024-09-02 10:05:45 +00:00
Julian Descottes 90bb6ad318 Bug 1914863 - [devtools] Remove windowUtils cache in layout/utils.js r=devtools-reviewers,nchevobbe
This cache might keep destroyed windowUtils helpers in some scenarios involving navigations with a process change.
The regular getter is slightly slower, but the performance hit should not be noticeable.

Differential Revision: https://phabricator.services.mozilla.com/D220785
2024-09-02 09:47:14 +00:00
Andrea Marchesini 77c26f16b7 Bug 1913161 - Implement a max-age cap for cookies, r=devtools-reviewers,cookie-reviewers,timhuang,webdriver-reviewers,Sasha
Differential Revision: https://phabricator.services.mozilla.com/D219216
2024-09-02 07:57:30 +00:00
Nicolas Chevobbe 9bf6bf3136 Bug 1915799 - [devtools] Add focus-indicator on conditional breakpoint/log point panel. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D220681
2024-09-02 05:47:36 +00:00
Hubert Boma Manilla 323b231b0c Bug 1915636 - [devtools] Fix regression of tab key working with selected content in the js terminal r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D220678
2024-08-30 21:32:23 +00:00
Nicolas Chevobbe b09aa122b7 Bug 1915887 - [devtools] Center CSS variable tooltip value when no other section is visible.
Differential Revision: https://phabricator.services.mozilla.com/D220721
2024-08-30 15:57:08 +00:00
Nicolas Chevobbe dece54e2b1 Bug 1915555 - [devtools] Fix color contrast in CSS variable tooltip in dark-mode. r=devtools-reviewers,bomsy.
dquote>
dquote> The default dark-mode tooltip background is lighter than
dquote> the tooltip, which was causing some low contrast issues.
dquote> A solution might have been to define specific colors that
dquote> would work against such background, but this would be complex,
dquote> and brittle IMO.
dquote> The simpler solution is to make the tooltip background the
dquote> same as the rules view background, where we know our colors
dquote> have enough contrast, and introducing new ones have a higher
dquote> chance of having good contrast as it is upfront, in comparison
dquote> to the tooltip that you have to trigger.

Differential Revision: https://phabricator.services.mozilla.com/D220567
2024-08-30 15:08:02 +00:00
Julian Descottes 530ba0fd27 Bug 1915423 - [devtools] Update MDN compat data (131) r=devtools-reviewers,nchevobbe
Regular update + 1 test adjustment

Differential Revision: https://phabricator.services.mozilla.com/D220436
2024-08-29 11:45:26 +00:00
Stanca Serban deae773f19 Backed out changeset cee8b3d4ad60 (bug 1915423) for causing xpcshell failures in test_mdn-compatibility.js. CLOSED TREE 2024-08-29 14:22:07 +03:00
Gregory Pappas 68146534c6 Bug 1915014 - Remove fallback to hidden window in ParentProcessTargetActor._getInitialDocShell r=ochameau,firefox-desktop-core-reviewers
This was added in bug 1275942, which added the --wait-for-jsdebugger option.
I think it's not necessary because BrowserGlue.sys.mjs is loaded before
"command-line-handler" category runs[1], so the early blank window will
have already opened before DevToolsStartup.handleDebuggerFlag spins the
event loop[2].

Currently, the early blank window is not enabled on all platforms and
can be disabled by pref. To make it reliable for DevTools use, we will
forcefully create the early blank window regardless of OS or pref when
--wait-for-jsdebugger is passed to the application. I tested this patch
on macOS (where the early blank window is not enabled) and it works well.


[1] https://searchfox.org/mozilla-central/rev/3f193a8bb0759058c2f9a9d7761ad73bc6ffd4b1/toolkit/xre/nsAppRunner.cpp#5571-5573,5734-5737
[2] https://searchfox.org/mozilla-central/rev/1d4c27f9f166ce6e967fb0e8c8d6e0795dbbd12e/devtools/startup/DevToolsStartup.sys.mjs#1011,1037-1043

Differential Revision: https://phabricator.services.mozilla.com/D220171
2024-08-29 08:18:48 +00:00
Julian Descottes 350054ceb6 Bug 1915423 - [devtools] Update MDN compat data (131) r=devtools-reviewers,nchevobbe
Regular update + 1 test adjustment

Differential Revision: https://phabricator.services.mozilla.com/D220436
2024-08-29 08:00:34 +00:00
Stanca Serban 70d11b2cc5 Backed out changeset e04c427060e1 (bug 1915014) for causing OS X mochitests failures in browser_startup.js. 2024-08-29 09:54:16 +03:00
Nicolas Chevobbe 5053f14005 Bug 1915353 - [devtools] Fix error in OutputParser when parsing ParenthesisBlock. r=devtools-reviewers,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D220374
2024-08-29 04:56:13 +00:00
Hubert Boma Manilla a5b64ee88c Bug 1913693 - [devtools] Cleanup legacy code added to handle escaping out of the editor r=devtools-reviewers,jdescottes
After a bit of investigation it seems like the code in the `onKeyDown` event was added to work around
the source editor hijacking all the Tab and Shift + Tab key events. The source editor code responsible can be found here
https://searchfox.org/mozilla-central/rev/ea91f336d0004ca28c909da948cb363f3e560877/devtools/client/shared/sourceeditor/editor.js#311-346.
The debugger does not seem to use most of the config settings related to the tab.

Differential Revision: https://phabricator.services.mozilla.com/D219425
2024-08-28 21:44:53 +00:00
Tamas Szentpeteri 5738bda40d Backed out 2 changesets (bug 1909980, bug 1913161) for causing mochitest and wd failures related to cookies. CLOSED TREE
Backed out changeset 606b39b7dbfe (bug 1909980)
Backed out changeset 2ce372d2cff0 (bug 1913161)
2024-08-28 21:31:55 +03:00
Gregory Pappas d9ef635fd7 Bug 1915014 - Remove fallback to hidden window in ParentProcessTargetActor._getInitialDocShell r=ochameau,firefox-desktop-core-reviewers
This was added in bug 1275942, which added the --wait-for-jsdebugger option.
I think it's not necessary because BrowserGlue.sys.mjs is loaded before
"command-line-handler" category runs[1], so the early blank window will
have already opened before DevToolsStartup.handleDebuggerFlag spins the
event loop[2].

Currently, the early blank window is not enabled on all platforms and
can be disabled by pref. To make it reliable for DevTools use, we will
forcefully create the early blank window regardless of OS or pref when
--wait-for-jsdebugger is passed to the application. I tested this patch
on macOS (where the early blank window is not enabled) and it works well.


[1] https://searchfox.org/mozilla-central/rev/3f193a8bb0759058c2f9a9d7761ad73bc6ffd4b1/toolkit/xre/nsAppRunner.cpp#5571-5573,5734-5737
[2] https://searchfox.org/mozilla-central/rev/1d4c27f9f166ce6e967fb0e8c8d6e0795dbbd12e/devtools/startup/DevToolsStartup.sys.mjs#1011,1037-1043

Differential Revision: https://phabricator.services.mozilla.com/D220171
2024-08-28 17:42:15 +00:00
Andrea Marchesini 45de281573 Bug 1913161 - Implement a max-age cap for cookies, r=devtools-reviewers,cookie-reviewers,timhuang
Differential Revision: https://phabricator.services.mozilla.com/D219216
2024-08-28 15:16:57 +00:00
Butkovits Atila 48282434ec Backed out 2 changesets (bug 1913161, bug 1909980) for causing xpcshell failures at test_bug1321912.js. CLOSED TREE
Backed out changeset 0a3cd5d9f229 (bug 1909980)
Backed out changeset 8118def08de0 (bug 1913161)
2024-08-28 15:37:12 +03:00
Andrea Marchesini b578003e92 Bug 1913161 - Implement a max-age cap for cookies, r=devtools-reviewers,cookie-reviewers,timhuang
Differential Revision: https://phabricator.services.mozilla.com/D219216
2024-08-28 11:35:22 +00:00
Hubert Boma Manilla 9f025ea87a Bug 1913061 - [devtools] Fix crash when no editor and no next selected source r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D220086
2024-08-28 10:33:34 +00:00
Julian Descottes 9c0bde6b45 Bug 1913263 - [devtools] Handle generic keydown events in nodePicker even if no currentNode available r=devtools-reviewers,ochameau
Depends on D219804

Differential Revision: https://phabricator.services.mozilla.com/D219973
2024-08-27 13:16:48 +00:00
Julian Descottes 562caf3c68 Bug 1913263 - [devtools] Also prevent mozSystemGroup events while using the node picker r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D219804
2024-08-27 13:16:48 +00:00
Nicolas Chevobbe 9041e9be68 Bug 1915108 - [devtools] Localize variable tooltip computed value string. r=devtools-reviewers,jdescottes.
Depends on D219145

Differential Revision: https://phabricator.services.mozilla.com/D220228
2024-08-27 12:08:59 +00:00
Nicolas Chevobbe 11fbac6a5c Bug 1912006 - [devtools] Use OutputParser to display values in variable tooltip. r=devtools-reviewers,jdescottes.
Re-use the OutputParser options from the declaration so we can have similar
results than in the Rules view.

Differential Revision: https://phabricator.services.mozilla.com/D219145
2024-08-27 12:08:59 +00:00
pstanciu fbb266b306 Backed out changeset f89c9403564e (bug 1913161) for causing multiple failures. CLOSED TREE 2024-08-27 15:13:00 +03:00
Andrea Marchesini a170a65684 Bug 1913161 - Implement a max-age cap for cookies, r=devtools-reviewers,cookie-reviewers,timhuang
Differential Revision: https://phabricator.services.mozilla.com/D219216
2024-08-27 11:02:18 +00:00
Nicolas Chevobbe 5482373919 Bug 1912268 - [devtools] Display <empty> for empty custom properties in computed panel. r=devtools-reviewers,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D219144
2024-08-27 06:07:51 +00:00