Commit Graph
4006 Commits
Author SHA1 Message Date
Alexandre Poirot 5b05cf4097 Bug 1916533 - [devtools] Always use native codepath when recording JS traces to the profiler output. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D220936
2024-09-04 11:49:41 +00:00
Alexandre Poirot 7006fb6f69 Bug 1916462 - [devtools] Enable tracer debugger sidebar by default. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D220910
2024-09-04 11:49:40 +00:00
Alexandre Poirot 5f19b26230 Bug 1914239 - [devtools] Unhighlight the paused frame when selecting a JavaScript Tracer frame. r=devtools-reviewers,nchevobbe
The paused frame will still be considered as selected from the point of view of stepping buttons, and shown with a grey background,
but will no longer be highlighted with a blue background.

Differential Revision: https://phabricator.services.mozilla.com/D219779
2024-09-03 10:19:02 +00:00
Nicolas Chevobbe 7f16f148da Bug 1915800 - [devtools] Add new line in conditional breakpoint panel on shift+Enter instead of alt+Enter. r=devtools-reviewers,ochameau.
This better matches what we do in the console inline mode.

Differential Revision: https://phabricator.services.mozilla.com/D220682
2024-09-03 06:32:03 +00:00
Butkovits Atila ea018e77a3 Backed out changeset 3152a219f274 (bug 1914239) for causing failures at browser_dbg-javascript-tracer-sidebar.js. 2024-09-02 18:45:18 +03:00
Alexandre Poirot f42f3dd9cb Bug 1914239 - [devtools] Unhighlight the paused frame when selecting a JavaScript Tracer frame. r=devtools-reviewers,nchevobbe
The paused frame will still be considered as selected from the point of view of stepping buttons, and shown with a grey background,
but will no longer be highlighted with a blue background.

Differential Revision: https://phabricator.services.mozilla.com/D219779
2024-09-02 13:43:54 +00:00
Alexandre Poirot 18b04bc7de Bug 1915619 - [devtools] Fix trace selection from the timeline while being zoomed-in. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D220564
2024-09-02 13:20:40 +00:00
Alexandre Poirot 4e77f872e4 Bug 1909548 - [devtools] Display jstracer function argument values in preview popups. r=bomsy,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D217501
2024-09-02 13:20:39 +00:00
Alexandre Poirot ad6d4585e7 Bug 1909548 - [devtools] Removing unused Preview.css file. r=devtools-reviewers,jdescottes
Only Popup.css is actually used for popup previews.

Differential Revision: https://phabricator.services.mozilla.com/D219090
2024-09-02 13:20:39 +00:00
Julian Descottes c6e7ad0994 Bug 1913529 - [devtools] Fix propTypes warnings when using the debugger r=devtools-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D219367
2024-09-02 10:05:45 +00:00
Nicolas Chevobbe 9bf6bf3136 Bug 1915799 - [devtools] Add focus-indicator on conditional breakpoint/log point panel. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D220681
2024-09-02 05:47:36 +00:00
Hubert Boma Manilla a5b64ee88c Bug 1913693 - [devtools] Cleanup legacy code added to handle escaping out of the editor r=devtools-reviewers,jdescottes
After a bit of investigation it seems like the code in the `onKeyDown` event was added to work around
the source editor hijacking all the Tab and Shift + Tab key events. The source editor code responsible can be found here
https://searchfox.org/mozilla-central/rev/ea91f336d0004ca28c909da948cb363f3e560877/devtools/client/shared/sourceeditor/editor.js#311-346.
The debugger does not seem to use most of the config settings related to the tab.

Differential Revision: https://phabricator.services.mozilla.com/D219425
2024-08-28 21:44:53 +00:00
Hubert Boma Manilla 9f025ea87a Bug 1913061 - [devtools] Fix crash when no editor and no next selected source r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D220086
2024-08-28 10:33:34 +00:00
Nicolas Chevobbe 5ac2ff58d1 Bug 1890205 - [devtools] Use CodeMirror 6 to highlight syntax of breakpoint line in Breakpoints panel when cm6 is enabled. r=devtools-reviewers,bomsy.
A method is added to the source editor to handle syntax highlighting so we can
handle both cm5 and cm6.

As the rules for syntax highlighting in CodeMirror 6 were all defined in the `cm-editor`
class, we have to add a specific class that we can target for the previews,
and handle it in the light and dark CSS files.

Differential Revision: https://phabricator.services.mozilla.com/D219175
2024-08-26 05:16:38 +00:00
Julian Descottes b3199fda2b Bug 1914657 - [devtools] Move the network overrides to a shared toolbox reducer r=devtools-reviewers,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D219235
2024-08-23 17:19:58 +00:00
Hubert Boma Manilla 9f58803c47 Bug 1898204 - [devtools] Show cursor location as document selection changes r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D215787
2024-08-20 20:15:42 +00:00
Iulian Moraru 72dd47149b Backed out changeset 7f90a3644c28 (bug 1898204) for causing dt failures on browser_dbg-search-file.js. CLOSED TREE 2024-08-20 11:54:51 +03:00
Hubert Boma Manilla 0f2f04e940 Bug 1898204 - [devtools] Show cursor location as document selection changes r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D215787
2024-08-20 07:32:53 +00:00
Julian Descottes 4479511cb0 Bug 1913285 - [devtools] Stop using mask-image for source debugger icon r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D219229
2024-08-16 09:03:14 +00:00
Alexandre Poirot ae236bcb47 Bug 1685412 - [devtools] Enable browser_dbg-browser-toolbox-workers.js test. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D218076
2024-08-13 09:50:50 +00:00
Julian Descottes 1d385bf3ad Bug 1908095 - [devtools] Regenerate debugger mochitest sourcemap resources r=devtools-reviewers,nchevobbe
Depends on D218084

Differential Revision: https://phabricator.services.mozilla.com/D218349
2024-08-07 11:58:36 +00:00
Julian Descottes 2f670b84dd Bug 1908095 - [devtools] removeSessionDataEntry for webextension toolboxes and watcher targets r=ochameau,devtools-reviewers
Fix removing breakpoints in webextension toolboxes and watcher targets, add tests to cover both scenarios

Differential Revision: https://phabricator.services.mozilla.com/D218084
2024-08-07 11:58:36 +00:00
alexical a0fa98ad19 Bug 1906719 - Output native JS trace to the profiler r=ochameau,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D215933
2024-08-05 15:44:21 +00:00
Alexandre Poirot 37b729fea9 Bug 1871500 - [devtools] Display tracer function call arguments as inline previews. r=devtools-reviewers,nchevobbe
When selecting a trace in the debugger sidebar, we are opening the location
in CodeMirror, but compared to the Web Console input, we were missing the recorded JS values.
Let's try to display them similarly to inline previews.

Differential Revision: https://phabricator.services.mozilla.com/D197118
2024-08-02 06:56:06 +00:00
Nicolas Chevobbe 1e9c3e90b5 Bug 1910908 - [devtools] Use opaque background for inline preview. r=devtools-reviewers,ochameau.
Having an opaque background for inline preview makes it nicer
when the line gets highlighted.

Differential Revision: https://phabricator.services.mozilla.com/D218203
2024-08-01 06:49:43 +00:00
Nicolas Chevobbe 9120345208 Bug 1908918 - [devtools] Fix typo in debugger (interation) -> (interaction). r=devtools-reviewers,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D217098
2024-08-01 06:41:10 +00:00
Alexandre Poirot 753bfd10cd Bug 1909920 - [devtools] Avoid rendering duplicated frames because of using float instead of decimal for trace indexes. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D218192
2024-07-31 20:52:09 +00:00
Hubert Boma Manilla fa9944434b Bug 1905840 - [devtools] Maintain scroll positon when switching through documents r=devtools-reviewers,nchevobbe
This implements caching of scroll snapshots of each source openend in the editor

Differential Revision: https://phabricator.services.mozilla.com/D216922
2024-07-31 12:56:09 +00:00
Alexandre Poirot a441733f0e Bug 1866818 - [devtools] Enable the JS tracer on remote debugging. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
Display a warning message in the tracer sidebar when there could be a backward compat issue.

Differential Revision: https://phabricator.services.mozilla.com/D217745
2024-07-31 12:48:21 +00:00
Nicolas Chevobbe 552c9d0878 Bug 1909804 - [devtools] Fix ignored file style when tree node is selected. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D217674
2024-07-31 12:36:46 +00:00
Alexandre Poirot 34e0e44a23 Bug 1907977 - [devtools] Fix source text content of worker ESM loaded via ChromeUtils methods. r=devtools-reviewers,nchevobbe
Spidermonkey fails returning source text content via `Source.text` attribute.
It returns "[no source]" and the urlContents fallback was trying to keep using this instead
of the text content fetched via a request.

Differential Revision: https://phabricator.services.mozilla.com/D218003
2024-07-30 15:43:12 +00:00
Masayuki Nakano 528d09c312 Bug 1904279 - Get rid of dom.w3c_pointer_events.dispatch_click_as_pointer_event pref r=smaug,pip-reviewers,search-reviewers,devtools-reviewers,urlbar-reviewers,nchevobbe,dao,jteow,mconley
Keep supporting the pref makes a lot of `click`, `auxclick` and `contextmenu`
event creators complicated (and look messy).  So, let's delete it as soon as
possible.

Differential Revision: https://phabricator.services.mozilla.com/D217225
2024-07-30 06:49:42 +00:00
Alexandre Poirot 5968f06139 Bug 1909899 - [devtools] Do not show unexpected children in traces. r=devtools-reviewers,nchevobbe
The end index is meant to be exclusing (while the start is inclusive)

Differential Revision: https://phabricator.services.mozilla.com/D217730
2024-07-29 14:58:16 +00:00
Alexandre Poirot a4cb1e4574 Bug 1909899 - [devtools] Fix zooming on the last traced call tree. r=devtools-reviewers,nchevobbe
When zooming past the last top trace, i.e. on the last call tree,
we should be using the startIndex of unique top trace and nothing else.

Differential Revision: https://phabricator.services.mozilla.com/D217729
2024-07-29 14:58:15 +00:00
Alexandre Poirot 2017f29cce Bug 1909899 - [devtools] Ensure always rendering one trace when zooming on the end of the record. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D217728
2024-07-29 14:58:14 +00:00
Hubert Boma Manilla 1722dad3c8 Bug 1909594 - [devtools] Use the preview value to check the equality of the line content widget r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D217564
2024-07-25 18:11:31 +00:00
Stanca Serban f4543287df Backed out changeset 07d262b4af4e (bug 1909804) as requested by dev. CLOSED TREE 2024-07-25 19:31:00 +03:00
Nicolas Chevobbe d29abec74e Bug 1909804 - [devtools] Fix ignored file style when tree node is selected. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D217674
2024-07-25 15:14:16 +00:00
Alexandre Poirot 4c946b19bd Bug 1885054 - [devtools] Display tracer data in a debugger sidebar. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D204446
2024-07-22 18:49:43 +00:00
Sandor Molnar 0e45f1b380 Backed out changeset b6571a4222fb (bug 1885054) for causing bug 1909068 CLOSED TREE 2024-07-22 18:24:44 +03:00
Sandor Molnar c02b09f2a7 Backed out changeset 0cee63f307b9 (bug 1908918) for causing bug 1909068
Backed out changeset 0cee63f307b9 (bug 1908918)
2024-07-22 18:23:19 +03:00
Nicolas Chevobbe 4e52e779f7 Bug 1906587 - [devtools] Fix preview for this property access with bracket notation. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D217110
2024-07-22 09:19:31 +00:00
Nicolas Chevobbe bf4e419cbf Bug 1908918 - [devtools] Fix typo in debugger (interation) -> (interaction). r=devtools-reviewers,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D217098
2024-07-22 07:20:30 +00:00
Alexandre Poirot c2af106622 Bug 1885054 - [devtools] Display tracer data in a debugger sidebar. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D204446
2024-07-18 09:02:06 +00:00
Hubert Boma Manilla cf89b8860f Bug 1907259 - [devtools] Fix the hover breakpoint styling when line wrapping is on r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D216553
2024-07-16 20:43:39 +00:00
Alexandre Poirot 5e10385a3b Bug 1906496 - [devtools] Avoid throwing from debugger components when there is no selected source. r=devtools-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D216146
2024-07-15 13:34:42 +00:00
Hubert Boma Manilla 00b017592e Bug 1897755 - [devtools] Stop using e.pageX/pageY for mouse events r=devtools-reviewers,nchevobbe
In the DAMP tests we dispatch mouse-events, where `e.pageX/Y` or `e.screenX/Y` are 0 if they are not explicitly set.
So dependence on `pageX/Y` are therefore not reliable.
This patch removes the use of `pageX/Y` to determine the token positions for toolip previews.

To test this, just make sure that tooltip breakpoints still works.

Differential Revision: https://phabricator.services.mozilla.com/D216144
2024-07-11 11:24:50 +00:00
Alexandre Poirot 266545744b Bug 1906125 - [devtools] Fix arrows orientation of debugger accordion in RTL. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D216026
2024-07-10 21:25:47 +00:00
Alexandre Poirot 27ee6fdd0f Bug 1906125 - [devtools] Unify VirtualizedTree and Tree CSS and move SourcesTree specifics to Tree. r=devtools-reviewers,nchevobbe
- make them both use .theme-twisty to show an arrow icon.
- move some specifics stylings of SourcesTree to the base class.
- make SourcesTree use the arrow React component provided by Tree class.
- use .theme-twisty instead of .arrow (which already implements rotation and colors on expand). But it uses "open" instead of "expanded" classname.
  (VirtualizedTree was already using theme-twisty)

This impacts the Source Tree, ObjectInspector (console, debugger), Watch Expressions, memory panel (dominator view).

Differential Revision: https://phabricator.services.mozilla.com/D215637
2024-07-10 21:25:46 +00:00
Alexandre Poirot 56f1de2b31 Bug 1873060 - [devtools] Move JS tracer icon to the toolbox level. r=devtools-reviewers,nchevobbe
Also moving the LOG_METHODS from actors to specs so that the frontend
can import them from devtools/shared instead of devtools/server.

Differential Revision: https://phabricator.services.mozilla.com/D215085
2024-07-09 15:19:05 +00:00