Commit Graph
212 Commits
Author SHA1 Message Date
Alexandre Poirot 56f1de2b31 Bug 1873060 - [devtools] Move JS tracer icon to the toolbox level. r=devtools-reviewers,nchevobbe
Also moving the LOG_METHODS from actors to specs so that the frontend
can import them from devtools/shared instead of devtools/server.

Differential Revision: https://phabricator.services.mozilla.com/D215085
2024-07-09 15:19:05 +00:00
Sandor Molnar d22465071b Backed out 5 changesets (bug 1873060, bug 1906291) for causing talos perma failures @ jstracer/jstracer.js CLOSED TREE
Backed out changeset 6f0fa044aa35 (bug 1906291)
Backed out changeset 53b5ad4055ed (bug 1906291)
Backed out changeset d72f48618f38 (bug 1906291)
Backed out changeset 17873318ca4a (bug 1906291)
Backed out changeset f3c126a6f60b (bug 1873060)
2024-07-09 02:50:07 +03:00
Alexandre Poirot ca845feadc Bug 1873060 - [devtools] Move JS tracer icon to the toolbox level. r=devtools-reviewers,nchevobbe
Also moving the LOG_METHODS from actors to specs so that the frontend
can import them from devtools/shared instead of devtools/server.

Differential Revision: https://phabricator.services.mozilla.com/D215085
2024-07-08 13:10:39 +00:00
Emilio Cobos Álvarez a898423415 Bug 1902896 - Remove unnecessary fallback font family. r=devtools-reviewers,nchevobbe
system-ui should be enough. It's also equivalent to -apple-system on
macOS right now.

Differential Revision: https://phabricator.services.mozilla.com/D213881
2024-06-17 10:50:34 +00:00
Hubert Boma Manilla 4e49e8d2c5 Bug 1900475 - [devtools] Fix Proptypes boolean to bool r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D212490
2024-06-04 08:24:57 +00:00
artem manushenkov 0c607a8763 Bug 1731635 [devtools] Add option to disable split console r=nchevobbe,fluent-reviewers,devtools-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D204142
2024-03-27 06:34:50 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Nicolas Chevobbe 34cdb11876 Bug 1843309 - [devtools] Add aria-pressed attribute on toolbox toggle buttons. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D189741
2023-10-03 04:59:03 +00:00
Mark Banner 0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner 91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Nicolas Chevobbe 76fcf0fcdd Bug 1808708 - [devtools] Only show Alway-on-top button in about:debugging webextension toolboxes. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D166097
2023-01-05 17:25:44 +00:00
Alexandre Poirot 2c8165afbf Bug 1625939 - [devtools] Remove devtools.browsertoolbox.fission preference and remove old non-fission Browser Toolbox. r=nchevobbe,fluent-reviewers,flod,perftest-reviewers,kshampur
Differential Revision: https://phabricator.services.mozilla.com/D164699
2022-12-20 10:16:48 +00:00
Julian Descottes 15d8bdc5e0 Bug 1798859 - [devtools] Add label to always on top button for webextension toolbox r=nchevobbe,fluent-reviewers,flod
Added a blink animation instead of the transition as well. Added a border when hover/active.

Differential Revision: https://phabricator.services.mozilla.com/D161370
2022-11-07 07:58:03 +00:00
Hubert Boma Manilla 692eaaac2e Bug 1794367 - [devtools] Remove backward compatibility code for 105 r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158937
2022-10-10 15:29:38 +00:00
Alexandre Poirot 59fe57c052 Bug 1793396 - [devtools] Use absolute URLs in all usages of loader.lazyRequireGetter. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D158489
2022-10-03 18:57:13 +00:00
Alexandre Poirot 9beeb07755 Bug 1792847 - [devtools] Use absolute URLs to import modules in devtools/client/framework. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158373
2022-09-30 15:17:36 +00:00
Alexandre Poirot 4ff70fda6f Bug 1780912 - [devtools] Make the local web extension toolbox be always on top. r=nchevobbe,eemeli
This allows to keep the DevTools visible while interacting with the Firefox
window where the extension is running.

This behavior is enabled by default, but can be disable on-demand via a button
in the top toolbar.
Note that it requires to close and reopen the window/toolbox as platform APIs
disallow changing this behavior "live" on a given window.

Differential Revision: https://phabricator.services.mozilla.com/D155843
2022-09-15 07:31:31 +00:00
Alexandre Poirot 0f32f335e3 Bug 1789201 - [devtools] Expose Services as a global to all DevTools modules. r=perftest-reviewers,nchevobbe,julienw,AlexandruIonescu
This will help transition to ES Modules as this symbol is exposed to them.

$ sed -ie "/require(.Services.)/d" $(git grep -l 'require("Services")' devtools/)
$ sed -ie "/loader.lazyRequireGetter(this, .Services./d" $(git grep -l 'loader.lazyRequireGetter(this, "Services"' devtools/)
+ the edition of builtin-modules.js + eslintrc.js
+ manual eslint fixes
+ removal of devtools-services in the debugger, except for jest tests

Differential Revision: https://phabricator.services.mozilla.com/D156401
2022-09-09 07:22:51 +00:00
Noemi Erli 233f0fcdf4 Backed out 2 changesets (bug 1780912) for causing failures in browser_aboutdebugging_addons_debug_console.js CLOSED TREE
Backed out changeset d2360a2a3d70 (bug 1780912)
Backed out changeset 21f1e9031be0 (bug 1780912)
2022-09-08 01:59:18 +03:00
Alexandre Poirot ce1e1a4cbe Bug 1780912 - [devtools] Make the local web extension toolbox be always on top. r=nchevobbe,eemeli
This allows to keep the DevTools visible while interacting with the Firefox
window where the extension is running.

This behavior is enabled by default, but can be disable on-demand via a button
in the top toolbar.
Note that it requires to close and reopen the window/toolbox as platform APIs
disallow changing this behavior "live" on a given window.

Differential Revision: https://phabricator.services.mozilla.com/D155843
2022-09-07 21:00:17 +00:00
Alexandre Poirot 3cadeaeb46 Bug 1788536 - [devtools] Use descriptorType instead of a type decipher from toolbox URL. r=jdescottes
This helps having the right type, even if we open the toolbox without any search params
in about:devtools-toolbox URL.

Differential Revision: https://phabricator.services.mozilla.com/D156134
2022-09-02 09:10:01 +00:00
Nicolas Chevobbe a361a2ece2 Bug 1787685 - [devtools] Fix ChromeDebugToolbar styling in Windows High Contrast mode. r=jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D156274
2022-09-02 08:09:44 +00:00
Alexandre Poirot 531f08b810 Bug 1693686 - [devtools] Display the navigation buttons in WebExtension toolboxes. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D155563
2022-08-29 08:54:00 +00:00
Mark Banner 3387a89bc7 Bug 1786197 - Turn on ESLint rule for prefer-boolean-length-check for devtools. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D155167
2022-08-26 13:39:34 +00:00
Nicolas Chevobbe 1b481f44eb Bug 1776853 - [devtools] Add BrowserToolbox-specific toolbar. r=ochameau,jdescottes,fluent-reviewers,flod.
This adds an additional toolbar in the Browser Toolbox which will contain specific
tools and options.
At the moment we only display a couple input button to be able to switch from
Parent process only to multiprocess mode.
We remove the similar UI in the iframe picker and adapt the existing test.

A trait is added to not show the toolbar when debugging server where we wouldn't
get the `isSwitchingMode` property in `onTargetDestroyed`, as this can cause
misbehavior in various tool when switching between different modes.

Differential Revision: https://phabricator.services.mozilla.com/D150575
2022-08-01 09:33:17 +00:00
Bogdan Szekely 69bbe7a93b Backed out 5 changesets (bug 1777253, bug 1776853) for causing devtools failures on browser_console_modes.js CLOSED TREE
Backed out changeset dbd68a657d6f (bug 1777253)
Backed out changeset f401150fb142 (bug 1776853)
Backed out changeset 209aade12fc6 (bug 1776853)
Backed out changeset dc24308ff8ef (bug 1776853)
Backed out changeset ea98ed858bae (bug 1776853)
2022-08-01 10:43:40 +03:00
Nicolas Chevobbe c39cba2689 Bug 1776853 - [devtools] Add BrowserToolbox-specific toolbar. r=ochameau,jdescottes,fluent-reviewers,flod.
This adds an additional toolbar in the Browser Toolbox which will contain specific
tools and options.
At the moment we only display a couple input button to be able to switch from
Parent process only to multiprocess mode.
We remove the similar UI in the iframe picker and adapt the existing test.

A trait is added to not show the toolbar when debugging server where we wouldn't
get the `isSwitchingMode` property in `onTargetDestroyed`, as this can cause
misbehavior in various tool when switching between different modes.

Differential Revision: https://phabricator.services.mozilla.com/D150575
2022-08-01 06:55:54 +00:00
Alexandre Poirot 44a6b99c4a Bug 1770363 - [devtools] Introduce on-demand multiprocess browser toolbox. r=nchevobbe
This introduces a checkbox in the iframe dropdown to enable/disable multiprocess debugging live.
Switching between:
 - debugging only the main process (all documents, workers and priviledged JS)
 - debugging all the processes (same, for each process, we will debug documents, workers, JS, ...)

This helps significantly speed up the browser toolbox when debugging only parent process resources,
while still allowing to switch to debug everything when required.

Depends on D146891

Differential Revision: https://phabricator.services.mozilla.com/D148527
2022-06-20 10:12:31 +00:00
criss b77042dbdd Backed out 5 changesets (bug 1770363) for causing mochitest failures on browser_ext_addon_debugging_netmonitor.js
Backed out changeset d29f5041fd98 (bug 1770363)
Backed out changeset a91879be9b4a (bug 1770363)
Backed out changeset 27e78762006f (bug 1770363)
Backed out changeset 18a6433fd24a (bug 1770363)
Backed out changeset 5cdcd2318a9f (bug 1770363)
2022-06-16 21:57:46 +03:00
Alexandre Poirot c6c835f8de Bug 1770363 - [devtools] Introduce on-demand multiprocess browser toolbox. r=nchevobbe
This introduces a checkbox in the iframe dropdown to enable/disable multiprocess debugging live.
Switching between:
 - debugging only the main process (all documents, workers and priviledged JS)
 - debugging all the processes (same, for each process, we will debug documents, workers, JS, ...)

This helps significantly speed up the browser toolbox when debugging only parent process resources,
while still allowing to switch to debug everything when required.

Differential Revision: https://phabricator.services.mozilla.com/D148527
2022-06-16 17:19:06 +00:00
Tetsuharu Ohzeki ffcebd0019 Bug 1508688 - Add UNSAFE_ prefix to React deprecated lifecycle methods in devtools/client/framework/. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D149479
2022-06-16 10:03:09 +00:00
Greg Tatum a1fbf5cf93 Bug 1767537 - Update pseudolocalization docs; r=platform-i18n-reviewers,dminor
Differential Revision: https://phabricator.services.mozilla.com/D145374
2022-05-05 16:25:32 +00:00
Jan Odvarko d56b1500b0 Bug 1744752 - [devtools] Browser Toolbox documentation link should be fixed r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D137749
2022-02-04 13:20:42 +00:00
Greg Tatum 022b42f73c Bug 1580599 - Add pseudo-locale configuration to the browser toolbox; r=platform-i18n-reviewers,devtools-reviewers,fluent-reviewers,nchevobbe,dminor
This commit adds support for setting the pseudo-locale for the browser
UI directly from the Browser Toolbox. This places the icons in the same
place as the "Disable Popup Autohide" command. This will make it easier
for Firefox developers to test that their UI is properly localized.

The SVGs were optimized for size using an optimizer that dropped the
path precision and any extra tags. I tested that they work correctly in
both light and dark modes.

Pseudo-localization is documented here:
https://firefox-source-docs.mozilla.org/l10n/fluent/tutorial.html#pseudolocalization

After this patch lands I'll follow-up with updating that documentation.

Differential Revision: https://phabricator.services.mozilla.com/D134420
2022-01-10 17:09:17 +00:00
Greg Tatum 7bcaae147b Bug 1580599 - Migrate DevTools toolbox meatball menu to fluent; r=devtools-reviewers,fluent-reviewers,nchevobbe,flod
Differential Revision: https://phabricator.services.mozilla.com/D134419
2022-01-10 17:09:16 +00:00
Nicolas Chevobbe 241a974611 Bug 1730148 - [devtools] Use targetCommand to populate iframe picker when EFT is enabled. r=ochameau.
The iframe picker code is refactored a bit so it's easier to follow.
This patch makes it so we support both EFT and non EFT scenarios.

Differential Revision: https://phabricator.services.mozilla.com/D130241
2021-11-10 14:51:04 +00:00
Cristian Tuns f0b1f0f677 Backed out 5 changesets (bug 1738915, bug 1739061, bug 1730148) for causing mochitest failures on browser_resources_document_events.js CLOSED TREE DONTBUILD
Backed out changeset 24c1a120bb77 (bug 1739061)
Backed out changeset eb9953fd3252 (bug 1738915)
Backed out changeset 9bd72db885eb (bug 1730148)
Backed out changeset 819078e24fa6 (bug 1730148)
Backed out changeset a0e706688adc (bug 1730148)
2021-11-10 07:07:57 -05:00
Nicolas Chevobbe ac4ef999a6 Bug 1730148 - [devtools] Use targetCommand to populate iframe picker when EFT is enabled. r=ochameau.
The iframe picker code is refactored a bit so it's easier to follow.
This patch makes it so we support both EFT and non EFT scenarios.

Differential Revision: https://phabricator.services.mozilla.com/D130241
2021-11-10 10:44:51 +00:00
htmlHxcker be378d41c1 Bug 1709137 - Use Multilocalization Helper for the Toolbox l10n helper r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D128204
2021-10-12 16:50:00 +00:00
Hubert Boma Manilla 21d26a9df1 Bug 1630525 - [devtools] Merge all the BrowsingContext traits to the form() r=ochameau
The traits set on attach have been a source of intermittent failures.
See Bug 1726220

Differential Revision: https://phabricator.services.mozilla.com/D123293
2021-08-23 11:10:13 +00:00
Sam Foster af0a4c265d Bug 1699631 - Move the reload icon into toolkit. r=harry,preferences-reviewers,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D119554
2021-07-12 20:45:08 +00:00
Marian-Vasile Laza d5c0b4d67a Backed out changeset c47653711a25 (bug 1699631) for causing node devtools failures. CLOSED TREE 2021-07-12 21:04:22 +03:00
Sam Foster 7d0c8a043f Bug 1699631 - Move the reload icon into toolkit. r=harry,preferences-reviewers,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D119554
2021-07-12 17:26:16 +00:00
Alexandre Poirot 53ff042d9c Bug 1708635 - [devtools] Migrate usages of TargetFront.reload to TargetCommand.reloadTopLevelTarget. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D113936
2021-05-07 12:07:42 +00:00
Sandor Molnar 870749c7b1 Backed out 2 changesets (bug 1708635) for causing dt failures in devtools/client/responsive/test/browser/browser_device_change. CLOSED TREE
Backed out changeset 6bce4e61777b (bug 1708635)
Backed out changeset f15acee46be2 (bug 1708635)
2021-05-04 18:11:27 +03:00
Alexandre Poirot a086f7ff8c Bug 1708635 - Migrate usages of TargetFront.reload to TargetCommand.reloadTopLevelTarget. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D113936
2021-05-04 12:43:21 +00:00
John Bieling 384135720e Bug 1708793 - Use brandShortName in Devtools when inspecting an add-on. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D114010
2021-05-03 14:35:54 +00:00
Nicolas Chevobbe d8f4979868 Bug 1685985 - [devtools] Handle error count button like other toolbox buttons. r=jdescottes.
A button configuration is now created from _buildButtons so the error count button
is part of the `toolbarButtons` property on the toolbox.
An `updateErrorCountButton` updates the property of the button, and we call it
from the function that updates the error count, from which we also trigger a new
render for the toolbar.

This way updating the error count will go through the overflow logic we have in
the toolbar (to show the chevron or not).

A "side effect" of this is that an item is automatically created in the options
panel to disable the error count button. In order for it to work properly, we
need to add a preference to store its enabled state, as well as a specific
localized string for the input label.

browser_toolbox_error_count is updated to ensure that the error button isn't
displayed if it was disabled in the option panel, even if new errors are emitted.

browser_toolbox_options_disable_buttons was updated to reflect the changes made
to the error count button.

Differential Revision: https://phabricator.services.mozilla.com/D101569
2021-01-14 07:54:44 +00:00
Nicolas Chevobbe aa9ac25544 Bug 1109362 - [devtools] Show number of errors in Toolbox toolbar. r=jdescottes,Honza.
This patch displays an error icon matching the number
of errors handled in the console.
An error can be:
- a nsIScriptError that is not a warning
- a console.error call
- a console.assert call
- a 4xx or 5xx network call

The counter is handled via the resourceWatcher of the toolbox,
where we listen for the different resources we need.
Clearing the console from the UI or via console.clear resets
the error count.
Clicking on the icon opens the split console if it wasn't already.
Navigating clears the error count, except if the persist log
option is enabled in the console.

A test is added to ensure this works as expected.

Differential Revision: https://phabricator.services.mozilla.com/D100668
2021-01-07 09:19:08 +00:00
Ricky Stewart 31b8ca9716 Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00