Commit Graph
217 Commits
Author SHA1 Message Date
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Anna Yeddi e1ba7c0b2e Bug 1849021 - Temporarily fail-if some Tier 2 a11y_checks for DevTools while the larger a11y improvement work is in progress. r=Jamie,devtools-reviewers,nchevobbe,profiler-reviewers,julienw
Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests were temporarily fail-if'ed in the directory's browser.ini file. After the ongoing accessibility improvements work is completed, we'll need to re-run a11y-checks, investigate new failures, and for confirmed bugs individual defects should be filed.

When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.

Depends on D189007

Differential Revision: https://phabricator.services.mozilla.com/D186405
2023-10-09 18:20:23 +00:00
Cristian Tuns 896197e59e Backed out 30 changesets (bug 1854447, bug 1855491, bug 1854646, bug 1854520, bug 1854528, bug 1854506, bug 1854502, bug 1854443, bug 1854538, bug 1854525, bug 1854660, bug 1854514, bug 1854460, bug 1854625, bug 1854228, bug 1854517, bug 1854533, bug 1692110, bug 1854636, bug 1849021, bug 1854512, bug 1854522, bug 1854509, bug 1854452, bug 1854536, bug 1854531) for causing multiple tier 2 failures on a11y-checks. CLOSED TREE
Backed out changeset 5714b7239b70 (bug 1849021)
Backed out changeset 91e5d7de3484 (bug 1849021)
Backed out changeset cc3142b909f6 (bug 1854660)
Backed out changeset 76d2a8ae9c19 (bug 1854646)
Backed out changeset 36460a147684 (bug 1854636)
Backed out changeset c7529a962a8c (bug 1854625)
Backed out changeset 791f9b03ea96 (bug 1854538)
Backed out changeset bd3f3cb434a5 (bug 1854536)
Backed out changeset 16f4f5bdcaa7 (bug 1855491)
Backed out changeset 6258bab20196 (bug 1854533)
Backed out changeset 29dca16eee2e (bug 1854531)
Backed out changeset 3a69d2c3f562 (bug 1854528)
Backed out changeset 0c63a9ea8b34 (bug 1854525)
Backed out changeset 5795bb6187a5 (bug 1854522)
Backed out changeset 7d4a123a432f (bug 1854520)
Backed out changeset ec95287bd702 (bug 1854517)
Backed out changeset 9914c1481f0d (bug 1854514)
Backed out changeset 25d85e656905 (bug 1854512)
Backed out changeset 828657f2ab73 (bug 1854509)
Backed out changeset 9d8b2e14c375 (bug 1854506)
Backed out changeset 1b3ee1e46e12 (bug 1854502)
Backed out changeset 37c2ec0851dc (bug 1854460)
Backed out changeset c2a60a8fc2d3 (bug 1854452)
Backed out changeset 744a163f2bd1 (bug 1854447)
Backed out changeset 1a9629dae7d5 (bug 1854443)
Backed out changeset c3d5c1ba2a84 (bug 1854228)
Backed out changeset dcd05518b004 (bug 1692110)
Backed out changeset 1c65a4cb618c (bug 1692110)
Backed out changeset 603b891147bd (bug 1692110)
Backed out changeset 53e2fac79d84 (bug 1692110)
2023-10-07 14:43:05 -04:00
Anna Yeddi f069716c4e Bug 1849021 - Temporarily disable some Tier 2 a11y_checks for DevTools while the larger a11y improvement work is in progress. r=Jamie,devtools-reviewers,nchevobbe,profiler-reviewers,julienw
Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests were temporarily skipped in the directory's browser.ini file. After the ongoing accessibility improvements work is completed, we'll need to re-run a11y-checks, investigate new failures, and for confirmed bugs individual defects should be filed.

When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.

Differential Revision: https://phabricator.services.mozilla.com/D186405
2023-10-06 18:11:40 +00:00
Tom Marble 6c1231e2e8 Bug 1853244 - convert .ini manifests to .toml: batch 6 {caps,devtools,dom}/**/browser.ini r=jmaher,media-playback-reviewers,devtools-reviewers,profiler-reviewers,alwu,nchevobbe,canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D188856
2023-09-22 20:42:14 +00:00
Mark Banner 0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner 91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Mark Banner b3474f4614 Bug 1812977 - Remove now unnecessary import-globals-from statements in devtools. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D168071
2023-01-30 19:33:38 +00:00
Alexandre Poirot 59fe57c052 Bug 1793396 - [devtools] Use absolute URLs in all usages of loader.lazyRequireGetter. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D158489
2022-10-03 18:57:13 +00:00
Alexandre Poirot caaf5fa378 Bug 1792847 - [devtools] Use absolute URLs to import modules in devtools/client/inspector. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158375
2022-09-30 15:17:37 +00:00
Alexandre Poirot 0f32f335e3 Bug 1789201 - [devtools] Expose Services as a global to all DevTools modules. r=perftest-reviewers,nchevobbe,julienw,AlexandruIonescu
This will help transition to ES Modules as this symbol is exposed to them.

$ sed -ie "/require(.Services.)/d" $(git grep -l 'require("Services")' devtools/)
$ sed -ie "/loader.lazyRequireGetter(this, .Services./d" $(git grep -l 'loader.lazyRequireGetter(this, "Services"' devtools/)
+ the edition of builtin-modules.js + eslintrc.js
+ manual eslint fixes
+ removal of devtools-services in the debugger, except for jest tests

Differential Revision: https://phabricator.services.mozilla.com/D156401
2022-09-09 07:22:51 +00:00
Mark Banner 6d03c63e2d Bug 1330099 - Enable object-shorthand eslint rule. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D153567
2022-08-03 14:57:05 +00:00
Mark Banner 1e3410cbdd Bug 1782008 - Remove now unnecessary .eslintrc.js files. r=webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,denschub,rpl,alwu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D152736
2022-08-03 11:16:20 +00:00
Noemi Erli c9b2cebd5c Backed out changeset 7985a1fa0789 (bug 1764768) for causing multiple failures CLOSED TREE 2022-04-20 22:25:02 +03:00
Emilio Cobos Álvarez e1ac6cb990 Bug 1764768 - Don't truncate viewport units at computed value time. r=dholbert
Instead, make the behavior consistent across all <length-percentage>
values (by truncating instead of rounding). This is the already-existing
behavior for calc() and percentages, but with this patch we also apply
it to plain length-flavored <length-percentage> values (this is needed
to avoid regressing things like bug 989802).

Regular <length>s keep rounding, to preserve existing behavior. We can
consider changing that in a follow-up if need be.

Differential Revision: https://phabricator.services.mozilla.com/D143857
2022-04-20 17:22:36 +00:00
Sai Hemanth B f90ab5a879 Bug 1757816 - Use rule parameter in inspector EditingSession:getPropertyIndex. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D140439
2022-03-09 22:35:35 +00:00
Julian Descottes f9ac5700c1 Bug 1734725 - Ensure tests within devtools/client/inspector are https-first compliant r=nchevobbe
Depends on D127918

Differential Revision: https://phabricator.services.mozilla.com/D127964
2021-10-11 08:01:47 +00:00
Nicolas Chevobbe d27e201390 Bug 1733046 - [devtools] Hide Geometry highlighter on various user interaction. r=jdescottes.
The code was written to hide the geometry highlighter when:
- the nodepicker was selected
- another node was selected in the markup view
- a node was hovered in the markup view

but this wasn't working as intended, as the line setting
the first of the event listeners was throwing, and we
don't have tests for this.

This patch fixes the faulty line and adds a test to check
that the geometry highlighter does hide on those actions.
We take this opportunity to use an AbortController to handle
the removal of the event listeners added when starting the
geometry highlighter.

Differential Revision: https://phabricator.services.mozilla.com/D126885
2021-09-29 14:38:56 +00:00
Alexandre Poirot 4da661202f Bug 1729925 - [devtools] Avoid leaking Commands/DevToolsClient/Fronts when closing the toolbox. r=nchevobbe
Currently, we do leak the Toolbox/Inspector and some Documents when
closing the toolbox.
So that these classes are kept in memory, while not nullifying all its references
to client classes.

By adding these few nullications we can at least avoid leaking the fronts and commands.

(also fix a failure due to null markup.walker in browser_rules_add-rule-with-menu.js)

Differential Revision: https://phabricator.services.mozilla.com/D125535
2021-09-16 14:43:44 +00:00
Butkovits Atila 68a259ed57 Backed out 9 changesets (bug 1729925) for causing leaks. CLOSED TREE
Backed out changeset 509a0601481a (bug 1729925)
Backed out changeset ac9a15005a5b (bug 1729925)
Backed out changeset 331ffa0bd2f9 (bug 1729925)
Backed out changeset 22097d7a00c2 (bug 1729925)
Backed out changeset e9f40c89753f (bug 1729925)
Backed out changeset 14619c743301 (bug 1729925)
Backed out changeset 61dfd48f3409 (bug 1729925)
Backed out changeset 9b1eb369d679 (bug 1729925)
Backed out changeset 955138a73fa4 (bug 1729925)
2021-09-16 01:07:41 +03:00
Alexandre Poirot 70c8f3b535 Bug 1729925 - [devtools] Avoid leaking Commands/DevToolsClient/Fronts when closing the toolbox. r=nchevobbe
Currently, we do leak the Toolbox/Inspector and some Documents when
closing the toolbox.
So that these classes are kept in memory, while not nullifying all its references
to client classes.

By adding these few nullications we can at least avoid leaking the fronts and commands.

(also fix a failure due to null markup.walker in browser_rules_add-rule-with-menu.js)

Differential Revision: https://phabricator.services.mozilla.com/D125535
2021-09-15 20:08:32 +00:00
Julian Descottes 994c5bb325 Bug 1688067 - [devtools] Repurpose refreshTab as reloadBrowser and use in browser_toolbox_error_count_reset_on_navigation.js r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D124168
2021-09-01 19:24:24 +00:00
Nicolas Chevobbe d4218f1fe9 Bug 1716703 - [devtools] Rename TestActor to HighlighterTestActor. r=jdescottes.
Renaming the actor makes it more explicit that it should
only be used for highlighter-related assertions.
We take this opportunity to rename all the 'testActor' instances
in tests to 'highlighterTestFront' which better represents
what the object is.
While doing this work, I was able to cleanup a few function definition
where the testActor parameter wasn't needed.

Differential Revision: https://phabricator.services.mozilla.com/D117978
2021-06-17 10:03:03 +00:00
Nicolas Chevobbe 7a18ae616a Bug 1714920 - [devtools] Remove testActor#reload. r=jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D116965
2021-06-07 16:12:46 +00:00
Julian Descottes b5a338bfbd Bug 1714037 - [devtools] Move get/set/removeAttributeInBrowser test helpers from to inspector shared-head r=nchevobbe
Depends on D116557

Differential Revision: https://phabricator.services.mozilla.com/D116572
2021-06-03 14:49:00 +00:00
Julian Descottes 3aac6acebd Bug 1708252 - [devtools] Stop using test-actor eval r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D113714
2021-04-29 07:31:11 +00:00
Julian Descottes 9583ab3de0 Bug 1705769 - [devtools] Remove get/set/removeAttribute helpers on test-actor r=nchevobbe
Depends on D112380

Differential Revision: https://phabricator.services.mozilla.com/D112381
2021-04-20 20:24:43 +00:00
Julian Descottes f68edc6c12 Bug 1705753 - [devtools] Stop using testActor for alternate setStyleInFrame helpers in boxmodel test suite r=nchevobbe
Depends on D112379

Differential Revision: https://phabricator.services.mozilla.com/D112380
2021-04-20 20:24:43 +00:00
Julian Descottes 5da7ca489e Bug 1705753 - [devtools] Stop using testActor for setStyle/getStyle helpers in boxmodel test suite r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D112379
2021-04-20 20:24:42 +00:00
Sebastian Zartner 3cedc659d1 Bug 1357890 - Improved UX for switching between input boxes in box model view. r=jdescottes
Tabbing through the input boxes now moves the focus one level down when all inputs of a level had focus, starting from the outermost top. This is either `margin-top` for unpositioned elements or `top` for positioned elements. Once the innermost inputs all had focus, the focus jumps back to the outermost top one.

With this change the `getAriaActiveDescendant()` and `setAriaActiveDescendant()` methods were renamed to `getActiveDescendant()` and `setActiveDescendant()` because their functionality doesn't currently rely on ARIA attributes. See the notes at https://bugzilla.mozilla.org/show_bug.cgi?id=1343167#c4.

Differential Revision: https://phabricator.services.mozilla.com/D68902
2021-04-15 08:59:37 +00:00
Julian Descottes 372187816a Bug 1703275 - [devtools] Share implementation for inspector test helpers selectNodeInFrames & getNodeFrontInFrame r=nchevobbe
Depends on D110746

Differential Revision: https://phabricator.services.mozilla.com/D110943
2021-04-07 06:42:56 +00:00
Alexandre Poirot aa4c30771b Bug 1700106 - [devtools] Remove now-useless eslint files related to mochitests. r=jdescottes,Standard8
I kept a few having some overrides. But they may be irrelevant.
And I kept some eslint files for all folder that aren't matching the pattern matching "**/test*/**/browser*/".
Ideally we would rename these folder to match.

Last but not least, I identified one case where we were using mochitest file for xpcshell tests!

Differential Revision: https://phabricator.services.mozilla.com/D109481
2021-03-23 15:51:18 +00:00
Julian Descottes 9d38d241c4 Bug 1665302 - [devtools] Wait for span text content in boxmodel tests r=nchevobbe
Boxmodel spans are rendered with react and might not be updated synchronously.

I couldn't verify that this was fixing the intermittent, because I didn't manage to get the failure on try or locally.
However, if we still get failures after this lands, we will know that it is not a timing issue, but rather a race condition in the boxmodel editorsession.

Differential Revision: https://phabricator.services.mozilla.com/D104742
2021-02-11 14:22:44 +00:00
Razvan Caliman 164b1bc5ec Bug 1623906 - [devtools] Dispatch thunks from Box Model panel React components to show/hide the Box Model Highlighter r=gl
Depends on D79556

This patch is using the approach introduced in D79556 to dispatch thunks (functions) to the Redux store to show/hide the box model highlighter from individual React components instead of passing down the methods through deeply nested trees of components that don't use them.

The Redux `dispatch()` method is passed down via the component tree instead. This enables further usage of dispatching thunks for other scenarios avoiding prop drilling.
The `showBoxModelHighlighterForNode`, `hideBoxModelHighlighter` and `showBoxModelHighlighter` props and methods are removed in favor of the corresponding thunks.

Differential Revision: https://phabricator.services.mozilla.com/D95033
2020-10-29 14:35:53 +00:00
Razvan Caliman 443b7ab153 Bug 1623906 - [devtools] Dispatch thunks from Flexbox panel React components to highlight nodes r=gl,jdescottes,nchevobbe
### Problem
There is a lot of [prop drilling](https://kentcdodds.com/blog/prop-drilling) in React components to pass down a callback that is invoked at the bottom of a long chain of components.

[onShowBoxModelHighlighterForNode()](https://searchfox.org/mozilla-central/search?path=&q=onShowBoxModelHighlighterForNode) is one such example. It is created at the [Inspector client level](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/devtools/client/inspector/inspector.js#1885-1908) then passed to React components for panels, then drilled down to the consumer component which invokes it. There is also some [needless duplication](https://searchfox.org/mozilla-central/source/devtools/client/inspector/layout/layout.js#85-86) with [onShowBoxModelHighlighter](https://searchfox.org/mozilla-central/search?q=onShowBoxModelHighlighter%5CW&path=&case=false&regexp=true).

### Solution

With this patch, we leverage thunks in Redux.
In Redux, you can `dispatch()`:
- actions -> an object with an action type string which is matched by reducers
- thunks -> a function which can be async and can itself dispatch actions or other thunks

Thunks are supported by middleware already set up in the DevTools Redux [createStore()](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/create-store.js#54,104) helper. During store setup, we pass `thunkOptions` to the middleware, an object with arguments which will be available to all thunks when invoked. This is where we pass in the inspector client as a thunk option so we can invoke the highlighter.

This is the replacement for prop drilling the `onShowBoxModelHighlighterForNode()` method. The same way they dispatch actions, components can now dispatch the thunk to show/hide the highlighter when they need it without direct knowledge of the `inspector`, thus satisfying the original intent of passing down the `onShowBoxModelHighlighterForNode()` callback while cleaning up the code.

### Prior art
Thunks are not something new to DevTools. They are extensively used by the WebConsole, for example:
- passing [thunk options to the store](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/devtools/client/webconsole/webconsole-wrapper.js#95-104)
- making use of thunk options,  [webConsoleUI and hud](https://searchfox.org/mozilla-central/source/devtools/client/webconsole/actions/autocomplete.js#14-91) in a thunk to handle autocomplete


###Useful context:
DevTools helpers
- [thunkWithOptions](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/middleware/thunk-with-options.js)
- [shared Redux createStore helper with thunks middleware](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/create-store.js#54,104)
Redux docs
- [Async Actions in Redux](https://redux.js.org/advanced/async-actions)
- [dispatch() as default prop with redux-connect](https://react-redux.js.org/using-react-redux/connect-mapdispatch#default-dispatch-as-a-prop)

Differential Revision: https://phabricator.services.mozilla.com/D79556
2020-10-29 14:35:55 +00:00
Butkovits Atila a7dc0693bb Backed out 5 changesets (bug 1623906) for node failures. CLOSED TREE
Backed out changeset 92d23f0ea155 (bug 1623906)
Backed out changeset 2af3b0ee91ac (bug 1623906)
Backed out changeset bc7e021e8d98 (bug 1623906)
Backed out changeset 362bad2b7311 (bug 1623906)
Backed out changeset 78d0de3437ab (bug 1623906)
2020-10-29 16:32:29 +02:00
Razvan Caliman 9b3826971e Bug 1623906 - [devtools] Dispatch thunks from Box Model panel React components to show/hide the Box Model Highlighter r=gl
Depends on D79556

This patch is using the approach introduced in D79556 to dispatch thunks (functions) to the Redux store to show/hide the box model highlighter from individual React components instead of passing down the methods through deeply nested trees of components that don't use them.

The Redux `dispatch()` method is passed down via the component tree instead. This enables further usage of dispatching thunks for other scenarios avoiding prop drilling.
The `showBoxModelHighlighterForNode`, `hideBoxModelHighlighter` and `showBoxModelHighlighter` props and methods are removed in favor of the corresponding thunks.

Differential Revision: https://phabricator.services.mozilla.com/D95033
2020-10-29 14:04:42 +00:00
Razvan Caliman f6ff117dfb Bug 1623906 - [devtools] Dispatch thunks from Flexbox panel React components to highlight nodes r=gl,jdescottes,nchevobbe
### Problem
There is a lot of [prop drilling](https://kentcdodds.com/blog/prop-drilling) in React components to pass down a callback that is invoked at the bottom of a long chain of components.

[onShowBoxModelHighlighterForNode()](https://searchfox.org/mozilla-central/search?path=&q=onShowBoxModelHighlighterForNode) is one such example. It is created at the [Inspector client level](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/devtools/client/inspector/inspector.js#1885-1908) then passed to React components for panels, then drilled down to the consumer component which invokes it. There is also some [needless duplication](https://searchfox.org/mozilla-central/source/devtools/client/inspector/layout/layout.js#85-86) with [onShowBoxModelHighlighter](https://searchfox.org/mozilla-central/search?q=onShowBoxModelHighlighter%5CW&path=&case=false&regexp=true).

### Solution

With this patch, we leverage thunks in Redux.
In Redux, you can `dispatch()`:
- actions -> an object with an action type string which is matched by reducers
- thunks -> a function which can be async and can itself dispatch actions or other thunks

Thunks are supported by middleware already set up in the DevTools Redux [createStore()](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/create-store.js#54,104) helper. During store setup, we pass `thunkOptions` to the middleware, an object with arguments which will be available to all thunks when invoked. This is where we pass in the inspector client as a thunk option so we can invoke the highlighter.

This is the replacement for prop drilling the `onShowBoxModelHighlighterForNode()` method. The same way they dispatch actions, components can now dispatch the thunk to show/hide the highlighter when they need it without direct knowledge of the `inspector`, thus satisfying the original intent of passing down the `onShowBoxModelHighlighterForNode()` callback while cleaning up the code.

### Prior art
Thunks are not something new to DevTools. They are extensively used by the WebConsole, for example:
- passing [thunk options to the store](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/devtools/client/webconsole/webconsole-wrapper.js#95-104)
- making use of thunk options,  [webConsoleUI and hud](https://searchfox.org/mozilla-central/source/devtools/client/webconsole/actions/autocomplete.js#14-91) in a thunk to handle autocomplete


###Useful context:
DevTools helpers
- [thunkWithOptions](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/middleware/thunk-with-options.js)
- [shared Redux createStore helper with thunks middleware](https://searchfox.org/mozilla-central/source/devtools/client/shared/redux/create-store.js#54,104)
Redux docs
- [Async Actions in Redux](https://redux.js.org/advanced/async-actions)
- [dispatch() as default prop with redux-connect](https://react-redux.js.org/using-react-redux/connect-mapdispatch#default-dispatch-as-a-prop)

Differential Revision: https://phabricator.services.mozilla.com/D79556
2020-10-29 14:04:25 +00:00
Ricky Stewart 31b8ca9716 Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Razvan Maries 094f389b0d Bug 1582395 - Disabled browser_boxmodel_update-after-navigation.js on Windows and Linux x64. r=intermittent-reviewers,ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D94689
2020-10-26 13:28:27 +00:00
Bogdan Tara 612312a64c Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart 065d2eb893 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca 95b44c982f Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart 43baed3c18 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Alexandre Poirot 826181672f Bug 1620280 - [devtools] Prevent showing/hiding highlighters when the panels are already destroyed. r=jdescottes
browser_animation_animation-target_select.js was failing on debug builds because of exception during test ends.

Differential Revision: https://phabricator.services.mozilla.com/D91892
2020-10-05 08:29:12 +00:00
Butkovits Atila e903ace85e Backed out 9 changesets (bug 1620280) for failure at browser_ext_devtools_inspectedWindow_targetSwitch.js. CLOSED TREE
Backed out changeset 8dda1f048067 (bug 1620280)
Backed out changeset 309c0be48745 (bug 1620280)
Backed out changeset 78a06cd336c6 (bug 1620280)
Backed out changeset 74aba83895ce (bug 1620280)
Backed out changeset 6a8126ded6ec (bug 1620280)
Backed out changeset 47a2d6b77270 (bug 1620280)
Backed out changeset 526c067da0c1 (bug 1620280)
Backed out changeset 488f645884ba (bug 1620280)
Backed out changeset 9cffe1c5fb6d (bug 1620280)
2020-10-01 23:32:57 +03:00
Alexandre Poirot e3fdfbf974 Bug 1620280 - [devtools] Prevent showing/hiding highlighters when the panels are already destroyed. r=jdescottes
browser_animation_animation-target_select.js was failing on debug builds because of exception during test ends.

Differential Revision: https://phabricator.services.mozilla.com/D91892
2020-10-01 14:22:50 +00:00
Razvan Caliman b4f4a889ed Bug 1646028 - Update Box Model diagram to use Box Model Highlighter. r=jdescottes
Depends on D85859

The Box Model diagram in the Layout sidebar panel of the Inspector shows a Box Model Highlighter on hover over its components parts: margin, border, padding, content.

This patch routes the calls to the highlighter to use the approach introduced in `HighlightersOverlay` in D81526

Differential Revision: https://phabricator.services.mozilla.com/D85860
2020-09-10 11:57:09 +00:00
Joel Maher b6788b7287 Bug 1652440 - adjust devtools to work with object.is() instead of ==. r=rcaliman,jdescottes
adjust devtools to work with object.is() instead of ==

Differential Revision: https://phabricator.services.mozilla.com/D83302
2020-07-22 14:53:16 +00:00
Marco Zehe 6d37da7553 Bug 1644343 Part 3 - Make the box model understandable to screen reader users, r=yzen,flod
This patch adds IDs to all the box divs so they can be referenced by ARIA attributes. The actual legend spans also act as region landmarks with an associated level so the nesting is relayed.

In addition, each of those boxes gets the buttons for its dimensions rendered in-place so for assistive technologies, this all follows a logical flow. aria-owns changes the accessibility tree so the nesting and associated properties are grouped together.

The actual buttons also receive a localizable aria-label that is a combination of the button text and title, so screen reader users not only hear "0 button" without knowing immediately what that button actually belongs to. Title is secondary information.

Differential Revision: https://phabricator.services.mozilla.com/D78953
2020-06-12 12:08:09 +00:00