Commit Graph
29 Commits
Author SHA1 Message Date
Emilio Cobos Álvarez f7551929f8 Bug 1916098 - Remove appcontent box. r=dao,desktop-theme-reviewers,devtools-reviewers,tabbrowser-reviewers,nchevobbe
gNotificationBox doesn't go there anymore (it goes inside the toolbox),
so we have really no use for that.

Simplify how the devtools theme is set on the browser, so that it is set
on the root.

Differential Revision: https://phabricator.services.mozilla.com/D220769
2024-09-02 13:47:45 +00:00
Niklas Baumgardner 0daa54c8cb Bug 1897095 - Shift dialogBox when browser is in RDM. r=desktop-theme-reviewers,devtools-reviewers,dao,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D217820
2024-07-31 15:36:08 +00:00
Emilio Cobos Álvarez a4aa5d0b16 Bug 1802338 - Centralize z-indices that fight in the browser area. r=Gijs
Not sure if this is worth it, your call. But it's a bit clearer to
figure out what fights with what.

Differential Revision: https://phabricator.services.mozilla.com/D163003
2023-01-03 13:35:26 +00:00
Emilio Cobos Álvarez 9b5795c9df Bug 1802338 - Tweak z-index of the RDM toolbar. r=devtools-reviewers,jdescottes
So that it paints on top of the dialog stack, and the devtools splitter.

Differential Revision: https://phabricator.services.mozilla.com/D163002
2022-11-30 10:17:03 +00:00
Csoregi Natalia 1246d3b6d6 Backed out 2 changesets (bug 1802338) for causing z-index failures. CLOSED TREE
Backed out changeset 0abf88b6f60a (bug 1802338)
Backed out changeset 6ded71887ed3 (bug 1802338)
2022-11-30 04:42:01 +02:00
Emilio Cobos Álvarez abea4ce995 Bug 1802338 - Centralize z-indices that fight in the browser area. r=Gijs
Not sure if this is worth it, your call. But it's a bit clearer to
figure out what fights with what.

Depends on D163002

Differential Revision: https://phabricator.services.mozilla.com/D163003
2022-11-30 01:28:00 +00:00
Emilio Cobos Álvarez c53988408f Bug 1802338 - Tweak z-index of the RDM toolbar. r=devtools-reviewers,jdescottes
So that it paints on top of the dialog stack, and the devtools splitter.

Differential Revision: https://phabricator.services.mozilla.com/D163002
2022-11-30 01:28:00 +00:00
Emilio Cobos Álvarez 5f1c827293 Bug 1794499 - Make RDM intrinsic size not affect the rest of the browser area. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D159284
2022-10-13 16:28:59 +00:00
Emilio Cobos Álvarez 11f34416e8 Bug 1791972 - Simplify dialog stack and rdm styles. r=Gijs,devtools-reviewers,jdescottes
.browserContainer is relatively positioned, so we can position the
tab-modal dialogs absolutely inside it instead of making them part of
the browser stack.

While at it, make the rdm toolbar part of the regular browserContainer,
just like the regular devtools toolbox is. That way there's no need to
do ResizeObserver shenanigans to be able to let it grow. Keep it also
absolutely positioned tho, because we need to overlay the whole
container when the device modal is opened. That's somewhat gross.

This should in general be simpler to understand than the current set-up,
and more performant to since it avoids the dialog stack from forming
part of the browser element's flow.

Differential Revision: https://phabricator.services.mozilla.com/D157912
2022-09-23 22:23:37 +00:00
Emilio Cobos Álvarez 98196eb0a8 Bug 1789125 - Explicitly position statuspanel vertically. r=dao
Right now, the vertical position of the status panel is the "auto"
position, which ends up working out, but mostly by chance, and relies on
behavior that's different from the standard flexbox, see bug 1789165.

Instead of using `position: fixed` and relying on not having any
sidebars or other content to the inline-end (otherwise the [mirror] rule
would be incorrect), explicitly position it against the
.browserContainer.

Differential Revision: https://phabricator.services.mozilla.com/D156384
2022-09-06 19:05:54 +00:00
Micah Tigley b168a5fbcf Bug 1696563 - Reuse RDM's toolbar resize observer to set the size of the dialogStack r=Gijs
Overlays for content prompts that are opened with tabdialog box occupy the entire browser viewport when RDM is opened. This is because `.dialogStack` is `position: fixed` to remove it from the grid layout and to avoid issues with scrolling when the simulated viewport is larger than the device viewport. The simulated viewport causing overflow is the reason why `position: absolute` might not be what we want to use here.

Now we have to deal with the problem of the overlay covering other browser UI.. To deal with this, this patch reuses the resize observer to store the `.browserStack` sizes so that `.dialogStack` can use these values to resize the modal overlay when other browser UI occupy the space of the browserStack (such as DevTools or the findbar).

Differential Revision: https://phabricator.services.mozilla.com/D107501
2021-03-10 15:54:20 +00:00
Gijs Kruitbosch d2c3a97b34 Bug 1661629 - size tabdialogbox items correctly when shown in responsive design mode, r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D89228
2020-09-03 14:10:12 +00:00
Emilio Cobos Álvarez 0c95165176 Bug 1633938 - Implement RDM zoom with transform. r=bradwerth
Differential Revision: https://phabricator.services.mozilla.com/D72981
2020-04-30 01:37:30 +00:00
Dorel Luca 68be601e48 Backed out 4 changesets (bug 1633938, bug 1578008, bug 1633488) for Devtool failures in browser/base/content/test/static/browser_parsable_css.js. CLOSED TREE
Backed out changeset e690c4cf8848 (bug 1633938)
Backed out changeset c999ecad3be8 (bug 1633488)
Backed out changeset abbc47ce1451 (bug 1578008)
Backed out changeset 9e6925ea790f (bug 1578008)
2020-04-30 04:13:42 +03:00
Emilio Cobos Álvarez 3143e89fe0 Bug 1633938 - Implement RDM zoom with transform. r=bradwerth
Differential Revision: https://phabricator.services.mozilla.com/D72981
2020-04-29 21:44:17 +00:00
Micah Tigley 06c769a101 Bug 1604726 - Use a ResizeObserver to responsively size the toolbar. r=bgrins
The RDM toolbar currently scrolls with the page when there is overflow in `.browserStack`. This is because the browser viewport can be set to a size larger than browser window. The solution here sets makes the toolbar `position: fixed` and utilizes the `ResizeObserver` to adjust the size of the device modal/selector to take up the size of the browser stack.

Differential Revision: https://phabricator.services.mozilla.com/D63245
2020-02-26 14:46:58 +00:00
Daisuke Akatsuka 011e0d86d5 Bug 1610594: Use HTML menu component instead of xul menu. r=mtigley,jdescottes
Before now, we used XUL elements as the menu for device selection on RDM.
We introduced the icon on the XUL menuitem in bug 1306198, but the UI on Ubuntu
became weird looking. In order to fix this, we could think to modify Linux
gadget, but we replace to HTML menu components we are using in DevTools with
considering deXUL as well.

Differential Revision: https://phabricator.services.mozilla.com/D61149
2020-02-12 01:33:55 +00:00
Csoregi Natalia 0a03c7c4dc Backed out 3 changesets (bug 1610594) for failures on e.g. browser_device_selector_items.js. CLOSED TREE
Backed out changeset a9a2395b667f (bug 1610594)
Backed out changeset c3f7182fd57f (bug 1610594)
Backed out changeset 3ec353a434f9 (bug 1610594)
2020-02-06 04:26:59 +02:00
Daisuke Akatsuka 7f9b296ea2 Bug 1610594: Use HTML menu component instead of xul menu. r=mtigley,jdescottes
Before now, we used XUL elements as the menu for device selection on RDM.
We introduced the icon on the XUL menuitem in bug 1306198, but the UI on Ubuntu
became weird looking. In order to fix this, we could think to modify Linux
gadget, but we replace to HTML menu components we are using in DevTools with
considering deXUL as well.

Differential Revision: https://phabricator.services.mozilla.com/D61149
2020-02-05 23:44:51 +00:00
Micah Tigley 25aae872d4 Bug 1604729 - Make device modal height take up 100% of the browser stack. r=bradwerth
Differential Revision: https://phabricator.services.mozilla.com/D60052
2020-01-15 19:37:59 +00:00
Micah Tigley bc27f8ddd1 Bug 1585008 - Part 1: Use CSS grid to place browser resizers in RDM. r=bgrins,bradwerth
Place resizers for RDM browser using CSS grid. This revision takes advantage of using grid-template-columns/rows to specify where browser stack elements are placed in the grid.

Differential Revision: https://phabricator.services.mozilla.com/D59189
2020-01-10 18:01:05 +00:00
Brad Werth 585a7193e3 Bug 1595092 Part 1: Make new RDM UI size the content pane with content-box. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D56979
2019-12-13 19:22:02 +00:00
Micah Tigley 29a6416bc6 Bug 1596166 - Remove "height: 30px" on RDM toolbar r=bgrins
The UA input field gets caught off when the browser viewport is too small. This is because the RDM toolbar has an explicit height of 30px set on it, so it can't accomodate the second row created for the UA input.

Differential Revision: https://phabricator.services.mozilla.com/D56783
2019-12-11 19:50:34 +00:00
Tim Nguyen 06cda0a8d3 Bug 1596047 - Remove new RDM CSS that's now obsolete. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D52895
2019-11-13 23:26:34 +00:00
Micah Tigley 22de5ac794 Bug 1579129 - Implement left-aligning/centering the viewport based on user prefs. r=gl,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D51671
2019-11-12 20:34:55 +00:00
Micah Tigley 692b019839 Bug 1578865 - Show the device settings modal over the RDM UI . r=gl
Since closing D50559, we're not using CSS Grid for the browser's container layout (see D48778 for context). This means positioning the device settings modal using CSS grid areas won't work.

An alternative to this is to contain the RDM toolbar inside the browser stack now that it uses CSS Grid. We can then use absolute positioning to have the RDM toolbar always positioning on top of the browser element and adjust its size when the device settings is opened.

Differential Revision: https://phabricator.services.mozilla.com/D51102
2019-11-01 19:23:55 +00:00
Micah Tigley 3b547b572d Bug 1585080 - Make RDM browser <stack> use CSS Grid r=mconley,gl
Differential Revision: https://phabricator.services.mozilla.com/D50559
2019-10-29 19:49:03 +00:00
Gabriel Luong 66c25d8546 Bug 1578839 - Implement resizing of the browser with the embedded RDM UI. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D47569
2019-10-08 16:19:34 +00:00
Gabriel Luong 7daac512d6 Bug 1583945 - Import the RDM browser stylesheet along with the devtools-browser stylesheet. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D47132
2019-10-04 22:29:47 +00:00