The plain class that was removed in Bug 1896330 was set
on a few elements in the variable view, the table and
the chart widgets, as well as in the inspector breadcrumb.
This patch removes the plain class and adjust styling
where it's needed.
Differential Revision: https://phabricator.services.mozilla.com/D210316
The data were presented in a table-like fashion, but weren't using accessible
elements for this, making it impossible to understand when using a screenreader.
We switch to use `<table>` and proper internal elements.
The pie-chart wasn't accessible at all, so we create groups and adds proper role
to items, and wrap slices in an interactive element so they can be interacted with
through the keyboard. This allow us to remove the fail-if annotation on the browser_net_statistics-02.js test.
Some items were missing, both in the table and the pie-chart, to make the panel
cleaner. The downside is that it was hard for a keyboard-only user to understand
the whole thing. So now, we do put all the data in the DOM, and label them with
'aria-label' attribute when needed..
Finally, we take this opportuniy to cleanup the implementation a bit, removing
unnecessary CSS and properties.
Differential Revision: https://phabricator.services.mozilla.com/D155364
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.
Overall it's not a very interesting patch I think.
nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.
I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.
While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.