This should allow the number of hidden messages to be notified to
screen reader users.
We update the Console FilterBar behavior to always show the "X hidden" message
when the input is focused, so screen reader can also pick up when no messages
are hidden.
Differential Revision: https://phabricator.services.mozilla.com/D213181
Requests can be blocked because of many reasons, but the label was always
saying it was because of DevTools.
Update the label so we follow what's done in Netmonitor.
Differential Revision: https://phabricator.services.mozilla.com/D210471
In some cases, we were getting null sourceId, which was causing an exception
to be thrown in `getFormattedSourceId` since it expects a string.
We add a simple guard in this function so we don't throw anymore.
But we shouldn't get null sourceId in the first place. It looks like for
some Wasm sources, the SavedFrame sourceId can be 0, which wasn't playing
well with some loose check we were doing in the sources manager.
Finally, the "Copy metadata" button we display when a console message crash
wasn't working. The message now includes the targetFront, which can be serialized
in JSON, so we simply ignore it.
Differential Revision: https://phabricator.services.mozilla.com/D206105
This feature is only exposed to internal usages of tracer.jsm, by passing traceStep boolean option:
```
startTracing({ global, traceSteps: true });
```
This will automatically log to stdout all traces, including each frame step within a function execution.
Without this flag, the tracer would only trace function calls and nothing more.
We would not know which line is being executed within the function execution.
Differential Revision: https://phabricator.services.mozilla.com/D201977
Also allow logging trace whenever any DOM Element get added, removed or modified.
For now this is exposed only via the console command via:
:tracer --dom-mutations (for all types of mutation)
:tracer --dom-mutations add,attributes,remove (coma separated list of mutation types you want to listen for)
Also revise the handling of "isWorker" so that all checks have the best possible check.
Differential Revision: https://phabricator.services.mozilla.com/D201976
The "is in opening group" computation, which goes through all message arrays
can be avoided until it is meaningful to check for this particular edge case.
Also we can remove the redundant check against `nextProps.messagesUi`.
Differential Revision: https://phabricator.services.mozilla.com/D197770
Updating eslint-plugin-react to 7.33.2 raises new eslint errors.
A few component needed to have their proptypes fixed (or added).
JSPropertyProvider was considered as a react component by the plugin,
I guess because it is a function starting with an uppercase letter.
Since it is a bit unusual to have such thing, I renamed it slightly
to make it look more like a function.
Differential Revision: https://phabricator.services.mozilla.com/D197596
This help reduce the RDP overhead by only transferring what is strictly necessary.
The console message resources bundles various useless attributes.
This also help use a custom rendering in the frontend so that traces can
be displayed distinctly and differently from the console API calls.
Differential Revision: https://phabricator.services.mozilla.com/D196020
This help reduce the RDP overhead by only transferring what is strictly necessary.
The console message resources bundles various useless attributes.
This also help use a custom rendering in the frontend so that traces can
be displayed distinctly and differently from the console API calls.
Differential Revision: https://phabricator.services.mozilla.com/D196020
This patch displays a notification in the console when the debugger is paused
in an original file with original variable mapping is turned off.
The notification is displayed when console input is focused, also if the user selects
a generated file, or is no longer paused or switches on varaible mapping, the notification is removed
once the console input is refocused.
Also added support for specific notifications to control displaying the close button.
Differential Revision: https://phabricator.services.mozilla.com/D191568
This patch displays a notification in the console when the debugger is paused
in an original file with original variable mapping is turned off.
The notification is displayed when console input is focused, also if the user selects
a generated file, or is no longer paused or switches on varaible mapping, the notification is removed
once the console input is refocused.
Also added support for specific notifications to control displaying the close button.
Differential Revision: https://phabricator.services.mozilla.com/D191568
This patch displays a notification in the console when the debugger is paused
in an original file with original variable mapping is turned off.
The notification is displayed when console input is focused, also if the user selects
a generated file, or is no longer paused or switches on varaible mapping, the notification is removed
once the console input is refocused.
Also added support for specific notifications to control displaying the close button.
Differential Revision: https://phabricator.services.mozilla.com/D191568
The new focus indicator is bigger and has a better contrast, making it more accessible
than the thin dotted line we had previously.
It also includes a white box-shadow so even on our blue "active/selected" backgrounds,
the indicator is still visible (e.g. in the markup view, for a selected node, with
focus on badges / text inputs).
Finally, I tried to go over the elements of the shared components and most used
panels to adjust the outline offset when it was not visible/clipped, or when
it could be conflated with the focused element border/background.
Differential Revision: https://phabricator.services.mozilla.com/D192185
Don't override all colors to turn them (insufficiently contrasted) grey,
but apply a desaturate filter which should keep a good enought contrast.
Differential Revision: https://phabricator.services.mozilla.com/D190551
On the server side, this patch introduces:
* a new "tracer" Target Scope actor to start and stop tracing per target
* a new TRACING_STATE resource in order to report to the client when we start/stop tracing and with which log method.
On the frontend side, this patch introduces:
* a global tracer button, which will enable/disable tracing for all targets/threads
all at once.
* a global header, similar to pause, reporting if any target is tracing or not.
The header reuses the pause header and we may want to followup to better coordinate case
where we pause and trace at the same time. Only one of the two states is displayed.
We may want to followup here to be able to trace only one target and see the state per target.
Differential Revision: https://phabricator.services.mozilla.com/D163614
First, we set the max-width of the message location in percentage
instead of vw, as the console output inline-size can be different
than the viewport one (e.g. when it is in editor mode).
We then turn the media query we had to hide the timestamp into a
container query, again, to take into account editor mode.
Finally, we place the location on its own row when the output is
narrow so the message text itself can still be readable.
Differential Revision: https://phabricator.services.mozilla.com/D168778
Use new "commands" thunk argument.
We were passing connector as argument whereas we could have fetched it from thunk arguments.
This will help slowly convert Connector/NetMonitorAPI to a command.
Differential Revision: https://phabricator.services.mozilla.com/D166055
This was no longer implemented/shown in the fission browser toolbox.
Now that we removed the non-fission toolbox, we can remove this feature.
Instead, content process messages are shown/hidden depending on browser toolbox's scope.
"everything" will show them. "parent-process" won't.
Differential Revision: https://phabricator.services.mozilla.com/D165026
This will help transition to ES Modules as this symbol is exposed to them.
$ sed -ie "/require(.Services.)/d" $(git grep -l 'require("Services")' devtools/)
$ sed -ie "/loader.lazyRequireGetter(this, .Services./d" $(git grep -l 'loader.lazyRequireGetter(this, "Services"' devtools/)
+ the edition of builtin-modules.js + eslintrc.js
+ manual eslint fixes
+ removal of devtools-services in the debugger, except for jest tests
Differential Revision: https://phabricator.services.mozilla.com/D156401
Julian Descottes