Commit Graph
180 Commits
Author SHA1 Message Date
Jonathan Kew 34a39b9f68 Bug 1913536 - Expose the special shorthands in the SpecifiedValueInfo for the CSS white-space shorthand. r=firefox-style-system-reviewers,devtools-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D219426
2024-08-21 14:48:25 +00:00
Nicolas Chevobbe 843ab01105 Bug 1909307 - [devtools] Always show the same label in Debugger paused overlay. r=devtools-reviewers,ochameau,fluent-reviewers.
This way the overlay doesn't jump around when stepping.

Differential Revision: https://phabricator.services.mozilla.com/D217799
2024-07-29 21:39:47 +00:00
Sebastian Zartner 35e9286f2b Bug 1551580 - [devtools] Handle float-related issues in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,nchevobbe.
The `clear` property currently only applies to block-Level elements, not to floats, regions, or pages, because the related CSS Page Floats Module (https://www.w3.org/TR/css-page-floats-3/) is not implemented yet.
For the same reason, we don't check `float-offset` and `float-defer` at the moment.

Differential Revision: https://phabricator.services.mozilla.com/D215299
2024-07-03 14:09:17 +00:00
Nicolas Chevobbe d08b80cdc9 Bug 1904285 - [devtools] Don't mark CSS variable declaration invalid in ::cue and highlight pseudo-elements. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D214546
2024-06-27 05:00:36 +00:00
Sebastian Zartner 58505ec331 Bug 1868788 - [devtools] Handle table-related issues in inactive CSS. r=devtools-reviewers,fluent-reviewers,nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D212793
2024-06-26 21:11:49 +00:00
Nicolas Chevobbe 345028b729 Bug 1902961 - [devtools] Include proper computed display value in inactive-css-not-display-block-on-floated message. r=devtools-reviewers,fluent-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D214284
2024-06-24 06:46:39 +00:00
Sebastian Zartner a7d2d37e2c Bug 1583894 - [devtools] Handle 'box-sizing' property in inactive CSS. r=devtools-reviewers,fluent-reviewers,bolsson,nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D212784
2024-06-12 11:25:45 +00:00
Sebastian Zartner d2ad11815f Bug 1551579 - [devtools] Handle 'resize' property in inactive CSS. r=devtools-reviewers,fluent-reviewers,nchevobbe,bolsson.
Differential Revision: https://phabricator.services.mozilla.com/D212994
2024-06-11 19:19:02 +00:00
Sebastian Zartner 6d11285925 Bug 1848705 - [devtools] Handle 'column-span' property in inactive CSS. r=devtools-reviewers,fluent-reviewers,bolsson,nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D212472
2024-06-06 10:04:01 +00:00
Sebastian Zartner f479f915e6 Bug 1583903 - [devtools] Handle properties only applying to replaced elements in inactive CSS. r=devtools-reviewers,fluent-reviewers,bolsson,nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D212480
2024-06-06 00:02:41 +00:00
Nicolas Chevobbe 7e3ff18292 Bug 1844446 - [devtools] Send rules matching selectors indexes instead of the selector strings. r=devtools-reviewers,bomsy.
This is done to avoid a performance issue with deeply nested rules,
where computing the desugared selector can be super expensive.
This should help overall since we're doing a bit less work, as well
as returning smaller data.

Differential Revision: https://phabricator.services.mozilla.com/D207727
2024-05-14 06:19:43 +00:00
Nicolas Chevobbe 9b1522fec0 Bug 1868732 - [devtools] Add tests for ::target-text pseudo elements. r=devtools-reviewers,bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D206507
2024-04-24 12:28:42 +00:00
Nicolas Chevobbe 94fc97f9cc Bug 1882741 - [devtools] Do not show inactive CSS warning for align-content on (inline-)block elements. r=devtools-reviewers,fluent-reviewers,bolsson,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D203408
2024-03-20 16:41:18 +00:00
Dave Townsend 2af4d349f3 Bug 1864896: Autofix unused function arguments (devtools). r=profiler-reviewers,devtools-reviewers,nchevobbe,julienw
Differential Revision: https://phabricator.services.mozilla.com/D202959
2024-03-05 14:21:15 +00:00
Jonathan Kew 5c2c2026b5 Bug 1852478 - Update property_database.js for conversion of white-space and text-wrap to shorthands. r=firefox-style-system-reviewers,emilio,devtools-reviewers,nchevobbe
Also fix up devtools data/tests now that white-space is a shorthand.

Differential Revision: https://phabricator.services.mozilla.com/D198792
2024-01-26 09:40:03 +00:00
Cristian Tuns b0886adb5c Backed out 4 changesets (bug 1758391, bug 1852478) for causing build bustages in UseCounterMetrics.cpp CLOSED TREE
Backed out changeset fe673f87d86a (bug 1852478)
Backed out changeset d466ccbd1aad (bug 1852478)
Backed out changeset c0fa98fec39a (bug 1758391)
Backed out changeset 04d322f23fd0 (bug 1852478)
2024-01-25 18:29:39 -05:00
Jonathan Kew 4570d7572a Bug 1852478 - Update property_database.js for conversion of white-space and text-wrap to shorthands. r=firefox-style-system-reviewers,emilio,devtools-reviewers,nchevobbe
Also fix up devtools data/tests now that white-space is a shorthand.

Differential Revision: https://phabricator.services.mozilla.com/D198792
2024-01-25 22:20:06 +00:00
Nicolas Chevobbe e09a0ec37d Bug 1865264 - [devtools] Remove CssRule/CssSheet unused source getters. r=devtools-reviewers,ochameau.
test_css-logic-media-queries.html was only checking this property,
and we have a mochitest equivalent checking the UI (browser_rules_media-queries.js),
so we remove it.

Depends on D193872

Differential Revision: https://phabricator.services.mozilla.com/D193873
2023-11-22 09:37:37 +00:00
Nicolas Chevobbe 6e6afdd3e1 Bug 1865026 - [devtools] Don't send unused mediaText property. r=devtools-reviewers,ochameau.
This looks like a legacy property that we're not using anymore.

Differential Revision: https://phabricator.services.mozilla.com/D193872
2023-11-22 09:37:36 +00:00
Nicolas Chevobbe a670cbbb32 Bug 1861031 - [devtools] Handle InspectorUtils.getBlockLineCounts returning null. r=devtools-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D191862
2023-10-26 16:01:58 +00:00
Mark Banner cc2be2ea34 Bug 1858673 - Remove now unnecessary disabling of ESLint no-unsanitized/* rules from test files. r=freddyb,media-playback-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,places-reviewers,aosmond,sgalich,dao,padenot
Differential Revision: https://phabricator.services.mozilla.com/D190985
2023-10-24 08:48:41 +00:00
Sebastian Zartner cf3e93c8a0 Bug 1858937 - [devtools] Enable preference layout.css.text-wrap-balance.enabled in tests for inactive CSS in DevTools. r=devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D190999
2023-10-14 16:10:38 +00:00
Sebastian Zartner 798f509d51 Bug 1851756 - [devtools] Handle 'text-wrap: balance;' in inactive CSS. r=devtools-reviewers,nchevobbe,flod.
Differential Revision: https://phabricator.services.mozilla.com/D190505
2023-10-12 10:48:43 +00:00
Tom Marble d70780c99c Bug 1850545 - convert .ini manifests to .toml: batch 3 chrome.ini (bis) r=jmaher,geckoview-reviewers,extension-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,places-reviewers,profiler-reviewers,m_kato,mak,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D187597
2023-09-13 18:28:32 +00:00
Sebastian Zartner ede6514ba4 Bug 1849235 - [devtools] Handle ::cue pseudo-element's ignored properties in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D186509
2023-09-09 21:16:57 +00:00
Sebastian Zartner fc04233d84 Bug 1842175 - [devtools] Handle ::first-letter pseudo-element's ignored properties in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D186493
2023-09-08 19:32:26 +00:00
Sebastian Zartner 5c735718b3 Bug 1849255 - [devtools] Handle ::placeholder pseudo-element's ignored properties in inactive CSS. r=devtools-reviewers,fluent-reviewers,nchevobbe.
Differential Revision: https://phabricator.services.mozilla.com/D186742
2023-09-07 20:14:31 +00:00
Sebastian Zartner 5eb95bb51e Bug 1842174 - [devtools] Handle ::first-line pseudo-element's ignored properties in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D186188
2023-08-16 20:34:57 +00:00
Sebastian Zartner 611e035114 Bug 1583912 - [devtools] Handle ignored properties in non-multi-column containers in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D186096
2023-08-14 20:41:29 +00:00
Sebastian Zartner a0a8952db4 Bug 1583906 - [devtools] Handle 'empty-cells' property in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D186082
2023-08-14 20:14:34 +00:00
june wilde 48e92f0dba Bug 1550792 - Change LoadInfo to use GetIsOriginPotentiallyTrustworthy; r=ckerschb,necko-reviewers,freddyb,kershaw,extension-reviewers,devtools-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D175649
2023-07-13 22:40:30 +00:00
Nicolas Chevobbe 42c7ce803d Bug 1842157 - [devtools] Handle highlight pseudo-elements ignored properties in inactive CSS. r=devtools-reviewers,fluent-reviewers,ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D182986
2023-07-13 16:48:56 +00:00
Nicolas Chevobbe c2ffaf0b8c Bug 1824653 - [devtools] Fix CSSSelectorInfo#compare. r=devtools-reviewers,ochameau.
Given that we get the rules from `InspectorUtils.getCSSStyleRules`, the selectors
are already sorted the way the platform handles them.
We only need to reorder those in case a value is important, otherwise we rely
on the original rules order.

Extensive tests are added to make sure we covered possible cases.

Differential Revision: https://phabricator.services.mozilla.com/D182780
2023-07-13 15:38:22 +00:00
Sandor Molnar 58de8d0876 Backed out 2 changesets (bug 1824653, bug 1841971) for causing dt failures in devtools/client/debugger/test/mochitest/browser_dbg-preview-frame.js CLOSED TREE
Backed out changeset 76f0ed4453d7 (bug 1824653)
Backed out changeset f5ea13dea488 (bug 1841971)
2023-07-13 18:00:36 +03:00
Nicolas Chevobbe 8f8aa48c2a Bug 1824653 - [devtools] Fix CSSSelectorInfo#compare. r=devtools-reviewers,ochameau.
Given that we get the rules from `InspectorUtils.getCSSStyleRules`, the selectors
are already sorted the way the platform handles them.
We only need to reorder those in case a value is important, otherwise we rely
on the original rules order.

Extensive tests are added to make sure we covered possible cases.

Differential Revision: https://phabricator.services.mozilla.com/D182780
2023-07-13 13:33:05 +00:00
Emilio Cobos Álvarez c8d2c23403 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-09 11:34:05 +00:00
Stanca Serban 27c720052b Backed out changeset 1c835137f532 (bug 1824886) for causing multiple failures. CLOSED TREE 2023-07-06 02:11:59 +03:00
Emilio Cobos Álvarez 8053b896a6 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-05 21:59:44 +00:00
Cosmin Sabou 20fa44fbeb Backed out 2 changesets (bug 1824886) for causing failures on browser_all_files_referenced.js. CLOSED TREE
Backed out changeset 650ef77d1c4d (bug 1824886)
Backed out changeset 1c835137f532 (bug 1824886)
2023-07-06 00:42:53 +03:00
Emilio Cobos Álvarez b1433254b6 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-05 18:21:31 +00:00
Nicolas Chevobbe 7829a14122 Bug 1838164 - [devtools] Fix matchedSelectors for nested rules. r=devtools-reviewers,ochameau.
Return the desugared selectors from `getMatchedSelectors`, and use the desugared
selector we have on the rule to match against those.
A test case with nested rule is added to ensure the issue is properly fixed.

Differential Revision: https://phabricator.services.mozilla.com/D181773
2023-06-27 13:15:01 +00:00
Emilio Cobos Álvarez dde7ee0dea Bug 1838627 - Refactor InspectorUtils APIs that just forward to CSSStyleRule, and expose desugared selectors on them. r=nchevobbe,webidl,firefox-style-system-reviewers,smaug,devtools-reviewers,boris
Differential Revision: https://phabricator.services.mozilla.com/D181109
2023-06-21 07:14:57 +00:00
Mark Banner 0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner 91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Alexandre Poirot a6ffe0d5fb Bug 1813477 - [devtools] Convert all tests still using ActorClassWithSpec. r=devtools-reviewers,perftest-reviewers,jdescottes,sparky
Differential Revision: https://phabricator.services.mozilla.com/D169358
2023-02-14 10:34:19 +00:00
Julian Descottes f1a3dac261 Bug 1811138 - [devtools] Remove require calls to InspectorUtils r=ochameau,perftest-reviewers,sparky
Depends on D167211

Differential Revision: https://phabricator.services.mozilla.com/D167308
2023-02-06 09:47:18 +00:00
Alexandre Poirot 4bba703e0d Bug 1766485 - [devtools] Consider server side target switching always enabled for tab toolboxes. r=devtools-reviewers,nchevobbe
This removes the devtools.target-switching.server.enabled preference,
which was only having an impact on tab debugging.
Toolboxes other than tabs aren't yet using "server side target switching",
which will probably happen once we enable EFT in these and
we would probably not use a preference for enabling this.

This remove all assertions in tests covering client side target switching.
And it removed a couple of tests that became irrelevant.

Differential Revision: https://phabricator.services.mozilla.com/D166921
2023-01-30 12:49:54 +00:00
Mark Banner fa33e4f28f Bug 1799314 - Convert consumers of testing modules to import ES modules direct (devtools/). r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D161916
2022-11-17 12:00:31 +00:00
Mark Banner 4ba1d59826 Bug 1778110 - Move devtools code to use mjs files, rather than defining sourceType for ESLint. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D161263
2022-11-07 09:49:53 +00:00
Alexandre Poirot bde84f5b65 Bug 1793604 - [devtools] Convert Loader.jsm to ESM. r=perftest-reviewers,geckoview-reviewers,preferences-reviewers,owlish,kshampur,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158582
2022-10-14 12:19:42 +00:00