Commit Graph
44 Commits
Author SHA1 Message Date
Henrik Skupin 3a548b37ef Bug 1912237 - [devtools] Remove backward compatibility code for Firefox 131 release. r=devtools-backward-compat-reviewers,devtools-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D219877
2024-08-23 17:22:32 +00:00
Alexandre Poirot 077d52cc17 Bug 1901643 - [devtools] Gather resources in arrays in order to prevent having to pass the resource type everytime. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D213224
2024-06-18 18:33:18 +00:00
Alexandre Poirot dd2ec2e844 Bug 1814013 - [devtools] Remove test-only echo request from the root actor. r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
This wasn't so trivial to revisit tests, but at least we stop shipping test-only
features in RDP. And the cryptic echo implement now only exists in tests.

Differential Revision: https://phabricator.services.mozilla.com/D168360
2023-02-07 10:36:59 +00:00
Alexandre Poirot 07e6ce0083 Bug 1792848 - [devtools] Use absolute URLs to import modules in devtools/shared. r=Honza,devtools-backward-compat-reviewers,bomsy
Differential Revision: https://phabricator.services.mozilla.com/D158643
2022-10-12 15:56:22 +00:00
Hubert Boma Manilla 991021d23f Bug 1775084 - [devtools] Support clearing of root-resources r=ochameau,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D149635
2022-06-20 15:32:16 +00:00
Nicolas Chevobbe ba35898f0a Bug 1763364 - [devtools] Remove getTab unused option tabId. r=ochameau,devtools-backward-compat-reviewers,bomsy.
Depends on D143027

Differential Revision: https://phabricator.services.mozilla.com/D143028
2022-04-12 11:59:31 +00:00
Nicolas Chevobbe 776faaa0f3 Bug 1763364 - [devtools] Call getTab with browserId instead of outerWindowID. r=ochameau,devtools-backward-compat-reviewers,bomsy.
This allows to remove the `outerWindowID` option from `getTab`.

Depends on D143026

Differential Revision: https://phabricator.services.mozilla.com/D143027
2022-04-12 11:59:30 +00:00
Alexandre Poirot 379bb208f6 Bug 1757951 - [devtools] Implement "Root" Resources in order to be able to watch for context-less resources in the parent process. r=jdescottes,devtools-backward-compat-reviewers
This is equivalent to the ResourceCommand, but isn't related to any context/descriptor.
This helps listen to things right away when connecting to a RDP server.
That, without having to instantiate any descriptor/watcher actor.
It works right away via the root actor which is instantiated by default.

Differential Revision: https://phabricator.services.mozilla.com/D140206
2022-03-10 22:43:48 +00:00
Alexandre Poirot 92a4a4f7a5 Bug 1755963 - [devtools] Use the browserId to identify which tab to be picked by a given tab descriptor. r=jdescottes,devtools-backward-compat-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D139035
2022-02-21 18:20:53 +00:00
Julian Descottes a2ea1a6a96 Bug 1692965 - [devtools] Remove the ChromeWindowTargetActor r=ochameau,devtools-backward-compat-reviewers
The ChromeWindowTargetActor was not exposed to end users and doesn't support descriptors which will make it a blocker for fission refactors.
So we remove it for now.

Differential Revision: https://phabricator.services.mozilla.com/D105452
2021-02-18 11:10:13 +00:00
Nicolas Chevobbe 7ae5067d59 Bug 1680440 - [devtools] Remove favicons parameter in listTabs call. r=ladybenko,devtools-backward-compat-reviewers,jdescottes.
The parameter was only used for older servers, so we
can remove it now.

Differential Revision: https://phabricator.services.mozilla.com/D98726
2020-12-11 13:54:06 +00:00
Nicolas Chevobbe 05cd5a9f33 Bug 1677942 - [devtools] Use new syntax for backward compatibility comments. r=jdescottes,devtools-backward-compat-reviewers.
This turns all existing backward compatibility comments (or
comments mentioning a specific Firefox version), into the new
syntax we agreed upon in Bug 1673535.

Differential Revision: https://phabricator.services.mozilla.com/D97395
2020-12-01 10:27:47 +00:00
Julian Descottes 3302013720 Bug 1654763 - [devtools] Remove implementation, tests and documentation for actorHasMethod r=rcaliman,ochameau,devtools-backward-compat-reviewers
actorhasMethod had several technical limitations making it hard to use consistently. We now removed all the call sites for this method. This changeset removes the method and all its dependencies.

Differential Revision: https://phabricator.services.mozilla.com/D95861
2020-11-06 13:50:52 +00:00
Nicolas Chevobbe 124ea2f1a0 Bug 1573779 - [devtools] Rename WorkerTarget to WorkerDescriptor. r=ochameau,jdescottes,devtools-backward-compat-reviewers.
This renames the current WorkerTargetActor which is actually a descriptor.
We also rename the existing `workerTargetFront` occurences to `workerDescriptorFront`
to avoid confusion when we do introduce the real worker fronts and actors.

Differential Revision: https://phabricator.services.mozilla.com/D91100
2020-09-29 14:30:24 +00:00
Dorel Luca 2767dba5fe Backed out 3 changesets (bug 1573779, bug 1662734) for Geckoview failures. CLOSED TREE
Backed out changeset 0adff4f08b28 (bug 1662734)
Backed out changeset c6bb84f2a032 (bug 1573779)
Backed out changeset 0c605800aa6b (bug 1573779)
2020-09-29 12:59:39 +03:00
Nicolas Chevobbe afff47ed89 Bug 1573779 - [devtools] Rename WorkerTarget to WorkerDescriptor. r=ochameau,jdescottes,devtools-backward-compat-reviewers.
This renames the current WorkerTargetActor which is actually a descriptor.
We also rename the existing `workerTargetFront` occurences to `workerDescriptorFront`
to avoid confusion when we do introduce the real worker fronts and actors.

Differential Revision: https://phabricator.services.mozilla.com/D91100
2020-09-28 12:27:22 +00:00
Julian Descottes ff88be7757 Bug 1642875 - Remove getBrowsingContextDescriptor r=ochameau,nchevobbe
Depends on D77998

Differential Revision: https://phabricator.services.mozilla.com/D77999
2020-06-09 07:27:27 +00:00
Julian Descottes afbb8b1806 Bug 1642875 - Remove listRemoteFrames r=nchevobbe
Depends on D77995

Differential Revision: https://phabricator.services.mozilla.com/D77996
2020-06-09 07:26:38 +00:00
Julian Descottes b78f1f0bc5 Bug 1642875 - Remove unused Frame Descriptor r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D77995
2020-06-09 07:26:11 +00:00
Alexandre Poirot 96dd62a328 Bug 1593937 - Remove/Deprecate listRemoteFrames. r=jdescottes
The previous changeset removed all the usages of listRemoteFrames from
the frontend code. We can start removing this method from the actor codebase,
and keep backward compat code in the client.

Differential Revision: https://phabricator.services.mozilla.com/D65522
2020-04-30 07:59:42 +00:00
Alexandre Poirot 049366f79c Bug 1593937 - Fetch BrowsingContextTargets via the watcher instead of the RootFront. r=jdescottes
Now that the BrowsingContextTarget are created by the watcher,
we should redirect existing code in the frontend which was using
`RootFront.getBrowsingContextDescriptor` in order to directly fetch the target from the watcher.

We don't really need descriptors for additional targets.
I think that descriptors are mostly useful for the top level target and for about:debugging, to describe a target without debugging it yet.

This patch is a bit complex because we can't fetch the "parent BrowsingContext ID" from actors/browsing-context.js:form().
browsingContext.parent and browsingContext.embedderWindowGlobal are both null from the content process.
I have not found any way/API to get the parent browsing context ID from the content process, i.e. the ID of browser.xhtml from a tab content process.
So, I end up with this helper method on Watcher actor to get the parent ID on-demand.
We could also inject the parent ID into the browsingContextTarget's form in WindowGlobalWatcher._createTarget,
but that sounds very hacky and hard to follow.

Note that this patch address the issue of duplicated targets.
WatcherFront.getBrowsingContextTarget ensures fetching the ParentProcessTarget for browser.xhtml
instead of recreating a duplicated FrameDescriptor and BrowsingContextTarget for this document, as we do in the existing codebase.

Differential Revision: https://phabricator.services.mozilla.com/D62465
2020-04-30 07:59:38 +00:00
Julian Descottes 8133e11b16 Bug 1618691 - Simplify RootActor::listTabs response r=ochameau
Depends on D65693

Differential Revision: https://phabricator.services.mozilla.com/D70174
2020-04-14 13:16:33 +00:00
Julian Descottes 41c7173a54 Bug 1618691 - Stop returning selected tab information in listTabs r=ochameau
Depends on D69544
Since selected is read on the descriptor form, there is no need to include it in the listTabs response.

Differential Revision: https://phabricator.services.mozilla.com/D69545
2020-04-14 13:15:37 +00:00
Julian Descottes 2801dbc925 Bug 1618691 - Remove < FF75 backward compatibility code for getTab and listTabs r=ochameau
Depends on D69542

Differential Revision: https://phabricator.services.mozilla.com/D69543
2020-04-14 12:51:55 +00:00
Julian Descottes b0da5fbe03 Bug 1618691 - Remove < FF75 backward compatibility code for getProcess r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D69542
2020-04-14 12:51:01 +00:00
Julian Descottes 8a76b29ad3 Bug 1619720 - Request favicons directly from the tab descriptor r=ochameau,ladybenko
Depends on D69331

This changeset adds a new getFavicon API on the TabDescriptorActor and uses it from about:debugging to retrieve the favicons for the tabs.

Currently, the TabDescriptorActor (living in the parent process) modifies the form of its BrowsingContextTargetActor (living in the content process) to add a "favicon" property on it. The reason we do this is that the API to get favicons can only be used from the parent process. Before tab descriptors, we had "frame-prox(ies)" instead in the parent process and the client could not directly query those frame proxies (they were not actors, and had no corresponding front). That's why we used this workaround of modifying the target actor form.

But now clients can directly call APIs on the TabDescriptor, so we don't have to insert the favicon information in the form of the target actor anymore.

Differential Revision: https://phabricator.services.mozilla.com/D65360
2020-04-02 15:44:24 +00:00
Julian Descottes 7b0f79096a Bug 1618876 - Remove backward compatibility related to process descriptor r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D64744
2020-03-03 09:24:47 +00:00
Julian Descottes d73475592d Bug 1579042 - Move tab call to getTarget from the server to the client r=ochameau
Depends on D63501

Differential Revision: https://phabricator.services.mozilla.com/D63502
2020-02-28 11:45:32 +00:00
yulia 076bd332bc Bug 1574401 - move listRemoteFrame from targets to mainRoot and descriptors r=jdescottes,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D45367
2019-10-02 09:48:47 +00:00
Alexandre Poirot c8a786fec1 Bug 1522572 - Move local tab specifics out of TargetMixin. r=jdescottes,yulia
Differential Revision: https://phabricator.services.mozilla.com/D41854
2019-08-28 16:06:22 +00:00
yulia 8a7c434988 Bug 1575557 - rename webExtension to webExtensionDescriptor; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D42867
2019-08-28 10:02:57 +00:00
yulia 072ef9b9e2 Bug 1522571 - Unify addonTargetFront with webExtensionSpec; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D42833
2019-08-28 10:01:43 +00:00
Victor Porof 435f7b056d Bug 1561435 - Format remaining devtools/, a=automatic-formatting, CLOSED TREE
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35894
2019-07-05 11:29:32 +02:00
Julian Descottes cc81cc88fe Bug 1510654 - Create fronts for ServiceWorkerRegistration, PushSubscription and ServiceWorker;r=ochameau,ladybenko
Depends on D15375

Differential Revision: https://phabricator.services.mozilla.com/D15376
2019-01-10 17:26:35 +00:00
Daisuke Akatsuka 622139b97d Bug 1506770: Extract data url from icon of addon. r=jdescottes,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D14368
2018-12-20 02:11:56 +00:00
Alexandre Poirot eab3bc2c14 Bug 1514819 - Convert RootFront.getWindow to return a front instead of a form. r=yulia
This method is only used by target-from-url, it allows to return
a target got one precise top level window and instead of the whole main process.

It looks like it was the very last non-front/still-form target codepath.

Differential Revision: https://phabricator.services.mozilla.com/D14841
2018-12-18 08:54:01 +00:00
Alexandre Poirot 662d5ebb84 Bug 1508285 - Refactor RootFront.listTabs to return BrowsingContextTargetFront instead of JSON form. r=yulia,jdescottes
MozReview-Commit-ID: 4CMHJ3tV7Rc

Depends on D14174

Differential Revision: https://phabricator.services.mozilla.com/D14175
2018-12-17 11:56:30 +00:00
Alexandre Poirot c2c92214da Bug 1508285 - Refactor RootFront.getTab to return BrowsingContextTargetFront instead of JSON form. r=yulia
MozReview-Commit-ID: 6TOInM5BmYe

Differential Revision: https://phabricator.services.mozilla.com/D14173
2018-12-17 11:56:26 +00:00
Alexandre Poirot 05559ce854 Bug 1506546 - Change the spec type of listAddons and accomodate using the front rather than the form. r=yulia
MozReview-Commit-ID: 4MAjszUiGUZ

Depends on D12573

Differential Revision: https://phabricator.services.mozilla.com/D12574
2018-11-27 19:18:28 +00:00
Andreea Pavel 2e1438afd5 Backed out 7 changesets (bug 1506546) fo failing devtools at devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_system_addons.js on a CLOSED TREE
Backed out changeset fbe3f2183f32 (bug 1506546)
Backed out changeset 8972a2f14015 (bug 1506546)
Backed out changeset 00fe26234b3d (bug 1506546)
Backed out changeset 7d8e650e25c2 (bug 1506546)
Backed out changeset a293a37483b9 (bug 1506546)
Backed out changeset 7b75250a4f12 (bug 1506546)
Backed out changeset 23ad29cb776e (bug 1506546)
2018-11-27 14:37:14 +02:00
Alexandre Poirot 8df5a146e5 Bug 1506546 - Change the spec type of listAddons and accomodate using the front rather than the form. r=yulia
MozReview-Commit-ID: 4MAjszUiGUZ

Depends on D12573

Differential Revision: https://phabricator.services.mozilla.com/D12574
2018-11-27 11:23:18 +00:00
Alexandre Poirot e1d0ca7c1b Bug 1506548 - Return WorkerTargetFront from listWorkers instead of form. r=yulia
MozReview-Commit-ID: 4CBQNwC8tKq

Depends on D11762

Differential Revision: https://phabricator.services.mozilla.com/D11763
2018-11-15 10:23:50 +00:00
Julian Descottes dc150b343f Bug 1505285 - Restore favicons option for root listTabs;r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D11161
2018-11-07 16:44:37 +00:00
Alexandre Poirot 7f70817c9c Bug 1485661 - Convert RootClient to protocol.js front. r=yulia
MozReview-Commit-ID: 1FfeXpVNYTk

Differential Revision: https://phabricator.services.mozilla.com/D8820
2018-10-30 08:08:20 +00:00