Commit Graph
16 Commits
Author SHA1 Message Date
Tooru Fujisawa 504c8e1285 Bug 1831819 - Remove per-global function support in eager evaluation allow list. r=devtools-reviewers,nchevobbe
Stop supporting instance methods and getters in allowlist.
Now the allowlist is independent of global and can be shared across multiple
globals.

Differential Revision: https://phabricator.services.mozilla.com/D178884
2023-05-26 10:45:27 +00:00
Noemi Erli 7d41e7869b Backed out 3 changesets (bug 1831819, bug 1832769, bug 1831826) for causing build bustages in Object-isSameNativeWithJitInfo.js CLOSED TREE
Backed out changeset 260ffbbe45e0 (bug 1832769)
Backed out changeset e6a25ac049e4 (bug 1831819)
Backed out changeset dc4f6fa24aa3 (bug 1831826)
2023-05-26 06:17:20 +03:00
Tooru Fujisawa 6a2ac06235 Bug 1831819 - Remove per-global function support in eager evaluation allow list. r=devtools-reviewers,nchevobbe
Stop supporting instance methods and getters in allowlist.
Now the allowlist is independent of global and can be shared across multiple
globals.

Differential Revision: https://phabricator.services.mozilla.com/D178884
2023-05-26 02:53:58 +00:00
Tooru Fujisawa 283d429cea Bug 1815381 - Part 3: Remove DOM getters from explicit allowlist. r=nchevobbe,devtools-reviewers,ochameau
Now that all DOM getters are caught by `isNativeGetterWithJitInfo`,
we don't need the DOM getters in explicit allowlist.

Differential Revision: https://phabricator.services.mozilla.com/D175091
2023-05-12 06:21:41 +00:00
Nicolas Chevobbe 70245631b7 Bug 860312 - [devtools] Add LegacyLenientThis getters to unsafe list. r=devtools-reviewers,ochameau.
Getters with LegacyLenientThis attribute will trigger a warning in the console
if it's called with the unexpected `this`.
We can't tell in DevTools if we have the "right" `this`.
For example displaying an `HTMLDivElementPrototype` object, we'll trigger the
warning because of the `onmouseenter` getter, which is supposed to be called
with the `HTMLElement` instance, which we don't have at this point.

For this reason, we exclude those from being safe getters, which will prevent
triggering the warning.

Differential Revision: https://phabricator.services.mozilla.com/D174070
2023-04-11 06:25:58 +00:00
Nicolas Chevobbe cab2e6654d Bug 860312 - [devtools] Generate list of unsafe getters. r=devtools-reviewers,ochameau.
We'll only need those names to avoid executing getters.
The file is renamed to better convey what data it represents.

Differential Revision: https://phabricator.services.mozilla.com/D174056
2023-04-11 06:25:56 +00:00
Tooru Fujisawa 8ccbac98ad Bug 1806598 - Part 6: Add Location accessors, window.location, and document.location to allowlist. r=nchevobbe
Location related accessors are not marked Pure, but some testcase expects
them to be eagerly evaluateable.

Differential Revision: https://phabricator.services.mozilla.com/D168340
2023-02-07 07:36:16 +00:00
Tooru Fujisawa 7f2aefdc4c Bug 1806598 - Part 5: Add Window accessors to allowlist. r=nchevobbe
Add support for [Global] extended attribute and methods/getters on instances.

This retrieves the Xray getter function of the given eval global, so that even
if some configurable properties are modified by the web content, debugger
can see the original getters, and pass them to isSameNativeWithJitInfo.

Differential Revision: https://phabricator.services.mozilla.com/D168339
2023-02-07 07:36:15 +00:00
Tooru Fujisawa 5f7402f606 Bug 1806598 - Part 4: Collect safe DOM getters into webidl-pure-allowlist.js. r=nchevobbe
Also refactor the allowlist structure to represent static vs prototype and
methods vs getters clearly.

And also moved the pre-defined pure methods list into GenerateDataFromWebIdls.py
for simplicity.

Differential Revision: https://phabricator.services.mozilla.com/D168338
2023-02-07 07:36:15 +00:00
Sandor Molnar 190b92321c Backed out 11 changesets (bug 1806598, bug 1812905, bug 1812540) for causing dt failures in devtools/client/webconsole/test/browser/browser_console_evaluation_context_selector.js CLOSED TREE
Backed out changeset 3b0e28b20def (bug 1812540)
Backed out changeset 810ed5832764 (bug 1812540)
Backed out changeset 9e042da8472f (bug 1806598)
Backed out changeset ab04e3122f20 (bug 1806598)
Backed out changeset f97c01add0a5 (bug 1806598)
Backed out changeset de9d04dc5014 (bug 1806598)
Backed out changeset 3808fc5bf528 (bug 1806598)
Backed out changeset 9be2509e8540 (bug 1806598)
Backed out changeset 3fc6c5d9d620 (bug 1806598)
Backed out changeset 297a91be123b (bug 1806598)
Backed out changeset 24cc5069faf3 (bug 1812905)
2023-02-06 07:19:51 +02:00
Tooru Fujisawa a872bd3260 Bug 1806598 - Part 6: Add Location accessors, window.location, and document.location to allowlist. r=nchevobbe
Location related accessors are not marked Pure, but some testcase expects
them to be eagerly evaluateable.

Differential Revision: https://phabricator.services.mozilla.com/D168340
2023-02-06 03:42:36 +00:00
Tooru Fujisawa 6c7c4283d1 Bug 1806598 - Part 5: Add Window accessors to allowlist. r=nchevobbe
Add support for [Global] extended attribute and methods/getters on instances.

This retrieves the Xray getter function of the given eval global, so that even
if some configurable properties are modified by the web content, debugger
can see the original getters, and pass them to isSameNativeWithJitInfo.

Differential Revision: https://phabricator.services.mozilla.com/D168339
2023-02-06 03:42:36 +00:00
Tooru Fujisawa 355e58e88e Bug 1806598 - Part 4: Collect safe DOM getters into webidl-pure-allowlist.js. r=nchevobbe
Also refactor the allowlist structure to represent static vs prototype and
methods vs getters clearly.

And also moved the pre-defined pure methods list into GenerateDataFromWebIdls.py
for simplicity.

Differential Revision: https://phabricator.services.mozilla.com/D168338
2023-02-06 03:42:36 +00:00
Marco Castelluccio ba39d286d5 Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D165395
2022-12-23 22:45:46 +00:00
nchevobbe c414244c2e Bug 1719133 - [devtools] Generate webidl-deprecated-list.js for Firefox 91. r=jdescottes.
The comment documenting the command was fixed.

Differential Revision: https://phabricator.services.mozilla.com/D119061
2021-07-05 08:49:05 +00:00
Nicolas Chevobbe 3cbfdfb282 Bug 1686417 - [devtools] Generate a list of deprecated DOM methods and attributes. r=ladybenko.
This patch modifies and renameGeneratePureDOMFunctions.py so it generates a new file
indicating all the deprecated properties and methods so we can retrieve those information
in DevTools, in order, for example, to not call those deprecated properties and avoid generating
warning messages.

Differential Revision: https://phabricator.services.mozilla.com/D80864
2021-01-13 13:03:10 +00:00