Commit Graph
18 Commits
Author SHA1 Message Date
Botond Ballo fb1065c0c3 Bug 1858446 - Document that classes representing HTML elements should live in the mozilla::dom namespace. r=peterv DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D210576
2024-05-17 23:23:44 +00:00
Eemeli Aro 3d25e4614a Bug 1804404 - Update l10n documentation due to DTD & .inc removal. r=flod
Differential Revision: https://phabricator.services.mozilla.com/D164047
2022-12-07 11:50:39 +00:00
Greg Stoll 757c579cea no bug - fx doc: fix a few links to old pages r=sylvestre DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D162421
2022-11-18 21:20:18 +00:00
Greg Stoll 72069a846d no bug - fx doc: fix link to moved string guide page r=sylvestre DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D159705
2022-10-19 19:51:27 +00:00
Bobby Holley 98e3028bb3 Bug 1772234 - Update the style guide to deprecate rooting API typedefs. r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D148081
2022-06-02 21:01:42 +00:00
Janvi Bajoria a6d7d18556 Bug 1759754 - fix use the static preference API link in C++ coding style documentation r=KrisWright
Differential Revision: https://phabricator.services.mozilla.com/D144191
2022-05-10 17:26:31 +00:00
Bobby Holley 0d8d639e0d Bug 1740616 - Modify the C++ style guide to prefer unsigned types and CheckedInt. r=glandium DONTBUILD
This commit resolves the question posed in [1], largely on the basis of
the rationale put forth by emilio [2].

The reasons cited for using signed types boil down to (1) taking
advantage of UB optimizations, (2) more tractable dynamic overflow
analysis, and (3) increased chance of the surrounding logic identifying
and rejecting overflowed values.

Emilio points out that (1) is not a durable advantage. I see some value
in (2) and (3), but I see more value in consistency with existing code
and clear communication of semantic intent to the reader.

[1] https://groups.google.com/a/mozilla.org/g/dev-platform/c/-h_2cz5APmY/
[2] https://groups.google.com/a/mozilla.org/g/dev-platform/c/-h_2cz5APmY/m/NPdl2uIhAgAJ

Differential Revision: https://phabricator.services.mozilla.com/D130928
2021-11-16 19:38:01 +00:00
Chris Peterson 811beee789 Bug 1729598 - Remove now-unused MustUseChecker and MOZ_MUST_USE_TYPE attribute. r=static-analysis-reviewers,andi
Depends on D125504

Differential Revision: https://phabricator.services.mozilla.com/D125505
2021-09-15 05:10:51 +00:00
Simon Giesecke 969138c537 Bug 1677549 - Add some guidelines on include directives and header files to the coding style. r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D97916
2021-09-08 12:56:01 +00:00
surajeet310 6cf624ea47 Bug 1714788 - Fixed more Sphinx warnings in 'mach doc' r=sylvestre DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D117419
2021-06-10 19:33:53 +00:00
Butkovits Atila 84f1d7afa2 Backed out changeset eb6cdd43ce2e (bug 1677549) as requested by Simon. CLOSED TREE 2020-12-14 17:32:44 +02:00
Simon Giesecke 0db014fa9a Bug 1677549 - Add some guidelines on include directives and header files to the coding style. r=andi,sylvestre,asuth
Differential Revision: https://phabricator.services.mozilla.com/D97916
2020-12-11 10:35:54 +00:00
Simon Giesecke 29f4eb535b Bug 1648010 - Update coding style with respect to string literals. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D81503
2020-07-21 11:24:06 +00:00
Simon Giesecke c9d094b6d9 Bug 1653532 - Improve reference of Google Coding Style for C++ Code. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D83923
2020-08-04 08:31:17 +00:00
Chris Peterson 5bc9d3f177 Bug 1625855 - Replace MOZ_MUST_USE with [[nodiscard]] in some Servo Rust code. r=emilio
Are there any Rust crates outside mozilla-central that include or emit Mozilla C++ code that should be updated to use [[nodiscard]] instead of MOZ_MUST_USE?

Depends on D68751

Differential Revision: https://phabricator.services.mozilla.com/D69319
2020-04-02 08:27:59 +00:00
Sylvestre Ledru cfdb53e6d1 Bug 1605934 - Add nested namespaces in the C++ coding style r=sg
Differential Revision: https://phabricator.services.mozilla.com/D64301
2020-02-26 09:31:44 +00:00
Sylvestre Ledru a2354fa746 no bug - Recommends using instead of typedef r=sg
Differential Revision: https://phabricator.services.mozilla.com/D63834
2020-02-24 13:13:19 +00:00
Sylvestre Ledru 4c68ca682b Bug 1613526 - Create a code quality documentation and move the appropriate docs r=ahal
This for a few reasons:
* The summary becomes the landing page for code quality:
  https://firefox-source-docs.mozilla.org/tools/static-analysis/summary.html
* I don't think we need a full code quality category
* Closer to the source-code-doc
* All the files at the same place

Differential Revision: https://phabricator.services.mozilla.com/D61767
2020-02-11 09:11:44 +00:00