Commit Graph
35 Commits
Author SHA1 Message Date
Sean Burke ed77fb1c89 Bug 1900392 - Isolate x-moz-ews URI scheme to parent process. r=nika,jesup,smaug
Thunderbird architecture does not currently allow for redirecting channels to
child processes, so new schemes need to be isolated to the parent process.
`x-moz-ews` was selected to clearly designate that the scheme is private and
restricted to Mozilla/MZLA code. It doesn't follow the RFC 7595 recommendation
to use a registered domain as a namespace, but this was felt to be unwieldy.

Differential Revision: https://phabricator.services.mozilla.com/D212439
2024-06-03 21:04:18 +00:00
Daisuke Akatsuka 8743a1971a Bug 130327: Use exposable URL when updating history r=mak
Differential Revision: https://phabricator.services.mozilla.com/D193271
2024-03-07 05:11:51 +00:00
Sandor Molnar e80bc66ede Backed out 3 changesets (bug 130327) for causing build bustages @ toolkit/components/places/nsFaviconService.cpp
Backed out changeset 23d5336f3a16 (bug 130327)
Backed out changeset 7303defc69b0 (bug 130327)
Backed out changeset 7f3eb4071a8c (bug 130327)
2024-03-07 02:28:35 +02:00
Daisuke Akatsuka 0d166c6c73 Bug 130327: Use exposable URL when updating history r=mak
Differential Revision: https://phabricator.services.mozilla.com/D193271
2024-03-06 23:56:37 +00:00
Daisuke Akatsuka 352c077df4 Bug 1849866: Rename moz-anno:favicon protocol to cached-favicon r=necko-reviewers,places-reviewers,valentin,mak
Differential Revision: https://phabricator.services.mozilla.com/D198130
2024-01-24 22:05:42 +00:00
Daniel Holbert f05bfd236f Bug 1834133 part 1: Remove about:config prefs layout.css.notify-of-unvisited and layout.css.always-repaint-on-unvisited. r=emilio
Update all of their usages to assume that they're true (which they have been, by-default, for several years).

Differential Revision: https://phabricator.services.mozilla.com/D178569
2023-05-20 06:07:48 +00:00
Florian Quèze abd5628380 Bug 1822062 - avoid sending NotifyVisited IPCs with no URIs, r=emilio.
Differential Revision: https://phabricator.services.mozilla.com/D172688
2023-03-15 18:29:59 +00:00
Emilio Cobos Álvarez 17ebd805d1 Bug 1760674. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D141958
2022-03-29 12:15:52 +00:00
Cristian Tuns f3979ba261 Backed out changeset ddf7a48e3bf1 (bug 1760674) for causing mochitest failures on Link.cpp CLOSED TREE 2022-03-29 07:39:21 -04:00
Emilio Cobos Álvarez cc01425709 Bug 1760674. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D141958
2022-03-29 10:56:50 +00:00
Emilio Cobos Álvarez a1276cb23f Bug 1714614 - Send visited query results only to interested processes. r=mak,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D117179
2021-07-21 12:23:33 +00:00
Alexandru Michis 6f4460b588 Backed out changeset 1e76e5ecdfbe (bug 1714614) for causing gtest and gv-junit failures.
CLOSED TREE
2021-06-10 17:35:20 +03:00
Emilio Cobos Álvarez 256ad21942 Bug 1714614 - Send visited query results only to interested processes. r=mak,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D117179
2021-06-10 12:21:42 +00:00
Simon Giesecke 51a0df5b0f Bug 708901 - Migrate to nsTHashSet in docshell. r=smaug,geckoview-reviewers,aklotz
Differential Revision: https://phabricator.services.mozilla.com/D108591
2021-03-25 08:04:20 +00:00
Csoregi Natalia 37fe7677dd Backed out 13 changesets (bug 708901, bug 1184468) for causing build bustage on GeckoViewHistory.cpp. CLOSED TREE
Backed out changeset b1e4c01e63b8 (bug 708901)
Backed out changeset 37b52cce83c0 (bug 708901)
Backed out changeset eee75f33f060 (bug 708901)
Backed out changeset 479bf64c7986 (bug 708901)
Backed out changeset 15a8fb94d15d (bug 708901)
Backed out changeset be31ccd9a61d (bug 708901)
Backed out changeset fc54f4eaedd5 (bug 708901)
Backed out changeset 03c3a56c3d13 (bug 708901)
Backed out changeset 73f11d3c1298 (bug 708901)
Backed out changeset aed22fd80893 (bug 708901)
Backed out changeset 74d8249fbe7e (bug 708901)
Backed out changeset acb725eb3c1d (bug 1184468)
Backed out changeset 70f3ea6efec4 (bug 1184468)
2021-03-24 19:26:20 +02:00
Simon Giesecke 44334f3542 Bug 708901 - Migrate to nsTHashSet in docshell. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D108591
2021-03-24 16:58:57 +00:00
Simon Giesecke d4b20a96d1 Bug 1691913 - Add some convenience methods to LookupResult and EntryHandle. r=xpcom-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D105475
2021-03-01 09:59:29 +00:00
Simon Giesecke 888e262627 Bug 1688833 - Migrate LookupForAdd to WithEntryHandle in docshell. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D104200
2021-02-09 18:19:38 +00:00
Emilio Cobos Álvarez 697cc96086 Bug 1680977 - Add a null-check.
aLink might be null in the parent process, and even though it's only
null when getting URIs via IPC (which should never hit this code path in
a correct execution), we don't trust the child process so this is safer.

Differential Revision: https://phabricator.services.mozilla.com/D99703
2020-12-14 18:01:39 +00:00
Emilio Cobos Álvarez 2a1b9ed204 Bug 1680977 - Don't bother sending visited queries for URIs that we never store in history. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D99585
2020-12-14 15:23:08 +00:00
Emilio Cobos Álvarez e6fa449c74 Bug 1680977 - Move nsNavHistory::CanAddURIToHistory to BaseHistory. r=mak
And do some minor improvements (use static prefs etc) while at it.

Differential Revision: https://phabricator.services.mozilla.com/D99584
2020-12-14 15:23:10 +00:00
Simon Giesecke c3d543181b Bug 1645339 - Use range-based for with nsTObserverArray in docshell. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D79493
2020-06-16 10:14:24 +00:00
Emilio Cobos Álvarez f27d39b31e Bug 1626586 - Make history notifications do a bit less work. r=mak,lina,agi,snorp
And batch them when notifying child processes.

This makes RegisterVisitedQuery potentially notify synchronously, but changes
the code to deal with it properly.

Differential Revision: https://phabricator.services.mozilla.com/D69187
2020-04-15 21:19:41 +00:00
Emilio Cobos Álvarez 1cf22c6021 Bug 1600362 - Cleanup IntersectionObserver. r=smaug
Initially this was going to be a simple cleanup: Remove some useless namespaces
here and there and so on, remove `using` statements from the header and so on.

But unfortunately, DOMIntersectionObserver.h (which is included in Element.h,
unnecessarily) ended up exposing `Element` unnamespaced to a lot of code, so I
had to fix that.

Differential Revision: https://phabricator.services.mozilla.com/D55316
2019-11-29 20:39:36 +00:00
Emilio Cobos Álvarez 1d49be7681 Bug 1593690 - Start visited queries from an idle timer. r=mak,lina
Getting visited colors is relatively low priority during page load. GeckoView
was using a 250ms timer, which was somewhat arbitrary.

If this turns out not to be acceptable for desktop, we can change it to a higher
priority timer.

This enables batching queries from the content process. The lesser priority of
the queries, plus the batching that this enables on the content process I hope
will make a dent on the performance regression that bug 1506842 introduces
as-is.

We should probably introduce batching in the other direction too, both of those
are potential follow-up work.

Differential Revision: https://phabricator.services.mozilla.com/D51621
2019-11-06 12:10:59 +00:00
Emilio Cobos Álvarez 39e8cb3e01 Bug 1591717 - Add a pref to notify of unvisited uris in the history service. r=mak,lina
Behind a pref to ensure that we can turn this off pretty easily if it has perf
impact.

I want to leave the repainting stuff to another bug to land separately, to track
potential (though I hope not!) perf regressions more easily.

Differential Revision: https://phabricator.services.mozilla.com/D50704
2019-11-04 13:28:58 +00:00
Emilio Cobos Álvarez 24c01a6bb1 Bug 1590816 - Remove a useless script blocker and comment from BaseHistory. r=mak
This was copied verbatim from places, but the only thing the code can do is
schedule runnables, which outlive the function, so there's no script that can
run.

Depends on D50502.

Differential Revision: https://phabricator.services.mozilla.com/D50503
2019-10-25 13:02:39 +00:00
Emilio Cobos Álvarez bb0ed3e522 Bug 1590816 - Don't remove tracked links from GeckoViewHistory. r=lina
And make the assertions consistent with places.

Differential Revision: https://phabricator.services.mozilla.com/D50502
2019-10-25 13:02:35 +00:00
Emilio Cobos Álvarez 2a6a2744e0 Bug 1590816 - Cleanup some link coloring APIs to make them infallible when appropriate. r=mak
GeckoView does this link clearing stuff (which is somewhat dubious), but always
used to return NS_OK.

The error handling case in Link.cpp was pretty broken anyway (it'd leave the
link marked as registered), so make that infallible, given we fatally assert in
the non-android case.

NotifyVisited is also infallible so make that infallible too.

There's no need to use NS_IMETHOD gunk when not using scriptable XPCOM, and
these functions are not called from script, so make them regular pure-virtual
functions.

Depends on D50478.

Differential Revision: https://phabricator.services.mozilla.com/D50480
2019-10-25 13:02:25 +00:00
Emilio Cobos Álvarez c4d376f966 Bug 1590816 - Various naming and comment cleanups, as suggested in review comments. r=mak
Depends on D50266

Differential Revision: https://phabricator.services.mozilla.com/D50478
2019-10-25 13:02:23 +00:00
Emilio Cobos Álvarez e2f2716243 Bug 1590816 - Make GetLinkDocument a static function again. r=mak
Now without a duplicate version on another file :)

Differential Revision: https://phabricator.services.mozilla.com/D50266
2019-10-25 13:02:22 +00:00
Emilio Cobos Álvarez cef1d98aa2 Bug 1590816 - Move NotifyVisited to BaseHistory. r=mak,lina
Differential Revision: https://phabricator.services.mozilla.com/D50265
2019-10-25 13:02:20 +00:00
Emilio Cobos Álvarez 751a9960be Bug 1590816 - Move Register and UnregisterVisitedCallback to BaseHistory. r=mak,lina
Differential Revision: https://phabricator.services.mozilla.com/D50264
2019-10-25 13:02:18 +00:00
Emilio Cobos Álvarez 11e2f7e4d9 Bug 1590816 - Move History::DispatchNotifyVisited and related code to BaseHistory. r=mak,lina
Interestingly the android implementation had a potentially serious bug (was
missing a script blocker).

Differential Revision: https://phabricator.services.mozilla.com/D50263
2019-10-25 13:02:16 +00:00
Emilio Cobos Álvarez 0e37f43a41 Bug 1590816 - Introduce mozilla::BaseHistory, and move tracked URIs and a simple function there. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D50262
2019-10-25 13:02:08 +00:00