Commit Graph
28 Commits
Author SHA1 Message Date
Simon Giesecke ca547db942 Bug 1673931 - Avoid including Element.h from header files.
Differential Revision: https://phabricator.services.mozilla.com/D96535

Depends on D96534
2020-11-23 16:08:40 +00:00
Ehsan Akhgari 200d6ea9cc Bug 836176 - Part 3: Remove nsIHTMLDocument; r=farre
Differential Revision: https://phabricator.services.mozilla.com/D32925
2019-06-04 17:27:43 +00:00
Ehsan Akhgari 9c98e2b335 Bug 1415270 - Part 1: Move nsHTMLDocument editing APIs to Document; r=farre,masayuki
Differential Revision: https://phabricator.services.mozilla.com/D32911
2019-05-31 01:37:26 +00:00
Masayuki Nakano b8cee28dc1 Bug 1549925 - Mark all methods of nsIDocumentStateListener as can_run_script r=m_kato
`nsIDocumentStateListener` is a scriptable interface and each method may run
any script.  So, we should mark them as `can_run_script`.  Then, we need to
mark a lot of editing methods because we need to mark
`EditorBase::EndTransactionInternal()` and `EditorBase::DoTransactionInternal()`
as `MOZ_CAN_RUN_SCRIPT`.

Differential Revision: https://phabricator.services.mozilla.com/D30360
2019-05-09 07:37:51 +00:00
Makoto Kato b87cd0d3e4 Bug 1540107 - Use nsEditingSession directly in nsDocShellEditorData. r=masayuki
`nsIEditingSession.SetupEditorOnWindow` is used in `nsDocShellEditorData`.
To get rid of it, I would like to use `nsEditSession` directly instead of
`nsIEditingSession`.

Differential Revision: https://phabricator.services.mozilla.com/D25537
2019-04-03 01:56:31 +00:00
Masayuki Nakano 1235730ef9 Bug 1539356 - Mark EditorBase::InsertNodeTransaction() as MOZ_CAN_RUN_SCRIPT r=m_kato
This patch marks `EditorBase::InsertNodeTransaction()` **and** its callers as `MOZ_CAN_RUN_SCRIPT`.

Unfortunately, this patch tells us that some `GetSomething()` methods may destroy the editor since `HTMLEditRules::GetNodesForOperation()`, `HTMLEditRules::GetNodesFromPoint()` and `HTMLEditRules::GetNodesFromSelection()` may change the DOM tree.  Additionally, initialization methods may destroy the editor since it may insert a bogus `<br>` node.

Note that this patch also removes some unused methods. I.e., they are not result of some cleaning up the code. This patch just avoids marking unused methods as `MOZ_CAN_RUN_SCRIPT`.

Differential Revision: https://phabricator.services.mozilla.com/D25027
2019-03-30 11:55:29 +00:00
Oana Pop Rus 88181686ae Backed out changeset 447c87c2d139 (bug 1539356) on request of Jorg K. a=backout 2019-03-30 00:42:32 +02:00
Masayuki Nakano 7ee9ea1943 Bug 1539356 - Mark EditorBase::InsertNodeTransaction() as MOZ_CAN_RUN_SCRIPT r=m_kato
This patch marks `EditorBase::InsertNodeTransaction()` **and** its callers as `MOZ_CAN_RUN_SCRIPT`.

Unfortunately, this patch tells us that some `GetSomething()` methods may destroy the editor since `HTMLEditRules::GetNodesForOperation()`, `HTMLEditRules::GetNodesFromPoint()` and `HTMLEditRules::GetNodesFromSelection()` may change the DOM tree.  Additionally, initialization methods may destroy the editor since it may insert a bogus `<br>` node.

Note that this patch also removes some unused methods. I.e., they are not result of some cleaning up the code. This patch just avoids marking unused methods as `MOZ_CAN_RUN_SCRIPT`.

Differential Revision: https://phabricator.services.mozilla.com/D25027
2019-03-29 10:55:31 +00:00
Ehsan Akhgari 498e2df734 Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
# ignore-this-changeset
2019-01-18 10:16:18 +01:00
Sylvestre Ledru e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Ehsan Akhgari 4ad4399cd3 Bug 1489786 - Remove the XPCOM component registration for nsEditingSession; r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D5351
2018-09-09 15:47:00 -04:00
Masayuki Nakano 3e72c5fe70 Bug 1387406 - part1: nsDocShellEditorData should store editor as HTMLEditor r=smaug
The editor stored by nsDocShellEditorData should be always HTMLEditor.  So, it should store the editor as HTMLEditor and its getter and setter should treat the editor as HTMLEditor too.

MozReview-Commit-ID: GgfCd3zB887
2017-08-04 21:42:13 +09:00
Birunthan Mohanathas 97a3d5cc75 Bug 1129795 - Convert rest of docshell/ to Gecko style. r=mccr8 2015-05-06 10:57:23 -07:00
Birunthan Mohanathas e9f6010617 Bug 1129795 - Make modelines consistent in docshell/base/. r=mccr8 2015-02-13 21:36:47 +02:00
Birunthan Mohanathas 9a04e80e2c Bug 1129795 - Convert docshell/base/ to Gecko style. r=mccr8,smaug 2015-02-13 21:36:37 +02:00
Ehsan Akhgari 3447c753ce Bug 1048242 - Fix more bad implicit constructors in docshell; r=smaug 2014-08-05 09:19:03 -04:00
Ehsan Akhgari 72f9dd261a Bug 912129 - Minimize the #includes in docshell/base; r=bzbarsky 2013-09-03 16:17:26 -04:00
Gervase Markham cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Michael Wu 0fe7772ece Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones 2011-09-28 23:19:26 -07:00
Boris Zbarsky 8d569520d0 Bug 474389. Fix the 'set up editor after this load' setup, which hasn't really worked for a while, except for initial loads in the window. r+sr=peterv 2009-01-23 10:16:10 -05:00
05a85c8e3f Fix for bug 430624 (Crash [@ nsDocShellEditorData::DetachFromWindow] with spellcheck attribute). Patch by cpearce, r=peterv, sr=jst. 2008-05-02 04:36:29 -07:00
c8c3e7e610 Bug 386782. save and restore editor state so that it isn't lost when a page goes into the bfcache and then comes back. patch by Chris Pearce, r+sr=peterv,a=beltzner 2008-04-23 14:36:17 -07:00
bedbc25538 Fix bug 400556 by tearing down editor a little earlier. r+sr=peterv 2007-12-02 18:07:16 -08:00
[email protected] b9819a8116 Fixing bug 209020. Make midas (document eiditing mode) not partially persist when leaving a page, and make it possible to turn off designMode dynamically in a page. [email protected], [email protected] 2005-02-23 21:27:20 +00:00
[email protected] cf0b0c064a Bug 236613: change to MPL/LGPL/GPL tri-license. 2004-04-17 21:52:36 +00:00
[email protected] 8c98e13062 Fixed nsDocShell leak and nsEditingSession init after forced reload of document. b=180146, r=cmanske, sr=sfraser 2002-11-20 06:25:42 +00:00
[email protected] 9c3517f8f8 Fixed nsDocShell leak and nsEditingSession init after forced reload of document. b=180146, r=cmanske, sr=sfraser 2002-11-20 06:23:05 +00:00
[email protected] 6c2b3243c1 files not in build yet. BUG 115922. embedding work for editor. checking in files not in build yet to make tree landing more smooth. 2002-01-30 04:44:14 +00:00