Nika Layzell
ce0f2fd9a8
Bug 1814683 - Part 1: Combine parent/child fields in IPDL structs/unions, r=ipc-reviewers,necko-reviewers,mccr8
...
This combines the multiple fields or variants which were previously used to
track sided types like protocol types into a single field wrapped with a
SideVariant.
This will be used in the next part to avoid the need for default constructors
for actor types allowing the proper types to be used.
Differential Revision: https://phabricator.services.mozilla.com/D168879
2023-03-20 15:40:31 +00:00
Iulian Moraru
0c8d23ecea
Backed out 14 changesets (bug 1607634, bug 1814683, bug 1815177, bug 1814686) for causing build bustages on MaybeStorageBase. CLOSED TREE
...
Backed out changeset ae1c0551cea5 (bug 1815177)
Backed out changeset a11cafaa1884 (bug 1814686)
Backed out changeset 621507521762 (bug 1814686)
Backed out changeset ad692c73e381 (bug 1814686)
Backed out changeset 3be031e503dc (bug 1607634)
Backed out changeset aebbaa145d2d (bug 1607634)
Backed out changeset 9aa1f346fe14 (bug 1607634)
Backed out changeset e3eb77ad55ca (bug 1607634)
Backed out changeset e60591e5d5cf (bug 1607634)
Backed out changeset 6e43042d204a (bug 1814683)
Backed out changeset 1706e88652d6 (bug 1814683)
Backed out changeset 6878a1590e91 (bug 1814683)
Backed out changeset b1c980c834d8 (bug 1814683)
Backed out changeset 94480b82d102 (bug 1814683)
2023-03-15 01:58:36 +02:00
Nika Layzell
a0d0b2fb86
Bug 1814683 - Part 1: Combine parent/child fields in IPDL structs/unions, r=ipc-reviewers,necko-reviewers,mccr8
...
This combines the multiple fields or variants which were previously used to
track sided types like protocol types into a single field wrapped with a
SideVariant.
This will be used in the next part to avoid the need for default constructors
for actor types allowing the proper types to be used.
Differential Revision: https://phabricator.services.mozilla.com/D168879
2023-03-14 19:31:36 +00:00
Harveer Singh
4662926536
Bug 1636050 - PCacheOp protocol is now refcounted. r=dom-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D85780
2022-07-21 03:22:26 +00:00
Chris Peterson
5ac4034b03
Bug 1691889 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/. r=peterv
...
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
The [[nodiscard]] attribute must precede a function declaration's declaration specifiers (like static, extern, inline, or virtual). The __attribute__((warn_unused_result)) attribute does not have this order restriction.
Differential Revision: https://phabricator.services.mozilla.com/D107355
2021-03-10 08:19:25 +00:00
Sylvestre Ledru
68b806d604
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 17:04:01 +00:00
Butkovits Atila
a6e7dcc53f
Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE
2020-11-04 10:54:36 +02:00
Sylvestre Ledru
8f709b39e8
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 08:29:00 +00:00
Simon Giesecke
b728921956
Bug 1627892 - Use SafeRefPtr for Request. r=dom-workers-and-storage-reviewers,perry
...
Differential Revision: https://phabricator.services.mozilla.com/D70390
2020-05-11 12:13:48 +00:00
Simon Giesecke
571a9b1afd
Bug 1627892 - Make CacheWorkerRef derive from SafeRefCounted. r=dom-workers-and-storage-reviewers,perry
...
Differential Revision: https://phabricator.services.mozilla.com/D69960
2020-05-11 12:12:22 +00:00
Boris Zbarsky
3f4de1ace4
Bug 1619112 part 3. Pass UTF8 strings to MaybeRejectWithType/RangeError promise methods. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D65539
2020-03-06 21:05:48 +00:00
Boris Zbarsky
35bc278e5f
Bug 1615022 part 2. Require an rvalue reference to reject a Promise with an ErrorResult. r=farre,kvark
...
The rejection process consumes the ErrorResult, so an rvalue reference is the honest thing here.
Differential Revision: https://phabricator.services.mozilla.com/D62632
2020-02-14 15:42:30 +00:00
Boris Zbarsky
ed74c6c7c2
Bug 1152078. Remove the const_cast<ErrorResult> bits from DOM cache code. r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D61651
2020-02-05 16:15:07 +00:00
Boris Zbarsky
b92f406f4d
Bug 1581278 part 2. Add convenience methods for rejecting promises with various types of spec exceptions. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D46383
2019-09-19 13:02:39 +00:00
Boris Zbarsky
ebaf6de379
Bug 1581173 part 1. Add a way to more easily throw TypeErrors and RangeErrors with custom message strings via ErrorResult. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D45932
2019-09-20 02:19:18 +00:00
Andrea Marchesini
d20f028404
Bug 1559919 - Finish the WorkerHolder cleanup - part 10 - CacheWorkerHolder ported to WorkerRef, r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D35229
2019-07-12 11:17:59 +00:00
Alex Gaynor
2b388f974b
Bug 1533458 - replace OrVoid cache IPDL types with native maybe syntax; r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D22546
2019-03-21 11:09:44 +00:00
Sylvestre Ledru
e5a134f73a
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Jonathan Watt
4e2e2f0954
Bug 1417365 - Unified build issues in dom/cache. r=baku
2017-10-26 12:35:08 +01:00
Ben Kelly
05f0a13264
Bug 1397128 P8 Track which storage "namespace" each Cache object is associated with. r=tt
2017-09-15 12:25:41 -07:00
Sebastian Hengst
3733e4268a
Backed out changeset e37614cb41e1 (bug 1397128)
2017-09-15 18:28:21 +02:00
Ben Kelly
ba5947abb0
Bug 1397128 P8 Track which storage "namespace" each Cache object is associated with. r=tt
2017-09-15 09:11:23 -07:00
Ben Kelly
0c701d19d3
Bug 1362444 P2 Allow idle worker shutdown while Cache/CacheStorage DOM objects exist, but block it during Cache operation. r=baku
2017-05-10 09:27:10 -07:00
Ben Kelly
a7346ff365
Bug 1329669 Gracefully handle nullptr Cache actor in CacheStorage::Open() result. r=asuth
2017-01-10 08:20:15 -08:00
Ben Kelly
077c137d4a
Bug 1328686 Add diagnostic assertions to dom/cache. r=asuth
2017-01-06 12:41:15 -08:00
Kan-Ru Chen
1b9dd22e2d
Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm
...
We will use the new type for the generated IPDL message handler
prototype to make sure correct error handling method is called.
MozReview-Commit-ID: AzVbApxFGZ0
2016-11-15 04:26:00 +01:00
Kaku Kuo
bcb7169ac7
Bug 1292091 - Part 2 - replace MaybeResolve(JS::UndefinedHandleValue) with MaybeResolveWithUndefined(); r=bz
...
MozReview-Commit-ID: KNbxVcCVqts
2016-08-09 17:15:13 +08:00
Andrea Marchesini
796bda032a
Bug 1269154 - Get rid of WorkerFeature: WorkerHolder, r=khuey
2016-06-23 10:53:14 +02:00
Carsten "Tomcat" Book
ef49710e52
Backed out changeset 1c5d78c7ba43 (bug 1269154) for bustage on a CLOSED TREE
2016-06-23 10:13:54 +02:00
Andrea Marchesini
274f4e927f
Bug 1269154 - Get rid of WorkerFeature: WorkerHolder, r=khuey
2016-06-22 17:24:35 +02:00
Ben Kelly
2f4f1442e4
Bug 1093357 P3 Convert Cache to use IPCStream and AutoIPCStream. r=asuth
...
* * *
Bug 1093357 P3 interdiff 001 Use AutoIPCStream in dom/cache
2016-05-15 10:32:09 -07:00
Birunthan Mohanathas
bfee0fb40c
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-02-02 17:36:30 +02:00
Phil Ringnalda
d871b9515f
Back out 7 changesets (bug 1235261) for cpptest failures in TestTArray
...
CLOSED TREE
Backed out changeset d66c3f19a210 (bug 1235261)
Backed out changeset 467d945426bb (bug 1235261)
Backed out changeset 32b61df13142 (bug 1235261)
Backed out changeset c50bb8ed4196 (bug 1235261)
Backed out changeset 0ff0fa6fe81f (bug 1235261)
Backed out changeset df70e89669da (bug 1235261)
Backed out changeset 064969357fc9 (bug 1235261)
2016-01-31 10:10:57 -08:00
Birunthan Mohanathas
245cd6a02f
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-01-31 17:12:12 +02:00
Nathan Froyd
4e6d8f6705
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
2015-10-18 01:24:48 -04:00
Birunthan Mohanathas
a29151dc87
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
Ben Kelly
c41514ae25
Bug 1160227 Improve Cache API warnings. r=ehsan
2015-05-01 08:15:52 -07:00
Ben Kelly
b871f0effd
Bug 1160147 Improve Cache API WorkerFeature shutdown handling. r=baku
2015-05-01 08:13:36 -07:00
Ben Kelly
1e4ce069d9
Bug 1120501 P2 Move Cache Add/AddAll logic to child process. r=ehsan,smaug
2015-04-29 08:59:43 -07:00
Ben Kelly
82e0da9857
Bug 1110485 P8 Correctly set the Feature on the stream control child actor. r=baku
2015-04-16 12:00:16 -07:00
Ben Kelly
ccf34d901e
Bug 1110485 P4 Keep Cache Actors alive during async operations. r=baku
2015-04-16 12:00:15 -07:00
Ben Kelly
19788ebc81
Bug 1110485 P3 Move Fetch IPC PHeaderEntry type to Cache. Rename HeadesEntry. r=nsm
2015-04-16 12:00:15 -07:00
Ben Kelly
3eda7b0ad0
Bug 1110485 P2 Remove 'P' prefix from non-protocol IPC types in Cache API. r=baku
2015-04-16 12:00:15 -07:00
Ben Kelly
8160ae8ba1
Bug 1110485 P1 Refactor Cache IPC requests to use a separate actor. r=baku
2015-04-16 12:00:15 -07:00
Carsten "Tomcat" Book
d7a1b4397a
Backed out changeset 19f871364039 (bug 1110485) for causing bc1 winxp memory leaks on a CLOSED TREE
2015-04-15 09:55:53 +02:00
Carsten "Tomcat" Book
4fe7ad9602
Backed out changeset a74f0b2545ab (bug 1110485)
2015-04-15 09:54:48 +02:00
Carsten "Tomcat" Book
5c850292a0
Backed out changeset 1bbb1ec38652 (bug 1110485)
2015-04-15 09:54:45 +02:00
Carsten "Tomcat" Book
d689ffbffc
Backed out changeset f37dc22f4c4f (bug 1110485)
2015-04-15 09:54:39 +02:00
Ben Kelly
c6497b4262
Bug 1110485 P4 Keep Cache Actors alive during async operations. r=baku
2015-04-14 17:11:19 -07:00
Ben Kelly
07a1eaa64f
Bug 1110485 P3 Move Fetch IPC PHeaderEntry type to Cache. Rename HeadesEntry. r=nsm
2015-04-14 17:11:19 -07:00