Olli Pettay
acecfeab93
Bug 1856460, add support for HTMLDetailsElement.name, r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D215847
2024-07-08 20:39:44 +00:00
keithamus
af4755d972
Bug 1860457 - implement popover invoke defaults r=dom-core,sefeng
...
Differential Revision: https://phabricator.services.mozilla.com/D206184
2024-05-24 08:41:03 +00:00
Sandor Molnar
a9eee12a7d
Backed out changeset 4cce744a9cbb (bug 1860457) for causing wpt failures. CLOSED TREE
2024-05-24 07:07:16 +03:00
keithamus
05c91c9f0e
Bug 1860457 - implement popover invoke defaults r=dom-core,sefeng
...
Differential Revision: https://phabricator.services.mozilla.com/D206184
2024-05-23 20:56:58 +00:00
keithamus
1df93584c8
Bug 1867786 - Only dispatch for valid invoke actions r=dom-core,sefeng
...
Differential Revision: https://phabricator.services.mozilla.com/D206183
2024-05-16 09:49:50 +00:00
keithamus
dbce97da92
Bug 1888774 - make InvokeAction an enum, "auto" now implicit r=dom-core,sefeng
...
Only "custom" invoke actions (those with a dash) or well-defined built-in
actions can be defined. Auto action is now implicit from empty/null atom.
Differential Revision: https://phabricator.services.mozilla.com/D206182
2024-05-15 21:38:06 +00:00
Pier Angelo Vendrame
4323c13ff9
Bug 1880988 - Apply spoof English to the default detail summary. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D202203
2024-03-11 12:29:38 +00:00
Luke Warlow
9bdefe2698
Bug 1864331 - Implements HandleInvokeInternal for details element. r=smaug,CanadaHonk
...
Implements invoketarget defaults for details element, as specified in the open-ui "Invokers explainer".
(https://open-ui.org/components/invokers.explainer/ )
Differential Revision: https://phabricator.services.mozilla.com/D193382
2023-11-13 23:12:15 +00:00
Emilio Cobos Álvarez
2835e108b2
Bug 1817122 - Use a ToggleEvent for <details> toggle event. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D190060
2023-10-05 11:43:45 +00:00
Norisz Fay
85de591c5d
Backed out changeset a879c4fcdc4f (bug 1817122) for causing multiple failures CLOSED TREE
2023-10-05 04:29:13 +03:00
Emilio Cobos Álvarez
0ba6d614b7
Bug 1817122 - Use a ToggleEvent for <details> toggle event. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D190060
2023-10-04 22:01:20 +00:00
Emilio Cobos Álvarez
ded1458b5b
Bug 1829189 - Make OnAttrSetButNotChanged and AfterSetAttr infallible. r=smaug
...
Same rg + sed shenanigans as the first patch.
There were two that could fail, both due to OOM:
* HTMLInputElement::AfterSetAttr: If we fail (only in the type=range
case) we end up with an old value without it being clamped by
min/max/step.
* HTMLBodyElement::AfterSetAttr: If we fail we won't peek up the
DocShell's frame margins and styling could be incorrect.
That seems better than having to deal with broken states after we've
already set the attribute.
Depends on D176069
Differential Revision: https://phabricator.services.mozilla.com/D176070
2023-04-21 08:56:27 +00:00
Emilio Cobos Álvarez
bbb56ef32a
Bug 1308080 - Make <details> use a shadow tree as per spec. r=TYLin,smaug
...
The behavior changes match WebKit and Blink. I can look into upstreaming
some of these to WPT.
Differential Revision: https://phabricator.services.mozilla.com/D34754
2022-09-16 14:54:12 +00:00
Sandor Molnar
99feb142d1
Backed out changeset 27c0485f1740 (bug 1308080) for causing assertion failure in dom/ShadowRoot.h & wr failures in /css/css-multicol/multicol-span-all-dynamic CLOSED TREE
2022-09-14 05:47:49 +03:00
Emilio Cobos Álvarez
9673ac8ad9
Bug 1308080 - Make <details> use a shadow tree as per spec. r=TYLin,smaug
...
The behavior changes match WebKit and Blink. I can look into upstreaming
some of these to WPT.
Differential Revision: https://phabricator.services.mozilla.com/D34754
2022-09-13 21:52:50 +00:00
Sylvestre Ledru
68b806d604
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 17:04:01 +00:00
Butkovits Atila
a6e7dcc53f
Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE
2020-11-04 10:54:36 +02:00
Sylvestre Ledru
8f709b39e8
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 08:29:00 +00:00
Simon Giesecke
a69d79b6db
Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Simon Giesecke
968040c445
Bug 1613985 - Use default for equivalent-to-default constructors/destructors in dom/html. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D63171
2020-02-20 16:19:15 +00:00
Sylvestre Ledru
e5a134f73a
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Jeff Gilbert
70a22b2878
Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
...
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Emilio Cobos Álvarez
0348c342b8
Bug 1470930: Use enums for passing arguments for event dispatch. r=smaug
...
MozReview-Commit-ID: DsNuF7GAflJ
2018-06-26 18:22:06 +02:00
Andrew McCreight
2c2e9cbbbe
Bug 1412125, part 2 - Fix dom/ mode lines. r=qdot
...
This was automatically generated by the script modeline.py.
MozReview-Commit-ID: BgulzkGteAL
2017-10-26 15:08:41 -07:00
Nicholas Nethercote
7dbfdaf890
Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.
...
(Path is actually r=froydnj.)
Bug 1400459 devirtualized nsIAtom so that it is no longer a subclass of
nsISupports. This means that nsAtom is now a better name for it than nsIAtom.
MozReview-Commit-ID: 91U22X2NydP
2017-10-03 09:05:19 +11:00
Boris Zbarsky
d40e452ea9
Bug 656197 part 1. Remove the generic attr preparsing mechanism from BeforeSetAttr and just preparse class attributes directly in the one place that needs to do it. r=smaug
...
This removes the requirement that BeforeSetAttr comes before AttributeWillChange
(which needs the preparsed new value).
MozReview-Commit-ID: 87C6Mjc7ARh
2017-03-16 14:50:41 -04:00
Ting-Yu Lin
2cbd3d4835
Bug 1271549 - Remove details and summary preference. r=bz
...
Bug 1259889 Part 2 [1] cannot be reverted cleanly, so I manually undo those
changes in this patch. That is, remove the ability for html.css to
invalidate dynamically since it was added specifically for details element.
Although reftest-stylo.list explicit mentions "DO NOT EDIT!", but I still
remove details pref from the file, since it doesn't harm to edit it anyway.
[1] https://hg.mozilla.org/mozilla-central/rev/30aaf3805b56
MozReview-Commit-ID: FsyTGQTxujh
2016-11-16 14:02:58 +08:00
Edgar Chen
99917a281a
Bug 1309508 - Part 1: Remove ToggleEventDispatcher class that could be replaced by AsyncEventRunning() approach. r=bz
...
MozReview-Commit-ID: 7mp7yRVH31C
2016-10-13 12:22:13 +08:00
Jeremy Chen
e18b390d40
Bug 1273766 - part3: purge NS_UpdateHint inline. r=heycam
...
MozReview-Commit-ID: IIOT9jq8hOl
2016-05-23 11:26:03 +08:00
Ting-Yu Lin
24385dcb45
Bug 1225412 Part 2 - Add support to dispatch toggle events to details element. r=smaug
...
Add ontoggle event handler, and dispatch toggle events to the details
element if the open attribute is added or changed. According to the
spec, if a new toggle event has been queued, previous toggle events
should be aborted.
MozReview-Commit-ID: EN6Jf5hVHHD
2016-03-12 19:53:51 +08:00
Ting-Yu Lin
36cb8f27fa
Bug 1246185 - Do not collapsed <details> when preference off. r=bz
...
To retain backward compatibility, <details> tags should not collapse its
children when dom.details_element.enabled = false.
2016-02-09 14:07:01 +08:00
Ting-Yu Lin
edb31b5f99
Bug 591737 - Add pref for details and summary elements. r=bz
2016-01-20 23:20:43 +08:00
Ting-Yu Lin
5ec9e745ba
Bug 591737 - Construct details and summary in nsCSSFrameConstructor. r=bz
2016-02-02 17:39:49 +08:00
Ting-Yu Lin
cbdea44338
Bug 591737 - Add HTMLDetailsElement and webidl interface. r=bz
2016-01-20 23:20:40 +08:00