HeyPuter/firefox
1
0 Fork 0
mirror of https://github.com/HeyPuter/firefox.git synced 2026-11-13 20:14:57 -10:00
Code Issues Packages Projects Releases Wiki Activity
874,180 Commits 2 Branches 0 Tags
0917ddfc802da24cab5d63f0fcccdbe34494de6f
Commit Graph
46 Commits
Author SHA1 Message Date
Masayuki Nakano 9dfe52606b Bug 1906015 - part 2: Make the most do_QueryInterface users for nsIFormControl use new getter methods r=smaug,credential-management-reviewers,sessionstore-reviewers,sclements 
Unfortunately, the following QIs are still required.
https://searchfox.org/mozilla-central/rev/cbdfa503a87597b20719aae5f6a1efccd6cb3b7b/dom/html/nsIConstraintValidation.cpp#101,121

Depends on D215576

Differential Revision: https://phabricator.services.mozilla.com/D215577
 2024-07-10 00:46:59 +00:00
Emilio Cobos Álvarez 1df8c0453d Bug 1879579 - Clean up CompareTreePosition and related code. r=smaug 
Make TreeOrderedArray support what the form controls stuff needs, and
use it instead of custom nsContentUtils stuff.

Differential Revision: https://phabricator.services.mozilla.com/D201261
 2024-02-12 20:01:36 +00:00
Noemi Erli 1637a997a2 Backed out changeset 1acc95286189 (bug 1879579) for causing mass failures CLOSED TREE 2024-02-12 17:25:21 +02:00
Emilio Cobos Álvarez 97dc4d46da Bug 1879579 - Clean up CompareTreePosition and related code. r=smaug 
Make TreeOrderedArray support what the form controls stuff needs, and
use it instead of custom nsContentUtils stuff.

Differential Revision: https://phabricator.services.mozilla.com/D201261
 2024-02-12 00:01:23 +00:00
avandolder 8898fd2eec Bug 1837540 - Make radio button group navigation follow tree-order. r=sefeng,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D183426
 2023-08-03 01:52:19 +00:00
Narcis Beleuzu ed85f561c2 Backed out changeset 013278adabc7 (bug 1837540) for build bustages on mochitest.ini . CLOSED TREE 2023-08-03 02:25:53 +03:00
avandolder 9d805ab56a Bug 1837540 - Make radio button group navigation follow tree-order. r=sefeng,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D183426
 2023-08-02 23:04:07 +00:00
Edgar Chen b7f93a5d5c Bug 1556351 - Part 9: Implement FACE upgrade; r=smaug 
ElementInternal implements nsIFormControl and QueryInterface HTMLElement to a
nsIFormControl would return its associated ElementInternal instead.

Differential Revision: https://phabricator.services.mozilla.com/D125211
 2021-10-04 20:51:28 +00:00
Edgar Chen 4929cc1a94 Bug 1556351 - Part 5: Make nsGenericHTMLFormControlElement implement nsIFormControl; r=smaug 
nsGenericHTMLFormElement doesn't implement nsIFormControl now as HTMLElement would
inherit it to be able to be added into HTMLFormElement and HTMLFieldSetElement and
support some common form feature.

So some places that call the nsIFormControl method on nsGenericHTMLFormElement
directly would need to queryInterface it to nsIFormControl first, this should be
fine as those places are not in a hot path.

Differential Revision: https://phabricator.services.mozilla.com/D124788
 2021-10-04 20:51:27 +00:00
Emilio Cobos Álvarez 3daca083b1 Bug 1715134 - Make form control type an enum class. r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D117087
 2021-06-08 09:43:59 +00:00
Kagami Sascha Rosylight 86f808f056 Bug 1708228 - Part 1: Remove redundant flushing from HTMLFormControlsCollection r=smaug 
This was done in bug 324828 to workaround bug 22480 but shouldn't be needed anymore.

Differential Revision: https://phabricator.services.mozilla.com/D113805
 2021-04-30 11:25:22 +00:00
Simon Giesecke 87c754b1bd Bug 1184468 - Use nsTHashtable::Keys where possible. r=xpcom-reviewers,nika 
Differential Revision: https://phabricator.services.mozilla.com/D108588
 2021-03-24 17:56:50 +00:00
Sylvestre Ledru 68b806d604 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi 
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
 2020-11-04 17:04:01 +00:00
Butkovits Atila a6e7dcc53f Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE 2020-11-04 10:54:36 +02:00
Sylvestre Ledru 8f709b39e8 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi 
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
 2020-11-04 08:29:00 +00:00
Simon Giesecke ea268054bd Bug 1628715 - Part 7: Add MOZ_NONNULL_RETURN to infallible nsTArray::AppendElements. r=xpcom-reviewers,necko-reviewers,nika,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D70831
 2020-04-24 13:31:14 +00:00
Ryan Hunt ad7b7dbb30 Bug 1523969 part 6 - Move method definition inline comments to new line in 'dom/'. r=nika 
Differential Revision: https://phabricator.services.mozilla.com/D21106
 2019-02-25 16:05:29 -06:00
Emilio Cobos Álvarez dc336a73ba Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug 
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.

Overall it's not a very interesting patch I think.

nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.

I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.

While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.
 2019-01-03 17:48:33 +01:00
Sylvestre Ledru e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 
# ignore-this-changeset
 2018-11-30 11:46:48 +01:00
Jeff Gilbert 70a22b2878 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot 
MozReview-Commit-ID: JtTcLL5OPF0
 2018-06-26 17:05:01 -07:00
Boris Zbarsky 86d99155db Bug 1455676 part 14. Remove most use of nsIDOMNode in dom/. r=qdot 2018-05-29 22:58:49 -04:00
Adrian Wielgosik 38f9a663ce Bug 1447389 - Remove nsIDOMNodeList. r=bz 
MozReview-Commit-ID: 11szZP6dS6V
 2018-04-25 23:01:30 +02:00
Boris Zbarsky 035ea3c391 Bug 1415677 part 6. Remove nsIDOMHTMLCollection. r=qdot 
MozReview-Commit-ID: E8P9o0bv63L
 2017-11-13 10:41:33 -05:00
Boris Zbarsky c37cf6640d Bug 1415677 part 3. Remove nsIDOMHTMLCollection::GetLength. r=qdot 
MozReview-Commit-ID: H9rdYf47WV
 2017-11-13 10:39:06 -05:00
Boris Zbarsky ff3eab73d6 Bug 1415677 part 2. Remove nsIDOMHTMLCollection::Item. r=qdot 
MozReview-Commit-ID: AQUjBQhXLHE
 2017-11-13 10:39:02 -05:00
Boris Zbarsky e76fe87c40 Bug 1415677 part 1. Remove nsIDOMHTMLCollection::NamedItem. r=qdot 
MozReview-Commit-ID: EppP6KSYSn6
 2017-11-13 10:38:59 -05:00
Ehsan Akhgari b04faac567 Bug 1385324 - Part 2: Rewrite HTMLFormControlsCollection::GetSortedControls() to use RefPtr instead of raw pointers; r=qdot 2017-07-28 15:27:55 -04:00
Sylvestre Ledru 9d4a84d778 Bug 1378712 - Remove all trailing whitespaces r=Ehsan 
MozReview-Commit-ID: Kdz2xtTF9EG
 2017-07-06 14:00:35 +02:00
Jessica Jong 0a69701a7e Bug 1358448 - Add radio back to a radio group after moving out of a form. r=smaug 
The container of a radio group is the form, if it belongs to a form, or the
document object otherwise.
When moving a radio out of a form, we should add it back to a radio group.
Similary, before moving the radio to a form, we should remove it from the
original radio group.

MozReview-Commit-ID: 22WsEhz2SXH
 2017-05-01 23:10:00 +02:00
Olli Pettay 45822311b7 Bug 1351860 - Move mType from HTMLInputElement to nsIFormControl and make GetType non-virtual inlined, r=jessica 2017-03-31 22:49:00 -04:00
Olli Pettay 694b05ce02 Backout Bug 1351860, r=backout 2017-03-31 16:55:32 -04:00
Olli Pettay fa83f6684e Bug 1351860 - Move mType from HTMLInputElement to nsIFormControl and make GetType non-virtual inlined, r=jessica 2017-03-31 13:13:36 -04:00
Cameron McCormack 5f9911da79 Bug 1328832 - Part 2: Rename mozFlushType to mozilla::FlushType and make it an enum class. r=bzbarsky 
MozReview-Commit-ID: D3fIngSHSsl
 2017-01-05 15:31:56 +08:00
Cameron McCormack a35ad172e6 Bug 1328832 - Part 1: Rename mozFlushType.h to FlushType.h. r=bzbarsky 
MozReview-Commit-ID: 1ubwNkBEdfz
 2017-01-05 14:54:02 +08:00
Olli Pettay 3898f7d882 Bug 1326507, remove NS_IMPL_CYCLE_COLLECTION_TRAVERSE_SCRIPT_OBJECTS, r=mccr8 2017-01-03 21:47:55 +02:00
Jessica Jong 7ef7e911f2 Bug 1310076 - Add 'datetime-local' to the list of valid types attributes for <input>. r=smaug 2016-10-24 03:35:00 +02:00
Jessica Jong e854e57b5b Bug 1278738 - Add 'week' to the list of valid types attributes for <input>. r=smaug 2016-08-15 23:15:00 -04:00
Jessica Jong 1a6a96c66a Bug 1278737 - Add 'month' to the list of valid types attributes for <input>. r=smaug 2016-07-03 23:19:00 +02:00
Sebastian Hengst b74bde4463 Backed out changeset 444a4a7233f7 (bug 1278737) for frequent web platform test 2 failure on OSX in form-validation-reportValidity.html. r=backout 2016-07-01 20:04:58 +02:00
Jessica Jong 88770ff520 Bug 1278737 - Add 'month' to the list of valid types attributes for <input>. r=smaug 2016-06-29 23:16:00 +02:00
Boris Zbarsky e7fcf1b1a1 Bug 1268852. Change <label> elements to not be form-associated anymore. r=bkelly,hsivonen,surkov 
The web platform tests changes are just a cherrypick of
https://github.com/w3c/web-platform-tests/pull/2926 so I don't have to add
failure annotations until the next test uplift.

I've audited our uses of nsIFormControl, and this patch looks to me like it
preserves existing behavior in all but the following cases:

1)  nsXBLPrototypeHandler::DispatchXBLCommand, the case of scrolling when space
is pressed while something inside a <label> is focused.  We used to not scroll
in this situation; I think this is a bug, so I'm changing that behavior to
scroll instead.

2)  In Accessible::RelationByType for the RelationType::DEFAULT_BUTTON case,
when mContent is a <label> we used to return its form's default submit element.
Now we will just return Relation().
 2016-05-26 19:39:03 -04:00
Boris Zbarsky 79a0215206 Bug 1270349 part 5. Use LegacyUnenumerableNamedProperties instead of passing flags to GetSupportedNames to determine whether named props on DOM proxies should be reflected in ownPropertyKeys. r=peterv 2016-05-09 22:25:40 -04:00
Birunthan Mohanathas 8a0d49fd21 Bug 1186806 - Part 1: Replace nsBaseHashtable::EnumerateRead() with iterators in HTMLFormControlsCollection. r=khuey 2015-07-27 18:45:12 -07:00
Ehsan Akhgari dfcb2d8044 Bug 1162789 - Add a comment explaining why mForm is not set to null during unlink 
Comment-only, landed on a CLOSED TREE, DONTBUILD
 2015-05-07 23:13:13 -04:00
Boris Zbarsky 3a822d99b4 Bug 1117172 part 3. Change the wrappercached WrapObject methods to allow passing in aGivenProto. r=peterv 
The only manual changes here are to BindingUtils.h, BindingUtils.cpp,
Codegen.py, Element.cpp, IDBFileRequest.cpp, IDBObjectStore.cpp,
dom/workers/Navigator.cpp, WorkerPrivate.cpp, DeviceStorageRequestChild.cpp,
Notification.cpp, nsGlobalWindow.cpp, MessagePort.cpp, nsJSEnvironment.cpp,
Sandbox.cpp, XPCConvert.cpp, ExportHelpers.cpp, and DataStoreService.cpp.  The
rest of this diff was generated by running the following commands:

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObject\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'

  find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(Binding(?:_workers)?::Wrap\((?:aCx|cx|aContext|aCtx|js), [^,)]+)\)/\1, aGivenProto)/g'
 2015-03-19 10:13:33 -04:00
Birunthan Mohanathas 86c0c5b215 Bug 946065 - Part 11: Move content/html/ to dom/ and flatten subdirectories. r=peterv 2014-10-25 20:24:55 +03:00