Commit Graph
31 Commits
Author SHA1 Message Date
Emilio Cobos Álvarez bf22d33f87 Bug 1895208 - Refactor IsFocusable checks to take flags rather than bool arguments. r=smaug
This doesn't change behavior on its own, but it's likely we want to make
the tab focusability more complicated in bug 1895184, and this will make
changes to this area less painful.

Differential Revision: https://phabricator.services.mozilla.com/D209525
2024-05-06 21:54:37 +00:00
Stanca Serban 8d6a9ece7a Backed out 3 changesets (bug 1851970) for causing mochitests failures in browser_aboutNetError_csp_iframe.js.
Backed out changeset a2536c6c6c23 (bug 1851970)
Backed out changeset 23ddc229d1a1 (bug 1851970)
Backed out changeset b99a620a535c (bug 1851970)
2023-11-28 18:43:55 +02:00
Vincent Hilla 71d1502fdb Bug 1851970 - Part 3: Activation behavior method for summary element. r=edgar
Differential Revision: https://phabricator.services.mozilla.com/D183992
2023-11-28 14:09:02 +00:00
Emilio Cobos Álvarez a4c71c9a3f Bug 1797957 - Fix HTMLSummaryElement::GetDetails() for XML pretty print. r=smaug
That's the only place where we have a non-anonymous summary in an UA
widget, which the code didn't handle correctly (it assumed that if we
were in an UA widget we were in a details shadow tree).

I could try to write a test for this if you think it's worth it but we
don't have many existing tests (non-reftest) for the XML prettyprinter
that I can see...

Differential Revision: https://phabricator.services.mozilla.com/D160662
2022-10-31 10:37:33 +00:00
Emilio Cobos Álvarez bbb56ef32a Bug 1308080 - Make <details> use a shadow tree as per spec. r=TYLin,smaug
The behavior changes match WebKit and Blink. I can look into upstreaming
some of these to WPT.

Differential Revision: https://phabricator.services.mozilla.com/D34754
2022-09-16 14:54:12 +00:00
Sandor Molnar 99feb142d1 Backed out changeset 27c0485f1740 (bug 1308080) for causing assertion failure in dom/ShadowRoot.h & wr failures in /css/css-multicol/multicol-span-all-dynamic CLOSED TREE 2022-09-14 05:47:49 +03:00
Emilio Cobos Álvarez 9673ac8ad9 Bug 1308080 - Make <details> use a shadow tree as per spec. r=TYLin,smaug
The behavior changes match WebKit and Blink. I can look into upstreaming
some of these to WPT.

Differential Revision: https://phabricator.services.mozilla.com/D34754
2022-09-13 21:52:50 +00:00
Adam Vandolder fb0c637c7e Bug 1748975 - Don't trigger click event on untrusted keypresses for buttons and summaries. r=edgar
Differential Revision: https://phabricator.services.mozilla.com/D154942
2022-08-25 01:25:58 +00:00
Norisz Fay 7b031e64a3 Backed out changeset 879e2ae70979 (bug 1748975) for causing reftest failures on key-enter-single-summary.html CLOSED TREE 2022-08-22 18:16:34 +03:00
Adam Vandolder ee7039297a Bug 1748975 - Don't trigger click event on untrusted keypresses for buttons and summaries. r=edgar
Differential Revision: https://phabricator.services.mozilla.com/D154942
2022-08-22 14:27:36 +00:00
Emilio Cobos Álvarez 680ad75223 Bug 1481400 - Centralize keyboard activation code. r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D116584
2021-06-03 08:15:24 +00:00
Sylvestre Ledru 68b806d604 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 17:04:01 +00:00
Butkovits Atila a6e7dcc53f Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE 2020-11-04 10:54:36 +02:00
Sylvestre Ledru 8f709b39e8 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 08:29:00 +00:00
Keith Cirkel 0adc795727 Bug 1599415 trigger focus when details summary element is clicked r=TYLin,smaug
Differential Revision: https://phabricator.services.mozilla.com/D72603
2020-05-05 21:09:42 +00:00
Simon Giesecke 968040c445 Bug 1613985 - Use default for equivalent-to-default constructors/destructors in dom/html. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D63171
2020-02-20 16:19:15 +00:00
Ting-Yu Lin 14baf6ba54 Bug 1524893 - Prevent Label and Summary elements from handling click event if clicking on interactive html content. r=smaug
This patch fix label element when
1. clicking on an interactive content in the shadow tree, or
2. clicking on non-interactive content in the shadow tree, but the
   shadow root's parent is interactive.

The fix for summary element is similar to label element.

Differential Revision: https://phabricator.services.mozilla.com/D18791
2019-02-07 23:23:45 +00:00
Sylvestre Ledru e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Jeff Gilbert 70a22b2878 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Boris Zbarsky 152cd3ba6e Bug 1447098 part 1. Rename FromContent on various DOM classes to FromNode. r=mystor
MozReview-Commit-ID: 202nkbmkwfR
2018-03-21 17:39:04 -04:00
Andrew McCreight 2c2e9cbbbe Bug 1412125, part 2 - Fix dom/ mode lines. r=qdot
This was automatically generated by the script modeline.py.

MozReview-Commit-ID: BgulzkGteAL
2017-10-26 15:08:41 -07:00
Ting-Yu Lin 2cbd3d4835 Bug 1271549 - Remove details and summary preference. r=bz
Bug 1259889 Part 2 [1] cannot be reverted cleanly, so I manually undo those
changes in this patch. That is, remove the ability for html.css to
invalidate dynamically since it was added specifically for details element.

Although reftest-stylo.list explicit mentions "DO NOT EDIT!", but I still
remove details pref from the file, since it doesn't harm to edit it anyway.

[1] https://hg.mozilla.org/mozilla-central/rev/30aaf3805b56

MozReview-Commit-ID: FsyTGQTxujh
2016-11-16 14:02:58 +08:00
Masayuki Nakano f75bc688b3 Bug 1254755 part.2 Rename WidgetKeyboardEvent::charCode to WidgetKeyboardEvent::mCharCode r=smaug
And mCharCode shouldn't be compared with NS_VK_*, nsIDOMKeyEvent::DOM_VK_*. Additionally, when it's compared with a character constant, cast isn't necessary.

MozReview-Commit-ID: JMT614copjG
2016-05-13 16:06:18 +09:00
Masayuki Nakano 55b60a37e4 Bug 1254755 part.1 Rename WidgetKeyboardEvent::keyCode to WidgetKeyboardEvent::mKeyCode r=smaug
And also WidgetKeyboardEvent::mKeyCode should be compared with NS_VK_* rather than nsIDOMKeyEvent::DOM_VK_*.

MozReview-Commit-ID: IKjQ1nr8XYe
2016-05-12 17:13:49 +09:00
William Chen 3f3db96963 Bug 1259590 - Remove B2G ACL code. r=khuey 2016-04-07 09:50:01 -07:00
Ting-Yu Lin 8a6a995fd8 Bug 1245424 Part 2 - Stop checking the existence of details frame before toggling. r=bz
MozReview-Commit-ID: 6Xgyu7DDquy
2016-03-24 15:05:29 +08:00
Ting-Yu Lin 972d7f0af5 Bug 1249556 - Implement toggling details by keyboard. r=smaug
The user can switch to the main <summary> by tab key, and toggle the
<details> by either 'space' key or 'enter' key.

'return' key is handled with 'keypress', and the 'space' key is handled
with 'keyup' like the HTMLInputElement.

MozReview-Commit-ID: HE6IduUGCpj
2016-03-19 20:37:09 +08:00
Ting-Yu Lin edb31b5f99 Bug 591737 - Add pref for details and summary elements. r=bz 2016-01-20 23:20:43 +08:00
Ting-Yu Lin b707636623 Bug 591737 - Implement toggling open details by mouse click. r=bz 2016-01-20 23:20:42 +08:00
Ting-Yu Lin 5ec9e745ba Bug 591737 - Construct details and summary in nsCSSFrameConstructor. r=bz 2016-02-02 17:39:49 +08:00
Ting-Yu Lin cbaa036780 Bug 591737 - Add HTMLSummaryElement. r=bz 2016-01-20 23:20:40 +08:00