HeyPuter/firefox
1
0 Fork 0
mirror of https://github.com/HeyPuter/firefox.git synced 2026-11-13 20:14:57 -10:00
Code Issues Packages Projects Releases Wiki Activity
874,180 Commits 2 Branches 0 Tags
0917ddfc802da24cab5d63f0fcccdbe34494de6f
Commit Graph
140 Commits
Author SHA1 Message Date
alwu f52bd78451 Bug 1550633 - part6 : clear track's cues list whenever track element's src attribute set, changed or removed. r=jya,baku 
According to the spec [1], we should empty track's cue list whenever a track element has its src attribute set, changed, or removed.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:attr-track-src

Differential Revision: https://phabricator.services.mozilla.com/D31552
 2019-05-23 09:03:40 +00:00
alwu dfde8ca81f Bug 1550633 - part2 : maybe start loading resource when the track's mode changes. r=jya 
According to the spec [1], the user agent must start the track processing model when text track has its text track mode changed.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:start-the-track-processing-model

Differential Revision: https://phabricator.services.mozilla.com/D31372
 2019-05-23 09:05:02 +00:00
alwu 7327149474 Bug 1550633 - part1 : HTMLTrackElement should not load resource when its text track is disable. r=jya 
According to the spec step2 [1], we should not load resource for the track element which text track is disabled.

[1] https://html.spec.whatwg.org/multipage/media.html#start-the-track-processing-model

Differential Revision: https://phabricator.services.mozilla.com/D31371
 2019-05-23 09:05:04 +00:00
Mihai Alexandru Michis 38a06a0389 Backed out 22 changesets (bug 1550633) for browser-chrome failure at browser_cache.js. CLOSED TREE 
Backed out changeset 87067f045e1e (bug 1550633)
Backed out changeset a42883570179 (bug 1550633)
Backed out changeset bf1426571565 (bug 1550633)
Backed out changeset 97f61668f78c (bug 1550633)
Backed out changeset e22ef6f848aa (bug 1550633)
Backed out changeset 22213d6f047c (bug 1550633)
Backed out changeset 27e03b195718 (bug 1550633)
Backed out changeset 9a5e3e6b8c21 (bug 1550633)
Backed out changeset d338d667dcbd (bug 1550633)
Backed out changeset abc099f50543 (bug 1550633)
Backed out changeset ed0f76cca0d9 (bug 1550633)
Backed out changeset 4b193e156faa (bug 1550633)
Backed out changeset fefc8d667b9c (bug 1550633)
Backed out changeset e4128df1406b (bug 1550633)
Backed out changeset 9ad7d7b5ef6d (bug 1550633)
Backed out changeset d8fdfd9505bf (bug 1550633)
Backed out changeset 679ce0bdbf18 (bug 1550633)
Backed out changeset f75c225dc273 (bug 1550633)
Backed out changeset 4346465d73b1 (bug 1550633)
Backed out changeset 4c8fd0720cc2 (bug 1550633)
Backed out changeset 81545b2c0b58 (bug 1550633)
Backed out changeset 12fc5abcd066 (bug 1550633)
 2019-05-23 11:54:26 +03:00
alwu d4a0c4d365 Bug 1550633 - part15 : return error when we failed to create channel. r=jya 
The channel might not be created correctly if we pass invaild url (eg. "invalid://url"), we should handle this error.

Differential Revision: https://phabricator.services.mozilla.com/D32038
 2019-05-22 22:22:54 +00:00
alwu 8f3d6bb24a Bug 1550633 - part10 : automatically capture and print the address of track element in debug log and add new log. r=jya 
To reduce non-neccesary input, we can always capture `this` and print the address in the log, and use same log level for all of them.

Differential Revision: https://phabricator.services.mozilla.com/D31559
 2019-05-20 09:38:08 +00:00
alwu f73a1ec682 Bug 1550633 - part9 : capture 'this' in lambda. r=jya 
There are too many `self` used in the lambda, we can just capture `this` to remove redudant `self`.

Differential Revision: https://phabricator.services.mozilla.com/D31558
 2019-05-20 09:37:44 +00:00
alwu 680f31b952 Bug 1550633 - part8 : no need to reload if the new url is the same. r=jya 
Accoding to spec [1], after loading finished, the start the track processing model would stop at step12 and wait until the track URL changes to the URL which is not equal to the URL we have loaded before. That means, if we change track URL to the same URL we loaded before, we won't have to reload the resource.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:track-url-5

Differential Revision: https://phabricator.services.mozilla.com/D31557
 2019-05-22 01:49:35 +00:00
alwu 1e7f43ae52 Bug 1550633 - part7 : change ready state to 'FAILED_TO_LOAD' and dispatch 'error' event when we have no 'src' or have an empty url. r=jya 
`Failed to load` [1] indicates that the text track was enabled, but when the user agent attempted to obtain it, this failed in some way.

According to the spec [2], if fetching fails for any reason (network error, the server returns an error code, CORS fails, etc), or if URL is the empty string, then queue a task to first change the text track readiness state to `failed to load` and then fire an event named `error` at the track element. And spec [3] also mention that, if the track URL changes so that it is no longer equal to URL while fetching is ongoing, we also need to change the text track readiness state to`failed to load` and dispatch `error`.

[1] https://html.spec.whatwg.org/multipage/media.html#text-track-readiness-state
[2] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-failed-to-load
[3] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:text-track-failed-to-load-3

Differential Revision: https://phabricator.services.mozilla.com/D31556
 2019-05-21 13:37:15 +00:00
alwu 4465ab90bf Bug 1550633 - part6 : clear track's cues list whenever track element's src attribute set, changed or removed. r=jya,baku 
According to the spec [1], we should empty track's cue list whenever a track element has its src attribute set, changed, or removed.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:attr-track-src

Differential Revision: https://phabricator.services.mozilla.com/D31552
 2019-05-21 09:21:16 +00:00
alwu cd0627ec0a Bug 1550633 - part2 : maybe start loading resource when the track's mode changes. r=jya 
According to the spec [1], the user agent must start the track processing model when text track has its text track mode changed.

[1] https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:start-the-track-processing-model

Differential Revision: https://phabricator.services.mozilla.com/D31372
 2019-05-20 09:30:01 +00:00
alwu b8bc254b4c Bug 1550633 - part1 : HTMLTrackElement should not load resource when its text track is disable. r=jya 
According to the spec step2 [1], we should not load resource for the track element which text track is disabled.

[1] https://html.spec.whatwg.org/multipage/media.html#start-the-track-processing-model

Differential Revision: https://phabricator.services.mozilla.com/D31371
 2019-05-20 09:29:38 +00:00
dlee 3b26e613f7 Bug 1522412 - P2. Remove nsIChannel.LOAD_CLASSIFY_URI flag. r=Ehsan 
nsIChannel.LOAD_CLASSIFY_URI is no longer required so we can remove it from
the codebase.
In the mean time, we add a new LOAD_BYPASS_URL_CLASSIFIER load flag for
channel creator to be able to force channel to bypass URL classifier check.
The use of the new LOAD_BYPASS_URL_CLASSIFIER flag will be addressed in
the other patches.

Differential Revision: https://phabricator.services.mozilla.com/D22111
 2019-03-25 12:47:57 +00:00
Gurzau Raul 8cd94b1658 Backed out 7 changesets (bug 1522412) for xpcshell failures at test_shouldclassify.js on a CLOSED TREE. 
Backed out changeset 7c998456e1fd (bug 1522412)
Backed out changeset ebb581ddf1d1 (bug 1522412)
Backed out changeset 850e1c68d978 (bug 1522412)
Backed out changeset fe288a48cecb (bug 1522412)
Backed out changeset 5399bca472b1 (bug 1522412)
Backed out changeset 91e5b339fe11 (bug 1522412)
Backed out changeset b80098d0a5c4 (bug 1522412)
 2019-03-21 11:02:09 +02:00
Dimi Lee 2aec02089a Bug 1522412 - P2. Remove nsIChannel.LOAD_CLASSIFY_URI flag. r=Ehsan 
nsIChannel.LOAD_CLASSIFY_URI is no longer required so we can remove it from
the codebase.
In the mean time, we add a new LOAD_BYPASS_URL_CLASSIFIER load flag for
channel creator to be able to force channel to bypass URL classifier check.
The use of the new LOAD_BYPASS_URL_CLASSIFIER flag will be addressed in
the other patches.

Differential Revision: https://phabricator.services.mozilla.com/D22111
 2019-03-21 07:30:51 +00:00
Jonathan Kingston 58708e007c Bug 1520868 - Replacing AsyncOpen2 with AsyncOpen always r=valentin 
Replacing js and text occurences of asyncOpen2
Replacing open2 with open

Differential Revision: https://phabricator.services.mozilla.com/D16885
 2019-02-12 16:08:25 +00:00
Ehsan Akhgari 498e2df734 Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 
# ignore-this-changeset
 2019-01-18 10:16:18 +01:00
Emilio Cobos Álvarez dc336a73ba Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug 
Summary: Really sorry for the size of the patch. It's mostly automatic
s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
add the right namespacing and such.

Overall it's not a very interesting patch I think.

nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
nsIDocumentInlines.h into DocumentInlines.h.

I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.

While fixing up some of the bits I also removed some unneeded OwnerDoc() null
checks and such, but I didn't do anything riskier than that.
 2019-01-03 17:48:33 +01:00
Sylvestre Ledru 3ece000f7a Bug 1516555 - Reformat everything to the Google coding style r=Ehsan 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D15426
 2018-12-28 15:48:06 +00:00
Jean-Yves Avenard a5a7c908f9 Bug 1515021 - Interrupt steps if shutdown. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D15008
 2018-12-19 20:25:55 +00:00
Jean-Yves Avenard 313101b0e1 Bug 1443429 - P3. Don't use WebVTTListener while in stable state. r=smaug 
WebVTTListener is a JS wrapper around vtt.js.

Differential Revision: https://phabricator.services.mozilla.com/D14282
 2018-12-13 20:06:02 +00:00
Sylvestre Ledru e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 
# ignore-this-changeset
 2018-11-30 11:46:48 +01:00
Brian Grinstead 0d3ea34bc7 Bug 1425874 - Implement HTMLMarqueeElement r=bzbarsky 
This adds a new class for the marquee tag, instead of overloading HTMLDivElement.
It removes some of the XBL that was used to expose properties to web content.

Differential Revision: https://phabricator.services.mozilla.com/D3824
 2018-11-14 05:29:11 +00:00
Nathan Froyd f93834868a Bug 1492894 - part 1 - make the node hierarchy consistently constructed with NodeInfo&&; r=mccr8 
Various places in dom/ use the pattern:

  already_AddRefed<NodeInfo> ni = ...;

which is supposed to be disallowed by our static analysis code, but
isn't, for whatever reason.  To fix our static analysis code, we need to
eliminate instances of the above pattern.

Unfortunately, eliminating this pattern requires restructuring how Nodes
are created.  Most Node subclasses take `already_AddRefed<NodeInfo>&` in
their constructors, and a few accept `already_AddRefed<NodeInfo>&&`.  We
need to enforce the latter pattern consistently, which requires changing
dozens of source files.
 2018-09-21 16:45:49 -04:00
Emilio Cobos Álvarez bc847c0eef Bug 1479860: Remove unused aCompileEventHandlers argument from BindToTree. r=bz 
Mostly automatic via sed. Only parts which I touched manually (apart from a
couple ones where I fixed indentation or which had mispelled arguments) are the
callers. I may have removed a couple redundant `virtual` keywords as well when
I started to do it manually, I can revert those if wanted.

Most of them are just removing the argument, but in Element.cpp I also added an
assertion for GetBindingParent when binding the ShadowRoot's kids (the binding
parent is set from the ShadowRoot constructor, and I don't think we bind a
shadow tree during unlink or what not which could cause a behavior difference).

Differential Revision: https://phabricator.services.mozilla.com/D2574

MozReview-Commit-ID: 2oIgatty2HU
 2018-08-01 10:42:54 +02:00
Jeff Gilbert 70a22b2878 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot 
MozReview-Commit-ID: JtTcLL5OPF0
 2018-06-26 17:05:01 -07:00
Emilio Cobos Álvarez 0348c342b8 Bug 1470930: Use enums for passing arguments for event dispatch. r=smaug 
MozReview-Commit-ID: DsNuF7GAflJ
 2018-06-26 18:22:06 +02:00
Boris Zbarsky 5f0f9d3fb4 Bug 1429903 part 4. Remove nsIDOMEventTarget. r=mccr8 
MozReview-Commit-ID: 9XuenUHxfPx
 2018-04-20 00:49:30 -04:00
Emilio Cobos Álvarez a22d605d3a Bug 1454238: Remove nsINode::eMEDIA. r=bz 
MozReview-Commit-ID: LPutL6PlrgG
 2018-04-20 01:30:12 +02:00
Emilio Cobos Álvarez b1a35fbef7 Bug 1447358: Unifdef the old style system code. r=jwatt 
Summary:
This has been automatically generated using:

  http://dotat.at/prog/unifdef/

And:

find $OBJDIR -type f -name '*.h' |
while read FILE; do
  echo "$FILE"
  unifdef -m -DMOZ_STYLO -UMOZ_OLD_STYLE "$FILE";
done

find $OBJDIR -type f -name '*.cpp' |
while read FILE; do
  echo "$FILE"
  unifdef -m -DMOZ_STYLO -UMOZ_OLD_STYLE "$FILE";
done

MozReview-Commit-ID: I4NdKqbMXzJ

Reviewers: jwatt

Bug #: 1447358

Differential Revision: https://phabricator.services.mozilla.com/D779
 2018-03-21 10:20:34 +01:00
Kyle Machulis 9ce6990bc9 Bug 1407040 - Remove C++ usage of nsIDOMHTMLMediaElement; r=bz 
MozReview-Commit-ID: 6MGS4UqKwrU
 2018-02-14 21:22:38 -08:00
Cameron McCormack 34288f7f48 Bug 1430014 - Part 5: Stop building old style system classes when MOZ_OLD_STYLE is not defined. r=xidorn 
MozReview-Commit-ID: CIHyPdF7Exl
 2018-02-01 15:04:04 +11:00
Andrea Marchesini 3faaf5a84b Bug 1425458 - Resource timing entries Workers - part 0 - NS_NewChannel, r=smaug 
* * *
Bug 1425458 - Resource timing entries Workers - part 10 - Correct parameters in NS_NewChannel in nsDataObj.cpp, r=me
 2018-01-24 17:17:31 +01:00
Brindusan Cristian 1153f2c09e Backed out 12 changesets (bug 1425458) for mochitest failures on WorkerPrivate.cpp on a CLOSED TREE 
Backed out changeset 11997de13778 (bug 1425458)
Backed out changeset 100b9d4f36bc (bug 1425458)
Backed out changeset a29e9dbb8c42 (bug 1425458)
Backed out changeset b96d58fd945c (bug 1425458)
Backed out changeset f140da44ba68 (bug 1425458)
Backed out changeset af56400233d9 (bug 1425458)
Backed out changeset 7034af4332e4 (bug 1425458)
Backed out changeset f70500179140 (bug 1425458)
Backed out changeset 793bbfc23257 (bug 1425458)
Backed out changeset 2efb375a8ffc (bug 1425458)
Backed out changeset 07e781e37451 (bug 1425458)
Backed out changeset e875f3702a5f (bug 1425458)
 2018-01-24 20:47:48 +02:00
Andrea Marchesini b434804b93 Bug 1425458 - Resource timing entries Workers - part 0 - NS_NewChannel, r=smaug 2018-01-24 17:17:31 +01:00
Kris Maglione 48e53b3df5 Bug 1415352: Part 1a - Pass subject principal through to ParseAttribute. r=bz 
This is necessary in order to parse style attributes using the subject
principal of the caller, rather than defaulting to the page principal.

MozReview-Commit-ID: GIshajQ28la
 2017-11-01 20:35:52 -07:00
David Major 948e94b405 Bug 1408695 - Work around a VS2017 constexpr pointer math bug in HTMLTrackElement.cpp. r=gerald 2017-10-14 21:09:05 -04:00
Nicholas Nethercote 7dbfdaf890 Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro. 
(Path is actually r=froydnj.)

Bug 1400459 devirtualized nsIAtom so that it is no longer a subclass of
nsISupports. This means that nsAtom is now a better name for it than nsIAtom.

MozReview-Commit-ID: 91U22X2NydP
 2017-10-03 09:05:19 +11:00
Kyle Machulis 1bd2e725ef Bug 1405169 - Fix/Simplify Refcount and CC macros for HTML Element classes; r=bz 
MozReview-Commit-ID: CV77bM0Pq1e
 2017-10-02 16:42:09 -07:00
Andrew McCreight 84ee98de3c Bug 1391005 - Eliminate NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED. r=peterv 
Replace it with NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION, because it
has been the same for a while.

MozReview-Commit-ID: 5agRGFyUry1
 2017-08-29 16:02:48 -07:00
Bevis Tseng 2ecbda13e2 Bug 1378930 - Part 2: Remove the aName parameter from SchedulerGroup/DocGroup/DispatcherTrait. r=billm 2017-07-26 16:13:35 +08:00
Bill McCloskey ce42826bdf Bug 1372405 - Provide names for all runnables in the tree (r=froydnj) 
MozReview-Commit-ID: DKR6ROiHRS7
 2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book 238bf154d5 Backed out changeset 4f6302a98ae4 (bug 1372405) 2017-06-21 13:59:26 +02:00
Bill McCloskey 67e8af4720 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj) 
MozReview-Commit-ID: DKR6ROiHRS7
 2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book bbe9441993 Backed out changeset 9846de3bd954 (bug 1372405) 2017-06-20 08:27:02 +02:00
Bill McCloskey f69608368b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj) 
MozReview-Commit-ID: DKR6ROiHRS7
 2017-06-19 22:25:47 -07:00
bechen eab8f00c91 Bug 1343798 - Label runnables for HTMLTrackElement. r=jwwang 
MozReview-Commit-ID: El7LXJFAHiM
 2017-03-08 10:10:35 +08:00
bechen fa57853af2 Bug 1334112 -part3 : Trigger UpdateReadyState after unbind TrackElement's and TextTrack::SetReadyState. r=rillian 
MozReview-Commit-ID: pEeOzZSpak
 2017-02-21 15:44:10 +08:00
Henry Chang 48936c9334 Bug 1313711 - Fix track element CORS bug. r=dveditz 
MozReview-Commit-ID: SRWbiIuUdt
 2017-02-14 11:47:14 +08:00
bechen 4159bc7f3e Bug 1308862 - Null check for the innerWindow. r=jwwang 
MozReview-Commit-ID: DXrN3cnqV7U
 2016-10-12 17:26:20 +08:00