Commit Graph
130 Commits
Author SHA1 Message Date
Jonathan Kew 7d60f1be2f Bug 1903922 - Use upward-pointing disclosure triangle in vertical writing mode if directionality is RTL. r=layout-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D214530
2024-06-24 16:50:22 +00:00
Norisz Fay f4159a2118 Backed out 4 changesets (bug 1903922) for causing lint, mochitest, reftest failures
Backed out changeset 22921b44a1c1 (bug 1903922)
Backed out changeset dec0bbe3b578 (bug 1903922)
Backed out changeset becd5afc45c0 (bug 1903922)
Backed out changeset c82f3dea0d67 (bug 1903922)
2024-06-23 09:24:34 +03:00
Jonathan Kew d5d576fe03 Bug 1903922 - Use upward-pointing disclosure triangle in vertical writing mode if directionality is RTL. r=layout-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D214530
2024-06-22 09:30:36 +00:00
Iulian Moraru 5594117581 Backed out 3 changesets (bug 1903922) for causing bc failures on browser_openPreferences.js.
Backed out changeset 54e586b52673 (bug 1903922)
Backed out changeset 147da497b735 (bug 1903922)
Backed out changeset 5d3074a8077b (bug 1903922)
2024-06-22 03:01:42 +03:00
Jonathan Kew 2bc68b3365 Bug 1903922 - Use upward-pointing disclosure triangle in vertical writing mode if directionality is RTL. r=layout-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D214530
2024-06-21 16:24:06 +00:00
Emilio Cobos Álvarez 6320be3e20 Bug 1897361 - Share counter-style / list-style-type representation between Servo and Gecko. r=jwatt
It's not clear to me what is going on there or what caused it. I suspect
it might be:

  https://searchfox.org/mozilla-central/rev/1f46481d6c16f27c989e72b898fd1fddce9f445f/servo/components/style/gecko/values.rs#69

Which is the only potential from_raw_parts caller there. But hard to say
without a regression range.

However I've been wanting to get rid of that code for a while, and
this is a good opportunity for that.

The WithCounterStyleNameOrSymbols stuff isn't super pretty, but it has
only two callers, and something more complicated might require further
refactoring.

Differential Revision: https://phabricator.services.mozilla.com/D210814
2024-05-19 21:24:16 +00:00
Cristian Tuns fbb56a1610 Backed out changeset dffe004546c6 (bug 1897361) for causing reftest failures in /list-1.html CLOSED TREE 2024-05-19 17:09:47 -04:00
Emilio Cobos Álvarez ebdae8c849 Bug 1897361 - Share counter-style / list-style-type representation between Servo and Gecko. r=jwatt
It's not clear to me what is going on there or what caused it. I suspect
it might be:

  https://searchfox.org/mozilla-central/rev/1f46481d6c16f27c989e72b898fd1fddce9f445f/servo/components/style/gecko/values.rs#69

Which is the only potential from_raw_parts caller there. But hard to say
without a regression range.

However I've been wanting to get rid of that code for a while, and
this is a good opportunity for that.

The WithCounterStyleNameOrSymbols stuff isn't super pretty, but it has
only two callers, and something more complicated might require further
refactoring.

Differential Revision: https://phabricator.services.mozilla.com/D210814
2024-05-19 19:42:38 +00:00
Emilio Cobos Álvarez 057cadb272 Bug 1832173 - Finish removing HasArcFFI. r=boris
Use the actual Locked<T> types around (via a typedef, just for
convenience).

Differential Revision: https://phabricator.services.mozilla.com/D177824
2023-05-12 22:31:38 +00:00
Butkovits Atila 1f06787277 Backed out changeset f6e3d050b3e7 (bug 1832173) for causing bustages at CanvasRenderingContext2D.cpp. CLOSED TREE 2023-05-13 01:16:03 +03:00
Emilio Cobos Álvarez 5c9b936c47 Bug 1832173 - Finish removing HasArcFFI. r=boris
Use the actual Locked<T> types around (via a typedef, just for
convenience).

Differential Revision: https://phabricator.services.mozilla.com/D177824
2023-05-12 21:37:19 +00:00
Jonathan Kew ceba79c617 Bug 1830127 - Revert changeset 63b04ce7cf57 (bug 1808995) and remove associated WPT tests, because the behavior implemented there deviated from the Counter-Styles spec. r=emilio
Per https://github.com/w3c/csswg-drafts/issues/8619.

Differential Revision: https://phabricator.services.mozilla.com/D177240
2023-05-05 12:58:33 +00:00
Gagah Pangeran Rosfatiputra 726184a34e Bug 1801264 - Fix cyclic counter style show incorrectly when starting from negative value. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D167686
2023-02-10 12:16:07 +00:00
Jonathan Kew 3f96c279e5 Bug 1808995 - Handle @counter-style fallback behavior for the prefix and suffix descriptors. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D167409
2023-01-28 14:06:12 +00:00
Norisz Fay f42f1f3114 Backed out 4 changesets (bug 1808995) for causing Wr failures on CounterStyleManager.cpp CLOSED TREE
Backed out changeset d3ff45038932 (bug 1808995)
Backed out changeset 808aee125bc5 (bug 1808995)
Backed out changeset c2a49ee389d9 (bug 1808995)
Backed out changeset 3fab430c4e7c (bug 1808995)
2023-01-27 20:29:08 +02:00
Jonathan Kew a6bcaffd2b Bug 1808995 - Handle @counter-style fallback behavior for the prefix and suffix descriptors. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D167409
2023-01-27 13:05:27 +00:00
Emilio Cobos Álvarez 3574567db7 Bug 1803968 - Fix a bogus assert that was caught by GCC.
sizeof() is the wrong thing to test against there. And the 0 check is
unneeded now that counter styles are unsigned.

MANUAL PUSH: Trivial base toolchains fix CLOSED TREE
2022-12-07 12:13:53 +01:00
Ben Freist 33c4c1b8f3 Bug 1803968 - [refactor] Migrate NS_STYLE_LIST_STYLE_* defines r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D163792
2022-12-07 09:58:22 +00:00
Ting-Yu Lin 18989890b3 Bug 1745113 Part 3 - Change CountGraphemeClusters() to take a Span parameter. r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D135641
2022-01-13 18:36:04 +00:00
Mats Palmgren 9b44303ed1 Bug 1542807 part 1 - Create generated content and use normal box construction for list-style-type/list-style-image ::markers. r=emilio
The change from 0x25FE to 0x25AA for list-style-type:square
was approved here:
https://github.com/w3c/csswg-drafts/issues/6200#issuecomment-828616747

Differential Revision: https://phabricator.services.mozilla.com/D111691
2021-06-14 01:22:04 +00:00
Butkovits Atila c8f6a1fcf4 Backed out 7 changesets (bug 1542807) for causing failures at inert-retargeting-iframe.tentative.html. CLOSED TREE
Backed out changeset e9ef32fa2f2e (bug 1542807)
Backed out changeset 8fa0cb199975 (bug 1542807)
Backed out changeset 38daf64afe59 (bug 1542807)
Backed out changeset e3aee052c495 (bug 1542807)
Backed out changeset a71056d4c7cc (bug 1542807)
Backed out changeset cf91e7d0a37f (bug 1542807)
Backed out changeset eee949e5fd67 (bug 1542807)
2021-06-12 01:38:25 +03:00
Mats Palmgren d43697a633 Bug 1542807 part 1 - Create generated content and use normal box construction for list-style-type/list-style-image ::markers. r=emilio
The change from 0x25FE to 0x25AA for list-style-type:square
was approved here:
https://github.com/w3c/csswg-drafts/issues/6200#issuecomment-828616747

Differential Revision: https://phabricator.services.mozilla.com/D111691
2021-06-11 18:10:38 +00:00
Xidorn Quan 495d9c3b59 Bug 1714445 - Take negative sign into account when calculating padding. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D116935
2021-06-08 06:55:55 +00:00
Simon Giesecke 9e995a79e8 Bug 1184468 - Use nsBaseHashtable::Values. r=xpcom-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D108587
2021-03-24 17:56:49 +00:00
Simon Giesecke 95c38cc6b8 Bug 1691913 - Rename nsBaseHashtable::Put to InsertOrUpdate. r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika
This makes the naming more consistent with other functions called
Insert and/or Update. Also, it removes the ambiguity whether
Put expects that an entry already exists or not, in particular because
it differed from nsTHashtable::PutEntry in that regard.

Differential Revision: https://phabricator.services.mozilla.com/D105473
2021-02-26 09:11:46 +00:00
Philipp Zech d98b9eeb4d Bug 1625745 - Convert counter-system #defines to enum classes. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D72554
2020-05-03 14:36:55 +00:00
André Bargull 8911cf25d2 Bug 1625138 - Part 4: Replace mozilla::MakeUnsigned with std::make_unsigned. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68358
2020-03-28 13:57:12 +00:00
Simon Giesecke e613597e90 Bug 1613985 - Use default for equivalent-to-default constructors/destructors in layout. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D66016
2020-03-17 09:38:32 +00:00
Emilio Cobos Álvarez aab1464a8a Bug 1605803 - Use cbindgen for content property. r=xidorn
This cleans up and also allows us to keep the distinction between content: none
and content: normal, which allows us to fix the computed style we return from
getComputedStyle().

Do this last bit from the resolved value instead of StyleAdjuster, because
otherwise we need to tweak every initial struct for ::before / ::after.

Differential Revision: https://phabricator.services.mozilla.com/D58276
2020-01-05 13:10:39 +00:00
Sylvestre Ledru 69746836db Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D30883
2019-05-25 17:46:15 +00:00
arthur.iakab 699b884244 Backed out changeset a296439a25ff (bug 1519636) for frequent Windows cppunit failures CLOSED TREE 2019-05-24 14:26:01 +03:00
Sylvestre Ledru 10a773a4ca Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D30883
2019-05-24 09:59:17 +00:00
Emilio Cobos Álvarez 8ffd95c70d Bug 1552628 - Remove some more dead nsCSSValue code. r=xidorn
Most of it is not used at this point, this leaves the parts that are used by
MathML, which are minimal.

Differential Revision: https://phabricator.services.mozilla.com/D31706
2019-05-19 00:47:18 +00:00
Emilio Cobos Álvarez 2500e78a86 Bug 1551991 - followup: Give up on passing CounterSpeakAs by value since the previous patch busted non-Windows platforms.
CLOSED TREE
2019-05-17 07:01:26 +02:00
Emilio Cobos Álvarez e22896676d Bug 1551991 - Remove nsCSSValue bindings. r=jwatt
Depends on D31320

Differential Revision: https://phabricator.services.mozilla.com/D31321
2019-05-16 23:06:17 +00:00
Emilio Cobos Álvarez b33ba71f72 Bug 1551991 - Remove usage of nsCSSValue for SpeakAs. r=jwatt
Depends on D31319

Differential Revision: https://phabricator.services.mozilla.com/D31320
2019-05-16 23:06:06 +00:00
Emilio Cobos Álvarez 510b350a20 Bug 1551991 - Remove nsCSSValue usage of GetSymbols() GetAdditiveSymbols(). r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D31319
2019-05-16 23:05:54 +00:00
Emilio Cobos Álvarez cb433a9866 Bug 1551991 - Remove nsCSSValue usage for range checks in CounterStyleRule. r=jwatt
Depends on D31317

Differential Revision: https://phabricator.services.mozilla.com/D31318
2019-05-16 23:05:38 +00:00
Emilio Cobos Álvarez c36d535e59 Bug 1551991 - Remove nsCSSValue usage for negative / suffix / prefix. r=jwatt
Depends on D31316

Differential Revision: https://phabricator.services.mozilla.com/D31317
2019-05-16 23:05:25 +00:00
Emilio Cobos Álvarez 62b1d3d7ac Bug 1551991 - Remove nsCSSValue usage from GetPad. r=jwatt
Depends on D31315

Differential Revision: https://phabricator.services.mozilla.com/D31316
2019-05-16 23:05:10 +00:00
Ciure Andrei 0cdc899d9a Backed out 17 changesets (bug 1550554, bug 1549593, bug 1551991, bug 1529002) for failing multiple Android tests and Windows 2012 bustages CLOSED TREE
Backed out changeset 3bb3fafa62e2 (bug 1551991)
Backed out changeset e12a979de502 (bug 1551991)
Backed out changeset d81e4aa6bf0c (bug 1551991)
Backed out changeset c354e61f2a34 (bug 1551991)
Backed out changeset 37fd602bebc2 (bug 1551991)
Backed out changeset 6c1f00cc30ca (bug 1551991)
Backed out changeset 8a7a0329bdc3 (bug 1551991)
Backed out changeset 86159475ddd3 (bug 1551991)
Backed out changeset 35f91a9ea82a (bug 1529002)
Backed out changeset 6798155e71dc (bug 1529002)
Backed out changeset b90c2cf5b8c5 (bug 1550554)
Backed out changeset 882ab9868c95 (bug 1550554)
Backed out changeset b28a48e2ed21 (bug 1550554)
Backed out changeset 2c31fe18eefd (bug 1550554)
Backed out changeset 57f2362aa538 (bug 1550554)
Backed out changeset 45f171b26e95 (bug 1550554)
Backed out changeset 2e4b263c9410 (bug 1549593)
2019-05-16 13:17:10 +03:00
Emilio Cobos Álvarez c5e5943e12 Bug 1551991 - Remove nsCSSValue bindings. r=jwatt
Depends on D31320

Differential Revision: https://phabricator.services.mozilla.com/D31321
2019-05-16 14:31:52 +00:00
Emilio Cobos Álvarez 324e3a6962 Bug 1551991 - Remove usage of nsCSSValue for SpeakAs. r=jwatt
Depends on D31319

Differential Revision: https://phabricator.services.mozilla.com/D31320
2019-05-16 14:31:50 +00:00
Emilio Cobos Álvarez 0e4ad33645 Bug 1551991 - Remove nsCSSValue usage of GetSymbols() GetAdditiveSymbols(). r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D31319
2019-05-16 14:31:42 +00:00
Emilio Cobos Álvarez 9b17746b2a Bug 1551991 - Remove nsCSSValue usage for range checks in CounterStyleRule. r=jwatt
Depends on D31317

Differential Revision: https://phabricator.services.mozilla.com/D31318
2019-05-16 14:31:34 +00:00
Emilio Cobos Álvarez 2cd340d2d6 Bug 1551991 - Remove nsCSSValue usage for negative / suffix / prefix. r=jwatt
Depends on D31316

Differential Revision: https://phabricator.services.mozilla.com/D31317
2019-05-16 14:31:22 +00:00
Emilio Cobos Álvarez ff7af10d75 Bug 1551991 - Remove nsCSSValue usage from GetPad. r=jwatt
Depends on D31315

Differential Revision: https://phabricator.services.mozilla.com/D31316
2019-05-16 14:31:15 +00:00
Masayuki Nakano 394fc8aa9f Bug 1544343 - part 3: Make layout use mozilla::PresShell instead of nsIPresShell as far as possible r=emilio
This patch changes remaining things under `layout/`.  However, there are some
places which still need to use `nsIPresShell`.  That will be fixed in a
follow up bug.

Differential Revision: https://phabricator.services.mozilla.com/D27477
2019-04-16 07:25:10 +00:00
Masayuki Nakano edcab6281e Bug 1540930 - Make nsPresContext use mozilla::PresShell directly rather than via nsIPresShell r=emilio
`nsPresContext` should use `mozilla::PresShell` directly instead of
`nsIPresShell`.  This patch makes it.

Unfortunately, `nsPresContext` and `nsIFrame` have `PresShell()`.  Therefore,
we cannot use `PresShell*` in its methods so that this patch uses `mozilla::`
namespace prefix.

It might be better to rename them as `PresShellPtr()` in another bug.

Differential Revision: https://phabricator.services.mozilla.com/D25721
2019-04-03 12:40:26 +00:00
Masayuki Nakano bf9849f5f3 Bug 1540015 - part 2: Make nsPresContext.h stop including nsIPresShel.h and nsIPresShellInlines.h r=smaug
`*Inlines.h` shouldn't be included by another header file, but `nsPresContext.h`
does it.  This causes include-hell which blocks the following fix.

Additionally, it causes an include hell between `PresShell.h` vs.
`nsIPresShell.h` and `nsPresContext.h if `Document.h` includes `PresShell.h`.
Therefore, this patch also solves this include hell with adding
`nsPresContextInlines.h`.

Differential Revision: https://phabricator.services.mozilla.com/D25333
2019-03-29 15:11:22 +00:00