Commit Graph
67 Commits
Author SHA1 Message Date
Tooru Fujisawa adec9d4fda Bug 1907009 - Part 1: Add CacheExpirationTime type. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D217957
2024-08-06 05:38:23 +00:00
Tooru Fujisawa 1c0e44639b Bug 1893402 - Part 1: Accumulate the cache-ability of redirect responses for CSS cache. r=emilio,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D208844
2024-05-17 11:20:59 +00:00
Tamas Szentpeteri 4214cd6de9 Backed out 2 changesets (bug 1893402) for causing mochitest failures regarding nsGlobalWindowInner. CLOSED TREE
Backed out changeset e909b94c1280 (bug 1893402)
Backed out changeset beef636e1562 (bug 1893402)
2024-05-17 00:16:25 +03:00
Tooru Fujisawa 9f8759ef16 Bug 1893402 - Part 1: Accumulate the cache-ability of redirect responses for CSS cache. r=emilio,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D208844
2024-05-16 15:40:41 +00:00
Emilio Cobos Álvarez 1e6e3bfc0b Bug 1884759 - Don't use a mutex to handle parse promise blocking. r=firefox-style-system-reviewers,zrhoffman
It's more heavy-weight than it needs to be.

Differential Revision: https://phabricator.services.mozilla.com/D204287
2024-03-13 09:52:02 +00:00
sunil mayya c471ae360f Bug 1883391 - add telemetry to collect delta between OnDataFinished and OnStopRequest in CSSLoader. r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D203945
2024-03-10 19:03:13 +00:00
Cristian Tuns e6269d2d25 Backed out changeset 19762bd6f793 (bug 1883391) for causing build bustages in StreamLoader.cpp CLOSED TREE 2024-03-10 14:05:10 -04:00
sunil mayya fba95e17aa Bug 1883391 - add telemetry to collect delta between OnDataFinished and OnStopRequest in CSSLoader. r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D203945
2024-03-10 17:20:44 +00:00
sunil mayya 97971f8448 Bug 1864817 - implement OnDataFinished for CSSLoader. r=jesup,necko-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D189403
2024-03-10 14:12:04 +00:00
Cosmin Sabou ad055c9c92 Backed out changeset 9da36d4b3b14 (bug 1864817) for causing frequent StyleSheet related failures. CLOSED TREE 2024-03-09 03:43:15 +02:00
sunil mayya 4cb5965fd1 Bug 1864817 - implement OnDataFinished for CSSLoader. r=jesup,necko-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D189403
2024-03-08 20:58:37 +00:00
Emilio Cobos Álvarez 488a396e1b Bug 1855861 - Make stylesheet load events only fire if the sheet has an owner node. r=smaug
This matches the behavior of other browsers, and avoids having to keep
alive the link element and thus associated document etc for too long.

Differential Revision: https://phabricator.services.mozilla.com/D192834
2023-11-06 17:05:10 +00:00
sunil mayya a2d96efab4 Bug 1851992 - implement empty nsIThreadRetargetableStreamListener::OnDataFinished for stream loader. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D191097
2023-10-27 13:30:12 +00:00
Narcis Beleuzu a71d185ff5 Backed out 6 changesets (bug 1851992) for DT failure on browser_net_image_cache.js . CLOSED TREE
Backed out changeset 3ceaf46f8f55 (bug 1851992)
Backed out changeset c9d322362e22 (bug 1851992)
Backed out changeset 673df3f83249 (bug 1851992)
Backed out changeset 46e18c56dd39 (bug 1851992)
Backed out changeset f9f9143ac713 (bug 1851992)
Backed out changeset 38c40d735ab7 (bug 1851992)
2023-10-24 13:16:40 +03:00
sunil mayya a1f2ae2904 Bug 1851992 - implement empty nsIThreadRetargetableStreamListener::OnDataFinished for stream loader. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D191097
2023-10-24 01:48:11 +00:00
Cristina Horotan c792918ab6 Backed out 5 changesets (bug 1851992) for causing multiple failures
Backed out changeset d28399b3d947 (bug 1851992)
Backed out changeset 95e4df69007a (bug 1851992)
Backed out changeset fa61d4e76827 (bug 1851992)
Backed out changeset 79969d9eb5cd (bug 1851992)
Backed out changeset 03c17255f1af (bug 1851992)
2023-10-17 14:48:23 +03:00
sunil mayya 8966939fb6 Bug 1851992 - implement empty nsIThreadRetargetableStreamListener::OnDataFinished for stream loader. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D191097
2023-10-17 08:27:50 +00:00
Emilio Cobos Álvarez 5eb0f0584e Bug 1850012 - Move subresource validation time lookup in css::StreamLoader to OnStartRequest. r=necko-reviewers,valentin
We should have all the needed information then.

Differential Revision: https://phabricator.services.mozilla.com/D186801
2023-08-24 17:10:45 +00:00
Emilio Cobos Álvarez 79eaea46ba Bug 1849720 - Retarget OnDataAvailable for the CSS stream loader. r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D186646
2023-08-23 11:17:32 +00:00
Stanca Serban 606c3d0eac Backed out changeset eccdb961d59c (bug 1849720) for causing Mn failures. CLOSED TREE 2023-08-22 21:28:08 +03:00
Emilio Cobos Álvarez b1ca49c7af Bug 1849720 - Retarget OnDataAvailable for the CSS stream loader. r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D186646
2023-08-22 15:56:13 +00:00
Nika Layzell df139e1b20 Bug 1757253 - Use CheckedInt to avoid unnecessary warning in 64-bit builds, r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D140237
2022-03-03 21:10:35 +00:00
Luca Greco 0e1997bc94 Bug 1746841 - Revert Bug 1747091 temporary workaround to prevent moz-extension css from being cached. r=emilio
Depends on D134508

Differential Revision: https://phabricator.services.mozilla.com/D135739
2022-01-19 19:58:13 +00:00
Emilio Cobos Álvarez c9fedead09 Bug 1747091 - Force CSS with moz-extension schemes to get revalidated temporarily. r=rpl
See bug 1746841 comment 11 for the right fix instead.

Differential Revision: https://phabricator.services.mozilla.com/D134424
2021-12-22 11:46:59 +00:00
Nika Layzell 0e975d0e8d Bug 1741665 - Align nsCString's public size_type better with other C++ APIs, r=mccr8,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D131422
2021-12-13 21:47:56 +00:00
ssummar 43e270e58d Bug 1603127 - Replaced mozilla::Tuple with std::tuple and applied structured bindings in mozilla/Encoding.h. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D129920
2021-11-08 08:14:00 +00:00
Cristian Tuns 3b4f87f69c Backed out changeset 7e8e3747c3f8 (bug 1603127) for causing toolchains build bustages (Bug 1739589). CLOSED TREE 2021-11-05 07:23:45 -04:00
ssummar f2f04d2ae8 Bug 1603127 - Replaced mozilla::Tuple with std::tuple and applied structured bindings in mozilla/Encoding.h. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D129920
2021-11-05 05:33:58 +00:00
Emilio Cobos Álvarez 5217ea7f29 Bug 1729477 - Tweak SubresourceCacheValidationInfo to account for chrome uris. r=tnikkel
Turns out my patch above causes some failures because chrome:// channels
don't have cache information, so we conservatively assume they always
expire, which causes some interesting timing issues in a single test.
Fun stuff.

Tweak the code so that SubresourceCacheValidationInfo has the
pre-existing data:// URI special-case and also special-cases chrome://
URIs.

Differential Revision: https://phabricator.services.mozilla.com/D124921
2021-09-09 09:32:11 +00:00
Sandor Molnar d67f868876 Backed out 3 changesets (bug 1729477) for causing devtools failures in browser_webconsole_sidebar_object_expand_when_message_pruned. CLOSED TREE
Backed out changeset 8cbf3101ed8a (bug 1729477)
Backed out changeset 7457834fb7d0 (bug 1729477)
Backed out changeset 1259d2d1f247 (bug 1729477)
2021-09-09 03:55:31 +03:00
Emilio Cobos Álvarez e43fdcf427 Bug 1729477 - Tweak SubresourceCacheValidationInfo to account for chrome uris. r=tnikkel
Turns out my patch above causes some failures because chrome:// channels
don't have cache information, so we conservatively assume they always
expire, which causes some interesting timing issues in a single test.
Fun stuff.

Tweak the code so that SubresourceCacheValidationInfo has the
pre-existing data:// URI special-case and also special-cases chrome://
URIs.

Differential Revision: https://phabricator.services.mozilla.com/D124921
2021-09-08 21:03:02 +00:00
Simon Giesecke fbb9c742c8 Bug 1679272 - Include ScopeExit.h exactly where used. r=andi
Differential Revision: https://phabricator.services.mozilla.com/D98888
2020-12-07 14:25:59 +00:00
Simon Giesecke ab6f0a7137 Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D82325
2020-09-23 15:17:15 +00:00
Emilio Cobos Álvarez d84fc97f38 Bug 1646776 - Move the preloader for stylesheets to SheetLoadData rather than StreamLoader. r=mayhemer
So as to make sense in a world where we can coalesce loads across
documents. The per-load object is the SheetLoadData, so this way we
guarantee that we fire the right events in presence of the load
coalescing that the SharedStyleSheetCache does.

Differential Revision: https://phabricator.services.mozilla.com/D80380
2020-06-22 18:10:07 +00:00
Emilio Cobos Álvarez c40560dbff Bug 1645180 - Allow to cache data: stylesheets across documents. r=firefox-style-system-reviewers,heycam
This is useful, simplifies testing this bug, and also matches the image
cache:

  https://searchfox.org/mozilla-central/rev/0e09b9191c02097034e46b193930f91c45b7885d/image/imgLoader.cpp#1867-1870

Differential Revision: https://phabricator.services.mozilla.com/D79376
2020-06-13 02:02:56 +00:00
Emilio Cobos Álvarez 4cd771cff4 Bug 1599160 - Better integration of the shared stylesheet cache with the network cache. r=tnikkel,mayhemer,heycam
Make the stylesheet cache respect the same headers as the image cache
does. This makes no-cache stylesheets work as they do now, which is
useful for developers that want to develop sites locally, and for
shift-reloads, etc.

Differential Revision: https://phabricator.services.mozilla.com/D78659
2020-06-12 19:06:04 +00:00
Razvan Maries 36281afc64 Backed out 7 changesets (bug 1599160) for damp failures. CLOSED TREE
Backed out changeset edb0e17f3c98 (bug 1599160)
Backed out changeset 64b42ac358e6 (bug 1599160)
Backed out changeset ce1521b895e1 (bug 1599160)
Backed out changeset 0b0ff0ad8db7 (bug 1599160)
Backed out changeset c7ef05dae614 (bug 1599160)
Backed out changeset 466cfd0ad5db (bug 1599160)
Backed out changeset b3f28494f0e7 (bug 1599160)
2020-06-12 02:40:38 +03:00
Emilio Cobos Álvarez 1834d6c0b6 Bug 1599160 - Better integration of the shared stylesheet cache with the network cache. r=tnikkel,mayhemer,heycam
Make the stylesheet cache respect the same headers as the image cache
does. This makes no-cache stylesheets work as they do now, which is
useful for developers that want to develop sites locally, and for
shift-reloads, etc.

Differential Revision: https://phabricator.services.mozilla.com/D78659
2020-06-11 11:42:01 +00:00
Honza Bambas 58712a68b4 Bug 1618536 - Preload for fonts, r=heycam,hsivonen
Depends on D72118

Differential Revision: https://phabricator.services.mozilla.com/D70235
2020-05-11 14:14:32 +00:00
Honza Bambas ecb6c710b1 Bug 1618293 - Make css::Loader derive and use PreloaderBase to support new preload as speculative load feature, r=smaug
Depends on D67481

Differential Revision: https://phabricator.services.mozilla.com/D68786
2020-05-11 14:08:08 +00:00
Emilio Cobos Álvarez f12321c6f7 Bug 1615832 - Make an assertion nightly-only.
We confirmed that this is a networking issue, no point in making beta /
devedition crash due to this. Still worth keeping it on nightly to monitor the
crash volume once the networking fix arrives.

Differential Revision: https://phabricator.services.mozilla.com/D69602
2020-04-03 17:33:53 +00:00
Sylvestre Ledru 230ce836cb Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan,kvark
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D63787
2020-02-24 15:33:38 +00:00
Emilio Cobos Álvarez ecec90a8f6 Bug 1615832 - Fix diagnostics for error paths in sync loads.
This can happen with invalid @import rules in userContent / userChrome.css

Differential Revision: https://phabricator.services.mozilla.com/D63002
2020-02-15 21:27:06 +00:00
Emilio Cobos Álvarez dc1f7109b5 Bug 1605895 - Add some assertions to catch misuse of the stream loader / load datas. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D62671
2020-02-14 14:54:32 +00:00
Bogdan Tara 041d1af93a Backed out changeset 60549faf4734 (bug 1605895) for StreamLoader related failures CLOSED TREE 2020-02-14 14:35:46 +02:00
Emilio Cobos Álvarez ba0a9602d1 Bug 1605895 - Add some assertions to catch misuse of the stream loader / load datas. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D62671
2020-02-13 11:08:36 +00:00
Emilio Cobos Álvarez 9e5fabd1b6 Bug 1607816 - Fix another usage that I had submitted to bug 1607826, but without which the previous patch doesn't build.
CLOSED TREE

MANUAL PUSH: bustage

Differential Revision: https://phabricator.services.mozilla.com/D59161
2020-01-08 18:15:23 +01:00
Alex Henrie f2bb7af9a9 Bug 1604011 - Remove dead assignment from StreamLoader::OnStopRequest. r=emilio,xidorn
Differential Revision: https://phabricator.services.mozilla.com/D57235
2019-12-15 10:22:50 +00:00
Emilio Cobos Álvarez a6bfa4b95b Bug 1600376 - Remove useless namespace qualifications in layout/style. r=jwatt
All these things are in the mozilla namespace and such. Clean up a bit.

Differential Revision: https://phabricator.services.mozilla.com/D55319
2019-11-30 11:57:10 +00:00
Emilio Cobos Álvarez b79e7d563f Bug 1571530 - Cleanup confusing lifetime of SheetLoadData. r=heycam
Saving a refcount bump is not worth the churn. Use a proper RefPtr<>
everywhere instead of manual refcounting, and don't make DoSheetComplete call
NS_RELEASE unconditionally.

Also, make clear by using references where null is expected or not.

Also, properly use a RefPtr in mPendingDatas, since they are strong pointers,
in fact.

Finally, remove some unused macros from nsCSSValue of which this code was the
last consumer.

Differential Revision: https://phabricator.services.mozilla.com/D41090
2019-08-16 10:56:09 +00:00