Commit Graph
1770 Commits
Author SHA1 Message Date
Zach Hoffman 38cd60f455 Bug 1914777 - Use cbindgen for border-image-repeat. r=firefox-style-system-reviewers,layout-reviewers,emilio
nsStyleBorder field mBorderImageRepeat replaces fields
mBorderImageRepeatH and mBorderImageRepeatY.

Differential Revision: https://phabricator.services.mozilla.com/D220074
2024-08-25 15:57:04 +00:00
Zach Hoffman 9e2cb2d327 Bug 1914777 - Use cbindgen for StyleBorderImageRepeatKeyword. r=firefox-style-system-reviewers,layout-reviewers,emilio
Generated enum StyleBorderImageRepeatKeyword replaces enum StyleBorderImageRepeat.

Differential Revision: https://phabricator.services.mozilla.com/D220073
2024-08-25 15:57:04 +00:00
Boris Chiou 8095281d3b Bug 1823901 - Add view-transition-name longhand in style system. r=layout-reviewers,firefox-style-system-reviewers,emilio
Add `view-transition-name` into style system, behind the preference,
"dom.viewTransitions.enabled".

We will use `view-transition-name` somewhere when we create the pseudo
elements. This patch only add this atom into style system for future
usage.

Differential Revision: https://phabricator.services.mozilla.com/D218120
2024-08-22 07:21:09 +00:00
Jonathan Watt 17dfe4673b Bug 1909358. Rename inset-area to position-area. r=dshin
Differential Revision: https://phabricator.services.mozilla.com/D219225
2024-08-15 11:30:12 +00:00
Norisz Fay ef5b050f4b Backed out changeset e007fa3293a7 (bug 1891486) for causing mass failures 2024-08-09 20:22:29 +03:00
Jonathan Kew d9049debfa Bug 1891486 - Reconstruct frames if the lang attribute is modified, to ensure we have correct quote marks. r=layout-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D218847
2024-08-09 16:04:24 +00:00
Jonathan Watt cb91c45833 Bug 1907809. Rename CSS position-try-options to position-try-fallbacks. r=emilio,firefox-style-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D216523
2024-07-15 18:50:05 +00:00
Jonathan Kew f18797f6fa Bug 1894546 - Treat content-visibility:auto as visible when document is being used as an image. r=layout-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D216320
2024-07-12 09:54:02 +00:00
Jonathan Kew cfb5c2420d Bug 1907081 - In print/preview context, always treat content-visibility:auto as visible. r=layout-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D216254
2024-07-12 09:54:01 +00:00
longsonr 7f16b5a981 Bug 1903546 - fix non-scaling-stroke r=emilio
This implements https://github.com/w3c/svgwg/issues/582 and therefore mostly reverts bug 1904891

Differential Revision: https://phabricator.services.mozilla.com/D216303
2024-07-11 20:10:36 +00:00
Emilio Cobos Álvarez 0f9636cd14 Bug 1907243 - Comment tweak as per matrix chat. DONTBUILD
MANUAL PUSH: Trivial tweak CLOSED TREE
2024-07-11 17:34:24 +02:00
Emilio Cobos Álvarez 7321b1a037 Bug 1907243 - Switching checkbox from/to none appearance requires reframing. r=jfkthame,layout-reviewers
This is a pre-existing bug that assertion caught.

Differential Revision: https://phabricator.services.mozilla.com/D216294
2024-07-11 15:22:50 +00:00
longsonr 6fb47123ad Bug 1904891 - Support viewport and screen options for non-scaling-stroke r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D215138
2024-07-03 17:42:10 +00:00
Ting-Yu Lin ed92f8906f Bug 1905001 Part 1 - Add logical accessors to IntrinsicSize. r=dholbert
By adding `ISize()` and `BSize()` to `IntrinsicSize`, we can simplify the
repetitive pattern that checks writing mode and gets the corresponding width or
height.

Differential Revision: https://phabricator.services.mozilla.com/D215047
2024-07-02 23:21:45 +00:00
Luke Warlow c6c488b7fa Bug 1901374: Implement field-sizing parsing r=emilio
This change adds a new layout.css.field-sizing.enabled pref that controls the availability of the field-sizing CSS property.

With the pref enabled this property now parses according to the spec.

Spec: https://drafts.csswg.org/css-ui/#field-sizing

Differential Revision: https://phabricator.services.mozilla.com/D212983
2024-06-12 21:07:30 +00:00
pstanciu 94250eafea Backed out changeset e1b316eca9ec (bug 1901374) for causing mochitest failures on test_animation-type-longhand.html 2024-06-12 00:42:25 +03:00
Luke Warlow c897e253d5 Bug 1901374: Implement field-sizing parsing r=emilio
This change adds a new layout.css.field-sizing.enabled pref that controls the availability of the field-sizing CSS property.

With the pref enabled this property now parses according to the spec.

Spec: https://drafts.csswg.org/css-ui/#field-sizing

Differential Revision: https://phabricator.services.mozilla.com/D212983
2024-06-11 12:00:50 +00:00
Tamas Szentpeteri 91eb944015 Backed out changeset b50c8f1824f0 (bug 1901374) for causing wpt failures on field-sizing-computed.html. CLOSED TREE 2024-06-11 05:32:54 +03:00
Luke Warlow b001d54e7a Bug 1901374: Implement field-sizing parsing r=emilio
This change adds a new layout.css.field-sizing.enabled pref that controls the availability of the field-sizing CSS property.

With the pref enabled this property now parses according to the spec.

Spec: https://drafts.csswg.org/css-ui/#field-sizing

Differential Revision: https://phabricator.services.mozilla.com/D212983
2024-06-10 21:14:55 +00:00
Jonathan Watt ca24f45edd Bug 1899949. Implement parsing of CSS 'position-try-options' property. r=emilio,firefox-style-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D212335
2024-06-04 17:14:37 +00:00
Jonathan Watt 53bb6cb24a Bug 1900195. Remove support for the 'align-tracks' and 'justify-tracks' properties. r=emilio
These properties were added as part of the experimental Masonry support added
in bug 1607954. Since then the CSS WG resolved to remove these properties in:
https://github.com/w3c/csswg-drafts/pull/9529

This patch is a fairly brain dead removal of the properties, simply changing
the consumer code to take the code paths that would have been taken previously
if the properties were not set. That leaves some obvious dead code, which has
been removed, but no attempt has been made to redesign the Masonry code to
"make sense" without these properties. That would require a more prolonged
effort to understand Masonry, how the spec has changed in the last four years,
and how we should best change our code.

For now, this removal is simply focused on reducing the amount of memory used
by nsStyleDisplay to unblock the landing of bug 1899949.

Differential Revision: https://phabricator.services.mozilla.com/D212358
2024-06-02 00:16:26 +00:00
Jonathan Watt d4087bed86 Bug 1897659. Implement parsing of CSS 'position-try-order' property. r=emilio,firefox-style-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D212220
2024-05-31 10:35:07 +00:00
Jonathan Watt 42bc18d72e Bug 1898887. Implement parsing of CSS 'inset-area' property. r=emilio,firefox-style-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D211955
2024-05-30 19:39:07 +00:00
Emilio Cobos Álvarez 5f86f91a61 Bug 1899187 - Use cbindgen for column-count. r=firefox-style-system-reviewers,layout-reviewers,boris
Differential Revision: https://phabricator.services.mozilla.com/D211784
2024-05-28 09:37:23 +00:00
Emilio Cobos Álvarez 716862543d Bug 1899187 - Use cbindgen for initial-letter. r=firefox-style-system-reviewers,layout-reviewers,boris
Differential Revision: https://phabricator.services.mozilla.com/D211782
2024-05-28 09:37:22 +00:00
Emilio Cobos Álvarez 1d2f00404f Bug 1899187 - Use cbindgen for border-spacing. r=firefox-style-system-reviewers,layout-reviewers,boris
Differential Revision: https://phabricator.services.mozilla.com/D211781
2024-05-28 09:37:22 +00:00
Emilio Cobos Álvarez dd4cff6234 Bug 1899187 - Use a real percentage for -moz-min-font-size-ratio. r=firefox-style-system-reviewers,layout-reviewers,boris
Differential Revision: https://phabricator.services.mozilla.com/D211780
2024-05-28 09:37:21 +00:00
Jonathan Watt b4d4983f4b Bug 1897756. Implement parsing of CSS 'position-visibility' property. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D210910
2024-05-28 00:52:04 +00:00
Emilio Cobos Álvarez f9b44817e4 Bug 1899126 - Simplify text-transform representation. r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D211731
2024-05-27 17:24:10 +00:00
Jonathan Watt 4ebaa96406 Bug 1897619. Implement parsing of CSS 'position-anchor' property. r=emilio,firefox-style-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D210880
2024-05-27 14:43:11 +00:00
Tamas Szentpeteri 03c9e65872 Backed out 2 changesets (bug 1897619) for causing wpt failures on position-anchor-basics.html
Backed out changeset d1e736673f03 (bug 1897619)
Backed out changeset 62489eeeb03e (bug 1897619)
2024-05-21 18:53:31 +03:00
Jonathan Watt e3ca566fd8 Bug 1897619. Implement parsing of CSS 'position-anchor' property. r=emilio,firefox-style-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D210880
2024-05-21 10:12:22 +00:00
Emilio Cobos Álvarez 6320be3e20 Bug 1897361 - Share counter-style / list-style-type representation between Servo and Gecko. r=jwatt
It's not clear to me what is going on there or what caused it. I suspect
it might be:

  https://searchfox.org/mozilla-central/rev/1f46481d6c16f27c989e72b898fd1fddce9f445f/servo/components/style/gecko/values.rs#69

Which is the only potential from_raw_parts caller there. But hard to say
without a regression range.

However I've been wanting to get rid of that code for a while, and
this is a good opportunity for that.

The WithCounterStyleNameOrSymbols stuff isn't super pretty, but it has
only two callers, and something more complicated might require further
refactoring.

Differential Revision: https://phabricator.services.mozilla.com/D210814
2024-05-19 21:24:16 +00:00
Cristian Tuns fbb56a1610 Backed out changeset dffe004546c6 (bug 1897361) for causing reftest failures in /list-1.html CLOSED TREE 2024-05-19 17:09:47 -04:00
Emilio Cobos Álvarez ebdae8c849 Bug 1897361 - Share counter-style / list-style-type representation between Servo and Gecko. r=jwatt
It's not clear to me what is going on there or what caused it. I suspect
it might be:

  https://searchfox.org/mozilla-central/rev/1f46481d6c16f27c989e72b898fd1fddce9f445f/servo/components/style/gecko/values.rs#69

Which is the only potential from_raw_parts caller there. But hard to say
without a regression range.

However I've been wanting to get rid of that code for a while, and
this is a good opportunity for that.

The WithCounterStyleNameOrSymbols stuff isn't super pretty, but it has
only two callers, and something more complicated might require further
refactoring.

Differential Revision: https://phabricator.services.mozilla.com/D210814
2024-05-19 19:42:38 +00:00
Jonathan Watt 26c49a3375 Bug 1897605. Implement parsing of CSS 'anchor-scope'. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D210874
2024-05-18 16:47:28 +00:00
Jonathan Watt ea5cbc487d Bug 1897405 p1. Implement parsing of CSS 'anchor-name'. r=emilio,devtools-reviewers,firefox-style-system-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D210787
2024-05-18 16:47:27 +00:00
Ting-Yu Lin 27bb908f13 Bug 1824877 Part 2 - Rename nsHTMLScrollFrame to mozilla::ScrollContainerFrame. r=dholbert
Also, change the ScrollContainerFrame::GetFrameName() to return
"ScrollContainer" instead of "HTMLScroll".

Differential Revision: https://phabricator.services.mozilla.com/D210233
2024-05-15 17:50:48 +00:00
Emilio Cobos Álvarez 28bdfc0fba Bug 1281158 - Parse alternative text for the content property. r=dshin
This doesn't yet expose it to a11y but that will be done by the a11y
folks, since this blocks some of the a11y interop test-cases.

Modify the tests to not hit the network, and make -moz-alt-content not
exposed to content (we only need it for UA stylesheets).

Differential Revision: https://phabricator.services.mozilla.com/D209690
2024-05-08 16:06:47 +00:00
Emilio Cobos Álvarez 7de669cb54 Bug 1750072 - Allow to opt-out of password reveal using appearance: textfield. r=jwatt
Much like we do for the number input spinners.

Differential Revision: https://phabricator.services.mozilla.com/D208673
2024-05-06 15:13:35 +00:00
sid 568f27d168 Bug 1825386 - Converted LogicalAxis to enum class and type casted where necessary. r=TYLin
LogicalAxis is one of the Logical* enums. Converting it from enum to
enum class increases type safety. To run with the pre-existing code,
type casting was added when needed. Comments have been edited where
needed.

Differential Revision: https://phabricator.services.mozilla.com/D206108
2024-03-30 16:20:37 +00:00
Emilio Cobos Álvarez 1082ef75c8 Bug 1881220 - Change calc() resolution mode to always round than truncate-by-default. r=firefox-style-system-reviewers,boris
The regressing bug regressed some calc() expressions like the one in the
test-case:

  max-width: calc(100% - <some-fixed-length>);

Where floating point precision basically made us lose a little bit of
precision here and there.

Before bug 1841612, this worked because we'd operate in fixed point for
such simple expressions at least. Things could easily go equally south
for more complex things including e.g. rem().

Rounding seems like the better default for calc() since we basically
have no idea of what the output is going to be, and makes the answer
more likely to be precise.

Note that this only affects actual mixed calc() expressions: If things
resolve to a percentage we keep existing behavior.

Differential Revision: https://phabricator.services.mozilla.com/D202746
2024-02-27 11:06:52 +00:00
Boris Chiou 5ce2836649 Bug 1805727 - Part 1: Support transition-behavior longhand in style. r=emilio
Add transition-behavior longhand property. This doesn't include layout
animation support.

Differential Revision: https://phabricator.services.mozilla.com/D200408
2024-02-23 21:41:48 +00:00
Emilio Cobos Álvarez 3a411e96d5 Bug 1868316 - Remove user-find, make inert not findable. r=dholbert
As per the HTML spec.

Differential Revision: https://phabricator.services.mozilla.com/D201906
2024-02-16 20:18:06 +00:00
Emilio Cobos Álvarez 67262cc9ec Bug 1868316 - Prototype a user-find css property to control findability of text. r=jfkthame
Nightly-only for now waiting on CSSWG discussion.

Differential Revision: https://phabricator.services.mozilla.com/D199727
2024-02-02 09:45:45 +00:00
Jonathan Kew a5e405a07f Bug 1758391 - Rename text-wrap to text-wrap-style, and create the text-wrap shorthand. r=firefox-style-system-reviewers,emilio
This depends on having `text-wrap-mode`, introduced in bug 1852478 as part of
turning `white-space` into a shorthand.

Differential Revision: https://phabricator.services.mozilla.com/D198791
2024-01-26 09:40:03 +00:00
Jonathan Kew ba9032e630 Bug 1852478 - Convert CSS white-space into a shorthand that expands to white-space-collapse and text-wrap-mode longhands. r=firefox-style-system-reviewers,emilio
Note that although this builds, it would (by itself) result in some test breakage;
this is resolved in the following patches that build on this.

Differential Revision: https://phabricator.services.mozilla.com/D198790
2024-01-26 09:40:02 +00:00
Cristian Tuns b0886adb5c Backed out 4 changesets (bug 1758391, bug 1852478) for causing build bustages in UseCounterMetrics.cpp CLOSED TREE
Backed out changeset fe673f87d86a (bug 1852478)
Backed out changeset d466ccbd1aad (bug 1852478)
Backed out changeset c0fa98fec39a (bug 1758391)
Backed out changeset 04d322f23fd0 (bug 1852478)
2024-01-25 18:29:39 -05:00
Jonathan Kew 9c1ebcd370 Bug 1758391 - Rename text-wrap to text-wrap-style, and create the text-wrap shorthand. r=firefox-style-system-reviewers,emilio
This depends on having `text-wrap-mode`, introduced in bug 1852478 as part of
turning `white-space` into a shorthand.

Differential Revision: https://phabricator.services.mozilla.com/D198791
2024-01-25 22:20:05 +00:00
Jonathan Kew 87225af2ba Bug 1852478 - Convert CSS white-space into a shorthand that expands to white-space-collapse and text-wrap-mode longhands. r=firefox-style-system-reviewers,emilio
Note that although this builds, it would (by itself) result in some test breakage;
this is resolved in the following patches that build on this.

Differential Revision: https://phabricator.services.mozilla.com/D198790
2024-01-25 22:20:05 +00:00