Commit Graph
66 Commits
Author SHA1 Message Date
Sean c728db78f3 Bug 1908994 - Migrate NETWORK_CACHE_METADATA_* probes to Glean r=kershaw,acreskey,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D217177
2024-07-25 16:39:48 +00:00
Kershaw Chang b1346aabfe Bug 1893075 - Refactor CacheFileIOManager::Write, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D208739
2024-05-03 07:50:38 +00:00
Valentin Gosu 83def1272f Bug 1827504 - Remove last files of netwerk/cache/ r=sunil,geckoview-reviewers,zeid,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D175177
2023-04-13 09:04:24 +00:00
Kershaw Chang a1b5fc5bcb Bug 1615017 - Use a wrapped lock to protect data in CacheFileMetadata, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D126650
2021-09-27 20:59:17 +00:00
Valentin Gosu 9560d62d63 Bug 1714307 - Run modernize-use-default-member-init --fix check on netwerk r=necko-reviewers,kershaw
This changeset is the result of adding modernize-use-default-member-init to
tools/clang-tidy/config.yaml then proceeding to run
`./mach static-analysis check netwerk/ --fix`
I then went through the resulting fix and manually updated all of the member
variables which were missed due to them having a non-trivial constructor.

Note that the tool was only run on Linux, so code that only runs on some
platforms may have been missed.

The member variables that are still initialized in the contructor definition
are:
  - bitfields (not all currently supported compilers allow default-member-init
  - variables that are initialized via a parameter
  - variables that use code not visible in the header file

There are a few advantages to landing this change:
- fewer lines of code - now declaration is in the same place as initialization
  this also makes it easier to see when looking at the header.
- it makes it harder to miss initializing a member when adding a new contructor
- variables that depend on an include guard look much nicer now

Additionally I removed some unnecessary reinitialization of NetAddr members
(it has a constructor that does that now), and changed nsWifiScannerDBus to
use the thread-safe strtok_r instead of strtok.

Differential Revision: https://phabricator.services.mozilla.com/D116980
2021-06-11 07:10:41 +00:00
Csoregi Natalia e88581b300 Backed out changeset 6e00f8bd2acc (bug 1714307) for causing hazard bustage. CLOSED TREE 2021-06-09 21:50:03 +03:00
Valentin Gosu c01e585de7 Bug 1714307 - Run modernize-use-default-member-init --fix check on netwerk r=necko-reviewers,kershaw
This changeset is the result of adding modernize-use-default-member-init to
tools/clang-tidy/config.yaml then proceeding to run
`./mach static-analysis check netwerk/ --fix`
I then went through the resulting fix and manually updated all of the member
variables which were missed due to them having a non-trivial constructor.

Note that the tool was only run on Linux, so code that only runs on some
platforms may have been missed.

The member variables that are still initialized in the contructor definition
are:
  - bitfields (not all currently supported compilers allow default-member-init
  - variables that are initialized via a parameter
  - variables that use code not visible in the header file

There are a few advantages to landing this change:
- fewer lines of code - now declaration is in the same place as initialization
  this also makes it easier to see when looking at the header.
- it makes it harder to miss initializing a member when adding a new contructor
- variables that depend on an include guard look much nicer now

Additionally I removed some unnecessary reinitialization of NetAddr members
(it has a constructor that does that now), and changed nsWifiScannerDBus to
use the thread-safe strtok_r instead of strtok.

Differential Revision: https://phabricator.services.mozilla.com/D116980
2021-06-09 10:20:04 +00:00
Valentin Gosu 56cd5036af Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D116701
2021-06-04 12:35:16 +00:00
Butkovits Atila 1f3e4dc865 Backed out changeset c4b44c4ef15b (bug 1714307) for causing build bustages on nsHTTPCompressConv.h. CLOSED TREE 2021-06-04 13:53:37 +03:00
Valentin Gosu 5b4ead87fd Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D116701
2021-06-04 10:00:55 +00:00
Emilio Cobos Álvarez 3f4ce376a6 Bug 1599615 - Make some necko code less nsresult-happy. r=kershaw,valentin
Stuff that's infallible and not virtual has no reason to return an nsresult.

Differential Revision: https://phabricator.services.mozilla.com/D54831
2019-12-02 13:21:06 +00:00
Sylvestre Ledru ad31adba4c Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan
# ignore-this-changeset

Depends on D28954

Differential Revision: https://phabricator.services.mozilla.com/D28956
2019-05-01 08:47:10 +00:00
Michal Novotny f5eaaf384f Bug 1495336 - High limit of NETWORK_CACHE_METADATA_SIZE and NETWORK_CACHE_METADATA_FIRST_READ_SIZE probes is too low. r=chutten
Maximum size of elements in metadata is 64kB, the rest (URL, hashes and few uint32_t members) should normally fit into 1kB, so I set new high value of NETWORK_CACHE_METADATA_SIZE_2 to 65kB. With 66 buckets each bucket should be exactly 1kB wide.
NETWORK_CACHE_METADATA_FIRST_READ_SIZE doesn't provide any useful information and this patch removes the probe.
2019-01-09 10:27:00 +02:00
Sylvestre Ledru e5a134f73a Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Michal Novotny 810c774a1f Bug 1418028 - UBSan: null pointer passed to memcpy in CacheFileMetadata::WriteMetadata. r=honzab 2018-01-18 07:50:00 -05:00
Michal Novotny 079cf3b66f Bug 1414046 - Skip copying mHashArray in CacheFileMetadata::WriteMetadata if it's empty. r=valentin 2017-11-03 03:17:00 -04:00
Michal Novotny 850c895915 Bug 1403010 - Crash due to race condition in CacheFileMetadata::SizeOfExcludingThis when reading or writing metadata, r=valentin 2017-10-03 16:49:39 +02:00
Michal Novotny ccfdf28635 Bug 1352916 - Add release asserts to try to narrow down the source of the reported crashes. r=valentin 2017-04-05 08:13:00 -04:00
Michal Novotny 357c6b94e1 Bug 1343916 - CacheFile::Truncate doesn't update hashes in CacheFileMetadata, r=valentin 2017-03-09 17:28:56 +01:00
Tom Tromey a4b717ab39 Bug 1060419 - make log_print use Printf.h, r=froydnj
MozReview-Commit-ID: BIZ1GQEZ1vs
2016-12-15 20:16:31 -07:00
Andrew McCreight 209d4ee048 Bug 1323042 - forbid MOZ_COUNT_{CTOR,DTOR} for nsISupports classes; r=froydnj 2016-12-12 09:27:58 -05:00
Nathan Froyd f2d50c26f4 Backout aba6c73511a2 (bug 1307961) for massive test bustage resulting in a CLOSED TREE; r=alltheorange 2016-12-12 08:45:46 -05:00
Andrew McCreight 2f93d6e48d Bug 1307961 - require consistent bloatview reporting for nsISupports classes; r=froydnj 2016-12-12 07:58:33 -05:00
Michal Novotny 6265bfdf2d Bug 1258747 - Support for alternative data in CacheFile, r=honzab 2016-08-17 12:58:44 +02:00
Honza Bambas e1eaf2084a Bug 1292509 - Mark CacheFileHandles invalid ASAP we can't read metadata, r=michal 2016-08-05 11:10:00 +02:00
Michal Novotny 911d646438 Bug 1267980 - Leak buffers in CacheFileChunk and CacheFileMetadata during shutdown, r=honzab 2016-05-11 11:46:54 +02:00
Honza Bambas 88d540ea21 Bug 1032254 - Generic way to pin reasource in the HTTP cache, r=michal
* * *
Bug NNNNNNN - message, r=reviewer
2015-10-22 12:11:00 +02:00
Honza Bambas 213ca181dd Bug 1165269 - Use OriginAttributes in nsILoadContextInfo, r=michal+allstars 2015-10-11 18:13:09 +02:00
Michal Novotny a290271052 Bug 1177278 - Large OOMs in CacheFileMetadata::WriteMetadata, r=honzab 2015-07-22 15:23:16 +02:00
Birunthan Mohanathas a29151dc87 Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
The bulk of this commit was generated by running:

  run-clang-tidy.py \
    -checks='-*,llvm-namespace-comment' \
    -header-filter=^/.../mozilla-central/.* \
    -fix
2015-07-13 08:25:42 -07:00
Michal Novotny 3338621c85 Bug 1171724 - Large OOMs in CacheFileMetadata, r=honzab 2015-06-24 06:33:37 +02:00
Michal Novotny 2ef0ebc4df Bug 1141555 - HTTP cache v2 generates corrupted entries, r=jduell 2015-03-26 23:05:34 +01:00
Michal Novotny 0d57d2fe51 Bug 1139014 - Optimize memory allocations in CacheFileMetadata, r=honzab 2015-03-06 15:49:04 +01:00
Michal Novotny d533d6d313 Bug 1133739 - HTTP cache v2: Add telemetry probes to find out the best initial read size of the metadata (fixed missing initialization of mFirstRead in one constructor), r=jseward 2015-02-25 17:46:51 +01:00
Michal Novotny 5c17440712 Bug 1133739 - HTTP cache v2: Add telemetry probes to find out the best initial read size of the metadata, r=jduell 2015-02-23 16:13:02 +01:00
Honza Bambas df41234f0b Bug 1000338 - nsICacheEntry.lastModified not properly implemented, r=michal 2014-09-16 15:51:50 +02:00
Carsten "Tomcat" Book 4c057310ba Backed out changeset ce8f00cca9dd (bug 1000338) for XPC-2 test failures 2014-09-11 14:31:54 +02:00
Honza Bambas 654e1d3308 Bug 1000338 - nsICacheEntry.lastModified not properly implemented, r=michal 2014-09-11 11:44:31 +02:00
Michal Novotny c65103f840 Bug 1054425 - cache2: leak in CacheFileMetadata::WriteMetadata, r=jduell 2014-08-18 21:11:40 +02:00
Michal Novotny 357ecb53d6 Bug 1042192 - Use Cache2 I/O thread for callbacks from CacheFileIOManager, r=sworkman 2014-08-18 15:36:27 +02:00
Honza Bambas bd49b3e5b9 Bug 1034672 - Fix order of arguments to memcpy in WriteMetadata. r=michal 2014-07-16 10:07:48 -04:00
Michal Novotny 455b49dcaa Bug 1021612 - Fix offset calculation in CacheFileMetadata::ReadMetadata(), r=honzab 2014-06-08 00:00:57 +02:00
Honza Bambas ac742d35b0 Bug 916052 - Adapt about:cache to the HTTP cache v2 API, r=michal+MattN 2014-05-01 13:28:12 +02:00
Honza Bambas 363e4d697a Backing out bug 916052 (2557b51a47a0) for build bustage on linux/osx, r=bustage on CLOSED TREE 2014-04-30 13:05:43 +02:00
Honza Bambas a3fb819588 Bug 916052 - Adapt about:cache to the HTTP cache v2 API, r=michal+MattN 2014-04-30 12:39:18 +02:00
Birunthan Mohanathas eeb9aaaa94 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
Honza Bambas fb2a24ac11 Bug 999383 - optimize Open and Read inter-thread calls in CacheFileIOManager, r=michal 2014-04-26 18:42:07 +02:00
Michal Novotny 6cd996c63e Bug 994574 - HTTP cache v2: CacheFileMetadata::ParseMetadata() fails to parse any entry, r=honzab 2014-04-10 14:29:46 +02:00
Honza Bambas 2d71bee15e Bug 941698 - HTTP cache v2: add version information to cache entries, r=michal 2014-04-07 22:07:43 +02:00
Michal Novotny 2e2b9e63d9 Bug 988186 - HTTP cache v2: store all fields in CacheFileMetadata in network order on disk, r=honzab 2014-04-07 22:07:38 +02:00