Commit Graph
125 Commits
Author SHA1 Message Date
Emilio Cobos Álvarez 77c40caac6 Bug 1910698 - Remove nsIScriptError.sourceLine. r=smaug,devtools-reviewers,webdriver-reviewers,necko-reviewers,nchevobbe,kershaw,jdescottes,credential-management-reviewers,dimi
Afaict the source lines are not exposed anywhere in the UI.

Differential Revision: https://phabricator.services.mozilla.com/D218115
2024-08-01 17:12:48 +00:00
Emilio Cobos Álvarez a44b49af0b Bug 1910698 - Add a struct to represent JS caller location and more general warning source location. r=smaug,necko-reviewers,anti-tracking-reviewers,dom-storage-reviewers,pbz,kershaw,janv
Use it liberally across the tree. This could be cleaned up even more in the future.

Differential Revision: https://phabricator.services.mozilla.com/D218114
2024-08-01 17:12:48 +00:00
Sylvestre Ledru a3ea006705 Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,necko-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,devtools-reviewers,anti-tracking-reviewers,profiler-reviewers,win-reviewers,migration-reviewers,padenot,mconley,nchevobbe,kershaw,gstoll,mstange,bytesized,m_kato
This new version of clang 17 also slightly changed the formatting.

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D215914
2024-07-17 11:15:31 +00:00
Shravan Narayan 5767360484 Bug 1831654 - Graceful failures for out of range column number in expat error handling r=glandium,peterv
Differential Revision: https://phabricator.services.mozilla.com/D177311
2023-06-02 20:45:17 +00:00
Shravan Narayan 57e638ed99 Bug 1824892: Fix tainting use in the nsExpatDriver r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D175433
2023-04-26 20:15:15 +00:00
Shravan Narayan c62a90cbdc Bug 1827704 - Migrate to the upstream wasm2c for RLBox sandboxing r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D175439
2023-04-21 01:31:35 +00:00
Narcis Beleuzu 088eb27bf2 Backed out changeset 4b412f721080 (bug 1824892) for crashes on nsExpatDriver.cpp . CLOSED TREE 2023-04-20 05:12:27 +03:00
Shravan Narayan d1f6b927cf Bug 1824892: Fix tainting use in the nsExpatDriver r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D175433
2023-04-20 01:40:07 +00:00
Emilio Cobos Álvarez 8dabbf6590 Bug 1823686 - Share URLExtraData between SVG attribute mapping and style attribute. r=smaug
I don't think there's ever a way these should differ.

Got some include hell from removing ReferrerInfo.h from Document.h but
hopefully should be straight-forward to review.

Depends on D173154

Differential Revision: https://phabricator.services.mozilla.com/D173155
2023-03-22 14:54:43 +00:00
Peter Van der Beken b9199444b0 Bug 1751796 - XML parsererror eats two first letters. r=bholley
We were calling XML_GetCurrentColumnNumber after ParseBuffer caused Expat
to consume some data. XML_GetCurrentColumnNumber uses the buffer that was
last passed to Expat. Before Expat was put in an RLBox sandbox the caller
of ParseBuffer would keep the data in the scanner string until after the
call to XML_GetCurrentColumnNumber. Now that we copy the data into the
RLBox sandbox the data is freed when the TransferBuffer in ParseBuffer
goes out of scope, so in the caller of ParseBuffer the call to
XML_GetCurrentColumnNumber would cause us to read freed memory inside the
sandbox. Moving the call to XML_GetCurrentColumnNumber to inside
ParseBuffer, when TransferBuffer is still in scope, solves the issue.

Differential Revision: https://phabricator.services.mozilla.com/D141795
2022-04-05 14:10:11 +00:00
Peter Van der Beken f6c6b3e35f Bug 1749935 - Remove GetDTD. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D135899
2022-02-14 13:03:52 +00:00
Peter Van der Beken b98d7adef3 Bug 1749935 - Create nsParser directly instead of with a CID. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D135896
2022-02-14 13:03:51 +00:00
Peter Van der Beken a212cbea26 Bug 1749935 - Remove nsITokenizer. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D135887
2022-02-14 13:03:50 +00:00
Peter Van der Beken 6f87db68c6 Bug 1749935 - Inline nsParser::WillTokenize in the caller. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D135884
2022-02-14 13:03:49 +00:00
Peter Van der Beken e6399f71db Bug 1749935 - Remove nsIDTD::WillBuildModel. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D135883
2022-02-14 13:03:49 +00:00
Peter Van der Beken 4c3a5e50ca Bug 1749935 - Always create scanner upfront. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D135880
2022-02-14 13:03:48 +00:00
Peter Van der Beken 528ff7da63 Bug 1749935 - Remove nsIDTD::GetMode. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D135848
2022-02-14 13:03:47 +00:00
Peter Van der Beken 05bd795c54 Bug 1749935 - Remove unused argument from nsIDTD::DidBuildModel. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D135847
2022-02-14 13:03:47 +00:00
Peter Van der Beken 7649da240f Bug 1749935 - Remove unused nsIDTD::CanContain/IsContainer. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D135844
2022-02-14 13:03:46 +00:00
Peter Van der Beken cae2271aba Bug 1749935 - Remove unused aTokenizer argument for nsIDTD::WillBuildModel/BuildModel. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D135843
2022-02-14 13:03:45 +00:00
Peter Van der Beken 7c5ef476c3 Bug 1749935 - Remove unused NS_PARSER_FLAG_OBSERVERS_ENABLED and NS_PARSER_FLAG_FLUSH_TOKENS. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D135842
2022-02-14 13:03:45 +00:00
Peter Van der Beken 067f592d24 Bug 1752498 - XML error shows garbage for location. r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D137262
2022-02-02 09:28:33 +00:00
Peter Van der Beken 327ff927c4 Bug 1749462 - Don't convert URI to string for Expat. r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D135835
2022-01-17 08:49:11 +00:00
Bobby Holley 4f9856fe22 Bug 1747514 - Ensure the expat sandbox is large enough to hold the base URI. r=shravanrn,deian
Differential Revision: https://phabricator.services.mozilla.com/D134653
2021-12-25 06:00:25 +00:00
Bobby Holley d139a09ab6 Bug 1747514 - Make RLBoxTransferBufferToSandbox properly fallible. r=shravanrn
Differential Revision: https://phabricator.services.mozilla.com/D134670
2021-12-25 06:00:25 +00:00
Peter Van der Beken b8cc5a11eb Bug 1745239 - Chunk XML parsing to 64k characters at a time. r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D134320
2021-12-20 19:31:55 +00:00
Nika Layzell 0e975d0e8d Bug 1741665 - Align nsCString's public size_type better with other C++ APIs, r=mccr8,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D131422
2021-12-13 21:47:56 +00:00
[email protected] 08373fffb0 Bug 1744460 part 2 - Update woff2 RLBoxSandboxPool to track minimum sandbox size r=bholley
Depends on D133009

Differential Revision: https://phabricator.services.mozilla.com/D133158
2021-12-09 00:01:17 +00:00
Butkovits Atila 1365ffc7cd Backed out 2 changesets (bug 1744460) for causing build bustages at RLBoxSandboxPool.cpp. CLOSED TREE
Backed out changeset 582101d582a0 (bug 1744460)
Backed out changeset dba7b7c19b2f (bug 1744460)
2021-12-08 21:57:58 +02:00
[email protected] 85aef07ced Bug 1744460 part 2 - Update woff2 RLBoxSandboxPool to track minimum sandbox size r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D133158
2021-12-08 17:55:16 +00:00
Deian Stefan d6d54ecae7 Bug 1732201 - Sandbox woff2 in OTS using RLBox r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D126435
2021-11-27 23:30:49 +00:00
Cristian Tuns 14a75bfcae Backed out changeset d486edc7499b (bug 1732201) for causing web-platform-tests failures on header-totalsfntsize-001.xht CLOSED TREE 2021-11-27 07:32:22 -05:00
Deian Stefan 98c692b49c Bug 1732201 - Sandbox woff2 in OTS using RLBox r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D126435
2021-11-27 04:41:21 +00:00
Shravan Narayan 2a139d40ce Bug 1742914 - Add explicit casts for u8 and u16 parameters to RLBox sandbox_invoke r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D132113
2021-11-25 05:17:33 +00:00
Cosmin Sabou e6c83dd8c6 Backed out changeset 524df7136a1f (bug 1742914) for causing assertion failures on htmlparser/nsExpatDriver.cpp. CLOSED TREE 2021-11-25 11:14:20 +02:00
Shravan Narayan 71a0b5ef9a Bug 1742914 - Add explicit casts for u8 and u16 parameters to RLBox sandbox_invoke r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D132113
2021-11-25 05:17:33 +00:00
Deian Stefan 1ba1cc0da8 Bug 1688452 - Retrofit nsExpatDriver to use RLBoxed libexpat r=tjr,peterv,bholley,glandium
Differential Revision: https://phabricator.services.mozilla.com/D104658
2021-11-22 06:19:17 +00:00
Sandor Molnar 0afef2af22 Backed out changeset 4294063f1606 (bug 1688452) for causing mochitest and wpt failures. CLOSED TREE 2021-11-20 13:00:27 +02:00
Deian Stefan ef1400535a Bug 1688452 - Retrofit nsExpatDriver to use RLBoxed libexpat r=tjr,peterv,bholley,glandium
Differential Revision: https://phabricator.services.mozilla.com/D104658
2021-11-19 21:28:53 +00:00
Alexandru Michis 4305e8cd4a Backed out changeset 7893bbd002e0 (bug 1688452) for causing bustages in nsRLBoxExpatDriver.
CLOSED TREE
2021-11-19 15:54:31 +02:00
Deian Stefan 16c7c8eb8a Bug 1688452 - Retrofit nsExpatDriver to use RLBoxed libexpat r=tjr,peterv,bholley,glandium
Differential Revision: https://phabricator.services.mozilla.com/D104658
2021-11-19 06:08:36 +00:00
Cosmin Sabou af572dd42f Backed out 4 changesets (bug 1688452) for assertion and bc failures on browser_translation_bing.js.
Backed out changeset 1a720cffc019 (bug 1688452)
Backed out changeset 797a7e243d43 (bug 1688452)
Backed out changeset 00fd325069fa (bug 1688452)
Backed out changeset 23ef68478e93 (bug 1688452)
2021-09-29 20:13:33 +03:00
Deian Stefan 4a40bbbefb Bug 1688452 - Part 4: Add Wasm sandbox support for RLBoxed libexpat r=tjr
Depends on D126369

Differential Revision: https://phabricator.services.mozilla.com/D106254
2021-09-29 14:31:45 +00:00
Deian Stefan 4183763707 Bug 1688452 - Part 3: Eliminate redundant callback implementation in RLBoxed libexpat r=tjr
The default handler and character-data handler callbacks are identical
and some Windows compilers just reconciled them into a single function.
This, unfortunately, resulted in a RLBox runtime error: the same
callback was registered twice. This patch removes the duplicate handler
implementation and just sets the character-data handler callback as the
default handler.

Depends on D104658

Differential Revision: https://phabricator.services.mozilla.com/D126369
2021-09-29 14:31:45 +00:00
Deian Stefan c57a375651 Bug 1688452 - Part 2: Retrofit nsExpatDriver to use RLBoxed libexpat r=tjr,peterv
Depends on D117102

Differential Revision: https://phabricator.services.mozilla.com/D104658
2021-09-29 14:31:44 +00:00
Kershaw Chang 2b0a59794c Bug 1698073 - Extend ysod event telemetry to record the status of document r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D109484
2021-03-24 08:09:11 +00:00
Simon Giesecke 46908cfb51 Bug 1660470 - Add missing include directives/forward declarations. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Zibi Braniecki 58cd668106 Bug 1677822 - Capture last line in the YSOD telemetry. r=peterv DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D97348
2020-11-18 20:29:41 +00:00
Simon Giesecke ab6f0a7137 Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D82325
2020-09-23 15:17:15 +00:00
Zibi Braniecki cbf57ba0a6 Bug 1661646 - Extend YSOD Telemetry with error_code and location. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D88535
2020-08-28 22:04:13 +00:00