Sylvestre Ledru
a3ea006705
Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,necko-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,devtools-reviewers,anti-tracking-reviewers,profiler-reviewers,win-reviewers,migration-reviewers,padenot,mconley,nchevobbe,kershaw,gstoll,mstange,bytesized,m_kato
...
This new version of clang 17 also slightly changed the formatting.
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D215914
2024-07-17 11:15:31 +00:00
Kris Maglione
f08b8b6183
Bug 1729005: Recursively block parsing for parser blocking scripts. r=hsivonen
...
Bug 1333990 added the ability to have multiple parser blockers at the same
time, so we no longer need to guard against recursively blocking. What's more,
if we do, and skip calling `BlockParser` while it's blocked for another reason,
we still call `UnblockParser` when we receive script data, at which point we
crash.
This patch moves the XHTML parser's behavior closer in line with the HTML
parser's.
The only way I've seen this manifest as a bug is when we have an XHTML
document with a top-level <script> element, and an extension with content
scripts that cause us to block parsing when we see that top-level element and
need to wait for them to compile.
Differential Revision: https://phabricator.services.mozilla.com/D145513
2022-05-11 22:15:14 +00:00
Marian-Vasile Laza
aa56124b1f
Backed out changeset ae4f4209538e (bug 1729005) for causing xpcshell failures on test_blockParsing.js. CLOSED TREE
2022-05-10 01:00:43 +03:00
Kris Maglione
3723cb7374
Bug 1729005: Recursively block parsing for parser blocking scripts. r=hsivonen
...
Bug 1333990 added the ability to have multiple parser blockers at the same
time, so we no longer need to guard against recursively blocking. What's more,
if we do, and skip calling `BlockParser` while it's blocked for another reason,
we still call `UnblockParser` when we receive script data, at which point we
crash.
This patch moves the XHTML parser's behavior closer in line with the HTML
parser's.
The only way I've seen this manifest as a bug is when we have an XHTML
document with a top-level <script> element, and an extension with content
scripts that cause us to block parsing when we see that top-level element and
need to wait for them to compile.
Differential Revision: https://phabricator.services.mozilla.com/D145513
2022-05-09 20:08:08 +00:00
Peter Van der Beken
e1accb1578
Bug 1749935 - Simplify nsParser::Initialize. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135900
2022-02-14 13:03:52 +00:00
Peter Van der Beken
f6c6b3e35f
Bug 1749935 - Remove GetDTD. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135899
2022-02-14 13:03:52 +00:00
Peter Van der Beken
c48b2ef280
Bug 1749935 - Inline nsParser::CancelParsingEvents. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135898
2022-02-14 13:03:52 +00:00
Peter Van der Beken
d3cc175110
Bug 1749935 - Remove nsIParser::ParseFragment/Reset. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135897
2022-02-14 13:03:51 +00:00
Peter Van der Beken
b98d7adef3
Bug 1749935 - Create nsParser directly instead of with a CID. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135896
2022-02-14 13:03:51 +00:00
Peter Van der Beken
a212cbea26
Bug 1749935 - Remove nsITokenizer. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135887
2022-02-14 13:03:50 +00:00
Peter Van der Beken
bf373408c8
Bug 1749935 - Inline nsParser::Tokenize. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135886
2022-02-14 13:03:50 +00:00
Peter Van der Beken
04ac2a0e08
Bug 1749935 - Inline nsParser::BuildModel. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135885
2022-02-14 13:03:50 +00:00
Peter Van der Beken
6f87db68c6
Bug 1749935 - Inline nsParser::WillTokenize in the caller. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135884
2022-02-14 13:03:49 +00:00
Peter Van der Beken
e6399f71db
Bug 1749935 - Remove nsIDTD::WillBuildModel. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135883
2022-02-14 13:03:49 +00:00
Peter Van der Beken
87c74a1957
Bug 1749935 - Inline FindSuitableDTD in caller. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135882
2022-02-14 13:03:49 +00:00
Peter Van der Beken
4c3a5e50ca
Bug 1749935 - Always create scanner upfront. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135880
2022-02-14 13:03:48 +00:00
Peter Van der Beken
e171802e54
Bug 1749935 - Remove unused support for nested CParserContext. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135879
2022-02-14 13:03:47 +00:00
Peter Van der Beken
528ff7da63
Bug 1749935 - Remove nsIDTD::GetMode. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135848
2022-02-14 13:03:47 +00:00
Peter Van der Beken
05bd795c54
Bug 1749935 - Remove unused argument from nsIDTD::DidBuildModel. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135847
2022-02-14 13:03:47 +00:00
Peter Van der Beken
1d61f34f4a
Bug 1749935 - Remove nsDTDMode::eDTDMode_unknown and unused nsDTDMode::eDTDMode_almost_standards/eDTDMode_fragment. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135846
2022-02-14 13:03:46 +00:00
Peter Van der Beken
cae2271aba
Bug 1749935 - Remove unused aTokenizer argument for nsIDTD::WillBuildModel/BuildModel. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135843
2022-02-14 13:03:45 +00:00
Peter Van der Beken
7c5ef476c3
Bug 1749935 - Remove unused NS_PARSER_FLAG_OBSERVERS_ENABLED and NS_PARSER_FLAG_FLUSH_TOKENS. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135842
2022-02-14 13:03:45 +00:00
Peter Van der Beken
2b3a350bad
Bug 1749935 - Remove unused nsParser::SetUnusedInput. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135841
2022-02-14 13:03:44 +00:00
Peter Van der Beken
5c9947d359
Bug 1749935 - Remove nsIParser::MarkAsNotScriptCreated. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135840
2022-02-14 13:03:44 +00:00
Peter Van der Beken
934f1163cf
Bug 1749935 - Remove nsIParser::GetChannel. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135839
2022-02-14 13:03:44 +00:00
Peter Van der Beken
81e81c6b7c
Bug 1749935 - Remove unused eAutoDetectResult values. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135838
2022-02-14 13:03:43 +00:00
Peter Van der Beken
e799604b13
Bug 1749935 - Remove unused PREFER_LATTER_ERROR_CODE. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D135837
2022-02-14 13:03:43 +00:00
Peter Van der Beken
327ff927c4
Bug 1749462 - Don't convert URI to string for Expat. r=bholley
...
Differential Revision: https://phabricator.services.mozilla.com/D135835
2022-01-17 08:49:11 +00:00
Henri Sivonen
5a1fbba430
Bug 1748482 - Check XML parser for brokenness in various methods. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D135096
2022-01-05 13:43:35 +00:00
Henri Sivonen
2052e5e434
Bug 1747264 - Avoid OOMing if the URL of an XML document is huge. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D134506
2021-12-27 07:31:34 +00:00
ssummar
43e270e58d
Bug 1603127 - Replaced mozilla::Tuple with std::tuple and applied structured bindings in mozilla/Encoding.h. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D129920
2021-11-08 08:14:00 +00:00
Cristian Tuns
3b4f87f69c
Backed out changeset 7e8e3747c3f8 (bug 1603127) for causing toolchains build bustages (Bug 1739589). CLOSED TREE
2021-11-05 07:23:45 -04:00
ssummar
f2f04d2ae8
Bug 1603127 - Replaced mozilla::Tuple with std::tuple and applied structured bindings in mozilla/Encoding.h. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D129920
2021-11-05 05:33:58 +00:00
ssummar
b7e03bdd6d
Bug 1626517 - Replaced mozilla::Unused with mozilla::Ignore in mozilla::Decoder/mozilla::Encoder calls. r=m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D129022
2021-10-25 12:31:41 +00:00
Nicklas Boman
3eb1d3ea32
Bug 1308103 - Replace PL_strcmp/PL_strncmp with strcmp/strncmp in xpcom/ and parser/htmlparser/ r=xpcom-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D123879
2021-09-09 19:36:10 +00:00
Henri Sivonen
7cc2f552d4
Bug 1716290 - Remove protections against the document changing as part of kCharsetFromFinalUserForcedAutoDetection reload. r=emk,emilio
...
NOTE! In cases where there is no HTTP-layer encoding declaration, and CSS
parsing inherits the encoding from the HTML document, for preloads, this
changes the inherited encoding from windows-1252 to UTF-8 in order to
make the speculative encoding correct in the common `<meta charset=utf-8>`
case.
Differential Revision: https://phabricator.services.mozilla.com/D123593
2021-08-26 18:02:15 +00:00
criss
3963232b21
Backed out changeset ab805f2926d5 (bug 1716290) for causing failures on link-header-preload.html. CLOSED TREE
2021-08-26 12:07:17 +03:00
Henri Sivonen
274b08a6fa
Bug 1716290 - Remove protections against the document changing as part of kCharsetFromFinalUserForcedAutoDetection reload. r=emk
...
Differential Revision: https://phabricator.services.mozilla.com/D123593
2021-08-26 06:25:31 +00:00
Peter Van der Beken
14b63eef21
Bug 1721153 - Remove unused aListener and aMode arguments of nsIParser::Parse. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D120217
2021-08-12 14:11:38 +00:00
Henri Sivonen
1be77297f7
Bug 673087 - Honor encoding declared via XML declaration in text/html. r=emk
...
Differential Revision: https://phabricator.services.mozilla.com/D107806
2021-03-23 09:52:04 +00:00
Simon Giesecke
769d57149a
Bug 1634281 - Remove unused nsDataHashtable.h includes. r=xpcom-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D106007
2021-03-03 08:58:52 +00:00
Simon Giesecke
39124586b5
Bug 1653335 - Replace MakeSpan uses by constructor calls. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D83817
2020-08-07 07:49:47 +00:00
Simon Giesecke
a69d79b6db
Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Eric Rahm
d3646c39c7
Bug 1626452 - Remove remaining nsAutoPtr usage from parser/. r=hsivonen
...
Differential Revision: https://phabricator.services.mozilla.com/D69123
2020-04-03 21:05:30 +00:00
Kris Maglione
232ff37e9f
Bug 1535617: Part 2 - Clear weak references for most cycle collected objects on unlink. r=mccr8
...
This covers most cycle collected objects which support weak references, but
not the ones which inherit from a cycle collected class and don't do any cycle
collection on their own.
Differential Revision: https://phabricator.services.mozilla.com/D63962
2020-02-25 19:44:39 +00:00
Gabriele Svelto
f03cdb2b2d
Bug 1600545 - Remove useless inclusions of header files generated from IDL files in modules/, netwerk/, parser/, security/, startupcache/, storage/, toolkit/, tools/, uriloader/, widget/, xpcom/ and xpfe/ r=Ehsan
...
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.
find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
if [ -n "$interfaces" ]; then
if [[ "$interfaces" == *$'\n'* ]]; then
regexp="\("
for i in $interfaces; do regexp="$regexp$i\|"; done
regexp="${regexp%%\\\|}\)"
else
regexp="$interfaces"
fi
interface=$(basename "$path")
rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
if [ $hits -eq 0 ]; then
echo "Removing ${interface} from ${path2}"
grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
mv -f "$path2".tmp "$path2"
fi
done
fi
done
Differential Revision: https://phabricator.services.mozilla.com/D55444
2019-12-06 09:17:57 +00:00
Boris Zbarsky
490a516cd4
Bug 325352 part 1. Align our "defined insertion point" concept more closely with the spec's "script nesting level" concept. r=hsivonen
...
This also exposes an accessor for whether the parser has a nonzero script nesting level.
Differential Revision: https://phabricator.services.mozilla.com/D30313
2019-05-08 06:10:47 +00:00
Sylvestre Ledru
b31009da86
Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D22514
2019-03-13 10:19:06 +01:00
Jonathan Kingston
8397774fdf
Bug 1525319 - Removing context from OnDataAvailable r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D20881
2019-02-27 23:42:27 +00:00
Jonathan Kingston
3ef1df37e1
Bug 1525319 - Removing context from OnStopRequest r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D20770
2019-02-27 23:41:31 +00:00